<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/lib/api, branch doc-serverless-lambda</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Standardize remote_ip and path keys for auth.log and api_json.log</title>
<updated>2019-08-20T18:12:28+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-08-20T18:12:28+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e632ae80845f849f93e4d85ef9f836a4792844c9'/>
<id>e632ae80845f849f93e4d85ef9f836a4792844c9</id>
<content type='text'>
Current `auth.log` uses `fullpath` and `ip`, while `api_json.log` uses
`remote_ip` and `path` for the same fields. Let's standardize these
namings to make it easier for people working with the data.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66167
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Current `auth.log` uses `fullpath` and `ip`, while `api_json.log` uses
`remote_ip` and `path` for the same fields. Let's standardize these
namings to make it easier for people working with the data.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66167
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix Gitaly N+1 calls with listing issues/MRs via API</title>
<updated>2019-08-18T03:35:37+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-08-17T22:39:39+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ba7c501fef5976ea7a1cc4212e84742246fed781'/>
<id>ba7c501fef5976ea7a1cc4212e84742246fed781</id>
<content type='text'>
In GitLab 9.0,
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9661 removed the
`subscribed` flag from the API when the user requested a list of issues
or merge requests since calculating this value triggers extensive
Markdown processing.

In GitLab 12.0 via a4fbf39e, we accidentally reintroduced this
performance regression by changing `IssueBasic` to `Issue` in
`entities.rb`. This showed up as a Gitaly N+1 issue since the Markdown
processing would attempt to extract a commit if it detected a regex that
matched a commit.

We restore the prior behavior by once again removing the `subscribed`
flag for the bulk list of issues and merge requests and add a test to
ensure they aren't reintroduced.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66202
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In GitLab 9.0,
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9661 removed the
`subscribed` flag from the API when the user requested a list of issues
or merge requests since calculating this value triggers extensive
Markdown processing.

In GitLab 12.0 via a4fbf39e, we accidentally reintroduced this
performance regression by changing `IssueBasic` to `Issue` in
`entities.rb`. This showed up as a Gitaly N+1 issue since the Markdown
processing would attempt to extract a commit if it detected a regex that
matched a commit.

We restore the prior behavior by once again removing the `subscribed`
flag for the bulk list of issues and merge requests and add a test to
ensure they aren't reintroduced.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66202
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix/commits-api-empty-refname' into 'master'</title>
<updated>2019-08-16T14:46:22+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2019-08-16T14:46:22+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=94c7a93dcae1a0e865d11df00ac24add676b636b'/>
<id>94c7a93dcae1a0e865d11df00ac24add676b636b</id>
<content type='text'>
fix handling of empty ref_name parameter string in commits api

Closes #64745

See merge request gitlab-org/gitlab-ce!31687</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
fix handling of empty ref_name parameter string in commits api

Closes #64745

See merge request gitlab-org/gitlab-ce!31687</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-fix-discussions-api-perf' into 'master'</title>
<updated>2019-08-15T16:10:14+00:00</updated>
<author>
<name>Douglas Barbosa Alexandre</name>
<email>dbalexandre@gmail.com</email>
</author>
<published>2019-08-15T16:10:14+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8c8824d44290b920c57ba02c7aaa1a0aa3a8268f'/>
<id>8c8824d44290b920c57ba02c7aaa1a0aa3a8268f</id>
<content type='text'>
Eliminate many Gitaly calls in discussions API

Closes #65957

See merge request gitlab-org/gitlab-ce!31834</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Eliminate many Gitaly calls in discussions API

Closes #65957

See merge request gitlab-org/gitlab-ce!31834</pre>
</div>
</content>
</entry>
<entry>
<title>Eliminate many Gitaly calls in discussions API</title>
<updated>2019-08-15T15:02:30+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-08-15T04:50:52+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8044440d7ad8c476d05e3e204ee26b9663738cea'/>
<id>8044440d7ad8c476d05e3e204ee26b9663738cea</id>
<content type='text'>
Previously, the API to retrieve discussions from merge requests often
generated hundreds of Gitaly calls to determine whether a system note
should be shown to the user. It did this by:

1. Rendering the Markdown
2. Extracting cross-references from the Markdown
3. For cross-references that were commits, a Gitaly FindCommit RPC
   would be issued to validate that the commit exists.

The last step is unnecessary because we don't need to display a commit
if the user doesn't have access to the project in the first place.

`RendersNotes#prepare_notes_for_rendering` is already used in
`MergeRequestsController`, which is why we don't see N+1 Gitaly calls
there. We use it here to optimize the note redaction process.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65957
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, the API to retrieve discussions from merge requests often
generated hundreds of Gitaly calls to determine whether a system note
should be shown to the user. It did this by:

1. Rendering the Markdown
2. Extracting cross-references from the Markdown
3. For cross-references that were commits, a Gitaly FindCommit RPC
   would be issued to validate that the commit exists.

The last step is unnecessary because we don't need to display a commit
if the user doesn't have access to the project in the first place.

`RendersNotes#prepare_notes_for_rendering` is already used in
`MergeRequestsController`, which is why we don't see N+1 Gitaly calls
there. We use it here to optimize the note redaction process.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65957
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix-broken-ee-master-prepend-todos-api' into 'master'</title>
<updated>2019-08-15T14:41:17+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-08-15T14:41:17+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0495615502198e208fb9cb50d29adf26525b9b17'/>
<id>0495615502198e208fb9cb50d29adf26525b9b17</id>
<content type='text'>
Adds EE prepend, which for some reason was missing

See merge request gitlab-org/gitlab-ce!31851</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds EE prepend, which for some reason was missing

See merge request gitlab-org/gitlab-ce!31851</pre>
</div>
</content>
</entry>
<entry>
<title>Adds EE prepend, which for some reason was missing</title>
<updated>2019-08-15T13:16:29+00:00</updated>
<author>
<name>Alex Kalderimis</name>
<email>alex.kalderimis@gmail.com</email>
</author>
<published>2019-08-15T13:16:29+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=922f21e23d60b965d83bd50b780cb9b33e8010c1'/>
<id>922f21e23d60b965d83bd50b780cb9b33e8010c1</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove prepend_if_ee from CE codebase</title>
<updated>2019-08-15T09:06:01+00:00</updated>
<author>
<name>Luke Duncalfe</name>
<email>lduncalfe@eml.cc</email>
</author>
<published>2019-08-15T09:06:01+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d31405271179d9a95c2944e61249d2d906e4e7ac'/>
<id>d31405271179d9a95c2944e61249d2d906e4e7ac</id>
<content type='text'>
This was added in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31789
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This was added in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31789
</pre>
</div>
</content>
</entry>
<entry>
<title>CE-specific changes to allow design Todos</title>
<updated>2019-08-15T03:08:34+00:00</updated>
<author>
<name>Luke Duncalfe</name>
<email>lduncalfe@eml.cc</email>
</author>
<published>2019-08-14T01:34:42+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=88746f5311a2624d99c3639daf2760c6715d5670'/>
<id>88746f5311a2624d99c3639daf2760c6715d5670</id>
<content type='text'>
CE-specific changes for:
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/15129

Co-Authored-By:    Alex Kalderimis &lt;akalderimis@gitlab.com&gt;
Co-Authored-By:    Luke Duncalfe &lt;lduncalfe@eml.cc&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
CE-specific changes for:
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/15129

Co-Authored-By:    Alex Kalderimis &lt;akalderimis@gitlab.com&gt;
Co-Authored-By:    Luke Duncalfe &lt;lduncalfe@eml.cc&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Migrates Snowplow backend from EE to CE</title>
<updated>2019-08-14T19:21:58+00:00</updated>
<author>
<name>Jeremy Jackson</name>
<email>jjackson@gitlab.com</email>
</author>
<published>2019-08-14T19:21:58+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5d9d5e603119c3ae334b0855a63d10d12b2390bd'/>
<id>5d9d5e603119c3ae334b0855a63d10d12b2390bd</id>
<content type='text'>
This introduces several changes, but these are all just ported from the
EE project.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This introduces several changes, but these are all just ported from the
EE project.
</pre>
</div>
</content>
</entry>
</feed>
