<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/lib/api, branch github-import-docs</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Fix N+1 with source projects in merge requests API</title>
<updated>2018-06-03T11:24:23+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2018-06-03T10:31:41+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bd4bfcc6411e4819c0c67717095bb2e54e7bb6df'/>
<id>bd4bfcc6411e4819c0c67717095bb2e54e7bb6df</id>
<content type='text'>
Now that we are checking `MergeRequest#for_fork?`, we also need
the source project preloaded for a merge request.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Now that we are checking `MergeRequest#for_fork?`, we also need
the source project preloaded for a merge request.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '46010-add-more-validations-for-runners-and-runner-type' into 'master'</title>
<updated>2018-06-01T12:43:43+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2018-06-01T12:43:43+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=afb2d667cae42b77e090b4b240848c4d4ddcaf2d'/>
<id>afb2d667cae42b77e090b4b240848c4d4ddcaf2d</id>
<content type='text'>
Improve validations for Ci::Runner#runner_type

See merge request gitlab-org/gitlab-ce!18901</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Improve validations for Ci::Runner#runner_type

See merge request gitlab-org/gitlab-ce!18901</pre>
</div>
</content>
</entry>
<entry>
<title>Add merge requests list endpoint for groups</title>
<updated>2018-05-31T15:29:07+00:00</updated>
<author>
<name>Felipe Artur</name>
<email>fcardozo@gitlab.com</email>
</author>
<published>2018-05-31T15:29:07+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8ed12efecdcc355d4f5fd9be7b43df28f5d9d925'/>
<id>8ed12efecdcc355d4f5fd9be7b43df28f5d9d925</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-fix-issue-api-perf-n-plus-one' into 'master'</title>
<updated>2018-05-31T12:27:41+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2018-05-31T12:27:41+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2fdd8982f8204340e6413a57f46e6c41d8ecb429'/>
<id>2fdd8982f8204340e6413a57f46e6c41d8ecb429</id>
<content type='text'>
Eliminate cached N+1 queries for projects in Issue API

See merge request gitlab-org/gitlab-ce!19269</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Eliminate cached N+1 queries for projects in Issue API

See merge request gitlab-org/gitlab-ce!19269</pre>
</div>
</content>
</entry>
<entry>
<title>Improve Runners API validations</title>
<updated>2018-05-31T08:56:41+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2018-05-28T11:41:04+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5805e92299f91a8d849418a03ed0e6cbcbbb5568'/>
<id>5805e92299f91a8d849418a03ed0e6cbcbbb5568</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Improve runner registration API</title>
<updated>2018-05-31T08:56:41+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2018-05-28T11:09:31+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=385f37a724f8c63f551e7236649a3f28058b860b'/>
<id>385f37a724f8c63f551e7236649a3f28058b860b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Improve `Ci::Runner#assign_to` to return a flag whether it succeeded or not</title>
<updated>2018-05-31T08:56:41+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2018-05-28T10:49:08+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c6e95b04405f1e07f76505b03c6c096f4c4d084b'/>
<id>c6e95b04405f1e07f76505b03c6c096f4c4d084b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fj-36819-remove-v3-api' into 'master'</title>
<updated>2018-05-31T08:01:56+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2018-05-31T08:01:56+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ee3b5923a55b94631fa31bb1e8c1a5d7774bda71'/>
<id>ee3b5923a55b94631fa31bb1e8c1a5d7774bda71</id>
<content type='text'>
Removal of API v3 from the codebase

Closes #36819

See merge request gitlab-org/gitlab-ce!18970</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Removal of API v3 from the codebase

Closes #36819

See merge request gitlab-org/gitlab-ce!18970</pre>
</div>
</content>
</entry>
<entry>
<title>Eliminate cached N+1 queries for projects in Issue API</title>
<updated>2018-05-31T07:18:05+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2018-05-31T07:14:24+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ef253a1ee7c03edf9773574a843b5c458e9add36'/>
<id>ef253a1ee7c03edf9773574a843b5c458e9add36</id>
<content type='text'>
In CE, every `Issue` entity is also a `ProjectEntity`, which calls
`entity&amp;.project.try(:id)` to show the project ID. In an API
request with 100 issues, this would hit the Rails statement cache 100 times
for the same project and cause unnecessary overhead as related models would
also be loaded.

In EE, we call `Issue#supports_weight?` for each issue, which then calls
`project&amp;.feature_available?(:issue_weights)`. If the project is not
preloaded, this incurs additional overhead, as each individual Project
object has to be queried. This can lead to a significant performance hit.
In loading the CE project with 100 issues, this contributed to at least 22%
of the load time.

See https://gitlab.com/gitlab-org/gitlab-ce/issues/47031 for why testing this
is a bit tricky.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In CE, every `Issue` entity is also a `ProjectEntity`, which calls
`entity&amp;.project.try(:id)` to show the project ID. In an API
request with 100 issues, this would hit the Rails statement cache 100 times
for the same project and cause unnecessary overhead as related models would
also be loaded.

In EE, we call `Issue#supports_weight?` for each issue, which then calls
`project&amp;.feature_available?(:issue_weights)`. If the project is not
preloaded, this incurs additional overhead, as each individual Project
object has to be queried. This can lead to a significant performance hit.
In loading the CE project with 100 issues, this contributed to at least 22%
of the load time.

See https://gitlab.com/gitlab-org/gitlab-ce/issues/47031 for why testing this
is a bit tricky.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add missing usage_ping_enabled to API settings</title>
<updated>2018-05-30T17:50:30+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2018-05-30T17:50:30+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c20766e808a7d4167ae55ba28315e3e4dc972b7e'/>
<id>c20766e808a7d4167ae55ba28315e3e4dc972b7e</id>
<content type='text'>
Identified while resolving conflicts in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5906
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Identified while resolving conflicts in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5906
</pre>
</div>
</content>
</entry>
</feed>
