<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/lib/declarative_policy, branch instance_level_clusters</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Run rubocop -a on CE files</title>
<updated>2019-05-05T10:24:28+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-05-05T10:19:14+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f93b2e02a56a3b1f3041119e8302d43aeafc8284'/>
<id>f93b2e02a56a3b1f3041119e8302d43aeafc8284</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Adds the Rubocop ReturnNil cop</title>
<updated>2019-03-06T15:51:56+00:00</updated>
<author>
<name>Andrew Newdigate</name>
<email>andrew@gitlab.com</email>
</author>
<published>2019-02-08T12:19:53+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3288e1a874ec0184f9f27f932748e51c57babf17'/>
<id>3288e1a874ec0184f9f27f932748e51c57babf17</id>
<content type='text'>
This style change enforces `return if ...` instead of
`return nil if ...` to save maintainers a few minor review points
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This style change enforces `return if ...` instead of
`return nil if ...` to save maintainers a few minor review points
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable more frozen string in lib/**/*.rb</title>
<updated>2018-10-07T00:02:50+00:00</updated>
<author>
<name>gfyoung</name>
<email>gfyoung17@gmail.com</email>
</author>
<published>2018-10-06T23:10:08+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d598e4fd937797a7f7778f5b4158ebf73139ce7f'/>
<id>d598e4fd937797a7f7778f5b4158ebf73139ce7f</id>
<content type='text'>
Enables frozen for the following:

* lib/*.rb
* lib/banzai/**/*.rb
* lib/bitbucket/**/*.rb
* lib/constraints/**/*.rb
* lib/container_registry/**/*.rb
* lib/declarative_policy/**/*.rb

Partially addresses #47424.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Enables frozen for the following:

* lib/*.rb
* lib/banzai/**/*.rb
* lib/bitbucket/**/*.rb
* lib/constraints/**/*.rb
* lib/container_registry/**/*.rb
* lib/declarative_policy/**/*.rb

Partially addresses #47424.
</pre>
</div>
</content>
</entry>
<entry>
<title>Resolve Naming/UncommunicativeMethod</title>
<updated>2018-07-09T13:13:08+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2018-07-04T14:02:01+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3bfe30662436e48d4324b8fac5c1634df4a7cf7f'/>
<id>3bfe30662436e48d4324b8fac5c1634df4a7cf7f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Resolve "Make a Rubocop that forbids returning from a block"</title>
<updated>2018-04-18T09:19:40+00:00</updated>
<author>
<name>🙈  jacopo beschi 🙉</name>
<email>intrip@gmail.com</email>
</author>
<published>2018-04-18T09:19:40+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c6b1043e9d1b7fe9912c330b6e7d4342f2a9694e'/>
<id>c6b1043e9d1b7fe9912c330b6e7d4342f2a9694e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>[CE] Add Naming/FileName rule checking expected class/module per filename</title>
<updated>2018-03-08T12:56:54+00:00</updated>
<author>
<name>Gabriel Mazetto</name>
<email>gabriel@gitlab.com</email>
</author>
<published>2018-03-08T12:56:54+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5c7a738105b88c52d7765791419ee398d9e27ae0'/>
<id>5c7a738105b88c52d7765791419ee398d9e27ae0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Adds Rubocop rule for line break after guard clause</title>
<updated>2017-11-16T16:58:29+00:00</updated>
<author>
<name>Jacopo</name>
<email>beschi.jacopo@gmail.com</email>
</author>
<published>2017-11-14T09:02:39+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=181cd299f9e06223e8338e93b1c318c671ccb1aa'/>
<id>181cd299f9e06223e8338e93b1c318c671ccb1aa</id>
<content type='text'>
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
</pre>
</div>
</content>
</entry>
<entry>
<title>Speed up cached_pass? for composite rules</title>
<updated>2017-10-05T09:12:58+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-10-04T13:13:22+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e9476eb97af59404438d8403968a282d6d08a20d'/>
<id>e9476eb97af59404438d8403968a282d6d08a20d</id>
<content type='text'>
Both `Or` and `And` would evaluate whether each rule passed, then calculate a
value based on the results of all of those. We can actually return early in many
cases, without running the rule at all.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Both `Or` and `And` would evaluate whether each rule passed, then calculate a
value based on the results of all of those. We can actually return early in many
cases, without running the rule at all.
</pre>
</div>
</content>
</entry>
<entry>
<title>Speed up DeclarativePolicy::Runner#steps_by_score</title>
<updated>2017-10-04T12:50:05+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-10-04T12:43:39+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d7717192782232c14c4f16962ab450b08348a4c9'/>
<id>d7717192782232c14c4f16962ab450b08348a4c9</id>
<content type='text'>
There were a couple of things here:

1. If the state was already enabled, we don't need to check all the remaining
   steps - only those that can prevent the state. (An enable followed by an
   enable is a no-op.) This logic is in `#run`, but we still did the work of
   scoring and sorting the steps.
2. The sorting is known to be inefficient, but we can make it slightly more
   efficient by stopping once we have a step with zero score, as that means it's
   free.

Neither of these make this _fast_, especially when called lots of times - as we
do when there is lots of activity on an issue - but they do help some.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There were a couple of things here:

1. If the state was already enabled, we don't need to check all the remaining
   steps - only those that can prevent the state. (An enable followed by an
   enable is a no-op.) This logic is in `#run`, but we still did the work of
   scoring and sorting the steps.
2. The sorting is known to be inefficient, but we can make it slightly more
   efficient by stopping once we have a step with zero score, as that means it's
   free.

Neither of these make this _fast_, especially when called lots of times - as we
do when there is lots of activity on an issue - but they do help some.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'rs-more-public-send-whitelists' into 'master'</title>
<updated>2017-08-16T11:25:26+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2017-08-16T11:25:26+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fcce6c3168dbd04404f318b4e983d7395d21538c'/>
<id>fcce6c3168dbd04404f318b4e983d7395d21538c</id>
<content type='text'>
Whitelist or fix additional `Gitlab/PublicSend` cop violations

See merge request !13467</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Whitelist or fix additional `Gitlab/PublicSend` cop violations

See merge request !13467</pre>
</div>
</content>
</entry>
</feed>
