delta/gitlab/gitlab-ce.git/rubocop/cop/migration, branch docs-pages-https

Use gitlab-styles

2017-12-22T14:34:44+00:00

Signed-off-by: Rémy Coutable

Add cop for use of remove_column

2017-12-11T16:34:51+00:00

remove_column should only be used in the up (or change) step of a migration if
it's a post-deployment migration. Otherwise there will be downtime due to the
ActiveRecord column cache, which we can avoid by using the IgnorableColumn
concern in combination with a post-deployment migration.

Prevent update_column_in_batches on large tables

2017-11-17T16:56:50+00:00

add_column_with_default is implemented in terms of update_column_in_batches, but
update_column_in_batches can be used independently. Neither of these should be
used on the specified large tables, because they will cause issues on large
instances like GitLab.com.

This also ignores the cop for all existing migrations, renaming
AddColumnWithDefaultToLargeTable where appropriate.

Also warn on timestamp in datetime migration cop

2017-10-10T09:36:10+00:00

The types `timestamp` and `datetime` are aliases:
https://github.com/rails/rails/blob/v4.2.10/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb#L362-L364

Add SaferBooleanColumn cop

2017-08-14T14:57:57+00:00

ini

2017-08-01T05:16:10+00:00

Update the large table list in AddColumnWithDefaultToLargeTable cop

2017-07-26T16:40:59+00:00

- ci_builds -- 33 million rows, 55 GB
- merge_request_diff_files -- 5 million rows, 9 GB (and growing rapidly)
- merge_request_diffs -- 5 million rows, 190 GB

Added cop to blacklist the use of hash indexes

2017-07-14T11:19:00+00:00

These indexes are not recorded in the WAL (at least until PostgreSQL
10) and this isn't worth the minor performance improvement over btree
indexes.

Add database helpers 'add_timestamps_with_timezone' and 'timestamps_with_timezone'

2017-06-13T11:44:13+00:00

New Migration/UpdateColumnInBatches cop

2017-05-29T09:28:23+00:00

Signed-off-by: Rémy Coutable