<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/rubocop/rubocop.rb, branch add-remove-column-cop</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Add cop for use of remove_column</title>
<updated>2017-12-11T16:34:51+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-12-11T16:34:51+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1ab33b15d1f1cc6ce69514e545da1348fd750771'/>
<id>1ab33b15d1f1cc6ce69514e545da1348fd750771</id>
<content type='text'>
remove_column should only be used in the up (or change) step of a migration if
it's a post-deployment migration. Otherwise there will be downtime due to the
ActiveRecord column cache, which we can avoid by using the IgnorableColumn
concern in combination with a post-deployment migration.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
remove_column should only be used in the up (or change) step of a migration if
it's a post-deployment migration. Otherwise there will be downtime due to the
ActiveRecord column cache, which we can avoid by using the IgnorableColumn
concern in combination with a post-deployment migration.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '18040-rubocop-line-break-after-guard-clause' into 'master'</title>
<updated>2017-11-20T09:22:14+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2017-11-20T09:22:14+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4f09d099e9fa29659917f87c2dc25f2b9aa05b5e'/>
<id>4f09d099e9fa29659917f87c2dc25f2b9aa05b5e</id>
<content type='text'>
Adds Rubocop rule for line break after guard clause

Closes #18040

See merge request gitlab-org/gitlab-ce!15188</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds Rubocop rule for line break after guard clause

Closes #18040

See merge request gitlab-org/gitlab-ce!15188</pre>
</div>
</content>
</entry>
<entry>
<title>Prevent update_column_in_batches on large tables</title>
<updated>2017-11-17T16:56:50+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-11-17T13:38:14+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d8be981466e2a794b42996960f1fdb91e560a707'/>
<id>d8be981466e2a794b42996960f1fdb91e560a707</id>
<content type='text'>
add_column_with_default is implemented in terms of update_column_in_batches, but
update_column_in_batches can be used independently. Neither of these should be
used on the specified large tables, because they will cause issues on large
instances like GitLab.com.

This also ignores the cop for all existing migrations, renaming
AddColumnWithDefaultToLargeTable where appropriate.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
add_column_with_default is implemented in terms of update_column_in_batches, but
update_column_in_batches can be used independently. Neither of these should be
used on the specified large tables, because they will cause issues on large
instances like GitLab.com.

This also ignores the cop for all existing migrations, renaming
AddColumnWithDefaultToLargeTable where appropriate.
</pre>
</div>
</content>
</entry>
<entry>
<title>Adds Rubocop rule for line break after guard clause</title>
<updated>2017-11-16T16:58:29+00:00</updated>
<author>
<name>Jacopo</name>
<email>beschi.jacopo@gmail.com</email>
</author>
<published>2017-11-14T09:02:39+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=181cd299f9e06223e8338e93b1c318c671ccb1aa'/>
<id>181cd299f9e06223e8338e93b1c318c671ccb1aa</id>
<content type='text'>
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add a new RSpec::EnvAssignment cop to prevent assigning to ENV in specs</title>
<updated>2017-10-18T16:42:09+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2017-10-11T11:25:40+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8a31b0743753f080e0ba07c8d6d0da863a5c4726'/>
<id>8a31b0743753f080e0ba07c8d6d0da863a5c4726</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Replaces `tag: true` into `:tag` in the specs</title>
<updated>2017-10-07T11:57:54+00:00</updated>
<author>
<name>Jacopo</name>
<email>beschi.jacopo@gmail.com</email>
</author>
<published>2017-10-03T08:35:01+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0ce6785851510ccb49f0d1edc0220aca46f815f5'/>
<id>0ce6785851510ccb49f0d1edc0220aca46f815f5</id>
<content type='text'>
Replaces all the explicit include metadata syntax in the specs (tag:
true) into the implicit one (:tag).
Added a cop to prevent future errors and handle autocorrection.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Replaces all the explicit include metadata syntax in the specs (tag:
true) into the implicit one (:tag).
Added a cop to prevent future errors and handle autocorrection.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add SaferBooleanColumn cop</title>
<updated>2017-08-14T14:57:57+00:00</updated>
<author>
<name>Michael Kozono</name>
<email>mkozono@gmail.com</email>
</author>
<published>2017-07-27T20:54:48+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9beef1848791ac86d1b3eca083049cc2752b6713'/>
<id>9beef1848791ac86d1b3eca083049cc2752b6713</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Added cop to blacklist the use of hash indexes</title>
<updated>2017-07-14T11:19:00+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-07-14T11:19:00+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a004f9ec8c66ea9dcce0e76e28b0a343437c0b16'/>
<id>a004f9ec8c66ea9dcce0e76e28b0a343437c0b16</id>
<content type='text'>
These indexes are not recorded in the WAL (at least until PostgreSQL
10) and this isn't worth the minor performance improvement over btree
indexes.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These indexes are not recorded in the WAL (at least until PostgreSQL
10) and this isn't worth the minor performance improvement over btree
indexes.
</pre>
</div>
</content>
</entry>
<entry>
<title>Added EachBatch for iterating tables in batches</title>
<updated>2017-07-07T14:39:36+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-07-07T12:49:05+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ff78af152cc3054a7bb76af718943dca7a69a3c5'/>
<id>ff78af152cc3054a7bb76af718943dca7a69a3c5</id>
<content type='text'>
This module provides a class method called `each_batch` that can be used
to iterate tables in batches in a more efficient way compared to Rails'
`in_batches` method. This commit also includes a RuboCop cop to
blacklist the use of `in_batches` in favour of this new method.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This module provides a class method called `each_batch` that can be used
to iterate tables in batches in a more efficient way compared to Rails'
`in_batches` method. This commit also includes a RuboCop cop to
blacklist the use of `in_batches` in favour of this new method.
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename ActiverecordSerialize cop</title>
<updated>2017-07-06T10:01:36+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-07-03T14:01:41+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e1a3bf30b6ea04f2c658729f65a0eb09847dd341'/>
<id>e1a3bf30b6ea04f2c658729f65a0eb09847dd341</id>
<content type='text'>
This cop has been renamed to ActiveRecordSerialize to match the way
"ActiveRecord" is usually written.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This cop has been renamed to ActiveRecordSerialize to match the way
"ActiveRecord" is usually written.
</pre>
</div>
</content>
</entry>
</feed>
