delta/gitlab/gitlab-ce.git/rubocop, branch add-remove-column-cop gitlab.com: gitlab-org/gitlab-ce.git Add cop for use of remove_column 2017-12-11T16:34:51+00:00 Sean McGivern sean@gitlab.com 2017-12-11T16:34:51+00:00 1ab33b15d1f1cc6ce69514e545da1348fd750771 remove_column should only be used in the up (or change) step of a migration if it's a post-deployment migration. Otherwise there will be downtime due to the ActiveRecord column cache, which we can avoid by using the IgnorableColumn concern in combination with a post-deployment migration. 
remove_column should only be used in the up (or change) step of a migration if
it's a post-deployment migration. Otherwise there will be downtime due to the
ActiveRecord column cache, which we can avoid by using the IgnorableColumn
concern in combination with a post-deployment migration.
Merge branch '18040-rubocop-line-break-after-guard-clause' into 'master' 2017-11-20T09:22:14+00:00 Rémy Coutable remy@rymai.me 2017-11-20T09:22:14+00:00 4f09d099e9fa29659917f87c2dc25f2b9aa05b5e Adds Rubocop rule for line break after guard clause Closes #18040 See merge request gitlab-org/gitlab-ce!15188 
Adds Rubocop rule for line break after guard clause

Closes #18040

See merge request gitlab-org/gitlab-ce!15188
 Prevent update_column_in_batches on large tables 2017-11-17T16:56:50+00:00 Sean McGivern sean@gitlab.com 2017-11-17T13:38:14+00:00 d8be981466e2a794b42996960f1fdb91e560a707 add_column_with_default is implemented in terms of update_column_in_batches, but update_column_in_batches can be used independently. Neither of these should be used on the specified large tables, because they will cause issues on large instances like GitLab.com. This also ignores the cop for all existing migrations, renaming AddColumnWithDefaultToLargeTable where appropriate. 
add_column_with_default is implemented in terms of update_column_in_batches, but
update_column_in_batches can be used independently. Neither of these should be
used on the specified large tables, because they will cause issues on large
instances like GitLab.com.

This also ignores the cop for all existing migrations, renaming
AddColumnWithDefaultToLargeTable where appropriate.
Adds Rubocop rule for line break after guard clause 2017-11-16T16:58:29+00:00 Jacopo beschi.jacopo@gmail.com 2017-11-14T09:02:39+00:00 181cd299f9e06223e8338e93b1c318c671ccb1aa Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses. 
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
Add a new RSpec::EnvAssignment cop to prevent assigning to ENV in specs 2017-10-18T16:42:09+00:00 Rémy Coutable remy@rymai.me 2017-10-11T11:25:40+00:00 8a31b0743753f080e0ba07c8d6d0da863a5c4726 Signed-off-by: Rémy Coutable <remy@rymai.me> 
Signed-off-by: Rémy Coutable <remy@rymai.me>
Also warn on timestamp in datetime migration cop 2017-10-10T09:36:10+00:00 Sean McGivern sean@gitlab.com 2017-10-10T09:36:10+00:00 a560291f143399b2c8d340fb0a02615dc72552c3 The types `timestamp` and `datetime` are aliases: https://github.com/rails/rails/blob/v4.2.10/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb#L362-L364 
The types `timestamp` and `datetime` are aliases:
https://github.com/rails/rails/blob/v4.2.10/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb#L362-L364
Replaces `tag: true` into `:tag` in the specs 2017-10-07T11:57:54+00:00 Jacopo beschi.jacopo@gmail.com 2017-10-03T08:35:01+00:00 0ce6785851510ccb49f0d1edc0220aca46f815f5 Replaces all the explicit include metadata syntax in the specs (tag: true) into the implicit one (:tag). Added a cop to prevent future errors and handle autocorrection. 
Replaces all the explicit include metadata syntax in the specs (tag:
true) into the implicit one (:tag).
Added a cop to prevent future errors and handle autocorrection.
Add SaferBooleanColumn cop 2017-08-14T14:57:57+00:00 Michael Kozono mkozono@gmail.com 2017-07-27T20:54:48+00:00 9beef1848791ac86d1b3eca083049cc2752b6713 






ini
2017-08-01T05:16:10+00:00

Shinya Maeda
shinya@gitlab.com

2017-08-01T05:16:10+00:00

953aa380ebbbcaef8974c3cfb0e15925dbc2c9b6












Update the large table list in AddColumnWithDefaultToLargeTable cop
2017-07-26T16:40:59+00:00

Robert Speicher
rspeicher@gmail.com

2017-07-26T16:40:59+00:00

02139f5a775fafb3999976cdd213d7ef14e720d7

- ci_builds -- 33 million rows, 55 GB
- merge_request_diff_files -- 5 million rows, 9 GB (and growing rapidly)
- merge_request_diffs -- 5 million rows, 190 GB





- ci_builds -- 33 million rows, 55 GB
- merge_request_diff_files -- 5 million rows, 9 GB (and growing rapidly)
- merge_request_diffs -- 5 million rows, 190 GB