delta/gitlab/gitlab-ce.git/rubocop, branch docs-pages-https

Introduce PredicateMemoization cop and fix offenses

2018-01-12T09:54:55+00:00

with StrongMemoize

Adds Rubocop rule for line break around conditionals

2018-01-11T16:34:01+00:00

Require our own custom cops; Remove missing cops

2017-12-26T08:30:36+00:00

Also try to use the same config from EE

Use gitlab-styles

2017-12-22T14:34:44+00:00

Signed-off-by: Rémy Coutable

Merge remote-tracking branch 'upstream/master' into no-ivar-in-modules

2017-12-15T09:14:26+00:00

* upstream/master: (671 commits)
  Make rubocop happy
  Use guard clause
  Improve language
  Prettify
  Use temp branch
  Pass info about who started the job and which job triggered it
  Docs: add indexes for monitoring and performance monitoring
  clearer-documentation-on-inline-diffs
  Add docs for commit diff discussion in merge requests
  sorting for tags api
  Clear BatchLoader after each spec to prevent holding onto records longer than necessary
  Include project in BatchLoader key to prevent returning blobs for the wrong project
  moved lfs_blob_ids method into ExtractsPath module
  Converted JS modules into exported modules
  spec fixes
  Bump gitlab-shell version to 5.10.3
  Clear caches before updating MR diffs
  Use new Ruby version 2.4 in GitLab QA images
  moved lfs blob fetch from extractspath file
  Update GitLab QA dependencies
  ...

Add rubocops to ensure Sidekiq workers include ApplicationWorker and don't manually set their queue

2017-12-13T15:28:26+00:00

Add cop for use of remove_column

2017-12-11T16:34:51+00:00

remove_column should only be used in the up (or change) step of a migration if
it's a post-deployment migration. Otherwise there will be downtime due to the
ActiveRecord column cache, which we can avoid by using the IgnorableColumn
concern in combination with a post-deployment migration.

Merge remote-tracking branch 'upstream/master' into no-ivar-in-modules

2017-11-22T09:07:01+00:00

* upstream/master: (126 commits)
  Update VERSION to 10.3.0-pre
  Update CHANGELOG.md for 10.2.0
  default fill color for SVGs
  ignore hashed repos (for now) when using `rake gitlab:cleanup:repos`
  Use Redis cache for branch existence checks
  Update CONTRIBUTING.md: Link definition of done to criteria
  Use `make install` for Gitaly setups in non-test environments
  FileUploader should check for hashed_storage?(:attachments) to use disk_path
  Set the default gitlab-shell timeout to 3 hours
  Update composite pipelines index to include "id"
  Use arrays in Pipeline#latest_builds_with_artifacts
  Fix blank states using old css
  Skip confirmation user api
  Custom issue tracker
  Revert "check for `read_only?` first before seeing if request is disallowed"
  add `#with_metadata` scope to remove a N+1 from the notes' API
  Fix promoting milestone updating all issuables without milestone
  Batchload blobs for diff generation
  check for `read_only?` first before seeing if request is disallowed
  use `Gitlab::Routing.url_helpers` instead of `Rails.application.routes.url_helpers`
  ...

Move ModuleWithInstanceVariables to Gitlab namespace

2017-11-22T09:06:57+00:00

And use .rubocop.yml to exclude paths we don't care,
rather than using the cop itself to exclude.

Explain how to disable it in the doc

2017-11-22T09:06:57+00:00