<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/rubocop, branch scripts-differences</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Add RSpec/TopLevelDescribePath cop</title>
<updated>2019-08-01T10:07:26+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-07-29T15:27:36+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ab0a6455c790874cafd2deff9b7b2da8d82169f2'/>
<id>ab0a6455c790874cafd2deff9b7b2da8d82169f2</id>
<content type='text'>
The RSpec/FilePath cop checks that a spec file's path is correct, but
only if the file describes a constant. We want to check, for any file
with a top-level `describe`, whether the file path ends in
`_spec.rb`. We don't care what comes before that; just that it will be
executed by RSpec at all.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The RSpec/FilePath cop checks that a spec file's path is correct, but
only if the file describes a constant. We want to check, for any file
with a top-level `describe`, whether the file path ends in
`_spec.rb`. We don't care what comes before that; just that it will be
executed by RSpec at all.
</pre>
</div>
</content>
</entry>
<entry>
<title>Extend cop for verifying injecting of EE modules</title>
<updated>2019-07-30T12:52:54+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2019-07-26T12:52:18+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cc6619a80f5a101619d3631a05c61c8561705f69'/>
<id>cc6619a80f5a101619d3631a05c61c8561705f69</id>
<content type='text'>
This extends the InjectEnterpriseEditionModule RuboCop cop so that it
verifies the following:

1. The line number the injection occurs on (as before).
2. The method used (e.g. prepend instead of prepend_if_ee).
3. The argument type passed when using the new module injection methods.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This extends the InjectEnterpriseEditionModule RuboCop cop so that it
verifies the following:

1. The line number the injection occurs on (as before).
2. The method used (e.g. prepend instead of prepend_if_ee).
3. The argument type passed when using the new module injection methods.
</pre>
</div>
</content>
</entry>
<entry>
<title>Change element_with_pattern cop to not use quotes</title>
<updated>2019-07-10T23:10:28+00:00</updated>
<author>
<name>ddavison</name>
<email>ddavison@gitlab.com</email>
</author>
<published>2019-07-09T21:44:16+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=015b61b1dc73e2c8d6e6cf04b6b2c7fb896a452f'/>
<id>015b61b1dc73e2c8d6e6cf04b6b2c7fb896a452f</id>
<content type='text'>
Using quotes within string validations can be messy. Let's
use  a typical CSS selector for an unquoted attribute

Update the cop spec to validate appropriate new message
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Using quotes within string validations can be messy. Let's
use  a typical CSS selector for an unquoted attribute

Update the cop spec to validate appropriate new message
</pre>
</div>
</content>
</entry>
<entry>
<title>Introduce data-qa-selector to supplant .qa-class</title>
<updated>2019-07-10T23:09:43+00:00</updated>
<author>
<name>ddavison</name>
<email>ddavison@gitlab.com</email>
</author>
<published>2019-05-29T23:47:53+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=390e0d8906c066996e8bbb14aa5824643f9798f8'/>
<id>390e0d8906c066996e8bbb14aa5824643f9798f8</id>
<content type='text'>
In order to break away from using CSS classes as
our primary method of element identification, we
need to provide the ability to search for data
attributes.

Make Test::Sanity::Selectors now work

Utilize regex to match on literal strings of the element name

Suggest the data-qa-selector pattern vs the qa-

Add data-qa-selector to login page to start

We need a page that is heavily used in order to be
confident that this functionality works. Let's start
with the Login page

Use appropriate HAML data tag practices
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In order to break away from using CSS classes as
our primary method of element identification, we
need to provide the ability to search for data
attributes.

Make Test::Sanity::Selectors now work

Utilize regex to match on literal strings of the element name

Suggest the data-qa-selector pattern vs the qa-

Add data-qa-selector to login page to start

We need a page that is heavily used in order to be
confident that this functionality works. Let's start
with the Login page

Use appropriate HAML data tag practices
</pre>
</div>
</content>
</entry>
<entry>
<title>Add a rubocop for Rails.logger</title>
<updated>2019-07-10T19:26:47+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2019-07-10T19:26:47+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0ab89d8e36ba58a95244b4c6dd49d53fac7a699f'/>
<id>0ab89d8e36ba58a95244b4c6dd49d53fac7a699f</id>
<content type='text'>
Suggests to use a JSON structured log instead

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/54102
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Suggests to use a JSON structured log instead

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/54102
</pre>
</div>
</content>
</entry>
<entry>
<title>Add a cop to ensure we authorize GraphQL types</title>
<updated>2019-06-21T11:00:50+00:00</updated>
<author>
<name>Bob Van Landuyt</name>
<email>bob@vanlanduyt.co</email>
</author>
<published>2019-06-18T14:18:26+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ac2d08212b20bae20c85ea225ec3fb0052a9e1af'/>
<id>ac2d08212b20bae20c85ea225ec3fb0052a9e1af</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'qa-extend-click-visit-actions' into 'master'</title>
<updated>2019-05-28T16:44:22+00:00</updated>
<author>
<name>Dan Davison</name>
<email>ddavison@gitlab.com</email>
</author>
<published>2019-05-28T16:44:22+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e6c6acaf0750700614e9a28d1eb42ae6a206f90f'/>
<id>e6c6acaf0750700614e9a28d1eb42ae6a206f90f</id>
<content type='text'>
Implement dynamic validation on QA Pages

Closes gitlab-qa#280

See merge request gitlab-org/gitlab-ce!25704</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Implement dynamic validation on QA Pages

Closes gitlab-qa#280

See merge request gitlab-org/gitlab-ce!25704</pre>
</div>
</content>
</entry>
<entry>
<title>Link to issue in CodeReuse/ActiveRecord message</title>
<updated>2019-05-21T23:37:46+00:00</updated>
<author>
<name>Luke Duncalfe</name>
<email>lduncalfe@eml.cc</email>
</author>
<published>2019-05-20T05:13:29+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3783c23457adaa4a1f97ffd0891a1a5a8d02f188'/>
<id>3783c23457adaa4a1f97ffd0891a1a5a8d02f188</id>
<content type='text'>
This provides the user with some context as to why certain ActiveRecord
methods are blacklisted.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This provides the user with some context as to why certain ActiveRecord
methods are blacklisted.
</pre>
</div>
</content>
</entry>
<entry>
<title>Implement dynamic validation on QA Pages</title>
<updated>2019-05-20T19:35:51+00:00</updated>
<author>
<name>ddavison</name>
<email>ddavison@gitlab.com</email>
</author>
<published>2019-03-02T02:03:43+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7d5b68d837545909204e6caf2352f34ac2f1ba7a'/>
<id>7d5b68d837545909204e6caf2352f34ac2f1ba7a</id>
<content type='text'>
Elements now have the ability to be required on pages or not
Currently using the default wait mechanism
Altered the ElementWithPattern Cop to fit new splat for init
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Elements now have the ability to be required on pages or not
Currently using the default wait mechanism
Altered the ElementWithPattern Cop to fit new splat for init
</pre>
</div>
</content>
</entry>
<entry>
<title>Run rubocop -a on CE files</title>
<updated>2019-05-05T10:24:28+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-05-05T10:19:14+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f93b2e02a56a3b1f3041119e8302d43aeafc8284'/>
<id>f93b2e02a56a3b1f3041119e8302d43aeafc8284</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
