<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/features, branch docs-serverless-lambda</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Remove csslab</title>
<updated>2019-08-28T10:01:15+00:00</updated>
<author>
<name>Arun Kumar Mohan</name>
<email>arunmohandm@gmail.com</email>
</author>
<published>2019-08-28T09:05:37+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7f15dacb5504b0ba7f9eb73e8a60e494e3473274'/>
<id>7f15dacb5504b0ba7f9eb73e8a60e494e3473274</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove token field from runners edit form</title>
<updated>2019-08-28T08:39:47+00:00</updated>
<author>
<name>Payton Burdette</name>
<email>pburdette@gitlab.com</email>
</author>
<published>2019-08-28T08:39:47+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=748b89ee948c9b2123e86da40c46b71ae27ede80'/>
<id>748b89ee948c9b2123e86da40c46b71ae27ede80</id>
<content type='text'>
Add changelog entry

Remove unnecessary test checking for form value

Translations updated for gitlab.pot

Use proper format on changelog entry
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add changelog entry

Remove unnecessary test checking for form value

Translations updated for gitlab.pot

Use proper format on changelog entry
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'todos/include-issue-mr-titles' into 'master'</title>
<updated>2019-08-28T05:40:19+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-08-28T05:40:19+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6262a91e365c658dc7d4ea286cd0e7201249bfa4'/>
<id>6262a91e365c658dc7d4ea286cd0e7201249bfa4</id>
<content type='text'>
Add Issue and Merge Request titles to Todo items

Closes #63488

See merge request gitlab-org/gitlab-ce!30435</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add Issue and Merge Request titles to Todo items

Closes #63488

See merge request gitlab-org/gitlab-ce!30435</pre>
</div>
</content>
</entry>
<entry>
<title>Add Issue and Merge Request titles to Todo items</title>
<updated>2019-08-28T01:09:24+00:00</updated>
<author>
<name>Arun Kumar Mohan</name>
<email>arunmohandm@gmail.com</email>
</author>
<published>2019-06-27T05:56:08+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4ca32c2b55519aa2b7852c879ad700e8fa290f80'/>
<id>4ca32c2b55519aa2b7852c879ad700e8fa290f80</id>
<content type='text'>
Only displays the todo body if the todo has a note.
This is to avoid redundant Issue or Merge Request titles
displayed both in the Todo title and body.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Only displays the todo body if the todo has a note.
This is to avoid redundant Issue or Merge Request titles
displayed both in the Todo title and body.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-project-feature-nplus-one' into 'master'</title>
<updated>2019-08-27T06:41:38+00:00</updated>
<author>
<name>Jan Provaznik</name>
<email>jprovaznik@gitlab.com</email>
</author>
<published>2019-08-27T06:41:38+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f91b5d5840996736ee18ef457653cdd225f8445f'/>
<id>f91b5d5840996736ee18ef457653cdd225f8445f</id>
<content type='text'>
Remove N+1 SQL query loading project feature in dashboard

Closes #66482

See merge request gitlab-org/gitlab-ce!32169</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove N+1 SQL query loading project feature in dashboard

Closes #66482

See merge request gitlab-org/gitlab-ce!32169</pre>
</div>
</content>
</entry>
<entry>
<title>Update docs and comments about saml with allow_bypass_two_factor</title>
<updated>2019-08-27T03:46:32+00:00</updated>
<author>
<name>dodocat</name>
<email>jingqq5210@gmail.com</email>
</author>
<published>2019-08-27T03:46:32+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6e2032f24e0428189f8c9fe9e296a9630277155e'/>
<id>6e2032f24e0428189f8c9fe9e296a9630277155e</id>
<content type='text'>
allow_bypass_two_factor configration dose not work with saml provider
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
allow_bypass_two_factor configration dose not work with saml provider
</pre>
</div>
</content>
</entry>
<entry>
<title>Change misleading pipeline status tooltip</title>
<updated>2019-08-23T21:28:46+00:00</updated>
<author>
<name>Scott Hampton</name>
<email>shampton@gitlab.com</email>
</author>
<published>2019-08-23T21:28:46+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f093ceb4a0b15420cfe64fa9d97e73531b5fb35c'/>
<id>f093ceb4a0b15420cfe64fa9d97e73531b5fb35c</id>
<content type='text'>
Some pipeline status icon tooltips were showing
"Commit: ..." which customers found to be
misleading since it was not the commit that was
failing but the pipeline.

We are changing all status icon tooltips to say
"Pipeline: ..." instead of "Commit: ..." now.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some pipeline status icon tooltips were showing
"Commit: ..." which customers found to be
misleading since it was not the commit that was
failing but the pipeline.

We are changing all status icon tooltips to say
"Pipeline: ..." instead of "Commit: ..." now.
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove N+1 SQL query loading project feature in dashboard</title>
<updated>2019-08-23T21:11:23+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-08-23T20:53:02+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=29e60b0643ca5451919df233a9aeb4825779e846'/>
<id>29e60b0643ca5451919df233a9aeb4825779e846</id>
<content type='text'>
Projects that have a pipeline may need to check whether the user has
permission to read the build (`can?(current_user, :read_build,
project)`), which requires checking the `project_features` table.
This would cause an N+1 SQL query for each project.

This change also has a beneficial side effect that may avoid a race
condition. When a user deletes a project, the project is queued for
deletion and the user is redirected back to the dashboard page. However,
the following may happen:

1. The dashboard page may load this deleted project in the list of
20 projects.
2. The view will load the project pipeline status from the cache and
attempt to show each project.
3. When the view encounters the deleted project, it calls
`can?(current_user, :read_build, project)` to determine whether to
display the pipeline status.
4. Sidekiq deletes the project from the database.
5. However, since the deleted project is still loaded in memory, it will
attempt to call `project.project_feature.access_level`.
6. Since `project_feature` was not eager loaded, a lazy `SELECT` call is
made to the database.
7. This `SELECT` call returns nothing, and the user sees a 500 error.

By eager loading `project_feature`, we can ensure that we have a
consistent view and avoid records from being deleted later.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66482
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Projects that have a pipeline may need to check whether the user has
permission to read the build (`can?(current_user, :read_build,
project)`), which requires checking the `project_features` table.
This would cause an N+1 SQL query for each project.

This change also has a beneficial side effect that may avoid a race
condition. When a user deletes a project, the project is queued for
deletion and the user is redirected back to the dashboard page. However,
the following may happen:

1. The dashboard page may load this deleted project in the list of
20 projects.
2. The view will load the project pipeline status from the cache and
attempt to show each project.
3. When the view encounters the deleted project, it calls
`can?(current_user, :read_build, project)` to determine whether to
display the pipeline status.
4. Sidekiq deletes the project from the database.
5. However, since the deleted project is still loaded in memory, it will
attempt to call `project.project_feature.access_level`.
6. Since `project_feature` was not eager loaded, a lazy `SELECT` call is
made to the database.
7. This `SELECT` call returns nothing, and the user sees a 500 error.

By eager loading `project_feature`, we can ensure that we have a
consistent view and avoid records from being deleted later.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66482
</pre>
</div>
</content>
</entry>
<entry>
<title>Hide duplicate board list while dragging</title>
<updated>2019-08-23T11:40:56+00:00</updated>
<author>
<name>Winnie Hellmann</name>
<email>winnie@gitlab.com</email>
</author>
<published>2019-08-23T11:40:56+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8d5fac4f56bb6c0d6625ea5f6364796a80196933'/>
<id>8d5fac4f56bb6c0d6625ea5f6364796a80196933</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Always pre-select "Start a new merge request"</title>
<updated>2019-08-22T23:23:06+00:00</updated>
<author>
<name>Denys Mishunov</name>
<email>dmishunov@gitlab.com</email>
</author>
<published>2019-08-22T23:23:06+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=371e1ed3716d25f48c6458373e64ea81e0a45946'/>
<id>371e1ed3716d25f48c6458373e64ea81e0a45946</id>
<content type='text'>
One exception: there is an existing MR for the current branch and the
branch is non-default and non-protected.

Extended mock_data for ide/stores to have different types of branches:
default, protected and regular

Cleaned new MR checkbox view
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
One exception: there is an existing MR for the current branch and the
branch is non-default and non-protected.

Extended mock_data for ide/stores to have different types of branches:
default, protected and regular

Cleaned new MR checkbox view
</pre>
</div>
</content>
</entry>
</feed>
