diff options
author | Fatih Acet <acetfatih@gmail.com> | 2016-10-26 16:31:08 +0000 |
---|---|---|
committer | Fatih Acet <acetfatih@gmail.com> | 2016-10-26 16:31:08 +0000 |
commit | dd5e46ab693910f41333109bc8dfd5488121b440 (patch) | |
tree | f5f9fb333696a09c78f915a02a1d5dd1ca09c312 /.gitlab-ci.yml | |
parent | 5a4dabd0c9a58fbfc9ed103fa82bf84433756d27 (diff) | |
parent | 02f94cf038b08d25bc1b414a32d16f988fb9268e (diff) | |
download | gitlab-ce-dd5e46ab693910f41333109bc8dfd5488121b440.tar.gz |
Merge branch 'eslint' into 'master'
Add ESLint
## What does this MR do?
- create `package.json`
- add ESLint dependencies to `package.json`
- add JavaScript linting to CI
- add Rake task `lint:javascript`as alias for `eslint` (which itself is an alias for `npm run eslint`)
## Are there points in the code the reviewer needs to double check?
Probably not.
## Why was this MR needed?
My hovercraft was full of eels.
## What are the relevant issue numbers?
- https://gitlab.com/gitlab-org/gitlab-ce/issues/13224#note_12537431
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5006#note_13255658
See merge request !5445
Diffstat (limited to '.gitlab-ci.yml')
-rw-r--r-- | .gitlab-ci.yml | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 66a1791fc62..3f315550536 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -311,6 +311,14 @@ coverage: - coverage/index.html - coverage/assets/ +lint-javascript: + stage: test + image: "node:latest" + before_script: + - npm install + script: + - npm run eslint + # Trigger docs build # https://gitlab.com/gitlab-com/doc-gitlab-com/blob/master/README.md#deployment-process trigger_docs: |