diff options
| author | Yorick Peterse <yorickpeterse@gmail.com> | 2018-12-10 16:43:03 +0100 |
|---|---|---|
| committer | Yorick Peterse <yorickpeterse@gmail.com> | 2018-12-10 16:43:51 +0100 |
| commit | 09cf5514133e6493ee943b3d61c63a9f62c432a1 (patch) | |
| tree | 5408f01e1dce210c75e4206aed48be5f0379fdbf /.gitlab-ci.yml | |
| parent | 7dd8ef3e269b658113ce9422f225355da92de0ff (diff) | |
| download | gitlab-ce-09cf5514133e6493ee943b3d61c63a9f62c432a1.tar.gz | |
Don't allow Danger to fail in CI any more
In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20654 this job
was marked as allowing failures, but this allows developers to ignore
the results that Danger produces. Since it's not clear why the job was
allowed to fail, and since it's somewhat counter productive, we no
longer allow it to fail.
Diffstat (limited to '.gitlab-ci.yml')
| -rw-r--r-- | .gitlab-ci.yml | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 898d740ed63..4ae319d64d7 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -488,7 +488,6 @@ danger-review: <<: *pull-cache image: registry.gitlab.com/gitlab-org/gitlab-build-images:danger stage: test - allow_failure: true dependencies: [] before_script: [] only: |