summaryrefslogtreecommitdiff
path: root/.gitlab
diff options
context:
space:
mode:
authorYorick Peterse <yorickpeterse@gmail.com>2018-04-03 16:34:21 +0000
committerYorick Peterse <yorickpeterse@gmail.com>2018-04-03 16:34:21 +0000
commit047caa8c3a34989ce4dea99831bda1cb89cc36d3 (patch)
treefbed0f70ce0047dc04deb6c1a4992f80fddf0457 /.gitlab
parentfb55b2716b0419303eeb8884a8e67ec7cc9f0ab3 (diff)
parente04bfdac95b36bce262d97ff1df6f8f6e5b8333d (diff)
downloadgitlab-ce-047caa8c3a34989ce4dea99831bda1cb89cc36d3.tar.gz
Merge branch 'docs-add-qa-step-to-database-mr-template' into 'master'
Update the 'Database Changes' MR template to add a step for QA See merge request gitlab-org/gitlab-ce!16670
Diffstat (limited to '.gitlab')
-rw-r--r--.gitlab/merge_request_templates/Database Changes.md11
1 files changed, 7 insertions, 4 deletions
diff --git a/.gitlab/merge_request_templates/Database Changes.md b/.gitlab/merge_request_templates/Database Changes.md
index 8302b3b30c7..68bc0fd1c7f 100644
--- a/.gitlab/merge_request_templates/Database Changes.md
+++ b/.gitlab/merge_request_templates/Database Changes.md
@@ -33,13 +33,16 @@ When removing columns, tables, indexes or other structures:
## General Checklist
-- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
-- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
+- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
+- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
-- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
-- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
+- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
+- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
+- [ ] Internationalization required/considered
+- [ ] If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
+- [ ] End-to-end tests pass (`package-qa` manual pipeline job)