summaryrefslogtreecommitdiff
path: root/.gitlab
diff options
context:
space:
mode:
authorOlivier Gonzalez <ogonzalez@gitlab.com>2018-05-11 15:30:36 -0400
committerOlivier Gonzalez <ogonzalez@gitlab.com>2018-05-11 15:30:36 -0400
commit2543a0a942c60a3581dd35bae6d4fa1ee8ee70c0 (patch)
tree3f9ceae9370d83a100a51340eace5116e84589ed /.gitlab
parent40683268b2b5ad807194387d8345a30195e178c4 (diff)
downloadgitlab-ce-2543a0a942c60a3581dd35bae6d4fa1ee8ee70c0.tar.gz
Improve code review section in MR templates. refs #46297
Diffstat (limited to '.gitlab')
-rw-r--r--.gitlab/merge_request_templates/Database Changes.md6
1 files changed, 3 insertions, 3 deletions
diff --git a/.gitlab/merge_request_templates/Database Changes.md b/.gitlab/merge_request_templates/Database Changes.md
index 2bb1f374e98..b81900f67e1 100644
--- a/.gitlab/merge_request_templates/Database Changes.md
+++ b/.gitlab/merge_request_templates/Database Changes.md
@@ -37,9 +37,9 @@ When removing columns, tables, indexes or other structures:
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
-- Review
- - [ ] Has been reviewed by Backend
- - [ ] Has been reviewed by Database
+- Conform by the [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html)
+ - [ ] Has been reviewed by a Backend maintainer
+ - [ ] Has been reviewed by a Database specialist
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)