diff options
| author | Robert Speicher <robert@gitlab.com> | 2016-07-29 15:58:09 +0000 |
|---|---|---|
| committer | Robert Speicher <robert@gitlab.com> | 2016-07-29 15:58:09 +0000 |
| commit | 34c083a184b98372b3b28a661d5cf41e0f2d8259 (patch) | |
| tree | 54832269f981fa1fc0480ad1c2d448b7fc476718 /.rubocop.yml | |
| parent | 4284724de4ac86595dfa09cc1f8301770d667db7 (diff) | |
| parent | d6f669774481b160c2d963b56309ab6262216c42 (diff) | |
| download | gitlab-ce-34c083a184b98372b3b28a661d5cf41e0f2d8259.tar.gz | |
Merge branch 'rubocop/enable-access-modifiers-cops' into 'master'
Enable Rubocop cops that check access modifiers
## What does this MR do?
This MR enables Rubocop cops that detect methods that should be restricted but are the part of public API because of access modifiers used improperly.
This also fixes existing offenses.
## Why was this MR needed?
Some method in our codebase are public instead of being private because it is sometimes difficult to get it right without static analysis.
## What are the relevant issue numbers?
See #17478
Closes #17372
See merge request !5014
Diffstat (limited to '.rubocop.yml')
| -rw-r--r-- | .rubocop.yml | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/.rubocop.yml b/.rubocop.yml index 6adbda53456..556a5d11a39 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -510,6 +510,15 @@ Metrics/PerceivedComplexity: #################### Lint ################################ +# Checks for useless access modifiers. +Lint/UselessAccessModifier: + Enabled: true + +# Checks for attempts to use `private` or `protected` to set the visibility +# of a class method, which does not work. +Lint/IneffectiveAccessModifier: + Enabled: false + # Checks for ambiguous operators in the first argument of a method invocation # without parentheses. Lint/AmbiguousOperator: |