summaryrefslogtreecommitdiff
path: root/.rubocop.yml
diff options
context:
space:
mode:
authorDouwe Maan <douwe@selenight.nl>2017-02-22 12:37:01 -0600
committerDouwe Maan <douwe@selenight.nl>2017-02-23 09:32:42 -0600
commit2afb65468d688caa64ea53abfed35d0f4081102b (patch)
treeaa088a6ff43a90e1ba0227b3f2d4ca6b2e92cbe4 /.rubocop.yml
parent87c9df29ce8835da5d68dbf3e59674bd4524ee96 (diff)
downloadgitlab-ce-2afb65468d688caa64ea53abfed35d0f4081102b.tar.gz
Order cops alphabetically
Diffstat (limited to '.rubocop.yml')
-rw-r--r--.rubocop.yml244
1 files changed, 123 insertions, 121 deletions
diff --git a/.rubocop.yml b/.rubocop.yml
index 86f5df61724..4515bc431f1 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -24,6 +24,9 @@ AllCops:
- 'bin/**/*'
- 'generator_templates/**/*'
+Bundler/OrderedGems:
+ Enabled: false
+
# Style #######################################################################
# Check indentation of private/protected visibility modifiers.
@@ -47,6 +50,9 @@ Style/AlignArray:
Style/AlignHash:
Enabled: true
+Style/AlignParameters:
+ Enabled: false
+
# Whether `and` and `or` are banned only in conditionals (conditionals)
# or completely (always).
Style/AndOr:
@@ -68,6 +74,9 @@ Style/AsciiIdentifiers:
Style/Attr:
Enabled: true
+Style/BarePercentLiterals:
+ Enabled: true
+
# Avoid the use of BEGIN blocks.
Style/BeginBlock:
Enabled: true
@@ -76,15 +85,21 @@ Style/BeginBlock:
Style/BlockComments:
Enabled: true
-# Put end statement of multiline block on its own line.
-Style/BlockEndNewline:
- Enabled: true
-
# Avoid using {...} for multi-line blocks (multiline chaining is # always
# ugly). Prefer {...} over do...end for single-line blocks.
Style/BlockDelimiters:
Enabled: true
+# Put end statement of multiline block on its own line.
+Style/BlockEndNewline:
+ Enabled: true
+
+Style/BracesAroundHashParameters:
+ Enabled: false
+
+Style/CaseEquality:
+ Enabled: false
+
# Indentation of when in a case/when/[else/]end.
Style/CaseIndentation:
Enabled: true
@@ -113,10 +128,19 @@ Style/ClassMethods:
Style/ClassVars:
Enabled: true
+Style/ColonMethodCall:
+ Enabled: true
+
+Style/CommentAnnotation:
+ Enabled: false
+
# Indentation of comments.
Style/CommentIndentation:
Enabled: true
+Style/ConditionalAssignment:
+ Enabled: true
+
# Constants should use SCREAMING_SNAKE_CASE.
Style/ConstantName:
Enabled: true
@@ -133,6 +157,9 @@ Style/DotPosition:
Enabled: true
EnforcedStyle: leading
+Style/DoubleNegation:
+ Enabled: false
+
# Align elses and elsifs correctly.
Style/ElseAlignment:
Enabled: true
@@ -157,14 +184,14 @@ Style/EmptyLinesAroundBlockBody:
Style/EmptyLinesAroundClassBody:
Enabled: true
-# Keeps track of empty lines around module bodies.
-Style/EmptyLinesAroundModuleBody:
- Enabled: true
-
# Keeps track of empty lines around method bodies.
Style/EmptyLinesAroundMethodBody:
Enabled: true
+# Keeps track of empty lines around module bodies.
+Style/EmptyLinesAroundModuleBody:
+ Enabled: true
+
# Avoid the use of END blocks.
Style/EndBlock:
Enabled: true
@@ -210,15 +237,15 @@ Style/GlobalVars:
Style/HashSyntax:
Enabled: true
-# Do not use if x; .... Use the ternary operator instead.
-Style/IfWithSemicolon:
- Enabled: true
-
# Checks that conditional statements do not have an identical line at the
# end of each branch, which can validly be moved out of the conditional.
Style/IdenticalConditionalBranches:
Enabled: true
+# Do not use if x; .... Use the ternary operator instead.
+Style/IfWithSemicolon:
+ Enabled: true
+
# Checks the indentation of the first line of the right-hand-side of a
# multi-line assignment.
Style/IndentAssignment:
@@ -497,6 +524,9 @@ Metrics/AbcSize:
Enabled: true
Max: 60
+Metrics/BlockLength:
+ Enabled: false
+
# Avoid excessive block nesting.
Metrics/BlockNesting:
Enabled: true
@@ -536,20 +566,17 @@ Metrics/PerceivedComplexity:
# Lint ########################################################################
-# Checks for useless access modifiers.
-Lint/UselessAccessModifier:
- Enabled: true
-
-# Checks for attempts to use `private` or `protected` to set the visibility
-# of a class method, which does not work.
-Lint/IneffectiveAccessModifier:
- Enabled: false
-
# Checks for ambiguous operators in the first argument of a method invocation
# without parentheses.
Lint/AmbiguousOperator:
Enabled: true
+Lint/AmbiguousRegexpLiteral:
+ Enabled: false
+
+Lint/AssignmentInCondition:
+ Enabled: false
+
# Align block ends correctly.
Lint/BlockAlignment:
Enabled: true
@@ -615,11 +642,19 @@ Lint/FloatOutOfRange:
Lint/FormatParameterMismatch:
Enabled: true
+Lint/HandleExceptions:
+ Enabled: false
+
# Checks for adjacent string literals on the same line, which could better be
# represented as a single string literal.
Lint/ImplicitStringConcatenation:
Enabled: true
+# Checks for attempts to use `private` or `protected` to set the visibility
+# of a class method, which does not work.
+Lint/IneffectiveAccessModifier:
+ Enabled: false
+
# Checks for invalid character literals with a non-escaped whitespace
# character.
Lint/InvalidCharacterLiteral:
@@ -633,6 +668,9 @@ Lint/LiteralInCondition:
Lint/LiteralInInterpolation:
Enabled: true
+Lint/Loop:
+ Enabled: false
+
# Do not use nested method definitions.
Lint/NestedMethodDefinition:
Enabled: true
@@ -662,6 +700,9 @@ Lint/RescueException:
Lint/ShadowedException:
Enabled: false
+Lint/ShadowingOuterLocalVariable:
+ Enabled: false
+
# Checks for Object#to_s usage in string interpolation.
Lint/StringConversionInInterpolation:
Enabled: true
@@ -670,19 +711,32 @@ Lint/StringConversionInInterpolation:
Lint/UnderscorePrefixedVariableName:
Enabled: true
+Lint/UnifiedInteger:
+ Enabled: true
+
# Checks for rubocop:disable comments that can be removed.
# Note: this cop is not disabled when disabling all cops.
# It must be explicitly disabled.
Lint/UnneededDisable:
Enabled: false
+Lint/UnneededSplatExpansion:
+ Enabled: false
+
# Unreachable code.
Lint/UnreachableCode:
Enabled: true
+Lint/UnusedBlockArgument:
+ Enabled: false
+
Lint/UnusedMethodArgument:
Enabled: false
+# Checks for useless access modifiers.
+Lint/UselessAccessModifier:
+ Enabled: true
+
# Checks for useless assignment to a local variable.
Lint/UselessAssignment:
Enabled: true
@@ -722,6 +776,16 @@ Performance/LstripRstrip:
Performance/RangeInclude:
Enabled: true
+Performance/RedundantBlockCall:
+ Enabled: true
+
+Performance/RedundantMatch:
+ Enabled: true
+
+Performance/RedundantMerge:
+ Enabled: true
+ MaxKeyValuePairs: 1
+
# Use `sort` instead of `sort_by { |x| x }`.
Performance/RedundantSortBy:
Enabled: true
@@ -741,6 +805,11 @@ Performance/StringReplacement:
Performance/TimesMap:
Enabled: true
+# Security ####################################################################
+
+Security/JSONLoad:
+ Enabled: true
+
# Rails #######################################################################
# Enables Rails cops.
@@ -761,6 +830,15 @@ Rails/Date:
Rails/Delegate:
Enabled: true
+Rails/DynamicFindBy:
+ Enabled: false
+
+Rails/Exit:
+ Enabled: true
+ Exclude:
+ - lib/gitlab/upgrader.rb
+ - 'lib/backup/**/*'
+
# Prefer `find_by` over `where.first`.
Rails/FindBy:
Enabled: true
@@ -773,6 +851,9 @@ Rails/FindEach:
Rails/HasAndBelongsToMany:
Enabled: true
+Rails/HttpPositionalArguments:
+ Enabled: false
+
# Checks for calls to puts, print, etc.
Rails/Output:
Enabled: true
@@ -782,6 +863,9 @@ Rails/Output:
- 'lib/backup/**/*'
- 'lib/tasks/**/*'
+Rails/OutputSafety:
+ Enabled: false
+
# Checks for incorrect grammar when using methods like `3.day.ago`.
Rails/PluralizationGrammar:
Enabled: true
@@ -794,6 +878,12 @@ Rails/ReadWriteAttribute:
Rails/ScopeArgs:
Enabled: true
+Rails/TimeZone:
+ Enabled: false
+
+Rails/Validation:
+ Enabled: true
+
# RSpec #######################################################################
# Check that instances are not being stubbed globally.
@@ -851,50 +941,9 @@ RSpec/Focus:
RSpec/InstanceVariable:
Enabled: false
-# Checks for multiple top-level describes.
-RSpec/MultipleDescribes:
- Enabled: false
-
-# Enforces the usage of the same method on all negative message expectations.
-RSpec/NotToNot:
- EnforcedStyle: not_to
- Enabled: true
-
-# Prefer using verifying doubles over normal doubles.
-RSpec/VerifiedDoubles:
- Enabled: false
-
-RSpec/MultipleExpectations:
- Enabled: false
-
-RSpec/NamedSubject:
- Enabled: false
-
-RSpec/NestedGroups:
- Enabled: false
-
RSpec/LeadingSubject:
Enabled: false
-Lint/AmbiguousRegexpLiteral:
- Enabled: false
-
-Bundler/OrderedGems:
- Enabled: false
-
-Lint/HandleExceptions:
- Enabled: false
-
-Lint/Loop:
- Enabled: false
-
-Metrics/BlockLength:
- Enabled: false
-
-Performance/RedundantMerge:
- Enabled: true
- MaxKeyValuePairs: 1
-
RSpec/LetSetup:
Enabled: false
@@ -904,77 +953,30 @@ RSpec/MessageChain:
RSpec/MessageSpies:
Enabled: false
-RSpec/RepeatedDescription:
- Enabled: false
-
-RSpec/SubjectStub:
- Enabled: false
-
-Lint/UnifiedInteger:
- Enabled: true
-
-Lint/ShadowingOuterLocalVariable:
- Enabled: false
-
-Lint/AssignmentInCondition:
- Enabled: false
-
-Lint/UnneededSplatExpansion:
- Enabled: false
-
-Lint/UnusedBlockArgument:
- Enabled: false
-
-Performance/RedundantBlockCall:
- Enabled: true
-
-Performance/RedundantMatch:
- Enabled: true
-
-Rails/DynamicFindBy:
- Enabled: false
-
-Rails/HttpPositionalArguments:
+# Checks for multiple top-level describes.
+RSpec/MultipleDescribes:
Enabled: false
-Rails/OutputSafety:
+RSpec/MultipleExpectations:
Enabled: false
-Rails/TimeZone:
+RSpec/NamedSubject:
Enabled: false
-Rails/Validation:
- Enabled: true
-
-Security/JSONLoad:
- Enabled: true
-
-Style/AlignParameters:
+RSpec/NestedGroups:
Enabled: false
-Style/BarePercentLiterals:
+# Enforces the usage of the same method on all negative message expectations.
+RSpec/NotToNot:
+ EnforcedStyle: not_to
Enabled: true
-Style/BracesAroundHashParameters:
- Enabled: false
-
-Style/CaseEquality:
+RSpec/RepeatedDescription:
Enabled: false
-Style/ColonMethodCall:
- Enabled: true
-
-Style/CommentAnnotation:
+RSpec/SubjectStub:
Enabled: false
-Style/ConditionalAssignment:
- Enabled: true
-
-Style/DoubleNegation:
+# Prefer using verifying doubles over normal doubles.
+RSpec/VerifiedDoubles:
Enabled: false
-
-Rails/Exit:
- Enabled: true
- Exclude:
- - lib/gitlab/upgrader.rb
- - 'lib/backup/**/*'