diff options
| author | Rémy Coutable <remy@rymai.me> | 2016-05-11 08:59:44 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2016-05-11 08:59:44 +0000 |
| commit | e77a9a342e175c7274350ef6d655bde496eca778 (patch) | |
| tree | 0eb8e88db37a165b9098960caa32d0cf09ba52f1 /.rubocop.yml | |
| parent | de5ae1bf0604c9d250145e2c6aeaa0adfdc760bf (diff) | |
| parent | 377583a361988d9884808a3c3f5375497a9d5b56 (diff) | |
| download | gitlab-ce-e77a9a342e175c7274350ef6d655bde496eca778.tar.gz | |
Merge branch 'casecmp-cop' into 'master'
Enable Rubocop Casecmp Performance Cop.
Also fixes the errors caused by enabling the cop.
`casecmp` is more performant than `.downcase` and `==`.
See also: https://github.com/bbatsov/rubocop/blob/master/lib/rubocop/cop/performance/casecmp.rb
See merge request !3957
Diffstat (limited to '.rubocop.yml')
| -rw-r--r-- | .rubocop.yml | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/.rubocop.yml b/.rubocop.yml index c96c7123c16..ccceea45963 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -937,10 +937,9 @@ Lint/Void: ##################### Performance ############################ -# TODO: Enable Casecmp Cop. # Use `casecmp` rather than `downcase ==`. Performance/Casecmp: - Enabled: false + Enabled: true # TODO: Enable DoubleStartEndWith Cop. # Use `str.{start,end}_with?(x, ..., y, ...)` instead of |