summaryrefslogtreecommitdiff
path: root/.rubocop.yml
diff options
context:
space:
mode:
authorNick Thomas <nick@gitlab.com>2019-03-29 11:23:05 +0000
committerNick Thomas <nick@gitlab.com>2019-03-29 20:54:06 +0000
commit98a5976b787fad0797bc5e3231c48ab3f400bce6 (patch)
treeffb8799b5bbb65b3bcc7c54a8a59456f4777981c /.rubocop.yml
parent0d26c48332e7c580946adbd41795d4817909e2ef (diff)
downloadgitlab-ce-98a5976b787fad0797bc5e3231c48ab3f400bce6.tar.gz
Document ApplicationRecord / pluck_primary_key
We also enable the rubocop that makes it mandatory
Diffstat (limited to '.rubocop.yml')
-rw-r--r--.rubocop.yml14
1 files changed, 14 insertions, 0 deletions
diff --git a/.rubocop.yml b/.rubocop.yml
index 9143966b864..648d59e8062 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -146,6 +146,20 @@ Naming/FileName:
- XSS
- GRPC
+Rails/ApplicationRecord:
+ Enabled: true
+ Exclude:
+ # Models in database migrations should not subclass from ApplicationRecord
+ # as they need to be as decoupled from application code as possible
+ - db/**/*.rb
+ - lib/gitlab/background_migration/**/*.rb
+ - lib/gitlab/database/**/*.rb
+ - spec/**/*.rb
+ - ee/db/**/*.rb
+ - ee/lib/gitlab/background_migration/**/*.rb
+ - ee/lib/ee/gitlab/background_migration/**/*.rb
+ - ee/spec/**/*.rb
+
# GitLab ###################################################################
Gitlab/ModuleWithInstanceVariables: