diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-05-19 15:44:42 +0000 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-05-19 15:44:42 +0000 |
commit | 4555e1b21c365ed8303ffb7a3325d773c9b8bf31 (patch) | |
tree | 5423a1c7516cffe36384133ade12572cf709398d /.rubocop_manual_todo.yml | |
parent | e570267f2f6b326480d284e0164a6464ba4081bc (diff) | |
download | gitlab-ce-4555e1b21c365ed8303ffb7a3325d773c9b8bf31.tar.gz |
Add latest changes from gitlab-org/gitlab@13-12-stable-eev13.12.0-rc42
Diffstat (limited to '.rubocop_manual_todo.yml')
-rw-r--r-- | .rubocop_manual_todo.yml | 340 |
1 files changed, 7 insertions, 333 deletions
diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index f2aa94ac7ea..e5cb55488d7 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -13,22 +13,9 @@ # WIP See https://gitlab.com/gitlab-org/gitlab/-/issues/322903 Graphql/Descriptions: Exclude: - - 'app/graphql/types/access_level_enum.rb' - - 'app/graphql/types/base_enum.rb' - - 'app/graphql/types/ci/pipeline_config_source_enum.rb' - - 'app/graphql/types/ci/pipeline_status_enum.rb' - - 'app/graphql/types/container_expiration_policy_cadence_enum.rb' - - 'app/graphql/types/container_expiration_policy_keep_enum.rb' - - 'app/graphql/types/container_expiration_policy_older_than_enum.rb' - - 'app/graphql/types/notes/position_type_enum.rb' - - 'app/graphql/types/packages/package_type_enum.rb' - 'app/graphql/types/snippets/blob_action_enum.rb' - - 'app/graphql/types/snippets/type_enum.rb' - 'app/graphql/types/snippets/visibility_scopes_enum.rb' - - 'app/graphql/types/todo_action_enum.rb' - - 'app/graphql/types/tree/type_enum.rb' - 'ee/app/graphql/ee/types/list_limit_metric_enum.rb' - - 'ee/app/graphql/types/alert_management/payload_alert_field_name_enum.rb' - 'ee/app/graphql/types/epic_state_enum.rb' - 'ee/app/graphql/types/health_status_enum.rb' - 'ee/app/graphql/types/iteration_state_enum.rb' @@ -60,18 +47,11 @@ Rails/SaveBang: - 'ee/spec/lib/gitlab/git_access_spec.rb' - 'ee/spec/lib/gitlab/import_export/group/relation_factory_spec.rb' - 'ee/spec/lib/gitlab/mirror_spec.rb' - - 'ee/spec/mailers/notify_spec.rb' - 'ee/spec/models/application_setting_spec.rb' - 'ee/spec/models/approval_merge_request_rule_spec.rb' - 'ee/spec/models/approval_project_rule_spec.rb' - 'ee/spec/models/burndown_spec.rb' - - 'ee/spec/models/ee/appearance_spec.rb' - - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - - 'ee/spec/models/ee/protected_branch_spec.rb' - - 'ee/spec/models/ee/protected_ref_access_spec.rb' - - 'ee/spec/models/ee/protected_ref_spec.rb' - 'ee/spec/models/elasticsearch_indexed_namespace_spec.rb' - - 'ee/spec/models/environment_spec.rb' - 'ee/spec/models/epic_spec.rb' - 'ee/spec/models/gitlab_subscription_spec.rb' - 'ee/spec/models/issue_spec.rb' @@ -92,8 +72,6 @@ Rails/SaveBang: - 'ee/spec/models/visible_approvable_spec.rb' - 'ee/spec/models/vulnerabilities/feedback_spec.rb' - 'ee/spec/models/vulnerabilities/issue_link_spec.rb' - - 'ee/spec/services/approval_rules/finalize_service_spec.rb' - - 'ee/spec/services/approval_rules/update_service_spec.rb' - 'ee/spec/services/ee/boards/issues/create_service_spec.rb' - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' - 'ee/spec/services/ee/boards/lists/list_service_spec.rb' @@ -126,23 +104,6 @@ Rails/SaveBang: - 'ee/spec/services/status_page/trigger_publish_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' - 'ee/spec/services/vulnerability_feedback/create_service_spec.rb' - - 'ee/spec/support/protected_tags/access_control_shared_examples.rb' - - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb' - - 'ee/spec/support/shared_examples/finders/geo/framework_registry_finder_shared_examples.rb' - - 'ee/spec/support/shared_examples/graphql/geo/geo_registries_resolver_shared_examples.rb' - - 'ee/spec/support/shared_examples/lib/analytics/common_merge_request_metrics_refresh_shared_examples.rb' - - 'ee/spec/support/shared_examples/policies/protected_environments_shared_examples.rb' - - 'ee/spec/workers/adjourned_project_deletion_worker_spec.rb' - - 'ee/spec/workers/clear_shared_runners_minutes_worker_spec.rb' - - 'ee/spec/workers/create_github_webhook_worker_spec.rb' - - 'ee/spec/workers/elastic_namespace_rollout_worker_spec.rb' - - 'ee/spec/workers/geo/container_repository_sync_dispatch_worker_spec.rb' - - 'ee/spec/workers/geo/file_download_dispatch_worker_spec.rb' - - 'ee/spec/workers/geo/prune_event_log_worker_spec.rb' - - 'ee/spec/workers/geo/registry_sync_worker_spec.rb' - - 'ee/spec/workers/geo/repository_shard_sync_worker_spec.rb' - - 'ee/spec/workers/repository_import_worker_spec.rb' - - 'ee/spec/workers/update_all_mirrors_worker_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_mirroring_over_http_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_mirroring_lfs_over_http_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_http_spec.rb' @@ -151,11 +112,6 @@ Rails/SaveBang: - 'spec/controllers/boards/issues_controller_spec.rb' - 'spec/controllers/sent_notifications_controller_spec.rb' - 'spec/controllers/sessions_controller_spec.rb' - - 'spec/frontend/fixtures/issues.rb' - - 'spec/frontend/fixtures/merge_requests.rb' - - 'spec/graphql/mutations/merge_requests/set_locked_spec.rb' - - 'spec/graphql/mutations/merge_requests/set_wip_spec.rb' - - 'spec/graphql/resolvers/boards_resolver_spec.rb' - 'spec/lib/after_commit_queue_spec.rb' - 'spec/lib/backup/manager_spec.rb' - 'spec/lib/gitlab/alerting/alert_spec.rb' @@ -200,9 +156,6 @@ Rails/SaveBang: - 'spec/lib/gitlab/middleware/go_spec.rb' - 'spec/lib/gitlab/shard_health_cache_spec.rb' - 'spec/mailers/notify_spec.rb' - - 'spec/models/appearance_spec.rb' - - 'spec/models/application_record_spec.rb' - - 'spec/models/application_setting_spec.rb' - 'spec/models/clusters/applications/helm_spec.rb' - 'spec/models/container_repository_spec.rb' - 'spec/models/design_management/version_spec.rb' @@ -219,9 +172,6 @@ Rails/SaveBang: - 'spec/models/jira_import_state_spec.rb' - 'spec/models/key_spec.rb' - 'spec/models/lfs_objects_project_spec.rb' - - 'spec/models/member_spec.rb' - - 'spec/models/members/group_member_spec.rb' - - 'spec/models/members/project_member_spec.rb' - 'spec/models/merge_request_spec.rb' - 'spec/models/milestone_spec.rb' - 'spec/models/namespace_spec.rb' @@ -231,10 +181,6 @@ Rails/SaveBang: - 'spec/models/operations/feature_flags/strategy_spec.rb' - 'spec/models/operations/feature_flags/user_list_spec.rb' - 'spec/models/pages_domain_spec.rb' - - 'spec/models/project_auto_devops_spec.rb' - - 'spec/models/project_feature_spec.rb' - - 'spec/models/project_spec.rb' - - 'spec/models/project_team_spec.rb' - 'spec/models/protectable_dropdown_spec.rb' - 'spec/models/redirect_route_spec.rb' - 'spec/models/release_spec.rb' @@ -242,14 +188,8 @@ Rails/SaveBang: - 'spec/models/resource_milestone_event_spec.rb' - 'spec/models/route_spec.rb' - 'spec/models/sentry_issue_spec.rb' - - 'spec/models/service_spec.rb' - 'spec/models/snippet_spec.rb' - 'spec/models/upload_spec.rb' - - 'spec/models/user_preference_spec.rb' - - 'spec/models/user_spec.rb' - - 'spec/models/user_status_spec.rb' - - 'spec/models/wiki_page/meta_spec.rb' - - 'spec/models/wiki_page_spec.rb' Rails/TimeZone: Enabled: true @@ -410,61 +350,12 @@ Rails/TimeZone: # WIP: https://gitlab.com/gitlab-org/gitlab/-/issues/325836 RSpec/EmptyLineAfterFinalLetItBe: Exclude: - - ee/spec/controllers/groups/analytics/cycle_analytics/stages_controller_spec.rb - - ee/spec/controllers/groups/analytics/cycle_analytics/summary_controller_spec.rb - - ee/spec/controllers/groups/analytics/cycle_analytics/value_streams_controller_spec.rb - - ee/spec/controllers/groups/analytics/tasks_by_type_controller_spec.rb - - ee/spec/controllers/groups/autocomplete_sources_controller_spec.rb - - ee/spec/controllers/groups/insights_controller_spec.rb - - ee/spec/controllers/groups/todos_controller_spec.rb - - ee/spec/controllers/projects/branches_controller_spec.rb - - ee/spec/controllers/projects/incident_management/oncall_schedules_controller_spec.rb - - ee/spec/controllers/projects/insights_controller_spec.rb - - ee/spec/controllers/projects/licenses_controller_spec.rb - - ee/spec/controllers/projects/merge_requests_controller_spec.rb - - ee/spec/controllers/projects/mirrors_controller_spec.rb - - ee/spec/controllers/projects/threat_monitoring_controller_spec.rb - ee/spec/controllers/subscriptions_controller_spec.rb - - ee/spec/features/boards/group_boards/multiple_boards_spec.rb - ee/spec/features/ci_shared_runner_warnings_spec.rb - - ee/spec/features/dashboards/todos_spec.rb - - ee/spec/features/groups/groups_security_credentials_spec.rb - - ee/spec/features/groups/hooks/user_edits_hooks_spec.rb - - ee/spec/features/groups/iterations/user_edits_iteration_spec.rb - - ee/spec/features/groups/usage_quotas_spec.rb - ee/spec/features/integrations/jira/jira_issues_list_spec.rb - - ee/spec/features/issues/bulk_assignment_epic_spec.rb - - ee/spec/features/issues/user_uses_quick_actions_spec.rb - ee/spec/features/markdown/metrics_spec.rb - ee/spec/features/registrations/group_invites_during_signup_flow_spec.rb - ee/spec/features/subscriptions_spec.rb - - ee/spec/graphql/ee/mutations/concerns/mutations/resolves_issuable_spec.rb - - ee/spec/graphql/mutations/boards/update_epic_user_preferences_spec.rb - - ee/spec/graphql/mutations/clusters/agent_tokens/create_spec.rb - - ee/spec/graphql/mutations/compliance_management/frameworks/create_spec.rb - - ee/spec/graphql/mutations/compliance_management/frameworks/destroy_spec.rb - - ee/spec/graphql/mutations/compliance_management/frameworks/update_spec.rb - - ee/spec/graphql/mutations/dast_scanner_profiles/delete_spec.rb - - ee/spec/graphql/mutations/epics/add_issue_spec.rb - - ee/spec/graphql/mutations/gitlab_subscriptions/activate_spec.rb - - ee/spec/graphql/mutations/incident_management/oncall_rotation/create_spec.rb - - ee/spec/graphql/mutations/incident_management/oncall_rotation/destroy_spec.rb - - ee/spec/graphql/mutations/incident_management/oncall_schedule/create_spec.rb - - ee/spec/graphql/mutations/incident_management/oncall_schedule/destroy_spec.rb - - ee/spec/graphql/mutations/incident_management/oncall_schedule/update_spec.rb - - ee/spec/graphql/mutations/issues/set_epic_spec.rb - - ee/spec/graphql/mutations/requirements_management/export_requirements_spec.rb - - ee/spec/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb - - ee/spec/graphql/types/issue_type_spec.rb - - ee/spec/helpers/ee/graph_helper_spec.rb - - ee/spec/helpers/ee/issues_helper_spec.rb - - ee/spec/helpers/ee/projects/incidents_helper_spec.rb - - ee/spec/helpers/ee/projects/security/api_fuzzing_configuration_helper_spec.rb - - ee/spec/helpers/ee/projects/security/configuration_helper_spec.rb - - ee/spec/helpers/ee/projects/security/sast_configuration_helper_spec.rb - - ee/spec/helpers/ee/trial_helper_spec.rb - - ee/spec/helpers/ee/user_callouts_helper_spec.rb - - ee/spec/helpers/vulnerabilities_helper_spec.rb - ee/spec/lib/ee/api/entities/user_with_admin_spec.rb - ee/spec/lib/ee/api/entities/vulnerability_spec.rb - ee/spec/lib/ee/event_filter_spec.rb @@ -484,9 +375,6 @@ RSpec/EmptyLineAfterFinalLetItBe: - ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_time_summary_spec.rb - ee/spec/lib/gitlab/checks/diff_check_spec.rb - ee/spec/lib/gitlab/code_owners/loader_spec.rb - - ee/spec/lib/gitlab/elastic/document_reference_spec.rb - - ee/spec/lib/gitlab/elastic/group_search_results_spec.rb - - ee/spec/lib/gitlab/elastic/project_search_results_spec.rb - ee/spec/lib/gitlab/git_access_spec.rb - ee/spec/lib/gitlab/git_access_wiki_spec.rb - ee/spec/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate_spec.rb @@ -553,8 +441,6 @@ RSpec/EmptyLineAfterFinalLetItBe: - ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb - ee/spec/services/approval_rules/create_service_spec.rb - ee/spec/services/audit_event_service_spec.rb - - ee/spec/services/award_emojis/add_service_spec.rb - - ee/spec/services/award_emojis/destroy_service_spec.rb - ee/spec/services/billable_members/destroy_service_spec.rb - ee/spec/services/boards/epic_boards/destroy_service_spec.rb - ee/spec/services/clusters/agent_tokens/create_service_spec.rb @@ -563,7 +449,6 @@ RSpec/EmptyLineAfterFinalLetItBe: - ee/spec/services/dast_scanner_profiles/destroy_service_spec.rb - ee/spec/services/dast_scanner_profiles/update_service_spec.rb - ee/spec/services/dast_site_profiles/destroy_service_spec.rb - - ee/spec/services/dora/aggregate_metrics_service_spec.rb - ee/spec/services/external_approval_rules/create_service_spec.rb - ee/spec/services/external_approval_rules/destroy_service_spec.rb - ee/spec/services/external_approval_rules/update_service_spec.rb @@ -574,12 +459,6 @@ RSpec/EmptyLineAfterFinalLetItBe: - ee/spec/services/merge_request_approval_settings/update_service_spec.rb - ee/spec/services/personal_access_tokens/create_service_audit_log_spec.rb - ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb - - ee/spec/services/projects/after_rename_service_spec.rb - - ee/spec/services/projects/alerting/notify_service_spec.rb - - ee/spec/services/projects/destroy_service_spec.rb - - ee/spec/services/projects/gitlab_projects_import_service_spec.rb - - ee/spec/services/projects/import_export/export_service_spec.rb - - ee/spec/services/projects/transfer_service_spec.rb - ee/spec/services/push_rules/create_or_update_service_spec.rb - ee/spec/services/quality_management/test_cases/create_service_spec.rb - ee/spec/services/quick_actions/interpret_service_spec.rb @@ -588,11 +467,6 @@ RSpec/EmptyLineAfterFinalLetItBe: - ee/spec/services/requirements_management/update_requirement_service_spec.rb - ee/spec/services/resource_access_tokens/create_service_spec.rb - ee/spec/services/resource_access_tokens/revoke_service_spec.rb - - ee/spec/services/todo_service_spec.rb - - ee/spec/support/shared_examples/graphql/geo/geo_registries_resolver_shared_examples.rb - - ee/spec/support/shared_examples/graphql/mutations/set_multiple_assignees_shared_examples.rb - - ee/spec/support/shared_examples/quick_actions/issue/status_page_quick_actions_shared_examples.rb - - ee/spec/support/shared_examples/services/search_notes_shared_examples.rb - spec/controllers/confirmations_controller_spec.rb - spec/controllers/dashboard/projects_controller_spec.rb - spec/controllers/invites_controller_spec.rb @@ -606,30 +480,8 @@ RSpec/EmptyLineAfterFinalLetItBe: - spec/features/file_uploads/user_avatar_spec.rb - spec/features/issues/user_sees_breadcrumb_links_spec.rb - spec/features/markdown/metrics_spec.rb - - spec/features/merge_request/user_creates_merge_request_spec.rb - - spec/features/merge_request/user_posts_notes_spec.rb - spec/features/operations_sidebar_link_spec.rb - spec/features/participants_autocomplete_spec.rb - - spec/features/projects/badges/pipeline_badge_spec.rb - - spec/features/projects/branches/user_deletes_branch_spec.rb - - spec/features/projects/commit/cherry_pick_spec.rb - - spec/features/projects/commit/user_comments_on_commit_spec.rb - - spec/features/projects/commit/user_reverts_commit_spec.rb - - spec/features/projects/commit/user_views_user_status_on_commit_spec.rb - - spec/features/projects/confluence/user_views_confluence_page_spec.rb - - spec/features/projects/files/gitlab_ci_syntax_yml_dropdown_spec.rb - - spec/features/projects/issues/design_management/user_views_design_images_spec.rb - - spec/features/projects/labels/user_sees_links_to_issuables_spec.rb - - spec/features/projects/labels/user_views_labels_spec.rb - - spec/features/projects/members/master_adds_member_with_expiration_date_spec.rb - - spec/features/projects/merge_request_button_spec.rb - - spec/features/projects/pages/user_adds_domain_spec.rb - - spec/features/projects/pipelines/pipeline_spec.rb - - spec/features/projects/product_analytics/events_spec.rb - - spec/features/projects/settings/project_settings_spec.rb - - spec/features/projects/settings/repository_settings_spec.rb - - spec/features/projects/snippets/user_views_snippets_spec.rb - - spec/features/projects/user_sees_user_popover_spec.rb - spec/features/snippets/embedded_snippet_spec.rb - spec/finders/alert_management/alerts_finder_spec.rb - spec/finders/ci/commit_statuses_finder_spec.rb @@ -650,16 +502,6 @@ RSpec/EmptyLineAfterFinalLetItBe: - spec/frontend/fixtures/pipelines.rb - spec/graphql/features/authorization_spec.rb - spec/graphql/gitlab_schema_spec.rb - - spec/graphql/mutations/alert_management/alerts/todo/create_spec.rb - - spec/graphql/mutations/alert_management/create_alert_issue_spec.rb - - spec/graphql/mutations/alert_management/http_integration/create_spec.rb - - spec/graphql/mutations/alert_management/http_integration/destroy_spec.rb - - spec/graphql/mutations/alert_management/http_integration/reset_token_spec.rb - - spec/graphql/mutations/alert_management/http_integration/update_spec.rb - - spec/graphql/mutations/alert_management/prometheus_integration/create_spec.rb - - spec/graphql/mutations/alert_management/prometheus_integration/reset_token_spec.rb - - spec/graphql/mutations/alert_management/prometheus_integration/update_spec.rb - - spec/graphql/mutations/alert_management/update_alert_status_spec.rb - spec/graphql/mutations/boards/lists/update_spec.rb - spec/graphql/mutations/custom_emoji/create_spec.rb - spec/graphql/mutations/discussions/toggle_resolve_spec.rb @@ -667,53 +509,15 @@ RSpec/EmptyLineAfterFinalLetItBe: - spec/graphql/mutations/issues/set_severity_spec.rb - spec/graphql/mutations/labels/create_spec.rb - spec/graphql/mutations/notes/reposition_image_diff_note_spec.rb - - spec/graphql/resolvers/admin/analytics/usage_trends/measurements_resolver_spec.rb - - spec/graphql/resolvers/alert_management/alert_status_counts_resolver_spec.rb - - spec/graphql/resolvers/branch_commit_resolver_spec.rb - - spec/graphql/resolvers/design_management/designs_resolver_spec.rb - - spec/graphql/resolvers/design_management/version/designs_at_version_resolver_spec.rb - - spec/graphql/resolvers/group_milestones_resolver_spec.rb - - spec/graphql/resolvers/merge_request_pipelines_resolver_spec.rb - - spec/graphql/resolvers/metrics/dashboards/annotation_resolver_spec.rb - - spec/graphql/resolvers/project_pipeline_resolver_spec.rb - - spec/graphql/resolvers/project_pipelines_resolver_spec.rb - - spec/graphql/resolvers/timelog_resolver_spec.rb - spec/lib/bulk_imports/groups/loaders/group_loader_spec.rb - spec/lib/extracts_path_spec.rb - spec/lib/extracts_ref_spec.rb - spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb - - spec/lib/gitlab/ci/build/policy/changes_spec.rb - - spec/lib/gitlab/ci/config/external/file/local_spec.rb - - spec/lib/gitlab/ci/config/external/file/project_spec.rb - - spec/lib/gitlab/ci/config/external/file/template_spec.rb - - spec/lib/gitlab/ci/config/external/mapper_spec.rb - - spec/lib/gitlab/ci/config/external/processor_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/build_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/cancel_pending_pipelines_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/template_usage_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/validate/external_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/validate/repository_spec.rb - - spec/lib/gitlab/ci/pipeline/seed/build_spec.rb - - spec/lib/gitlab/ci/pipeline/seed/deployment_spec.rb - - spec/lib/gitlab/ci/pipeline/seed/environment_spec.rb - - spec/lib/gitlab/ci/pipeline/seed/processable/resource_group_spec.rb - - spec/lib/gitlab/ci/reports/test_failure_history_spec.rb - - spec/lib/gitlab/ci/syntax_templates_spec.rb - - spec/lib/gitlab/ci/trace/chunked_io_spec.rb - - spec/lib/gitlab/ci/trace_spec.rb - spec/lib/gitlab/closing_issue_extractor_spec.rb - spec/lib/gitlab/composer/cache_spec.rb - spec/lib/gitlab/data_builder/wiki_page_spec.rb - - spec/lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers_spec.rb - - spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb - spec/lib/gitlab/deploy_key_access_spec.rb - spec/lib/gitlab/email/handler/service_desk_handler_spec.rb - - spec/lib/gitlab/git/lfs_changes_spec.rb - - spec/lib/gitlab/git/merge_base_spec.rb - - spec/lib/gitlab/git/push_spec.rb - - spec/lib/gitlab/git_access_design_spec.rb - - spec/lib/gitlab/git_access_project_spec.rb - - spec/lib/gitlab/git_access_wiki_spec.rb - spec/lib/gitlab/gitaly_client/operation_service_spec.rb - spec/lib/gitlab/gl_repository/repo_type_spec.rb - spec/lib/gitlab/group_search_results_spec.rb @@ -723,11 +527,6 @@ RSpec/EmptyLineAfterFinalLetItBe: - spec/lib/gitlab/prometheus/query_variables_spec.rb - spec/lib/gitlab/reactive_cache_set_cache_spec.rb - spec/lib/gitlab/reference_extractor_spec.rb - - spec/lib/gitlab/repository_cache_spec.rb - - spec/lib/gitlab/repository_hash_cache_spec.rb - - spec/lib/gitlab/repository_set_cache_spec.rb - - spec/lib/gitlab/repository_size_checker_spec.rb - - spec/lib/gitlab/repository_size_error_message_spec.rb - spec/lib/gitlab/search_results_spec.rb - spec/lib/gitlab/shell_spec.rb - spec/models/abuse_report_spec.rb @@ -750,37 +549,15 @@ RSpec/EmptyLineAfterFinalLetItBe: - spec/models/note_spec.rb - spec/models/notification_setting_spec.rb - spec/models/operations/feature_flag_spec.rb - - spec/models/packages/dependency_spec.rb - - spec/models/packages/go/module_version_spec.rb - - spec/models/packages/package_spec.rb - - spec/models/packages/tag_spec.rb - spec/models/plan_limits_spec.rb - spec/models/prometheus_alert_spec.rb - spec/models/protected_branch/push_access_level_spec.rb - - spec/models/release_spec.rb - - spec/models/releases/evidence_spec.rb - - spec/models/releases/source_spec.rb - spec/models/repository_spec.rb - - spec/models/service_spec.rb - spec/models/snippet_repository_spec.rb - spec/models/snippet_spec.rb - spec/models/terraform/state_spec.rb - spec/models/u2f_registration_spec.rb - spec/models/user_spec.rb - - spec/models/wiki_page/meta_spec.rb - - spec/models/wiki_page_spec.rb - - spec/presenters/alert_management/alert_presenter_spec.rb - - spec/presenters/ci/pipeline_presenter_spec.rb - - spec/presenters/label_presenter_spec.rb - - spec/presenters/packages/composer/packages_presenter_spec.rb - - spec/presenters/packages/conan/package_presenter_spec.rb - - spec/presenters/packages/detail/package_presenter_spec.rb - - spec/presenters/packages/npm/package_presenter_spec.rb - - spec/presenters/packages/nuget/search_results_presenter_spec.rb - - spec/presenters/project_presenter_spec.rb - - spec/presenters/prometheus_alert_presenter_spec.rb - - spec/presenters/release_presenter_spec.rb - - spec/presenters/user_presenter_spec.rb - spec/requests/api/api_spec.rb - spec/requests/api/award_emoji_spec.rb - spec/requests/api/branches_spec.rb @@ -879,38 +656,11 @@ RSpec/EmptyLineAfterFinalLetItBe: - spec/services/auth/dependency_proxy_authentication_service_spec.rb - spec/services/auto_merge_service_spec.rb - spec/services/bulk_create_integration_service_spec.rb - - spec/services/ci/change_variable_service_spec.rb - - spec/services/ci/change_variables_service_spec.rb - - spec/services/ci/create_pipeline_service/cross_project_pipeline_spec.rb - - spec/services/ci/create_pipeline_service/custom_config_content_spec.rb - - spec/services/ci/create_pipeline_service/dry_run_spec.rb - - spec/services/ci/create_pipeline_service/environment_spec.rb - - spec/services/ci/create_pipeline_service/parameter_content_spec.rb - - spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb - - spec/services/ci/create_pipeline_service_spec.rb - - spec/services/ci/create_web_ide_terminal_service_spec.rb - - spec/services/ci/expire_pipeline_cache_service_spec.rb - - spec/services/ci/external_pull_requests/create_pipeline_service_spec.rb - - spec/services/ci/find_exposed_artifacts_service_spec.rb - - spec/services/ci/job_artifacts/create_service_spec.rb - - spec/services/ci/parse_dotenv_artifact_service_spec.rb - - spec/services/ci/pipeline_bridge_status_service_spec.rb - - spec/services/ci/pipeline_trigger_service_spec.rb - - spec/services/ci/prometheus_metrics/observe_histograms_service_spec.rb - - spec/services/ci/register_job_service_spec.rb - - spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb - - spec/services/ci/retry_build_service_spec.rb - - spec/services/ci/stop_environments_service_spec.rb - spec/services/clusters/applications/prometheus_health_check_service_spec.rb - spec/services/container_expiration_policy_service_spec.rb - spec/services/dependency_proxy/find_or_create_manifest_service_spec.rb - spec/services/discussions/resolve_service_spec.rb - spec/services/discussions/unresolve_service_spec.rb - - spec/services/feature_flags/create_service_spec.rb - - spec/services/feature_flags/destroy_service_spec.rb - - spec/services/feature_flags/disable_service_spec.rb - - spec/services/feature_flags/enable_service_spec.rb - - spec/services/feature_flags/update_service_spec.rb - spec/services/git/branch_push_service_spec.rb - spec/services/import/bitbucket_server_service_spec.rb - spec/services/incident_management/incidents/create_service_spec.rb @@ -999,27 +749,6 @@ RSpec/EmptyLineAfterFinalLetItBe: - spec/views/search/_results.html.haml_spec.rb - spec/views/shared/_label_row.html.haml_spec.rb - spec/views/shared/milestones/_top.html.haml_spec.rb - - spec/workers/ci/create_cross_project_pipeline_worker_spec.rb - - spec/workers/cluster_update_app_worker_spec.rb - - spec/workers/environments/canary_ingress/update_worker_spec.rb - - spec/workers/expire_job_cache_worker_spec.rb - - spec/workers/gitlab/jira_import/import_issue_worker_spec.rb - - spec/workers/gitlab/jira_import/stage/start_import_worker_spec.rb - - spec/workers/gitlab/jira_import/stuck_jira_import_jobs_worker_spec.rb - - spec/workers/import_issues_csv_worker_spec.rb - - spec/workers/incident_management/add_severity_system_note_worker_spec.rb - - spec/workers/incident_management/process_alert_worker_spec.rb - - spec/workers/incident_management/process_prometheus_alert_worker_spec.rb - - spec/workers/jira_connect/sync_project_worker_spec.rb - - spec/workers/namespaces/onboarding_issue_created_worker_spec.rb - - spec/workers/packages/composer/cache_update_worker_spec.rb - - spec/workers/pages_domain_ssl_renewal_cron_worker_spec.rb - - spec/workers/projects/git_garbage_collect_worker_spec.rb - - spec/workers/prometheus/create_default_alerts_worker_spec.rb - - spec/workers/propagate_integration_group_worker_spec.rb - - spec/workers/propagate_integration_project_worker_spec.rb - - spec/workers/run_pipeline_schedule_worker_spec.rb - - spec/workers/update_external_pull_requests_worker_spec.rb RSpec/TimecopFreeze: Exclude: @@ -1604,7 +1333,6 @@ RSpec/AnyInstanceOf: - 'spec/uploaders/workers/object_storage/migrate_uploads_worker_spec.rb' - 'spec/views/layouts/_head.html.haml_spec.rb' - 'spec/views/projects/artifacts/_artifact.html.haml_spec.rb' - - 'spec/views/shared/runners/show.html.haml_spec.rb' - 'spec/workers/archive_trace_worker_spec.rb' - 'spec/workers/build_coverage_worker_spec.rb' - 'spec/workers/build_hooks_worker_spec.rb' @@ -1689,9 +1417,6 @@ Gitlab/NamespacedClass: - 'app/finders/context_commits_finder.rb' - 'app/finders/contributed_projects_finder.rb' - 'app/finders/deployments_finder.rb' - - 'app/finders/environment_names_finder.rb' - - 'app/finders/environments_finder.rb' - - 'app/finders/environments_by_deployments_finder.rb' - 'app/finders/events_finder.rb' - 'app/finders/feature_flags_finder.rb' - 'app/finders/feature_flags_user_lists_finder.rb' @@ -1787,6 +1512,7 @@ Gitlab/NamespacedClass: - 'app/models/concerns/uniquify.rb' - 'app/models/container_expiration_policy.rb' - 'app/models/container_repository.rb' + - 'app/models/context_commits_diff.rb' - 'app/models/custom_emoji.rb' - 'app/models/data_list.rb' - 'app/models/deploy_key.rb' @@ -1846,6 +1572,7 @@ Gitlab/NamespacedClass: - 'app/models/individual_note_discussion.rb' - 'app/models/instance_configuration.rb' - 'app/models/instance_metadata.rb' + - 'app/models/integration.rb' - 'app/models/internal_id.rb' - 'app/models/issuable_severity.rb' - 'app/models/issue.rb' @@ -1933,21 +1660,13 @@ Gitlab/NamespacedClass: - 'app/models/project_repository_storage_move.rb' - 'app/models/project_services/alerts_service.rb' - 'app/models/project_services/alerts_service_data.rb' - - 'app/models/project_services/asana_service.rb' - - 'app/models/project_services/assembla_service.rb' - - 'app/models/project_services/bamboo_service.rb' - 'app/models/project_services/bugzilla_service.rb' - 'app/models/project_services/buildkite_service.rb' - - 'app/models/project_services/builds_email_service.rb' - - 'app/models/project_services/campfire_service.rb' - 'app/models/project_services/chat_notification_service.rb' - 'app/models/project_services/ci_service.rb' - - 'app/models/project_services/confluence_service.rb' - 'app/models/project_services/custom_issue_tracker_service.rb' - - 'app/models/project_services/datadog_service.rb' - 'app/models/project_services/discord_service.rb' - 'app/models/project_services/drone_ci_service.rb' - - 'app/models/project_services/emails_on_push_service.rb' - 'app/models/project_services/ewm_service.rb' - 'app/models/project_services/external_wiki_service.rb' - 'app/models/project_services/flowdock_service.rb' @@ -2014,7 +1733,6 @@ Gitlab/NamespacedClass: - 'app/models/self_managed_prometheus_alert_event.rb' - 'app/models/sent_notification.rb' - 'app/models/sentry_issue.rb' - - 'app/models/service.rb' - 'app/models/service_desk_setting.rb' - 'app/models/service_list.rb' - 'app/models/shard.rb' @@ -2092,6 +1810,7 @@ Gitlab/NamespacedClass: - 'app/policies/group_policy.rb' - 'app/policies/identity_provider_policy.rb' - 'app/policies/instance_metadata_policy.rb' + - 'app/policies/integration_policy.rb' - 'app/policies/issuable_policy.rb' - 'app/policies/issue_policy.rb' - 'app/policies/merge_request_policy.rb' @@ -2112,7 +1831,6 @@ Gitlab/NamespacedClass: - 'app/policies/release_policy.rb' - 'app/policies/repository_policy.rb' - 'app/policies/resource_label_event_policy.rb' - - 'app/policies/service_policy.rb' - 'app/policies/suggestion_policy.rb' - 'app/policies/timebox_policy.rb' - 'app/policies/timelog_policy.rb' @@ -2201,6 +1919,7 @@ Gitlab/NamespacedClass: - 'app/serializers/container_repository_entity.rb' - 'app/serializers/container_tag_entity.rb' - 'app/serializers/container_tags_serializer.rb' + - 'app/serializers/context_commits_diff_entity.rb' - 'app/serializers/current_board_entity.rb' - 'app/serializers/current_board_serializer.rb' - 'app/serializers/current_user_entity.rb' @@ -2252,6 +1971,8 @@ Gitlab/NamespacedClass: - 'app/serializers/group_entity.rb' - 'app/serializers/group_group_link_entity.rb' - 'app/serializers/group_group_link_serializer.rb' + - 'app/serializers/group_issuable_autocomplete_entity.rb' + - 'app/serializers/group_issuable_autocomplete_serializer.rb' - 'app/serializers/group_serializer.rb' - 'app/serializers/issuable_entity.rb' - 'app/serializers/issuable_sidebar_basic_entity.rb' @@ -2354,6 +2075,7 @@ Gitlab/NamespacedClass: - 'app/services/auto_merge_service.rb' - 'app/services/base_container_service.rb' - 'app/services/base_count_service.rb' + - 'app/services/base_project_service.rb' - 'app/services/base_renderer.rb' - 'app/services/base_service.rb' - 'app/services/bulk_create_integration_service.rb' @@ -2754,8 +2476,6 @@ Gitlab/NamespacedClass: - 'ee/app/serializers/geo_project_registry_entity.rb' - 'ee/app/serializers/geo_project_registry_serializer.rb' - 'ee/app/serializers/group_analytics_serializer.rb' - - 'ee/app/serializers/group_issuable_autocomplete_entity.rb' - - 'ee/app/serializers/group_issuable_autocomplete_serializer.rb' - 'ee/app/serializers/group_vulnerability_autocomplete_entity.rb' - 'ee/app/serializers/group_vulnerability_autocomplete_serializer.rb' - 'ee/app/serializers/invited_group_entity.rb' @@ -2975,7 +2695,6 @@ Performance/OpenStruct: - 'Guardfile' - 'app/finders/snippets_finder.rb' - 'app/helpers/application_settings_helper.rb' - - 'app/models/cycle_analytics/project_level_stage_adapter.rb' - 'ee/lib/gitlab/graphql/aggregations/epics/epic_node.rb' - 'ee/lib/gitlab/graphql/aggregations/epics/epic_node.rb' - 'lib/api/wikis.rb' @@ -3010,30 +2729,17 @@ Gitlab/FeatureAvailableUsage: - 'app/helpers/events_helper.rb' - 'app/helpers/labels_helper.rb' - 'app/policies/project_policy.rb' - - 'app/views/groups/issues.html.haml' - - 'app/views/groups/merge_requests.html.haml' - 'app/views/shared/boards/_switcher.html.haml' - 'ee/app/controllers/concerns/description_diff_actions.rb' - 'ee/app/controllers/concerns/ee/boards_actions.rb' - 'ee/app/controllers/concerns/security_dashboards_permissions.rb' - 'ee/app/controllers/ee/boards/lists_controller.rb' - - 'ee/app/controllers/ee/groups/application_controller.rb' - - 'ee/app/controllers/ee/groups/group_members_controller.rb' - 'ee/app/controllers/ee/projects/autocomplete_sources_controller.rb' - 'ee/app/controllers/ee/projects/issues_controller.rb' - 'ee/app/controllers/ee/projects/security/configuration_controller.rb' - 'ee/app/controllers/ee/projects/settings/ci_cd_controller.rb' - 'ee/app/controllers/ee/projects/settings/operations_controller.rb' - 'ee/app/controllers/ee/projects/settings/repository_controller.rb' - - 'ee/app/controllers/groups/analytics/application_controller.rb' - - 'ee/app/controllers/groups/audit_events_controller.rb' - - 'ee/app/controllers/groups/bulk_update_controller.rb' - - 'ee/app/controllers/groups/contribution_analytics_controller.rb' - - 'ee/app/controllers/groups/epics_controller.rb' - - 'ee/app/controllers/groups/hooks_controller.rb' - - 'ee/app/controllers/groups/issues_analytics_controller.rb' - - 'ee/app/controllers/groups/iterations_controller.rb' - - 'ee/app/controllers/projects/analytics/issues_analytics_controller.rb' - 'ee/app/controllers/projects/audit_events_controller.rb' - 'ee/app/controllers/projects/cluster_agents_controller.rb' - 'ee/app/controllers/projects/iterations/inherited_controller.rb' @@ -3044,23 +2750,18 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/finders/clusters/agents_finder.rb' - 'ee/app/finders/ee/alert_management/alerts_finder.rb' - 'ee/app/finders/ee/alert_management/http_integrations_finder.rb' - - 'ee/app/finders/ee/group_projects_finder.rb' - 'ee/app/graphql/ee/types/group_type.rb' - 'ee/app/graphql/mutations/dast/profiles/create.rb' - 'ee/app/graphql/mutations/dast/profiles/run.rb' - 'ee/app/graphql/mutations/dast/profiles/update.rb' - 'ee/app/graphql/mutations/instance_security_dashboard/remove_project.rb' - - 'ee/app/graphql/resolvers/boards/epic_boards_resolver.rb' - 'ee/app/graphql/resolvers/clusters/agent_tokens_resolver.rb' - - 'ee/app/graphql/resolvers/epics_resolver.rb' - - 'ee/app/helpers/ee/analytics/navbar_helper.rb' - 'ee/app/helpers/ee/application_helper.rb' - 'ee/app/helpers/ee/boards_helper.rb' - 'ee/app/helpers/ee/clusters_helper.rb' - 'ee/app/helpers/ee/dashboard_helper.rb' - 'ee/app/helpers/ee/form_helper.rb' - 'ee/app/helpers/ee/graph_helper.rb' - - 'ee/app/helpers/ee/groups_helper.rb' - 'ee/app/helpers/ee/issues_helper.rb' - 'ee/app/helpers/ee/lock_helper.rb' - 'ee/app/helpers/ee/operations_helper.rb' @@ -3069,7 +2770,6 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/helpers/ee/releases_helper.rb' - 'ee/app/helpers/ee/search_helper.rb' - 'ee/app/helpers/ee/tree_helper.rb' - - 'ee/app/helpers/groups/security_features_helper.rb' - 'ee/app/models/approval_state.rb' - 'ee/app/models/concerns/approvable.rb' - 'ee/app/models/concerns/ee/project_security_scanners_information.rb' @@ -3092,15 +2792,12 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/models/ee/project_ci_cd_setting.rb' - 'ee/app/models/namespace_statistics.rb' - 'ee/app/models/project_security_setting.rb' - - 'ee/app/models/saml_provider.rb' - - 'ee/app/policies/compliance_management/framework_policy.rb' - 'ee/app/policies/compliance_management/framework_policy.rb' - 'ee/app/policies/ee/group_policy.rb' - 'ee/app/policies/ee/namespace_policy.rb' - 'ee/app/policies/ee/project_policy.rb' - 'ee/app/policies/ee/protected_branch_policy.rb' - 'ee/app/presenters/ee/label_presenter.rb' - - 'ee/app/presenters/epic_presenter.rb' - 'ee/app/presenters/merge_request_approver_presenter.rb' - 'ee/app/serializers/dashboard_operations_project_entity.rb' - 'ee/app/serializers/ee/environment_entity.rb' @@ -3124,7 +2821,6 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/services/ee/boards/issues/list_service.rb' - 'ee/app/services/ee/boards/lists/create_service.rb' - 'ee/app/services/ee/boards/update_service.rb' - - 'ee/app/services/ee/groups/create_service.rb' - 'ee/app/services/ee/ide/schemas_config_service.rb' - 'ee/app/services/ee/issuable_base_service.rb' - 'ee/app/services/ee/issue_links/create_service.rb' @@ -3139,9 +2835,6 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/services/ee/projects/create_service.rb' - 'ee/app/services/ee/protected_branches/create_service.rb' - 'ee/app/services/ee/releases/create_evidence_service.rb' - - 'ee/app/services/ee/search/group_service.rb' - - 'ee/app/services/iterations/cadences/create_service.rb' - - 'ee/app/services/iterations/cadences/update_service.rb' - 'ee/app/services/iterations/create_service.rb' - 'ee/app/services/iterations/update_service.rb' - 'ee/app/services/merge_requests/sync_report_approver_approval_rules.rb' @@ -3150,16 +2843,6 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/services/quality_management/test_cases/create_service.rb' - 'ee/app/services/requirements_management/process_test_reports_service.rb' - 'ee/app/services/security/store_scans_service.rb' - - 'ee/app/views/groups/_templates_setting.html.haml' - - 'ee/app/views/groups/contribution_analytics/show.html.haml' - - 'ee/app/views/groups/ee/_settings_nav.html.haml' - - 'ee/app/views/groups/epics/index.html.haml' - - 'ee/app/views/groups/epics/show.html.haml' - - 'ee/app/views/groups/epics/show.html.haml' - - 'ee/app/views/groups/hooks/index.html.haml' - - 'ee/app/views/groups/roadmap/show.html.haml' - - 'ee/app/views/groups/settings/_allowed_email_domain.html.haml' - - 'ee/app/views/groups/settings/_ip_restriction.html.haml' - 'ee/app/views/layouts/nav/_test_cases_link.html.haml' - 'ee/app/views/layouts/nav/sidebar/_project_iterations_link.html.haml' - 'ee/app/views/projects/_merge_request_approvals_settings.html.haml' @@ -3193,7 +2876,6 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/views/shared/issuable/_board_create_list_dropdown.html.haml' - 'ee/app/views/shared/issuable/_board_create_list_dropdown.html.haml' - 'ee/app/views/shared/issuable/_group_bulk_update_sidebar.html.haml' - - 'ee/app/views/shared/issuable/_iteration_select.html.haml' - 'ee/app/views/shared/issuable/form/_default_templates.html.haml' - 'ee/app/views/shared/labels/_create_label_help_text.html.haml' - 'ee/app/views/shared/promotions/_promote_mr_features.html.haml' @@ -3207,14 +2889,10 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/workers/analytics/code_review_metrics_worker.rb' - 'ee/app/workers/group_saml_group_sync_worker.rb' - 'ee/lib/api/external_approval_rules.rb' - - 'ee/lib/api/helpers/epics_helpers.rb' - - 'ee/lib/api/ldap_group_links.rb' - 'ee/lib/ee/api/entities/approval_state.rb' - 'ee/lib/ee/api/entities/board.rb' - - 'ee/lib/ee/api/entities/group.rb' - 'ee/lib/ee/api/entities/issue.rb' - 'ee/lib/ee/api/entities/project.rb' - - 'ee/lib/ee/api/groups.rb' - 'ee/lib/ee/api/helpers.rb' - 'ee/lib/ee/api/internal/kubernetes.rb' - 'ee/lib/ee/api/job_artifacts.rb' @@ -3224,14 +2902,11 @@ Gitlab/FeatureAvailableUsage: - 'ee/lib/ee/gitlab/gon_helper.rb' - 'ee/lib/ee/gitlab/tree_summary.rb' - 'ee/lib/gitlab/alert_management.rb' - - 'ee/lib/gitlab/auth/group_saml/group_lookup.rb' - 'ee/lib/gitlab/ci/pipeline/chain/config/content/compliance.rb' - 'ee/lib/gitlab/code_owners.rb' - - 'ee/lib/gitlab/import_export/group/group_and_descendants_repo_restorer.rb' - 'ee/lib/gitlab/incident_management.rb' - 'ee/lib/gitlab/path_locks_finder.rb' - 'ee/lib/incident_management/incident_sla.rb' - - 'ee/spec/models/ee/namespace_spec.rb' - 'ee/spec/models/instance_security_dashboard_spec.rb' - 'ee/spec/models/license_spec.rb' - 'ee/spec/models/project_spec.rb' @@ -3249,7 +2924,6 @@ Style/RegexpLiteralMixedPreserve: - 'app/models/concerns/ci/maskable.rb' - 'app/models/operations/feature_flag.rb' - 'app/models/packages/go/module.rb' - - 'app/models/project_services/chat_message/base_message.rb' - 'app/services/packages/conan/search_service.rb' - 'app/services/projects/update_remote_mirror_service.rb' - 'config/initializers/rspec_profiling.rb' |