Remove some disabled cops.

1 files changed, 550 insertions, 17 deletions

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 9a791d74c15..cb6df9d88c2 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,15 +1,66 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2016-06-29 18:24:55 +0200 using RuboCop version 0.41.1.
+# `rubocop --auto-gen-config --exclude-limit 8`
+# on 2016-07-03 15:32:25 -0600 using RuboCop version 0.41.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 152
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+
+# Offense count: 42
+# Configuration parameters: AllowSafeAssignment.
+Lint/AssignmentInCondition:
+  Enabled: false
+
 # Offense count: 1
-Lint/ShadowedException:
+Lint/DuplicateMethods:
+  Exclude:
+    - 'lib/gitlab/github_import/branch_formatter.rb'
+
+# Offense count: 14
+Lint/HandleExceptions:
+  Enabled: false
+
+# Offense count: 20
+Lint/IneffectiveAccessModifier:
+  Enabled: false
+
+# Offense count: 2
+Lint/Loop:
+  Exclude:
+    - 'app/mailers/notify.rb'
+    - 'lib/gitlab/bitbucket_import/client.rb'
+
+# Offense count: 12
+Lint/ShadowingOuterLocalVariable:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Lint/StringConversionInInterpolation:
   Exclude:
-    - 'app/models/u2f_registration.rb'
+    - 'app/models/commit_range.rb'
+    - 'app/services/system_hooks_service.rb'
+    - 'app/services/system_note_service.rb'
+
+# Offense count: 42
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
+Lint/UnusedBlockArgument:
+  Enabled: false
+
+# Offense count: 125
+# Cop supports --auto-correct.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
+Lint/UnusedMethodArgument:
+  Enabled: false
+
+# Offense count: 11
+Lint/UselessAccessModifier:
+  Enabled: false
 
 # Offense count: 12
 # Cop supports --auto-correct.
@@ -23,10 +74,263 @@ Performance/PushSplat:
     - 'app/models/user.rb'
     - 'config/application.rb'
 
+# Offense count: 2
+# Cop supports --auto-correct.
+Performance/RedundantBlockCall:
+  Exclude:
+    - 'app/controllers/application_controller.rb'
+    - 'lib/gitlab/backend/shell.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+Performance/RedundantMatch:
+  Exclude:
+    - 'app/models/external_issue.rb'
+    - 'lib/extracts_path.rb'
+    - 'lib/gitlab/diff/highlight.rb'
+    - 'lib/gitlab/diff/inline_diff.rb'
+    - 'lib/gitlab/diff/parser.rb'
+
+# Offense count: 24
+# Cop supports --auto-correct.
+# Configuration parameters: MaxKeyValuePairs.
+Performance/RedundantMerge:
+  Enabled: false
+
 # Offense count: 59
 Rails/OutputSafety:
   Enabled: false
 
+# Offense count: 125
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: strict, flexible
+Rails/TimeZone:
+  Enabled: false
+
+# Offense count: 12
+# Cop supports --auto-correct.
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
+Rails/Validation:
+  Enabled: false
+
+# Offense count: 18
+Style/AccessorMethodName:
+  Enabled: false
+
+# Offense count: 208
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: with_first_parameter, with_fixed_indentation
+Style/AlignParameters:
+  Enabled: false
+
+# Offense count: 32
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: always, conditionals
+Style/AndOr:
+  Enabled: false
+
+# Offense count: 47
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: percent_q, bare_percent
+Style/BarePercentLiterals:
+  Enabled: false
+
+# Offense count: 255
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: braces, no_braces, context_dependent
+Style/BracesAroundHashParameters:
+  Enabled: false
+
+# Offense count: 4
+Style/CaseEquality:
+  Exclude:
+    - 'app/helpers/auth_helper.rb'
+    - 'app/models/commit.rb'
+    - 'app/services/projects/download_service.rb'
+    - 'config/initializers/trusted_proxies.rb'
+
+# Offense count: 19
+# Cop supports --auto-correct.
+Style/ColonMethodCall:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: Keywords.
+# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
+Style/CommentAnnotation:
+  Exclude:
+    - 'app/models/project.rb'
+    - 'lib/api/entities.rb'
+    - 'spec/requests/api/project_snippets_spec.rb'
+
+# Offense count: 35
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
+# SupportedStyles: assign_to_condition, assign_inside_condition
+Style/ConditionalAssignment:
+  Enabled: false
+
+# Offense count: 762
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: leading, trailing
+Style/DotPosition:
+  Enabled: false
+
+# Offense count: 14
+Style/DoubleNegation:
+  Enabled: false
+
+# Offense count: 3
+Style/EachWithObject:
+  Exclude:
+    - 'app/models/commit_status.rb'
+    - 'lib/ci/ansi2html.rb'
+    - 'lib/gitlab/import_export/members_mapper.rb'
+
+# Offense count: 29
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty, nil, both
+Style/EmptyElse:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/EmptyLiteral:
+  Exclude:
+    - 'features/steps/project/commits/commits.rb'
+    - 'lib/gitlab/fogbugz_import/importer.rb'
+    - 'spec/lib/gitlab/workhorse_spec.rb'
+
+# Offense count: 119
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
+Style/ExtraSpacing:
+  Enabled: false
+
+# Offense count: 7
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: format, sprintf, percent
+Style/FormatString:
+  Exclude:
+    - 'app/models/ci/pipeline.rb'
+    - 'app/services/gravatar_service.rb'
+    - 'config/initializers/rack_lineprof.rb'
+    - 'lib/ci/version_info.rb'
+    - 'lib/gitlab/version_info.rb'
+    - 'spec/requests/api/issues_spec.rb'
+
+# Offense count: 50
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Enabled: false
+
+# Offense count: 9
+Style/IdenticalConditionalBranches:
+  Exclude:
+    - 'app/controllers/projects_controller.rb'
+    - 'app/models/project_services/irker_service.rb'
+    - 'app/services/merge_requests/refresh_service.rb'
+    - 'lib/rouge/formatters/html_gitlab.rb'
+
+# Offense count: 10
+Style/IfInsideElse:
+  Enabled: false
+
+# Offense count: 178
+# Cop supports --auto-correct.
+# Configuration parameters: MaxLineLength.
+Style/IfUnlessModifier:
+  Enabled: false
+
+# Offense count: 48
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: special_inside_parentheses, consistent, align_brackets
+Style/IndentArray:
+  Enabled: false
+
+# Offense count: 85
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: special_inside_parentheses, consistent, align_braces
+Style/IndentHash:
+  Enabled: false
+
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: line_count_dependent, lambda, literal
+Style/Lambda:
+  Exclude:
+    - 'app/models/ci/runner.rb'
+    - 'app/models/event.rb'
+    - 'app/models/note.rb'
+    - 'config/routes.rb'
+    - 'lib/api/entities.rb'
+    - 'spec/models/concerns/participable_spec.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+Style/LineEndConcatenation:
+  Exclude:
+    - 'app/helpers/preferences_helper.rb'
+    - 'app/helpers/tree_helper.rb'
+    - 'app/models/merge_request.rb'
+    - 'app/models/user.rb'
+    - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
+
+# Offense count: 13
+# Cop supports --auto-correct.
+Style/MethodCallParentheses:
+  Exclude:
+    - 'lib/api/helpers.rb'
+    - 'lib/ci/ansi2html.rb'
+    - 'spec/features/dashboard/datetime_on_tooltips_spec.rb'
+    - 'spec/helpers/submodule_helper_spec.rb'
+    - 'spec/workers/post_receive_spec.rb'
+
+# Offense count: 9
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: module_function, extend_self
+Style/ModuleFunction:
+  Enabled: false
+
+# Offense count: 3
+Style/MultilineTernaryOperator:
+  Exclude:
+    - 'lib/banzai/filter/relative_link_filter.rb'
+    - 'spec/support/api_helpers.rb'
+
+# Offense count: 62
+# Cop supports --auto-correct.
+Style/MutableConstant:
+  Enabled: false
+
+# Offense count: 10
+# Cop supports --auto-correct.
+Style/NestedParenthesizedCalls:
+  Exclude:
+    - 'app/helpers/commits_helper.rb'
+    - 'app/workers/irker_worker.rb'
+    - 'spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb'
+    - 'spec/lib/gitlab/email/message/repository_push_spec.rb'
+    - 'spec/services/ci/create_builds_service_spec.rb'
+
+# Offense count: 13
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
+# SupportedStyles: skip_modifier_ifs, always
+Style/Next:
+  Enabled: false
+
 # Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
@@ -39,23 +343,166 @@ Style/NumericLiteralPrefix:
     - 'spec/support/test_env.rb'
     - 'spec/tasks/gitlab/backup_rake_spec.rb'
 
+# Offense count: 29
+# Cop supports --auto-correct.
+Style/ParallelAssignment:
+  Enabled: false
+
+# Offense count: 201
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Enabled: false
+
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: lower_case_q, upper_case_q
+Style/PercentQLiterals:
+  Exclude:
+    - 'spec/helpers/gitlab_markdown_helper_spec.rb'
+    - 'spec/lib/gitlab/diff/highlight_spec.rb'
+    - 'spec/models/project_services/bamboo_service_spec.rb'
+    - 'spec/models/project_services/teamcity_service_spec.rb'
+    - 'spec/workers/repository_import_worker_spec.rb'
+
+# Offense count: 14
+# Cop supports --auto-correct.
+Style/PerlBackrefs:
+  Enabled: false
+
+# Offense count: 30
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+Style/PredicateName:
+  Enabled: false
+
 # Offense count: 28
 # Cop supports --auto-correct.
 Style/PreferredHashMethods:
+  Enabled: false
+
+# Offense count: 6
+# Cop supports --auto-correct.
+Style/Proc:
   Exclude:
-    - 'app/helpers/dropdowns_helper.rb'
-    - 'app/models/application_setting.rb'
-    - 'app/models/members/project_member.rb'
-    - 'app/services/git_push_service.rb'
-    - 'lib/api/helpers.rb'
-    - 'lib/ci/api/builds.rb'
-    - 'lib/ci/gitlab_ci_yaml_processor.rb'
-    - 'lib/gitlab/ci/config/node/configurable.rb'
-    - 'lib/gitlab/ci/config/node/factory.rb'
-    - 'lib/gitlab/google_code_import/client.rb'
-    - 'lib/gitlab/google_code_import/importer.rb'
-    - 'lib/gitlab/visibility_level.rb'
-    - 'spec/requests/api/projects_spec.rb'
+    - 'app/mailers/base_mailer.rb'
+    - 'app/models/label.rb'
+    - 'app/models/service.rb'
+    - 'lib/api/api_guard.rb'
+    - 'spec/initializers/trusted_proxies_spec.rb'
+
+# Offense count: 21
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: compact, exploded
+Style/RaiseArgs:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/RedundantBegin:
+  Exclude:
+    - 'app/models/ci/build.rb'
+    - 'app/models/merge_request.rb'
+    - 'app/services/projects/import_service.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantException:
+  Exclude:
+    - 'app/helpers/preferences_helper.rb'
+
+# Offense count: 21
+# Cop supports --auto-correct.
+Style/RedundantFreeze:
+  Enabled: false
+
+# Offense count: 312
+# Cop supports --auto-correct.
+Style/RedundantSelf:
+  Enabled: false
+
+# Offense count: 92
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
+  Enabled: false
+
+# Offense count: 14
+# Cop supports --auto-correct.
+Style/RescueModifier:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/SelfAssignment:
+  Exclude:
+    - 'app/services/notification_service.rb'
+    - 'lib/api/runners.rb'
+
+# Offense count: 2
+# Configuration parameters: Methods.
+# Methods: {"reduce"=>["a", "e"]}, {"inject"=>["a", "e"]}
+Style/SingleLineBlockParams:
+  Exclude:
+    - 'app/models/commit.rb'
+    - 'spec/support/services_shared_context.rb'
+
+# Offense count: 50
+# Cop supports --auto-correct.
+# Configuration parameters: AllowIfMethodIsEmpty.
+Style/SingleLineMethods:
+  Exclude:
+    - 'lib/ci/ansi2html.rb'
+
+# Offense count: 14
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: space, no_space
+Style/SpaceAroundEqualsInParameterDefault:
+  Enabled: false
+
+# Offense count: 118
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: space, no_space
+Style/SpaceBeforeBlockBraces:
+  Enabled: false
+
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment.
+Style/SpaceBeforeFirstArg:
+  Exclude:
+    - 'config/initializers/doorkeeper.rb'
+    - 'config/routes.rb'
+    - 'features/steps/project/source/browse_files.rb'
+    - 'features/steps/project/source/markdown_render.rb'
+    - 'spec/routing/project_routing_spec.rb'
+    - 'spec/services/delete_user_service_spec.rb'
+    - 'spec/services/projects/fork_service_spec.rb'
+    - 'spec/services/system_note_service_spec.rb'
+
+# Offense count: 129
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
+# SupportedStyles: space, no_space
+Style/SpaceInsideBlockBraces:
+  Enabled: false
+
+# Offense count: 92
+# Cop supports --auto-correct.
+Style/SpaceInsideBrackets:
+  Enabled: false
+
+# Offense count: 60
+# Cop supports --auto-correct.
+Style/SpaceInsideParens:
+  Enabled: false
 
 # Offense count: 5
 # Cop supports --auto-correct.
@@ -63,3 +510,89 @@ Style/SpaceInsidePercentLiteralDelimiters:
   Exclude:
     - 'lib/event_filter.rb'
     - 'lib/gitlab/git_access.rb'
+
+# Offense count: 33
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles.
+# SupportedStyles: use_perl_names, use_english_names
+Style/SpecialGlobalVars:
+  EnforcedStyle: use_perl_names
+
+# Offense count: 30
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiteralsInInterpolation:
+  Enabled: false
+
+# Offense count: 24
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoredMethods.
+# IgnoredMethods: respond_to, define_method
+Style/SymbolProc:
+  Enabled: false
+
+# Offense count: 23
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
+# SupportedStyles: comma, consistent_comma, no_comma
+Style/TrailingCommaInArguments:
+  Enabled: false
+
+# Offense count: 117
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
+# SupportedStyles: comma, consistent_comma, no_comma
+Style/TrailingCommaInLiteral:
+  Enabled: false
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: AllowNamedUnderscoreVariables.
+Style/TrailingUnderscoreVariable:
+  Exclude:
+    - 'app/controllers/admin/background_jobs_controller.rb'
+    - 'app/controllers/invites_controller.rb'
+    - 'app/controllers/projects/git_http_controller.rb'
+    - 'app/helpers/tab_helper.rb'
+    - 'lib/gitlab/force_push_check.rb'
+    - 'lib/gitlab/logger.rb'
+
+# Offense count: 89
+# Cop supports --auto-correct.
+Style/TrailingWhitespace:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
+# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
+Style/TrivialAccessors:
+  Exclude:
+    - 'app/models/external_issue.rb'
+    - 'lib/gitlab/ldap/person.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/UnlessElse:
+  Exclude:
+    - 'lib/api/projects.rb'
+    - 'lib/gitlab/backend/grack_auth.rb'
+    - 'lib/gitlab/project_search_results.rb'
+
+# Offense count: 14
+# Cop supports --auto-correct.
+Style/UnneededInterpolation:
+  Enabled: false
+
+# Offense count: 8
+# Cop supports --auto-correct.
+Style/ZeroLengthPredicate:
+  Exclude:
+    - 'app/models/deploy_key.rb'
+    - 'app/models/network/commit.rb'
+    - 'app/models/network/graph.rb'
+    - 'app/models/project_services/asana_service.rb'
+    - 'app/models/repository.rb'
+    - 'lib/extracts_path.rb'
+    - 'lib/gitlab/force_push_check.rb'