diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-07-24 14:08:25 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-07-24 14:08:25 -0700 |
| commit | 07a308ad1b3e4ac1c6a3d81a60dac5c4254281b9 (patch) | |
| tree | 0f58b00d10eda0d7ee97255002bf051205db6dae /.rubocop_todo.yml | |
| parent | 35ec674ee69a04d771ed82eeb205c3cd527e4112 (diff) | |
| download | gitlab-ce-07a308ad1b3e4ac1c6a3d81a60dac5c4254281b9.tar.gz | |
Enable Rubocop Performance/ReverseEachsh-rubocop-reverse-each
`Array.reverse_each` is faster than `Array.reverse.each` because:
* reverse.each creates a new array then loops each element
* reverse_each loops in reverse order (no intermediate array created)
Diffstat (limited to '.rubocop_todo.yml')
| -rw-r--r-- | .rubocop_todo.yml | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 72de4f0b2aa..3898206e3b5 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -262,14 +262,6 @@ Naming/HeredocDelimiterNaming: Naming/RescuedExceptionsVariableName: Enabled: false -# Offense count: 3 -# Cop supports --auto-correct. -Performance/ReverseEach: - Exclude: - - 'app/models/commit.rb' - - 'db/migrate/20190222051615_add_indexes_for_merge_request_diffs_query.rb' - - 'lib/gitlab/profiler.rb' - # Offense count: 7081 # Configuration parameters: Prefixes. # Prefixes: when, with, without |