summaryrefslogtreecommitdiff
path: root/.rubocop_todo
diff options
context:
space:
mode:
authorGitLab Bot <gitlab-bot@gitlab.com>2023-01-18 19:00:14 +0000
committerGitLab Bot <gitlab-bot@gitlab.com>2023-01-18 19:00:14 +0000
commit05f0ebba3a2c8ddf39e436f412dc2ab5bf1353b2 (patch)
tree11d0f2a6ec31c7793c184106cedc2ded3d9a2cc5 /.rubocop_todo
parentec73467c23693d0db63a797d10194da9e72a74af (diff)
downloadgitlab-ce-05f0ebba3a2c8ddf39e436f412dc2ab5bf1353b2.tar.gz
Add latest changes from gitlab-org/gitlab@15-8-stable-eev15.8.0-rc42
Diffstat (limited to '.rubocop_todo')
-rw-r--r--.rubocop_todo/background_migration/feature_category.yml3
-rw-r--r--.rubocop_todo/cop/user_admin.yml1
-rw-r--r--.rubocop_todo/database/multiple_databases.yml9
-rw-r--r--.rubocop_todo/fips/sha1.yml1
-rw-r--r--.rubocop_todo/gitlab/namespaced_class.yml8
-rw-r--r--.rubocop_todo/gitlab/strong_memoize_attr.yml27
-rw-r--r--.rubocop_todo/graphql/descriptions.yml6
-rw-r--r--.rubocop_todo/layout/argument_alignment.yml20
-rw-r--r--.rubocop_todo/layout/array_alignment.yml365
-rw-r--r--.rubocop_todo/layout/first_argument_indentation.yml26
-rw-r--r--.rubocop_todo/layout/first_array_element_indentation.yml89
-rw-r--r--.rubocop_todo/layout/first_hash_element_indentation.yml480
-rw-r--r--.rubocop_todo/layout/hash_alignment.yml2
-rw-r--r--.rubocop_todo/layout/line_continuation_leading_space.yml75
-rw-r--r--.rubocop_todo/layout/line_continuation_spacing.yml224
-rw-r--r--.rubocop_todo/layout/line_end_string_concatenation_indentation.yml358
-rw-r--r--.rubocop_todo/layout/line_length.yml138
-rw-r--r--.rubocop_todo/layout/parameter_alignment.yml18
-rw-r--r--.rubocop_todo/layout/space_in_lambda_literal.yml2
-rw-r--r--.rubocop_todo/lint/ambiguous_regexp_literal.yml96
-rw-r--r--.rubocop_todo/lint/missing_cop_enable_directive.yml2
-rw-r--r--.rubocop_todo/lint/redundant_cop_disable_directive.yml3
-rw-r--r--.rubocop_todo/migration/background_migration_base_class.yml1
-rw-r--r--.rubocop_todo/migration/background_migration_record.yml1
-rw-r--r--.rubocop_todo/migration/background_migrations.yml12
-rw-r--r--.rubocop_todo/naming/heredoc_delimiter_naming.yml1
-rw-r--r--.rubocop_todo/performance/concurrent_monotonic_time.yml6
-rw-r--r--.rubocop_todo/performance/flat_map.yml38
-rw-r--r--.rubocop_todo/performance/map_compact.yml148
-rw-r--r--.rubocop_todo/performance/redundant_equality_comparison_block.yml23
-rw-r--r--.rubocop_todo/performance/redundant_split_regexp_argument.yml8
-rw-r--r--.rubocop_todo/rails/file_path.yml5
-rw-r--r--.rubocop_todo/rails/inverse_of.yml4
-rw-r--r--.rubocop_todo/rails/negate_include.yml1
-rw-r--r--.rubocop_todo/rails/pluck.yml4
-rw-r--r--.rubocop_todo/rails/redundant_foreign_key.yml1
-rw-r--r--.rubocop_todo/rspec/any_instance_of.yml19
-rw-r--r--.rubocop_todo/rspec/capybara/visibility_matcher.yml1
-rw-r--r--.rubocop_todo/rspec/context_wording.yml26
-rw-r--r--.rubocop_todo/rspec/described_class.yml1
-rw-r--r--.rubocop_todo/rspec/expect_change.yml2
-rw-r--r--.rubocop_todo/rspec/expect_in_hook.yml5
-rw-r--r--.rubocop_todo/rspec/factory_bot/avoid_create.yml1
-rw-r--r--.rubocop_todo/rspec/hooks_before_examples.yml1
-rw-r--r--.rubocop_todo/rspec/instance_variable.yml1
-rw-r--r--.rubocop_todo/rspec/multiple_memoized_helpers.yml1
-rw-r--r--.rubocop_todo/rspec/repeated_example_group_body.yml1
-rw-r--r--.rubocop_todo/rspec/repeated_example_group_description.yml1
-rw-r--r--.rubocop_todo/rspec/verified_doubles.yml4
-rw-r--r--.rubocop_todo/security/io_methods.yml1
-rw-r--r--.rubocop_todo/style/accessor_grouping.yml1
-rw-r--r--.rubocop_todo/style/bare_percent_literals.yml2
-rw-r--r--.rubocop_todo/style/class_and_module_children.yml2
-rw-r--r--.rubocop_todo/style/empty_method.yml4
-rw-r--r--.rubocop_todo/style/format_string.yml26
-rw-r--r--.rubocop_todo/style/guard_clause.yml4
-rw-r--r--.rubocop_todo/style/if_unless_modifier.yml7
-rw-r--r--.rubocop_todo/style/percent_literal_delimiters.yml28
-rw-r--r--.rubocop_todo/style/redundant_self.yml2
-rw-r--r--.rubocop_todo/style/string_concatenation.yml3
-rw-r--r--.rubocop_todo/style/symbol_proc.yml20
61 files changed, 1577 insertions, 793 deletions
diff --git a/.rubocop_todo/background_migration/feature_category.yml b/.rubocop_todo/background_migration/feature_category.yml
new file mode 100644
index 00000000000..69467a0b492
--- /dev/null
+++ b/.rubocop_todo/background_migration/feature_category.yml
@@ -0,0 +1,3 @@
+---
+BackgroundMigration/FeatureCategory:
+ Details: grace period
diff --git a/.rubocop_todo/cop/user_admin.yml b/.rubocop_todo/cop/user_admin.yml
index 6f8cc5429c2..c4d3e13b0b5 100644
--- a/.rubocop_todo/cop/user_admin.yml
+++ b/.rubocop_todo/cop/user_admin.yml
@@ -19,7 +19,6 @@ Cop/UserAdmin:
- 'app/helpers/visibility_level_helper.rb'
- 'app/models/concerns/protected_ref_access.rb'
- 'app/models/concerns/spammable.rb'
- - 'app/models/issue_collection.rb'
- 'app/models/merge_requests_closing_issues.rb'
- 'app/models/protected_branch.rb'
- 'app/models/user.rb'
diff --git a/.rubocop_todo/database/multiple_databases.yml b/.rubocop_todo/database/multiple_databases.yml
index 43da6f8a5b4..c59e8a8c15e 100644
--- a/.rubocop_todo/database/multiple_databases.yml
+++ b/.rubocop_todo/database/multiple_databases.yml
@@ -1,14 +1,5 @@
---
Database/MultipleDatabases:
Exclude:
- - 'db/post_migrate/20210317104032_set_iteration_cadence_automatic_to_false.rb'
- 'db/post_migrate/20210811122206_update_external_project_bots.rb'
- 'db/post_migrate/20210812013042_remove_duplicate_project_authorizations.rb'
- - 'ee/spec/services/ee/merge_requests/update_service_spec.rb'
- - 'spec/support/caching.rb'
- - 'spec/support/helpers/database/database_helpers.rb'
- - 'spec/support/helpers/database/table_schema_helpers.rb'
- - 'spec/support/helpers/migrations_helpers.rb'
- - 'spec/support/helpers/query_recorder.rb'
- - 'spec/support/helpers/usage_data_helpers.rb'
- - 'spec/tasks/gitlab/db_rake_spec.rb'
diff --git a/.rubocop_todo/fips/sha1.yml b/.rubocop_todo/fips/sha1.yml
index 35221d9d3ff..b07fef0ca54 100644
--- a/.rubocop_todo/fips/sha1.yml
+++ b/.rubocop_todo/fips/sha1.yml
@@ -88,7 +88,6 @@ Fips/SHA1:
- 'spec/lib/gitlab/git/tag_spec.rb'
- 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb'
- 'spec/migrations/20220524074947_finalize_backfill_null_note_discussion_ids_spec.rb'
- - 'spec/migrations/delete_security_findings_without_uuid_spec.rb'
- 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb'
- 'spec/models/ci/artifact_blob_spec.rb'
- 'spec/models/ci/job_artifact_spec.rb'
diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml
index e49169bae67..f394851193c 100644
--- a/.rubocop_todo/gitlab/namespaced_class.yml
+++ b/.rubocop_todo/gitlab/namespaced_class.yml
@@ -48,7 +48,6 @@ Gitlab/NamespacedClass:
- 'app/finders/feature_flags_user_lists_finder.rb'
- 'app/finders/fork_projects_finder.rb'
- 'app/finders/fork_targets_finder.rb'
- - 'app/finders/freeze_periods_finder.rb'
- 'app/finders/git_refs_finder.rb'
- 'app/finders/group_descendants_finder.rb'
- 'app/finders/group_finder.rb'
@@ -198,7 +197,6 @@ Gitlab/NamespacedClass:
- 'app/models/issuable_severity.rb'
- 'app/models/issue.rb'
- 'app/models/issue_assignee.rb'
- - 'app/models/issue_collection.rb'
- 'app/models/issue_email_participant.rb'
- 'app/models/issue_link.rb'
- 'app/models/issue_user_mention.rb'
@@ -371,6 +369,7 @@ Gitlab/NamespacedClass:
- 'app/policies/deploy_keys_project_policy.rb'
- 'app/policies/deploy_token_policy.rb'
- 'app/policies/deployment_policy.rb'
+ - 'app/policies/description_version_policy.rb'
- 'app/policies/draft_note_policy.rb'
- 'app/policies/environment_policy.rb'
- 'app/policies/external_issue_policy.rb'
@@ -404,7 +403,10 @@ Gitlab/NamespacedClass:
- 'app/policies/protected_branch_policy.rb'
- 'app/policies/release_policy.rb'
- 'app/policies/repository_policy.rb'
+ - 'app/policies/resource_event_policy.rb'
- 'app/policies/resource_label_event_policy.rb'
+ - 'app/policies/resource_milestone_event_policy.rb'
+ - 'app/policies/resource_state_event_policy.rb'
- 'app/policies/suggestion_policy.rb'
- 'app/policies/system_hook_policy.rb'
- 'app/policies/timebox_policy.rb'
@@ -960,6 +962,8 @@ Gitlab/NamespacedClass:
- 'ee/app/policies/issuable_metric_image_policy.rb'
- 'ee/app/policies/iteration_policy.rb'
- 'ee/app/policies/push_rule_policy.rb'
+ - 'ee/app/policies/resource_iteration_event_policy.rb'
+ - 'ee/app/policies/resource_weight_event_policy.rb'
- 'ee/app/policies/saml_provider_policy.rb'
- 'ee/app/policies/vulnerability_policy.rb'
- 'ee/app/presenters/approval_rule_presenter.rb'
diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml
index 5afb7574ff1..9fe784e1be9 100644
--- a/.rubocop_todo/gitlab/strong_memoize_attr.yml
+++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml
@@ -41,7 +41,6 @@ Gitlab/StrongMemoizeAttr:
- 'app/finders/ci/commit_statuses_finder.rb'
- 'app/finders/ci/pipelines_for_merge_request_finder.rb'
- 'app/finders/cluster_ancestors_finder.rb'
- - 'app/finders/clusters/knative_services_finder.rb'
- 'app/finders/concerns/finder_with_group_hierarchy.rb'
- 'app/finders/crm/contacts_finder.rb'
- 'app/finders/crm/organizations_finder.rb'
@@ -88,15 +87,12 @@ Gitlab/StrongMemoizeAttr:
- 'app/models/ci/processable.rb'
- 'app/models/ci/runner.rb'
- 'app/models/clusters/cluster.rb'
- - 'app/models/clusters/providers/aws.rb'
- 'app/models/commit.rb'
- 'app/models/commit_collection.rb'
- 'app/models/compare.rb'
- - 'app/models/concerns/analytics/cycle_analytics/stage.rb'
- 'app/models/concerns/avatarable.rb'
- 'app/models/concerns/cascading_namespace_setting_attribute.rb'
- 'app/models/concerns/ci/contextable.rb'
- - 'app/models/concerns/ci/partitionable.rb'
- 'app/models/concerns/discussion_on_diff.rb'
- 'app/models/concerns/has_repository.rb'
- 'app/models/concerns/has_wiki.rb'
@@ -155,7 +151,6 @@ Gitlab/StrongMemoizeAttr:
- 'app/presenters/blobs/unfold_presenter.rb'
- 'app/presenters/ci/build_runner_presenter.rb'
- 'app/presenters/ci/pipeline_artifacts/code_coverage_presenter.rb'
- - 'app/presenters/ci/pipeline_artifacts/code_quality_mr_diff_presenter.rb'
- 'app/presenters/ci/pipeline_presenter.rb'
- 'app/presenters/clusters/cluster_presenter.rb'
- 'app/presenters/merge_request_presenter.rb'
@@ -165,11 +160,7 @@ Gitlab/StrongMemoizeAttr:
- 'app/presenters/project_presenter.rb'
- 'app/presenters/projects/settings/deploy_keys_presenter.rb'
- 'app/serializers/ci/pipeline_entity.rb'
- - 'app/serializers/concerns/diff_file_conflict_type.rb'
- - 'app/serializers/diff_file_base_entity.rb'
- - 'app/serializers/integrations/field_entity.rb'
- 'app/serializers/linked_project_issue_entity.rb'
- - 'app/serializers/suggestion_entity.rb'
- 'app/services/alert_management/alerts/update_service.rb'
- 'app/services/alert_management/create_alert_issue_service.rb'
- 'app/services/alert_management/process_prometheus_alert_service.rb'
@@ -179,7 +170,6 @@ Gitlab/StrongMemoizeAttr:
- 'app/services/award_emojis/add_service.rb'
- 'app/services/base_project_service.rb'
- 'app/services/boards/base_items_list_service.rb'
- - 'app/services/boards/lists/base_create_service.rb'
- 'app/services/ci/create_downstream_pipeline_service.rb'
- 'app/services/ci/create_web_ide_terminal_service.rb'
- 'app/services/ci/job_artifacts/destroy_batch_service.rb'
@@ -194,7 +184,6 @@ Gitlab/StrongMemoizeAttr:
- 'app/services/ci/queue/build_queue_service.rb'
- 'app/services/ci/update_build_state_service.rb'
- 'app/services/clusters/agents/refresh_authorization_service.rb'
- - 'app/services/clusters/aws/finalize_creation_service.rb'
- 'app/services/clusters/integrations/prometheus_health_check_service.rb'
- 'app/services/concerns/alert_management/alert_processing.rb'
- 'app/services/concerns/incident_management/settings.rb'
@@ -273,7 +262,6 @@ Gitlab/StrongMemoizeAttr:
- 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb'
- 'app/services/projects/open_issues_count_service.rb'
- 'app/services/projects/record_target_platforms_service.rb'
- - 'app/services/projects/update_remote_mirror_service.rb'
- 'app/services/projects/update_statistics_service.rb'
- 'app/services/prometheus/proxy_service.rb'
- 'app/services/quick_actions/interpret_service.rb'
@@ -312,7 +300,6 @@ Gitlab/StrongMemoizeAttr:
- 'ee/app/controllers/ee/admin/health_check_controller.rb'
- 'ee/app/controllers/ee/groups/settings/repository_controller.rb'
- 'ee/app/controllers/ee/groups_controller.rb'
- - 'ee/app/controllers/ee/registrations/welcome_controller.rb'
- 'ee/app/controllers/ee/repositories/git_http_controller.rb'
- 'ee/app/controllers/groups/audit_events_controller.rb'
- 'ee/app/controllers/groups/epic_boards_controller.rb'
@@ -326,14 +313,12 @@ Gitlab/StrongMemoizeAttr:
- 'ee/app/finders/ee/issues_finder.rb'
- 'ee/app/finders/epics_finder.rb'
- 'ee/app/finders/incident_management/oncall_users_finder.rb'
- - 'ee/app/finders/requirements_management/requirements_finder.rb'
- 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb'
- 'ee/app/finders/security/training_providers/base_url_finder.rb'
- 'ee/app/graphql/resolvers/epics_resolver.rb'
- 'ee/app/graphql/resolvers/vulnerabilities_base_resolver.rb'
- 'ee/app/helpers/admin/emails_helper.rb'
- 'ee/app/helpers/auditor_user_helper.rb'
- - 'ee/app/helpers/billing_plans_helper.rb'
- 'ee/app/helpers/ee/ci/runners_helper.rb'
- 'ee/app/helpers/ee/preferences_helper.rb'
- 'ee/app/helpers/ee/registrations_helper.rb'
@@ -352,7 +337,6 @@ Gitlab/StrongMemoizeAttr:
- 'ee/app/models/approvals/scan_finding_wrapped_rule_set.rb'
- 'ee/app/models/approvals/wrapped_rule_set.rb'
- 'ee/app/models/burndown.rb'
- - 'ee/app/models/ci/minutes/limit.rb'
- 'ee/app/models/concerns/deprecated_approvals_before_merge.rb'
- 'ee/app/models/concerns/ee/approvable.rb'
- 'ee/app/models/concerns/ee/issue_available_features.rb'
@@ -363,7 +347,6 @@ Gitlab/StrongMemoizeAttr:
- 'ee/app/models/ee/ci/bridge.rb'
- 'ee/app/models/ee/ci/build.rb'
- 'ee/app/models/ee/ci/build_dependencies.rb'
- - 'ee/app/models/ee/ci/job_artifact.rb'
- 'ee/app/models/ee/ci/pipeline.rb'
- 'ee/app/models/ee/ci/runner.rb'
- 'ee/app/models/ee/deployment.rb'
@@ -403,7 +386,6 @@ Gitlab/StrongMemoizeAttr:
- 'ee/app/services/deployments/approval_service.rb'
- 'ee/app/services/ee/allowed_email_domains/update_service.rb'
- 'ee/app/services/ee/auto_merge_service.rb'
- - 'ee/app/services/ee/boards/lists/create_service.rb'
- 'ee/app/services/ee/ci/retry_pipeline_service.rb'
- 'ee/app/services/ee/incident_management/issuable_escalation_statuses/prepare_update_service.rb'
- 'ee/app/services/ee/integrations/test/project_service.rb'
@@ -440,7 +422,6 @@ Gitlab/StrongMemoizeAttr:
- 'ee/app/services/merge_commits/export_csv_service.rb'
- 'ee/app/services/merge_requests/update_blocks_service.rb'
- 'ee/app/services/projects/restore_service.rb'
- - 'ee/app/services/projects/update_mirror_service.rb'
- 'ee/app/services/protected_environments/base_service.rb'
- 'ee/app/services/security/ingestion/tasks/ingest_vulnerabilities/mark_resolved_as_detected.rb'
- 'ee/app/services/security/report_fetch_service.rb'
@@ -488,8 +469,6 @@ Gitlab/StrongMemoizeAttr:
- 'ee/lib/ee/gitlab/gitaly_client/with_feature_flag_actors.rb'
- 'ee/lib/ee/gitlab/import_export/after_export_strategies/custom_template_export_import_strategy.rb'
- 'ee/lib/ee/gitlab/issuable_metadata.rb'
- - 'ee/lib/ee/gitlab/scim/deprovision_service.rb'
- - 'ee/lib/ee/gitlab/scim/provisioning_service.rb'
- 'ee/lib/ee/gitlab/security/scan_configuration.rb'
- 'ee/lib/ee/gitlab/web_hooks/rate_limiter.rb'
- 'ee/lib/ee/sidebars/groups/menus/issues_menu.rb'
@@ -558,8 +537,6 @@ Gitlab/StrongMemoizeAttr:
- 'lib/banzai/filter/issuable_reference_expansion_filter.rb'
- 'lib/banzai/filter/references/reference_cache.rb'
- 'lib/banzai/filter/repository_link_filter.rb'
- - 'lib/banzai/reference_parser/merge_request_parser.rb'
- - 'lib/bulk_imports/clients/http.rb'
- 'lib/bulk_imports/pipeline.rb'
- 'lib/bulk_imports/users_mapper.rb'
- 'lib/container_registry/client.rb'
@@ -616,7 +593,6 @@ Gitlab/StrongMemoizeAttr:
- 'lib/gitlab/ci/pipeline/chain/seed.rb'
- 'lib/gitlab/ci/pipeline/chain/skip.rb'
- 'lib/gitlab/ci/pipeline/expression/lexer.rb'
- - 'lib/gitlab/ci/pipeline/logger.rb'
- 'lib/gitlab/ci/pipeline/metrics.rb'
- 'lib/gitlab/ci/pipeline/quota/deployments.rb'
- 'lib/gitlab/ci/pipeline/seed/processable/resource_group.rb'
@@ -687,7 +663,6 @@ Gitlab/StrongMemoizeAttr:
- 'lib/gitlab/gitaly_client/with_feature_flag_actors.rb'
- 'lib/gitlab/github_import/client.rb'
- 'lib/gitlab/github_import/importer/repository_importer.rb'
- - 'lib/gitlab/github_import/representation/diff_note.rb'
- 'lib/gitlab/github_import/representation/diff_notes/suggestion_formatter.rb'
- 'lib/gitlab/gl_repository/identifier.rb'
- 'lib/gitlab/gpg/commit.rb'
@@ -697,7 +672,6 @@ Gitlab/StrongMemoizeAttr:
- 'lib/gitlab/import_export/base/relation_object_saver.rb'
- 'lib/gitlab/import_export/decompressed_archive_size_validator.rb'
- 'lib/gitlab/import_export/fast_hash_serializer.rb'
- - 'lib/gitlab/import_export/group/legacy_tree_restorer.rb'
- 'lib/gitlab/import_export/group/tree_restorer.rb'
- 'lib/gitlab/import_export/importer.rb'
- 'lib/gitlab/import_export/json/legacy_reader.rb'
@@ -727,7 +701,6 @@ Gitlab/StrongMemoizeAttr:
- 'lib/gitlab/relative_positioning/starting_from.rb'
- 'lib/gitlab/request_context.rb'
- 'lib/gitlab/search/found_blob.rb'
- - 'lib/gitlab/search/parsed_query.rb'
- 'lib/gitlab/serverless/service.rb'
- 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb'
- 'lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/deduplicates_when_scheduling.rb'
diff --git a/.rubocop_todo/graphql/descriptions.yml b/.rubocop_todo/graphql/descriptions.yml
index 9d76d7d7638..b873ccc96ea 100644
--- a/.rubocop_todo/graphql/descriptions.yml
+++ b/.rubocop_todo/graphql/descriptions.yml
@@ -4,12 +4,6 @@ Graphql/Descriptions:
Safe: false
Details: grace period
Exclude:
- - 'app/graphql/mutations/boards/lists/base_update.rb'
- - 'app/graphql/mutations/ci/project_ci_cd_settings_update.rb'
- - 'app/graphql/mutations/clusters/agents/create.rb'
- - 'app/graphql/mutations/merge_requests/accept.rb'
- - 'app/graphql/mutations/notes/create/note.rb'
- - 'app/graphql/mutations/releases/create.rb'
- 'app/graphql/resolvers/admin/analytics/usage_trends/measurements_resolver.rb'
- 'app/graphql/resolvers/alert_management/alert_resolver.rb'
- 'app/graphql/resolvers/concerns/issues/sort_arguments.rb'
diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml
index 98633709bee..8531f0500f8 100644
--- a/.rubocop_todo/layout/argument_alignment.yml
+++ b/.rubocop_todo/layout/argument_alignment.yml
@@ -229,7 +229,6 @@ Layout/ArgumentAlignment:
- 'app/models/integrations/drone_ci.rb'
- 'app/models/integrations/emails_on_push.rb'
- 'app/models/integrations/external_wiki.rb'
- - 'app/models/integrations/flowdock.rb'
- 'app/models/integrations/harbor.rb'
- 'app/models/integrations/irker.rb'
- 'app/models/integrations/jenkins.rb'
@@ -332,15 +331,6 @@ Layout/ArgumentAlignment:
- 'config/routes/snippets.rb'
- 'config/routes/uploads.rb'
- 'config/routes/user.rb'
- - 'db/migrate/20210305002016_update_terraform_states_locked_by_user_id_foreign_key.rb'
- - 'db/migrate/20210308190413_change_batched_background_migrations_batch_class_name_default.rb'
- - 'db/migrate/20210324112439_add_index_mirror_data_on_retry_next_execution_where_status.rb'
- - 'db/migrate/20210329191850_add_finding_signature_table.rb'
- - 'db/migrate/20210413121101_add_created_at_web_hook_id_index_to_partitioned_web_hook_log.rb'
- - 'db/migrate/20210413123832_add_index_on_web_hook_id_to_partitioned_web_hook_log.rb'
- - 'db/migrate/20210505070612_create_packages_debian_group_distribution_keys.rb'
- - 'db/migrate/20210505070812_create_packages_debian_project_distribution_keys.rb'
- - 'db/migrate/20210601080039_group_protected_environments_add_index_and_constraint.rb'
- 'db/migrate/20210609013512_add_unique_index_for_batched_background_migrations.rb'
- 'db/migrate/20210625094554_create_error_tracking_error_events.rb'
- 'db/migrate/20210720130006_create_error_tracking_client_keys.rb'
@@ -397,10 +387,6 @@ Layout/ArgumentAlignment:
- 'db/migrate/20221102195642_create_dependency_proxy_manifest_states.rb'
- 'db/migrate/20221108185442_add_project_wiki_repository_id_to_project_wiki_repository_states.rb'
- 'db/migrate/20221110150942_add_project_id_lower_name_index_remove_old_index.rb'
- - 'db/post_migrate/20210330130420_drop_finding_fingerprint_table.rb'
- - 'db/post_migrate/20210413130011_add_partitioned_web_hook_log_fk.rb'
- - 'db/post_migrate/20210415101228_backfill_ci_build_needs_for_bigint_conversion.rb'
- - 'db/post_migrate/20210422023046_backfill_ci_sources_pipelines_source_job_id_for_bigint_conversion.rb'
- 'db/post_migrate/20210611080951_fix_missing_traversal_ids.rb'
- 'db/post_migrate/20210622045705_finalize_events_bigint_conversion.rb'
- 'db/post_migrate/20210701033622_finalize_ci_builds_needs_bigint_conversion.rb'
@@ -709,7 +695,6 @@ Layout/ArgumentAlignment:
- 'ee/spec/controllers/groups/security/policies_controller_spec.rb'
- 'ee/spec/controllers/groups/todos_controller_spec.rb'
- 'ee/spec/controllers/projects/iterations_controller_spec.rb'
- - 'ee/spec/controllers/projects/legacy_pipelines_controller_spec.rb'
- 'ee/spec/controllers/projects/merge_requests/creations_controller_spec.rb'
- 'ee/spec/controllers/projects/merge_requests_controller_spec.rb'
- 'ee/spec/controllers/projects/protected_environments_controller_spec.rb'
@@ -736,7 +721,6 @@ Layout/ArgumentAlignment:
- 'ee/spec/features/merge_trains/user_adds_to_merge_train_when_pipeline_succeeds_spec.rb'
- 'ee/spec/features/projects/environments/environments_spec.rb'
- 'ee/spec/features/projects/merge_requests/user_edits_merge_request_spec.rb'
- - 'ee/spec/features/projects/pipelines/legacy_pipeline_spec.rb'
- 'ee/spec/features/projects/pipelines/pipeline_spec.rb'
- 'ee/spec/features/registrations/saas/standard_flow_company_creating_project_spec.rb'
- 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb'
@@ -773,7 +757,6 @@ Layout/ArgumentAlignment:
- 'ee/spec/lib/incident_management/oncall_shift_generator_spec.rb'
- 'ee/spec/lib/slack/block_kit/app_home_opened_spec.rb'
- 'ee/spec/models/approval_wrapped_code_owner_rule_spec.rb'
- - 'ee/spec/models/ci/minutes/limit_spec.rb'
- 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb'
- 'ee/spec/models/ci/minutes/project_monthly_usage_spec.rb'
- 'ee/spec/models/ee/audit_event_spec.rb'
@@ -1096,7 +1079,6 @@ Layout/ArgumentAlignment:
- 'spec/controllers/projects/clusters_controller_spec.rb'
- 'spec/controllers/projects/commit_controller_spec.rb'
- 'spec/controllers/projects/design_management/designs/raw_images_controller_spec.rb'
- - 'spec/controllers/projects/design_management/designs/resized_image_controller_spec.rb'
- 'spec/controllers/projects/environments_controller_spec.rb'
- 'spec/controllers/projects/feature_flags_clients_controller_spec.rb'
- 'spec/controllers/projects/forks_controller_spec.rb'
@@ -1154,8 +1136,6 @@ Layout/ArgumentAlignment:
- 'spec/features/projects/files/user_reads_pipeline_status_spec.rb'
- 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb'
- 'spec/features/projects/jobs_spec.rb'
- - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb'
- - 'spec/features/projects/pipelines/legacy_pipelines_spec.rb'
- 'spec/features/projects/pipelines/pipeline_spec.rb'
- 'spec/features/projects/pipelines/pipelines_spec.rb'
- 'spec/features/tags/developer_deletes_tag_spec.rb'
diff --git a/.rubocop_todo/layout/array_alignment.yml b/.rubocop_todo/layout/array_alignment.yml
new file mode 100644
index 00000000000..3f3e6a393da
--- /dev/null
+++ b/.rubocop_todo/layout/array_alignment.yml
@@ -0,0 +1,365 @@
+---
+# Cop supports --autocorrect.
+Layout/ArrayAlignment:
+ Details: grace period
+ Exclude:
+ - 'app/controllers/admin/application_settings_controller.rb'
+ - 'app/controllers/admin/broadcast_messages_controller.rb'
+ - 'app/controllers/admin/plan_limits_controller.rb'
+ - 'app/controllers/concerns/observability/content_security_policy.rb'
+ - 'app/controllers/profiles_controller.rb'
+ - 'app/controllers/projects/feature_flags_controller.rb'
+ - 'app/controllers/projects/labels_controller.rb'
+ - 'app/controllers/projects/protected_branches_controller.rb'
+ - 'app/controllers/projects/settings/ci_cd_controller.rb'
+ - 'app/controllers/projects_controller.rb'
+ - 'app/controllers/users_controller.rb'
+ - 'app/finders/user_groups_counter.rb'
+ - 'app/graphql/resolvers/concerns/issues/sort_arguments.rb'
+ - 'app/graphql/types/permission_types/merge_request.rb'
+ - 'app/helpers/merge_requests_helper.rb'
+ - 'app/helpers/namespaces_helper.rb'
+ - 'app/helpers/search_helper.rb'
+ - 'app/helpers/submodule_helper.rb'
+ - 'app/models/ci/bridge.rb'
+ - 'app/models/ci/build.rb'
+ - 'app/models/concerns/ci/partitionable/switch.rb'
+ - 'app/models/container_repository.rb'
+ - 'app/models/deploy_token.rb'
+ - 'app/models/dev_ops_report/metric.rb'
+ - 'app/models/group.rb'
+ - 'app/models/integration.rb'
+ - 'app/models/integrations/hangouts_chat.rb'
+ - 'app/models/integrations/microsoft_teams.rb'
+ - 'app/models/integrations/pumble.rb'
+ - 'app/models/integrations/unify_circuit.rb'
+ - 'app/models/integrations/webex_teams.rb'
+ - 'app/models/issue.rb'
+ - 'app/models/repository.rb'
+ - 'app/models/snippet_repository.rb'
+ - 'app/models/user.rb'
+ - 'app/models/wiki.rb'
+ - 'app/services/ci/create_pipeline_service.rb'
+ - 'app/services/commits/create_service.rb'
+ - 'app/services/labels/transfer_service.rb'
+ - 'app/services/namespaces/package_settings/update_service.rb'
+ - 'app/services/packages/rpm/parse_package_service.rb'
+ - 'app/services/projects/participants_service.rb'
+ - 'app/services/web_hook_service.rb'
+ - 'config/application.rb'
+ - 'config/initializers/0_marginalia.rb'
+ - 'config/initializers/direct_upload_support.rb'
+ - 'db/post_migrate/20220728134255_update_index_vulnerabilities_common_finder.rb'
+ - 'ee/app/controllers/admin/push_rules_controller.rb'
+ - 'ee/app/controllers/ee/admin/application_settings_controller.rb'
+ - 'ee/app/controllers/ee/projects/merge_requests_controller.rb'
+ - 'ee/app/controllers/groups/protected_branches_controller.rb'
+ - 'ee/app/controllers/groups/push_rules_controller.rb'
+ - 'ee/app/controllers/projects/push_rules_controller.rb'
+ - 'ee/app/finders/autocomplete/project_invited_groups_finder.rb'
+ - 'ee/app/finders/ee/issues_finder/params.rb'
+ - 'ee/app/finders/geo/project_registry_finder.rb'
+ - 'ee/app/graphql/ee/resolvers/project_pipelines_resolver.rb'
+ - 'ee/app/helpers/ee/routing/projects_helper.rb'
+ - 'ee/app/models/concerns/geo/verification_state.rb'
+ - 'ee/app/models/dast_site_profile.rb'
+ - 'ee/app/models/dora/base_metric.rb'
+ - 'ee/app/models/ee/application_setting.rb'
+ - 'ee/app/models/ee/epic.rb'
+ - 'ee/app/models/ee/user.rb'
+ - 'ee/app/models/geo/event_log.rb'
+ - 'ee/app/models/gitlab_subscription_history.rb'
+ - 'ee/app/models/ip_restriction.rb'
+ - 'ee/app/models/license.rb'
+ - 'ee/app/models/protected_environment.rb'
+ - 'ee/app/models/security/finding.rb'
+ - 'ee/app/services/ee/users/authorized_build_service.rb'
+ - 'ee/app/services/jira/requests/issues/list_service.rb'
+ - 'ee/app/services/protected_environments/base_service.rb'
+ - 'ee/app/services/security/security_orchestration_policies/create_pipeline_service.rb'
+ - 'ee/app/services/vulnerabilities/create_service_base.rb'
+ - 'ee/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary.rb'
+ - 'ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb'
+ - 'ee/spec/controllers/admin/licenses/usage_exports_controller_spec.rb'
+ - 'ee/spec/factories/dependencies.rb'
+ - 'ee/spec/features/boards/boards_licensed_features_spec.rb'
+ - 'ee/spec/features/groups/analytics/cycle_analytics/charts_spec.rb'
+ - 'ee/spec/features/groups/group_roadmap_spec.rb'
+ - 'ee/spec/finders/namespaces/billed_users_finder_spec.rb'
+ - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb'
+ - 'ee/spec/frontend/fixtures/search.rb'
+ - 'ee/spec/graphql/resolvers/analytics/contribution_analytics/contributions_resolver_spec.rb'
+ - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb'
+ - 'ee/spec/graphql/types/dast_site_profile_type_spec.rb'
+ - 'ee/spec/graphql/types/permission_types/epic_spec.rb'
+ - 'ee/spec/graphql/types/permission_types/vulnerability_spec.rb'
+ - 'ee/spec/graphql/types/pipeline_security_report_finding_type_spec.rb'
+ - 'ee/spec/graphql/types/requirements_management/requirement_type_spec.rb'
+ - 'ee/spec/graphql/types/vulnerability_type_spec.rb'
+ - 'ee/spec/helpers/billing_plans_helper_spec.rb'
+ - 'ee/spec/helpers/boards_helper_spec.rb'
+ - 'ee/spec/helpers/ee/application_settings_helper_spec.rb'
+ - 'ee/spec/helpers/ee/environments_helper_spec.rb'
+ - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb'
+ - 'ee/spec/lib/audit/project_changes_auditor_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb'
+ - 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/config/security_orchestration_policies/processor_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/reports/dependency_list/report_spec.rb'
+ - 'ee/spec/lib/gitlab/graphql/loaders/oncall_participant_loader_spec.rb'
+ - 'ee/spec/lib/gitlab/search/index_curator_spec.rb'
+ - 'ee/spec/lib/gitlab/visibility_level_spec.rb'
+ - 'ee/spec/lib/incident_management/oncall_shift_generator_spec.rb'
+ - 'ee/spec/models/dora/base_metric_spec.rb'
+ - 'ee/spec/models/dora/daily_metrics_spec.rb'
+ - 'ee/spec/models/ee/group_spec.rb'
+ - 'ee/spec/models/ee/protected_ref_access_spec.rb'
+ - 'ee/spec/models/issue_spec.rb'
+ - 'ee/spec/models/project_spec.rb'
+ - 'ee/spec/models/repository_spec.rb'
+ - 'ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb'
+ - 'ee/spec/models/security/scan_spec.rb'
+ - 'ee/spec/policies/group_policy_spec.rb'
+ - 'ee/spec/policies/project_policy_spec.rb'
+ - 'ee/spec/requests/api/dora/metrics_spec.rb'
+ - 'ee/spec/requests/api/graphql/group/epic/epic_ancestors_spec.rb'
+ - 'ee/spec/requests/api/graphql/group/epic/epic_children_spec.rb'
+ - 'ee/spec/requests/api/graphql/group/epics_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/releases/update_spec.rb'
+ - 'ee/spec/requests/api/ldap_group_links_spec.rb'
+ - 'ee/spec/requests/api/license_spec.rb'
+ - 'ee/spec/requests/api/members_spec.rb'
+ - 'ee/spec/requests/api/saml_group_links_spec.rb'
+ - 'ee/spec/serializers/dashboard_environment_entity_spec.rb'
+ - 'ee/spec/serializers/user_analytics_entity_spec.rb'
+ - 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb'
+ - 'ee/spec/services/audit_events/export_csv_service_spec.rb'
+ - 'ee/spec/services/ee/auto_merge_service_spec.rb'
+ - 'ee/spec/services/ee/boards/issues/list_service_spec.rb'
+ - 'ee/spec/services/epic_issues/create_service_spec.rb'
+ - 'ee/spec/services/epics/epic_links/create_service_spec.rb'
+ - 'ee/spec/services/groups/seat_usage_export_service_spec.rb'
+ - 'ee/spec/services/incident_management/issuable_resource_links/zoom_link_service_spec.rb'
+ - 'ee/spec/services/security/dependency_list_service_spec.rb'
+ - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb'
+ - 'ee/spec/services/security/security_orchestration_policies/create_pipeline_service_spec.rb'
+ - 'ee/spec/services/security/security_orchestration_policies/scan_pipeline_service_spec.rb'
+ - 'ee/spec/services/security/token_revocation_service_spec.rb'
+ - 'ee/spec/support/helpers/vulnerability_exports_helpers.rb'
+ - 'ee/spec/support/shared_examples/finders/epics/findable_shared_examples.rb'
+ - 'ee/spec/support/shared_examples/policies/requirement_policy_shared_examples.rb'
+ - 'lib/api/api_guard.rb'
+ - 'lib/api/ci/runner.rb'
+ - 'lib/api/ci/runners.rb'
+ - 'lib/api/internal/base.rb'
+ - 'lib/api/statistics.rb'
+ - 'lib/gitlab/alert_management/payload/prometheus.rb'
+ - 'lib/gitlab/bitbucket_import/importer.rb'
+ - 'lib/gitlab/chat/command.rb'
+ - 'lib/gitlab/checks/single_change_access.rb'
+ - 'lib/gitlab/ci/config/entry/default.rb'
+ - 'lib/gitlab/ci/config/entry/job.rb'
+ - 'lib/gitlab/ci/config/entry/processable.rb'
+ - 'lib/gitlab/ci/config/entry/reports.rb'
+ - 'lib/gitlab/ci/config/entry/root.rb'
+ - 'lib/gitlab/ci/config/external/processor.rb'
+ - 'lib/gitlab/ci/status/bridge/factory.rb'
+ - 'lib/gitlab/ci/status/build/factory.rb'
+ - 'lib/gitlab/ci/status/stage/factory.rb'
+ - 'lib/gitlab/cleanup/project_upload_file_finder.rb'
+ - 'lib/gitlab/conflict/file_collection.rb'
+ - 'lib/gitlab/content_security_policy/config_loader.rb'
+ - 'lib/gitlab/database/background_migration/batched_job.rb'
+ - 'lib/gitlab/email/message/in_product_marketing/team.rb'
+ - 'lib/gitlab/email/message/in_product_marketing/trial.rb'
+ - 'lib/gitlab/email/message/in_product_marketing/verify.rb'
+ - 'lib/gitlab/email/receiver.rb'
+ - 'lib/gitlab/etag_caching/router/rails.rb'
+ - 'lib/gitlab/git/diff.rb'
+ - 'lib/gitlab/import_export/importer.rb'
+ - 'lib/gitlab/instrumentation/redis.rb'
+ - 'lib/gitlab/lograge/custom_options.rb'
+ - 'lib/gitlab/metrics/global_search_slis.rb'
+ - 'lib/gitlab/metrics/requests_rack_middleware.rb'
+ - 'lib/gitlab/metrics/samplers/threads_sampler.rb'
+ - 'lib/gitlab/object_hierarchy.rb'
+ - 'lib/gitlab/project_authorizations.rb'
+ - 'lib/gitlab/rack_attack/instrumented_cache_store.rb'
+ - 'lib/gitlab/reference_extractor.rb'
+ - 'lib/gitlab/sidekiq_middleware/size_limiter/validator.rb'
+ - 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric.rb'
+ - 'lib/gitlab/visibility_level.rb'
+ - 'lib/kramdown/parser/atlassian_document_format.rb'
+ - 'lib/tasks/cache.rake'
+ - 'qa/qa/specs/features/browser_ui/3_create/pages/new_static_page_spec.rb'
+ - 'qa/qa/specs/features/browser_ui/5_package/package_registry/composer_registry_spec.rb'
+ - 'qa/qa/specs/features/browser_ui/5_package/package_registry/generic_repository_spec.rb'
+ - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_instance_level_spec.rb'
+ - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_project_level_spec.rb'
+ - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb'
+ - 'qa/qa/specs/features/ee/browser_ui/10_govern/group/group_audit_logs_2_spec.rb'
+ - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb'
+ - 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb'
+ - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb'
+ - 'qa/spec/specs/runner_spec.rb'
+ - 'rubocop/cop/gitlab/rspec/avoid_setup.rb'
+ - 'rubocop/cop/graphql/authorize_types.rb'
+ - 'spec/controllers/import/bulk_imports_controller_spec.rb'
+ - 'spec/controllers/projects/pipeline_schedules_controller_spec.rb'
+ - 'spec/factories/ci/builds.rb'
+ - 'spec/features/groups_spec.rb'
+ - 'spec/features/issuables/sorting_list_spec.rb'
+ - 'spec/features/oauth_login_spec.rb'
+ - 'spec/features/uploads/user_uploads_file_to_note_spec.rb'
+ - 'spec/finders/ci/pipelines_finder_spec.rb'
+ - 'spec/finders/ci/runners_finder_spec.rb'
+ - 'spec/finders/groups/accepting_project_transfers_finder_spec.rb'
+ - 'spec/finders/groups_finder_spec.rb'
+ - 'spec/finders/snippets_finder_spec.rb'
+ - 'spec/graphql/gitlab_schema_spec.rb'
+ - 'spec/graphql/mutations/commits/create_spec.rb'
+ - 'spec/graphql/resolvers/ci/all_jobs_resolver_spec.rb'
+ - 'spec/graphql/resolvers/environments/nested_environments_resolver_spec.rb'
+ - 'spec/graphql/resolvers/project_issues_resolver_spec.rb'
+ - 'spec/graphql/types/blob_viewer_type_spec.rb'
+ - 'spec/graphql/types/boards/board_issue_input_type_spec.rb'
+ - 'spec/graphql/types/commit_signatures/verification_status_enum_spec.rb'
+ - 'spec/graphql/types/container_repository_details_type_spec.rb'
+ - 'spec/graphql/types/container_repository_type_spec.rb'
+ - 'spec/graphql/types/issuable_sort_enum_spec.rb'
+ - 'spec/graphql/types/issue_type_spec.rb'
+ - 'spec/graphql/types/project_type_spec.rb'
+ - 'spec/graphql/types/snippet_type_spec.rb'
+ - 'spec/graphql/types/snippets/blob_type_spec.rb'
+ - 'spec/graphql/types/snippets/blob_viewer_type_spec.rb'
+ - 'spec/helpers/blame_helper_spec.rb'
+ - 'spec/helpers/ci/pipelines_helper_spec.rb'
+ - 'spec/helpers/labels_helper_spec.rb'
+ - 'spec/helpers/releases_helper_spec.rb'
+ - 'spec/lib/banzai/filter/color_filter_spec.rb'
+ - 'spec/lib/banzai/reference_parser/design_parser_spec.rb'
+ - 'spec/lib/container_registry/path_spec.rb'
+ - 'spec/lib/gitlab/auth/saml/user_spec.rb'
+ - 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb'
+ - 'spec/lib/gitlab/background_migration/job_coordinator_spec.rb'
+ - 'spec/lib/gitlab/backtrace_cleaner_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/bridge_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/default_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/id_token_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/job_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/ports_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/root_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/services_spec.rb'
+ - 'spec/lib/gitlab/ci/config/external/file/remote_spec.rb'
+ - 'spec/lib/gitlab/ci/config/external/mapper/filter_spec.rb'
+ - 'spec/lib/gitlab/ci/config/external/mapper/location_expander_spec.rb'
+ - 'spec/lib/gitlab/ci/config/external/mapper/matcher_spec.rb'
+ - 'spec/lib/gitlab/ci/config/external/mapper/normalizer_spec.rb'
+ - 'spec/lib/gitlab/ci/config/external/mapper_spec.rb'
+ - 'spec/lib/gitlab/ci/config_spec.rb'
+ - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb'
+ - 'spec/lib/gitlab/ci/pipeline/chain/build/associations_spec.rb'
+ - 'spec/lib/gitlab/ci/pipeline/chain/seed_spec.rb'
+ - 'spec/lib/gitlab/ci/pipeline/duration_spec.rb'
+ - 'spec/lib/gitlab/ci/pipeline/preloader_spec.rb'
+ - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb'
+ - 'spec/lib/gitlab/ci/pipeline/seed/stage_spec.rb'
+ - 'spec/lib/gitlab/ci/reports/security/aggregated_report_spec.rb'
+ - 'spec/lib/gitlab/ci/secure_files/mobile_provision_spec.rb'
+ - 'spec/lib/gitlab/ci/secure_files/x509_name_spec.rb'
+ - 'spec/lib/gitlab/ci/status/bridge/factory_spec.rb'
+ - 'spec/lib/gitlab/ci/status/build/factory_spec.rb'
+ - 'spec/lib/gitlab/ci/variables/builder_spec.rb'
+ - 'spec/lib/gitlab/ci/variables/collection_spec.rb'
+ - 'spec/lib/gitlab/ci/variables/helpers_spec.rb'
+ - 'spec/lib/gitlab/ci/yaml_processor_spec.rb'
+ - 'spec/lib/gitlab/database/load_balancing/rack_middleware_spec.rb'
+ - 'spec/lib/gitlab/database/load_balancing/service_discovery/sampler_spec.rb'
+ - 'spec/lib/gitlab/database/load_balancing/sticking_spec.rb'
+ - 'spec/lib/gitlab/database/tables_sorted_by_foreign_keys_spec.rb'
+ - 'spec/lib/gitlab/diff/highlight_cache_spec.rb'
+ - 'spec/lib/gitlab/diff/inline_diff_spec.rb'
+ - 'spec/lib/gitlab/diff/lines_unfolder_spec.rb'
+ - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb'
+ - 'spec/lib/gitlab/git/push_spec.rb'
+ - 'spec/lib/gitlab/git_access_spec.rb'
+ - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb'
+ - 'spec/lib/gitlab/graphql/loaders/batch_model_loader_spec.rb'
+ - 'spec/lib/gitlab/i18n/po_linter_spec.rb'
+ - 'spec/lib/gitlab/import_export/attributes_finder_spec.rb'
+ - 'spec/lib/gitlab/import_export/members_mapper_spec.rb'
+ - 'spec/lib/gitlab/issuable_sorter_spec.rb'
+ - 'spec/lib/gitlab/kroki_spec.rb'
+ - 'spec/lib/gitlab/language_detection_spec.rb'
+ - 'spec/lib/gitlab/markup_helper_spec.rb'
+ - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb'
+ - 'spec/lib/gitlab/patch/prependable_spec.rb'
+ - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb'
+ - 'spec/lib/gitlab/reference_extractor_spec.rb'
+ - 'spec/lib/gitlab/serializer/ci/variables_spec.rb'
+ - 'spec/lib/gitlab/sidekiq_config/worker_spec.rb'
+ - 'spec/lib/gitlab/sidekiq_migrate_jobs_spec.rb'
+ - 'spec/lib/gitlab/ssh_public_key_spec.rb'
+ - 'spec/lib/gitlab/usage_data/topology_spec.rb'
+ - 'spec/lib/gitlab/utils/merge_hash_spec.rb'
+ - 'spec/lib/gitlab/visibility_level_spec.rb'
+ - 'spec/models/application_setting_spec.rb'
+ - 'spec/models/ci/bridge_spec.rb'
+ - 'spec/models/ci/build_spec.rb'
+ - 'spec/models/ci/group_spec.rb'
+ - 'spec/models/ci/pipeline_spec.rb'
+ - 'spec/models/ci/processable_spec.rb'
+ - 'spec/models/commit_status_spec.rb'
+ - 'spec/models/concerns/ci/has_status_spec.rb'
+ - 'spec/models/concerns/issuable_spec.rb'
+ - 'spec/models/design_management/version_spec.rb'
+ - 'spec/models/discussion_spec.rb'
+ - 'spec/models/external_pull_request_spec.rb'
+ - 'spec/models/group_group_link_spec.rb'
+ - 'spec/models/incident_management/timeline_event_tag_spec.rb'
+ - 'spec/models/integrations/irker_spec.rb'
+ - 'spec/models/issue_spec.rb'
+ - 'spec/models/namespace/package_setting_spec.rb'
+ - 'spec/models/operations/feature_flags/strategy_spec.rb'
+ - 'spec/models/operations/feature_flags/user_list_spec.rb'
+ - 'spec/models/project_group_link_spec.rb'
+ - 'spec/models/repository_spec.rb'
+ - 'spec/models/snippet_repository_spec.rb'
+ - 'spec/models/user_preference_spec.rb'
+ - 'spec/models/user_spec.rb'
+ - 'spec/models/web_ide_terminal_spec.rb'
+ - 'spec/policies/merge_request_policy_spec.rb'
+ - 'spec/policies/project_policy_spec.rb'
+ - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb'
+ - 'spec/requests/api/graphql/group_query_spec.rb'
+ - 'spec/requests/api/graphql/jobs_query_spec.rb'
+ - 'spec/requests/api/graphql/project/languages_spec.rb'
+ - 'spec/requests/api/projects_spec.rb'
+ - 'spec/requests/api/releases_spec.rb'
+ - 'spec/requests/api/settings_spec.rb'
+ - 'spec/requests/api/snippets_spec.rb'
+ - 'spec/serializers/fork_namespace_entity_spec.rb'
+ - 'spec/serializers/group_child_entity_spec.rb'
+ - 'spec/services/auto_merge_service_spec.rb'
+ - 'spec/services/ci/create_pipeline_service_spec.rb'
+ - 'spec/services/ci/enqueue_job_service_spec.rb'
+ - 'spec/services/ci/job_artifacts/destroy_batch_service_spec.rb'
+ - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb'
+ - 'spec/services/ci/play_build_service_spec.rb'
+ - 'spec/services/feature_flags/create_service_spec.rb'
+ - 'spec/services/issues/referenced_merge_requests_service_spec.rb'
+ - 'spec/services/merge_requests/conflicts/resolve_service_spec.rb'
+ - 'spec/services/projects/detect_repository_languages_service_spec.rb'
+ - 'spec/services/security/merge_reports_service_spec.rb'
+ - 'spec/services/spam/spam_verdict_service_spec.rb'
+ - 'spec/support/helpers/kubernetes_helpers.rb'
+ - 'spec/support/helpers/login_helpers.rb'
+ - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb'
+ - 'spec/support/shared_examples/lib/email/email_shared_examples.rb'
+ - 'spec/support/shared_examples/lib/wikis_api_examples.rb'
+ - 'spec/support/shared_examples/models/label_note_shared_examples.rb'
+ - 'spec/support/shared_examples/models/mentionable_shared_examples.rb'
+ - 'spec/workers/pages_domain_ssl_renewal_cron_worker_spec.rb'
diff --git a/.rubocop_todo/layout/first_argument_indentation.yml b/.rubocop_todo/layout/first_argument_indentation.yml
new file mode 100644
index 00000000000..fb364356a97
--- /dev/null
+++ b/.rubocop_todo/layout/first_argument_indentation.yml
@@ -0,0 +1,26 @@
+---
+# Cop supports --autocorrect.
+Layout/FirstArgumentIndentation:
+ Details: grace period
+ Exclude:
+ - 'app/models/customer_relations/contact.rb'
+ - 'app/models/cycle_analytics/project_level_stage_adapter.rb'
+ - 'app/models/users/user_follow_user.rb'
+ - 'ee/lib/ee/gitlab/scim/group/deprovisioning_service.rb'
+ - 'ee/spec/controllers/groups/omniauth_callbacks_controller_spec.rb'
+ - 'ee/spec/controllers/registrations/company_controller_spec.rb'
+ - 'ee/spec/lib/gitlab/geo/log_cursor/daemon_spec.rb'
+ - 'ee/spec/services/audit_events/protected_branch_audit_event_service_spec.rb'
+ - 'ee/spec/services/security/report_summary_service_spec.rb'
+ - 'spec/components/previews/pajamas/alert_component_preview.rb'
+ - 'spec/components/previews/pajamas/banner_component_preview.rb'
+ - 'spec/components/previews/pajamas/button_component_preview.rb'
+ - 'spec/controllers/import/bitbucket_controller_spec.rb'
+ - 'spec/lib/gitlab/application_rate_limiter_spec.rb'
+ - 'spec/lib/gitlab/database/loose_foreign_keys_spec.rb'
+ - 'spec/lib/gitlab/import_export/shared_spec.rb'
+ - 'spec/models/loose_foreign_keys/deleted_record_spec.rb'
+ - 'spec/requests/api/graphql/ci/jobs_spec.rb'
+ - 'spec/services/protected_branches/api_service_spec.rb'
+ - 'spec/support/shared_examples/features/search/redacted_search_results_shared_examples.rb'
+ - 'spec/support/shared_examples/quick_actions/issuable/max_issuable_examples.rb'
diff --git a/.rubocop_todo/layout/first_array_element_indentation.yml b/.rubocop_todo/layout/first_array_element_indentation.yml
new file mode 100644
index 00000000000..c42d1c54a8b
--- /dev/null
+++ b/.rubocop_todo/layout/first_array_element_indentation.yml
@@ -0,0 +1,89 @@
+---
+# Cop supports --autocorrect.
+Layout/FirstArrayElementIndentation:
+ Details: grace period
+ Exclude:
+ - 'app/controllers/admin/broadcast_messages_controller.rb'
+ - 'app/controllers/admin/plan_limits_controller.rb'
+ - 'app/finders/user_groups_counter.rb'
+ - 'app/helpers/search_helper.rb'
+ - 'app/models/container_repository.rb'
+ - 'app/models/group.rb'
+ - 'app/models/integration.rb'
+ - 'app/models/user.rb'
+ - 'app/services/labels/transfer_service.rb'
+ - 'ee/app/finders/autocomplete/project_invited_groups_finder.rb'
+ - 'ee/app/finders/geo/project_registry_finder.rb'
+ - 'ee/app/models/ee/application_setting.rb'
+ - 'ee/app/models/protected_environment.rb'
+ - 'ee/app/services/vulnerabilities/create_service_base.rb'
+ - 'ee/lib/ee/api/helpers/award_emoji.rb'
+ - 'ee/spec/controllers/admin/licenses/usage_exports_controller_spec.rb'
+ - 'ee/spec/controllers/projects/merge_requests_controller_spec.rb'
+ - 'ee/spec/features/boards/boards_licensed_features_spec.rb'
+ - 'ee/spec/features/groups/analytics/cycle_analytics/charts_spec.rb'
+ - 'ee/spec/features/groups/group_roadmap_spec.rb'
+ - 'ee/spec/finders/namespaces/billed_users_finder_spec.rb'
+ - 'ee/spec/frontend/fixtures/dast_profiles.rb'
+ - 'ee/spec/frontend/fixtures/search.rb'
+ - 'ee/spec/graphql/resolvers/analytics/contribution_analytics/contributions_resolver_spec.rb'
+ - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb'
+ - 'ee/spec/graphql/types/dast_site_profile_type_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/config/security_orchestration_policies/processor_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/Jobs/browser_performance_testing_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/Jobs/dast_default_branch_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/Jobs/load_performance_testing_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/models/ee/group_spec.rb'
+ - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb'
+ - 'ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb'
+ - 'ee/spec/policies/project_policy_spec.rb'
+ - 'ee/spec/requests/api/graphql/analytics/contribution_analytics/contributions_spec.rb'
+ - 'ee/spec/requests/api/graphql/group/epics_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/releases/update_spec.rb'
+ - 'ee/spec/requests/api/graphql/project/merge_requests_spec.rb'
+ - 'ee/spec/requests/api/ldap_group_links_spec.rb'
+ - 'ee/spec/requests/api/members_spec.rb'
+ - 'ee/spec/requests/api/saml_group_links_spec.rb'
+ - 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb'
+ - 'ee/spec/services/audit_events/export_csv_service_spec.rb'
+ - 'ee/spec/services/groups/seat_usage_export_service_spec.rb'
+ - 'lib/gitlab/email/message/in_product_marketing/team.rb'
+ - 'lib/gitlab/email/message/in_product_marketing/trial.rb'
+ - 'lib/gitlab/email/message/in_product_marketing/verify.rb'
+ - 'lib/gitlab/object_hierarchy.rb'
+ - 'lib/gitlab/project_authorizations.rb'
+ - 'qa/qa/specs/features/api/12_systems/gitaly/automatic_failover_and_recovery_spec.rb'
+ - 'qa/qa/specs/features/api/12_systems/gitaly/changing_repository_storage_spec.rb'
+ - 'qa/qa/specs/features/api/12_systems/gitaly/praefect_dataloss_spec.rb'
+ - 'qa/qa/specs/features/browser_ui/5_package/infrastructure_registry/terraform_module_registry_spec.rb'
+ - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_instance_level_spec.rb'
+ - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_project_level_spec.rb'
+ - 'qa/qa/specs/features/ee/api/9_data_stores/elasticsearch/index_tests/main_index/blob_index_spec.rb'
+ - 'qa/qa/specs/features/ee/api/9_data_stores/elasticsearch/nightly_elasticsearch_test_spec.rb'
+ - 'spec/controllers/projects/pipelines_controller_spec.rb'
+ - 'spec/finders/groups/accepting_project_transfers_finder_spec.rb'
+ - 'spec/graphql/mutations/commits/create_spec.rb'
+ - 'spec/graphql/resolvers/environments/nested_environments_resolver_spec.rb'
+ - 'spec/graphql/types/commit_signatures/verification_status_enum_spec.rb'
+ - 'spec/lib/gitlab/analytics/usage_trends/workers_argument_builder_spec.rb'
+ - 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb'
+ - 'spec/lib/gitlab/backtrace_cleaner_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/id_token_spec.rb'
+ - 'spec/lib/gitlab/ci/secure_files/x509_name_spec.rb'
+ - 'spec/lib/gitlab/database/load_balancing/rack_middleware_spec.rb'
+ - 'spec/lib/gitlab/database/load_balancing/service_discovery/sampler_spec.rb'
+ - 'spec/lib/gitlab/diff/inline_diff_spec.rb'
+ - 'spec/lib/gitlab/github_import/importer/diff_notes_importer_spec.rb'
+ - 'spec/lib/gitlab/github_import/importer/lfs_objects_importer_spec.rb'
+ - 'spec/lib/gitlab/github_import/importer/notes_importer_spec.rb'
+ - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb'
+ - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb'
+ - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb'
+ - 'spec/lib/gitlab/usage_data/topology_spec.rb'
+ - 'spec/models/group_group_link_spec.rb'
+ - 'spec/models/project_group_link_spec.rb'
+ - 'spec/models/user_preference_spec.rb'
+ - 'spec/services/issues/referenced_merge_requests_service_spec.rb'
+ - 'spec/services/security/merge_reports_service_spec.rb'
diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml
index e1ac4ccb650..facc7a58f1a 100644
--- a/.rubocop_todo/layout/first_hash_element_indentation.yml
+++ b/.rubocop_todo/layout/first_hash_element_indentation.yml
@@ -1,292 +1,159 @@
---
# Cop supports --autocorrect.
Layout/FirstHashElementIndentation:
+ Details: grace period
Exclude:
- - 'app/helpers/avatars_helper.rb'
- - 'app/helpers/breadcrumbs_helper.rb'
- - 'app/helpers/broadcast_messages_helper.rb'
+ - 'app/controllers/admin/system_info_controller.rb'
+ - 'app/controllers/concerns/milestone_actions.rb'
+ - 'app/controllers/concerns/render_service_results.rb'
+ - 'app/controllers/concerns/sourcegraph_decorator.rb'
+ - 'app/controllers/projects/badges_controller.rb'
+ - 'app/controllers/projects/merge_requests_controller.rb'
+ - 'app/controllers/repositories/lfs_locks_api_controller.rb'
+ - 'app/experiments/concerns/project_commit_count.rb'
+ - 'app/graphql/mutations/notes/create/diff_note.rb'
+ - 'app/graphql/mutations/notes/create/image_diff_note.rb'
+ - 'app/graphql/mutations/notes/create/note.rb'
+ - 'app/graphql/resolvers/ci/runner_projects_resolver.rb'
+ - 'app/graphql/resolvers/group_packages_resolver.rb'
- 'app/helpers/commits_helper.rb'
- - 'app/helpers/environments_helper.rb'
- - 'app/helpers/keyset_helper.rb'
- - 'app/helpers/listbox_helper.rb'
- - 'app/helpers/page_layout_helper.rb'
- 'app/helpers/projects/project_members_helper.rb'
- 'app/helpers/search_helper.rb'
- - 'app/helpers/sorting_helper.rb'
- 'app/helpers/ssh_keys_helper.rb'
- 'app/helpers/tags_helper.rb'
- - 'app/helpers/tree_helper.rb'
- - 'app/helpers/users_helper.rb'
- - 'app/mailers/emails/issues.rb'
- - 'app/mailers/emails/merge_requests.rb'
- 'app/models/application_setting.rb'
- - 'app/models/ci/build.rb'
- 'app/models/ci/build_metadata.rb'
- - 'app/models/ci/runner.rb'
- 'app/models/clusters/applications/crossplane.rb'
- - 'app/models/clusters/platforms/kubernetes.rb'
- - 'app/models/concerns/cross_database_modification.rb'
- - 'app/models/concerns/featurable.rb'
- 'app/models/concerns/has_wiki_page_slug_attributes.rb'
- - 'app/models/concerns/integrations/enable_ssl_verification.rb'
- 'app/models/concerns/subscribable.rb'
- 'app/models/concerns/taskable.rb'
- 'app/models/diff_note.rb'
- - 'app/models/integrations/jira.rb'
- - 'app/models/jira_connect_installation.rb'
+ - 'app/models/merge_request.rb'
- 'app/models/milestone.rb'
- - 'app/models/note.rb'
- 'app/models/operations/feature_flags/strategy.rb'
- 'app/models/project.rb'
- - 'app/models/wiki.rb'
- 'app/presenters/ci/build_metadata_presenter.rb'
- - 'app/presenters/packages/helm/index_presenter.rb'
- - 'app/serializers/cluster_serializer.rb'
- 'app/serializers/detailed_status_entity.rb'
- - 'app/services/award_emojis/base_service.rb'
- - 'app/services/ci/runners/reconcile_existing_runner_versions_service.rb'
- - 'app/services/google_cloud/create_service_accounts_service.rb'
- - 'app/services/members/create_service.rb'
- - 'app/services/notification_service.rb'
- - 'app/services/packages/composer/create_package_service.rb'
- - 'app/services/pages/delete_service.rb'
- - 'app/services/projects/after_rename_service.rb'
- - 'app/services/projects/create_service.rb'
- - 'app/services/projects/destroy_service.rb'
- - 'app/services/projects/transfer_service.rb'
- - 'app/services/projects/update_pages_service.rb'
- - 'app/services/projects/update_service.rb'
- - 'app/services/resource_events/change_milestone_service.rb'
+ - 'app/services/audit_events/build_service.rb'
- 'app/services/spam/ham_service.rb'
- - 'app/services/timelogs/base_service.rb'
- - 'app/validators/addressable_url_validator.rb'
- - 'app/workers/concerns/cluster_cleanup_methods.rb'
+ - 'app/services/work_items/widgets/milestone_service/base_service.rb'
+ - 'app/validators/bytesize_validator.rb'
- 'ee/app/components/namespaces/free_user_cap/enforcement_alert_component.rb'
- - 'ee/app/components/namespaces/free_user_cap/notification_alert_component.rb'
- - 'ee/app/controllers/groups/analytics/tasks_by_type_controller.rb'
- 'ee/app/graphql/mutations/boards/epic_lists/destroy.rb'
- 'ee/app/graphql/mutations/boards/epics/create.rb'
- 'ee/app/graphql/mutations/iterations/cadences/update.rb'
- 'ee/app/graphql/mutations/iterations/create.rb'
- 'ee/app/graphql/mutations/iterations/update.rb'
- - 'ee/app/graphql/mutations/projects/set_compliance_framework.rb'
- - 'ee/app/graphql/mutations/security_policy/commit_scan_execution_policy.rb'
- - 'ee/app/helpers/ee/application_settings_helper.rb'
- - 'ee/app/helpers/ee/ci/jobs_helper.rb'
- 'ee/app/helpers/ee/geo_helper.rb'
- 'ee/app/helpers/ee/groups/group_members_helper.rb'
- - 'ee/app/helpers/ee/namespaces_helper.rb'
- - 'ee/app/helpers/ee/projects_helper.rb'
- - 'ee/app/helpers/ee/sidebars_helper.rb'
- - 'ee/app/helpers/ee/tree_helper.rb'
+ - 'ee/app/helpers/ee/trial_helper.rb'
- 'ee/app/helpers/incident_management/escalation_policy_helper.rb'
- - 'ee/app/helpers/paid_feature_callout_helper.rb'
- - 'ee/app/helpers/projects/on_demand_scans_helper.rb'
- - 'ee/app/helpers/projects/security/dast_profiles_helper.rb'
- - 'ee/app/mailers/ee/emails/issues.rb'
- 'ee/app/models/ee/list.rb'
- - 'ee/app/serializers/ee/environment_serializer.rb'
- 'ee/app/services/app_sec/dast/profiles/update_service.rb'
- - 'ee/app/services/app_sec/dast/site_profiles/update_service.rb'
- - 'ee/app/services/ee/auth/container_registry_authentication_service.rb'
- - 'ee/app/services/ee/ci/register_job_service.rb'
- - 'ee/app/services/ee/issues/export_csv_service.rb'
- 'ee/app/services/elastic/cluster_reindexing_service.rb'
- 'ee/app/services/gitlab_subscriptions/plan_upgrade_service.rb'
- - 'ee/app/services/incident_management/issuable_resource_links/base_service.rb'
- - 'ee/app/services/jira/requests/issues/list_service.rb'
+ - 'ee/app/services/iterations/create_service.rb'
+ - 'ee/app/services/registrations/base_namespace_create_service.rb'
+ - 'ee/app/services/resource_events/change_iteration_service.rb'
- 'ee/app/services/security/token_revocation_service.rb'
- 'ee/app/services/timebox_report_service.rb'
- - 'ee/app/workers/elastic_delete_project_worker.rb'
- - 'ee/app/workers/groups/create_event_worker.rb'
- - 'ee/lib/api/epic_links.rb'
- - 'ee/lib/ee/api/geo.rb'
- 'ee/lib/ee/container_registry/client.rb'
- - 'ee/lib/ee/gitlab/application_rate_limiter.rb'
- 'ee/lib/ee/gitlab/ci/parsers.rb'
- 'ee/lib/ee/gitlab/usage_data.rb'
- 'ee/lib/elastic/latest/application_class_proxy.rb'
- 'ee/lib/elastic/latest/issue_class_proxy.rb'
- - 'ee/lib/gitlab/geo/project_log_helpers.rb'
+ - 'ee/lib/gitlab/analytics/type_of_work/tasks_by_type.rb'
+ - 'ee/lib/gitlab/ci/parsers/security/formatters/dependency_list.rb'
- 'ee/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate.rb'
- - 'ee/lib/gitlab/status_page/storage/s3_multipart_upload.rb'
- 'ee/spec/controllers/admin/application_settings_controller_spec.rb'
- 'ee/spec/controllers/ee/projects/jobs_controller_spec.rb'
- 'ee/spec/controllers/ee/projects/variables_controller_spec.rb'
- - 'ee/spec/controllers/groups/analytics/cycle_analytics/summary_controller_spec.rb'
- 'ee/spec/controllers/groups/epic_boards_controller_spec.rb'
- 'ee/spec/controllers/groups/issues_controller_spec.rb'
- - 'ee/spec/controllers/projects/feature_flag_issues_controller_spec.rb'
- 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb'
- - 'ee/spec/controllers/projects/licenses_controller_spec.rb'
+ - 'ee/spec/controllers/projects/repositories_controller_spec.rb'
- 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb'
- 'ee/spec/controllers/projects_controller_spec.rb'
- - 'ee/spec/controllers/security/projects_controller_spec.rb'
- - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb'
+ - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb'
+ - 'ee/spec/elastic/migrate/migration_shared_examples.rb'
- 'ee/spec/factories/dependencies.rb'
- 'ee/spec/factories/licenses.rb'
- 'ee/spec/finders/epics_finder_spec.rb'
- - 'ee/spec/frontend/fixtures/dast_profiles.rb'
- - 'ee/spec/frontend/fixtures/on_demand_dast_scans.rb'
+ - 'ee/spec/finders/namespaces/free_user_cap/users_finder_spec.rb'
+ - 'ee/spec/frontend/fixtures/oncall_schedule.rb'
- 'ee/spec/frontend/fixtures/search.rb'
- - 'ee/spec/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create_spec.rb'
+ - 'ee/spec/graphql/mutations/audit_events/streaming/event_type_filters/destroy_spec.rb'
+ - 'ee/spec/graphql/types/asset_type_spec.rb'
- 'ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb'
- - 'ee/spec/helpers/ee/access_tokens_helper_spec.rb'
- - 'ee/spec/helpers/ee/groups_helper_spec.rb'
- - 'ee/spec/helpers/ee/labels_helper_spec.rb'
- - 'ee/spec/helpers/ee/namespaces_helper_spec.rb'
- - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb'
- - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb'
- - 'ee/spec/helpers/ee/projects/security/sast_configuration_helper_spec.rb'
- - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb'
- - 'ee/spec/helpers/groups/sso_helper_spec.rb'
- - 'ee/spec/helpers/nav/new_dropdown_helper_spec.rb'
- - 'ee/spec/helpers/projects_helper_spec.rb'
- - 'ee/spec/helpers/search_helper_spec.rb'
- - 'ee/spec/helpers/security_helper_spec.rb'
- - 'ee/spec/helpers/trial_registrations/reassurances_helper_spec.rb'
+ - 'ee/spec/graphql/types/vulnerability_request_type_spec.rb'
+ - 'ee/spec/graphql/types/vulnerability_response_type_spec.rb'
+ - 'ee/spec/helpers/billing_plans_helper_spec.rb'
+ - 'ee/spec/helpers/groups/security_features_helper_spec.rb'
+ - 'ee/spec/helpers/projects/security/discover_helper_spec.rb'
+ - 'ee/spec/initializers/fog_google_https_private_urls_spec.rb'
+ - 'ee/spec/lib/audit/compliance_framework_changes_auditor_spec.rb'
+ - 'ee/spec/lib/audit/external_status_check_changes_auditor_spec.rb'
+ - 'ee/spec/lib/audit/project_changes_auditor_spec.rb'
+ - 'ee/spec/lib/audit/project_ci_cd_setting_changes_auditor_spec.rb'
+ - 'ee/spec/lib/audit/project_setting_changes_auditor_spec.rb'
- 'ee/spec/lib/container_registry/client_spec.rb'
- - 'ee/spec/lib/ee/backup/repositories_spec.rb'
- - 'ee/spec/lib/ee/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb'
+ - 'ee/spec/lib/ee/api/entities/experiment_spec.rb'
- 'ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb'
- - 'ee/spec/lib/ee/gitlab/ci/config/entry/bridge_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size_spec.rb'
- 'ee/spec/lib/ee/gitlab/ci/parsers/security/common_spec.rb'
- - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb'
- - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb'
- - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb'
- - 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb'
- - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary_spec.rb'
- - 'ee/spec/lib/gitlab/analytics/type_of_work/tasks_by_type_spec.rb'
- - 'ee/spec/lib/gitlab/auth/group_saml/membership_updater_spec.rb'
- - 'ee/spec/lib/gitlab/auth/saml/membership_updater_spec.rb'
- 'ee/spec/lib/gitlab/auth/smartcard/san_extension_spec.rb'
- - 'ee/spec/lib/gitlab/ci/config/entry/job_spec.rb'
- 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb'
- 'ee/spec/lib/gitlab/ci/reports/coverage_fuzzing/report_spec.rb'
- - 'ee/spec/lib/gitlab/ci/reports/security/finding_spec.rb'
- - 'ee/spec/lib/gitlab/ci/yaml_processor_spec.rb'
- - 'ee/spec/lib/gitlab/contribution_analytics/data_collector_spec.rb'
- - 'ee/spec/lib/gitlab/elastic/indexer_spec.rb'
- 'ee/spec/lib/gitlab/geo/log_cursor/lease_spec.rb'
- 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb'
- 'ee/spec/lib/gitlab/subscription_portal/clients/graphql_spec.rb'
- - 'ee/spec/lib/gitlab/web_ide/config/entry/schemas_spec.rb'
- - 'ee/spec/lib/system_check/app/search_check_spec.rb'
- 'ee/spec/mailers/credentials_inventory_mailer_spec.rb'
- 'ee/spec/mailers/emails/requirements_spec.rb'
- - 'ee/spec/models/analytics/cycle_analytics/project_stage_spec.rb'
- - 'ee/spec/models/concerns/elastic/application_versioned_search_spec.rb'
- - 'ee/spec/models/concerns/elastic/merge_request_spec.rb'
- - 'ee/spec/models/concerns/elastic/milestone_spec.rb'
- - 'ee/spec/models/concerns/elastic/snippet_spec.rb'
- - 'ee/spec/models/security/finding_spec.rb'
+ - 'ee/spec/models/concerns/elastic/issue_spec.rb'
+ - 'ee/spec/models/concerns/elastic/note_spec.rb'
- 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb'
- - 'ee/spec/requests/api/experiments_spec.rb'
- - 'ee/spec/requests/api/geo_spec.rb'
- - 'ee/spec/requests/api/graphql/app_sec/fuzzing/api/ci_configuration_type_spec.rb'
- - 'ee/spec/requests/api/graphql/app_sec/fuzzing/coverage/corpus_type_spec.rb'
- - 'ee/spec/requests/api/graphql/ci/minutes/usage_spec.rb'
- - 'ee/spec/requests/api/graphql/milestone_spec.rb'
- - 'ee/spec/requests/api/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create_spec.rb'
- - 'ee/spec/requests/api/graphql/mutations/gitlab_subscriptions/activate_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb'
- - 'ee/spec/requests/api/graphql/mutations/timelogs/create_spec.rb'
- - 'ee/spec/requests/api/internal/base_spec.rb'
- 'ee/spec/requests/api/internal/upcoming_reconciliations_spec.rb'
- - 'ee/spec/requests/api/members_spec.rb'
- 'ee/spec/requests/api/merge_requests_spec.rb'
+ - 'ee/spec/requests/ee/projects/deploy_tokens_controller_spec.rb'
- 'ee/spec/requests/groups/group_members_controller_spec.rb'
- - 'ee/spec/requests/projects/issue_feature_flags_controller_spec.rb'
- - 'ee/spec/serializers/issues/linked_issue_feature_flag_entity_spec.rb'
- - 'ee/spec/serializers/license_entity_spec.rb'
- - 'ee/spec/serializers/linked_feature_flag_issue_entity_spec.rb'
- - 'ee/spec/serializers/security/vulnerability_report_data_entity_spec.rb'
- - 'ee/spec/services/analytics/cycle_analytics/consistency_check_service_spec.rb'
- - 'ee/spec/services/analytics/cycle_analytics/data_loader_service_spec.rb'
- - 'ee/spec/services/app_sec/dast/profile_schedules/audit/update_service_spec.rb'
- - 'ee/spec/services/app_sec/dast/profiles/audit/update_service_spec.rb'
- - 'ee/spec/services/app_sec/dast/profiles/create_service_spec.rb'
- - 'ee/spec/services/app_sec/dast/profiles/destroy_service_spec.rb'
- - 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb'
- - 'ee/spec/services/app_sec/dast/scanner_profiles/create_service_spec.rb'
- - 'ee/spec/services/app_sec/dast/scanner_profiles/destroy_service_spec.rb'
- - 'ee/spec/services/app_sec/dast/site_profiles/audit/update_service_spec.rb'
- - 'ee/spec/services/app_sec/dast/site_profiles/create_service_spec.rb'
- - 'ee/spec/services/app_sec/dast/site_profiles/destroy_service_spec.rb'
- - 'ee/spec/services/app_sec/fuzzing/api/ci_configuration_create_service_spec.rb'
- - 'ee/spec/services/app_sec/fuzzing/coverage/corpuses/create_service_spec.rb'
- - 'ee/spec/services/approval_rules/create_service_spec.rb'
- - 'ee/spec/services/approval_rules/update_service_spec.rb'
- - 'ee/spec/services/audit_event_service_spec.rb'
- - 'ee/spec/services/ci/create_pipeline_service_spec.rb'
+ - 'ee/spec/services/approval_rules/project_rule_destroy_service_spec.rb'
+ - 'ee/spec/services/deploy_keys/create_service_spec.rb'
- 'ee/spec/services/ee/alert_management/http_integrations/create_service_spec.rb'
- 'ee/spec/services/ee/alert_management/http_integrations/update_service_spec.rb'
- - 'ee/spec/services/ee/merge_requests/create_pipeline_service_spec.rb'
- - 'ee/spec/services/ee/post_receive_service_spec.rb'
+ - 'ee/spec/services/ee/projects/deploy_tokens/create_service_spec.rb'
+ - 'ee/spec/services/ee/projects/deploy_tokens/destroy_service_spec.rb'
+ - 'ee/spec/services/ee/projects/unlink_fork_service_spec.rb'
- 'ee/spec/services/external_status_checks/create_service_spec.rb'
- - 'ee/spec/services/geo/node_status_request_service_spec.rb'
- - 'ee/spec/services/gitlab_subscriptions/check_future_renewal_service_spec.rb'
- - 'ee/spec/services/gitlab_subscriptions/create_trial_or_lead_service_spec.rb'
- - 'ee/spec/services/gitlab_subscriptions/plan_upgrade_service_spec.rb'
- - 'ee/spec/services/gitlab_subscriptions/preview_billable_user_change_service_spec.rb'
- - 'ee/spec/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service_spec.rb'
- - 'ee/spec/services/gitlab_subscriptions/reconciliations/check_seat_usage_alerts_eligibility_service_spec.rb'
+ - 'ee/spec/services/external_status_checks/destroy_service_spec.rb'
- 'ee/spec/services/groups/create_service_spec.rb'
- 'ee/spec/services/groups/destroy_service_spec.rb'
- 'ee/spec/services/iterations/create_service_spec.rb'
- 'ee/spec/services/projects/create_service_spec.rb'
+ - 'ee/spec/services/projects/disable_deploy_key_service_spec.rb'
+ - 'ee/spec/services/projects/enable_deploy_key_service_spec.rb'
- 'ee/spec/services/projects/group_links/create_service_spec.rb'
- 'ee/spec/services/projects/group_links/destroy_service_spec.rb'
- 'ee/spec/services/projects/transfer_service_spec.rb'
- - 'ee/spec/services/security/report_summary_service_spec.rb'
+ - 'ee/spec/services/security/security_orchestration_policies/create_pipeline_service_spec.rb'
- 'ee/spec/services/security/token_revocation_service_spec.rb'
- 'ee/spec/services/security/track_scan_service_spec.rb'
- 'ee/spec/services/timebox_report_service_spec.rb'
- - 'ee/spec/services/users/abuse/git_abuse/namespace_throttle_service_spec.rb'
- - 'ee/spec/support/helpers/ee/login_helpers.rb'
- - 'ee/spec/support/shared_contexts/fixtures/analytics_shared_context.rb'
- - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb'
- - 'ee/spec/support/shared_examples/controllers/namespace_storage_limit_alert_shared_examples.rb'
- - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb'
- - 'ee/spec/workers/analytics/cycle_analytics/consistency_worker_spec.rb'
- - 'ee/spec/workers/ci/runners/stale_group_runners_prune_cron_worker_spec.rb'
- - 'ee/spec/workers/gitlab_subscriptions/notify_seats_exceeded_worker_spec.rb'
- - 'lib/api/admin/instance_clusters.rb'
- - 'lib/api/group_clusters.rb'
- - 'lib/api/project_clusters.rb'
- - 'lib/atlassian/jira_connect/client.rb'
- - 'lib/banzai/filter/commit_trailers_filter.rb'
- 'lib/banzai/filter/playable_link_filter.rb'
- - 'lib/banzai/reference_parser/user_parser.rb'
- - 'lib/gitlab/analytics/cycle_analytics/aggregated/records_fetcher.rb'
- - 'lib/gitlab/analytics/cycle_analytics/records_fetcher.rb'
+ - 'lib/gitlab/application_rate_limiter.rb'
- 'lib/gitlab/asciidoc.rb'
- 'lib/gitlab/asciidoc/include_processor.rb'
- 'lib/gitlab/auth/otp/strategies/forti_token_cloud.rb'
- 'lib/gitlab/ci/config/entry/processable.rb'
- - 'lib/gitlab/database/query_analyzers/gitlab_schemas_metrics.rb'
- - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb'
- - 'lib/gitlab/github_import/importer/diff_note_importer.rb'
- - 'lib/gitlab/github_import/importer/pull_request_merged_by_importer.rb'
- - 'lib/gitlab/gitlab_import/client.rb'
- - 'lib/gitlab/graphql/query_analyzers/ast/logger_analyzer.rb'
+ - 'lib/gitlab/database/migrations/observers/query_details.rb'
+ - 'lib/gitlab/database/migrations/observers/transaction_duration.rb'
- 'lib/gitlab/hook_data/issue_builder.rb'
- 'lib/gitlab/hook_data/release_builder.rb'
- - 'lib/gitlab/kubernetes.rb'
- - 'lib/gitlab/kubernetes/namespace.rb'
- - 'lib/gitlab/kubernetes/rollout_instances.rb'
- - 'lib/gitlab/legacy_github_import/client.rb'
- - 'lib/gitlab/push_options.rb'
- 'lib/gitlab/quick_actions/issuable_actions.rb'
- - 'lib/gitlab/usage_data_counters/track_unique_events.rb'
- - 'lib/object_storage/direct_upload.rb'
- - 'lib/tasks/tanuki_emoji.rake'
- - 'qa/qa/ee/resource/board/board_list/project/assignee_board_list.rb'
- - 'qa/qa/ee/resource/board/board_list/project/milestone_board_list.rb'
- 'qa/qa/resource/snippet.rb'
+ - 'qa/qa/specs/features/api/1_manage/migration/gitlab_migration_release_spec.rb'
- 'qa/qa/specs/features/api/3_create/repository/commit_to_templated_project_spec.rb'
- 'qa/qa/specs/features/api/5_package/container_registry_spec.rb'
- - 'qa/qa/specs/features/browser_ui/3_create/repository/push_protected_branch_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_web_ide_from_diff_tab_spec.rb'
- 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_omnibus_spec.rb'
- 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_spec.rb'
@@ -299,279 +166,116 @@ Layout/FirstHashElementIndentation:
- 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb'
- 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/4_verify/new_discussion_not_dropping_merge_trains_mr_spec.rb'
- - 'spec/components/diffs/stats_component_spec.rb'
- - 'spec/components/pajamas/component_spec.rb'
- - 'spec/config/object_store_settings_spec.rb'
- - 'spec/config/smime_signature_settings_spec.rb'
- - 'spec/controllers/application_controller_spec.rb'
- - 'spec/controllers/concerns/import_url_params_spec.rb'
+ - 'qa/qa/specs/features/ee/browser_ui/5_package/dependency_proxy_sso_spec.rb'
+ - 'qa/spec/support/formatters/test_metrics_formatter_spec.rb'
- 'spec/controllers/concerns/issuable_collections_spec.rb'
- 'spec/controllers/groups/group_members_controller_spec.rb'
- - 'spec/controllers/groups/packages_controller_spec.rb'
- - 'spec/controllers/groups/registry/repositories_controller_spec.rb'
- - 'spec/controllers/import/available_namespaces_controller_spec.rb'
- 'spec/controllers/import/manifest_controller_spec.rb'
- 'spec/controllers/projects/boards_controller_spec.rb'
- 'spec/controllers/projects/branches_controller_spec.rb'
- 'spec/controllers/projects/commit_controller_spec.rb'
- 'spec/controllers/projects/commits_controller_spec.rb'
- 'spec/controllers/projects/design_management/designs/raw_images_controller_spec.rb'
- - 'spec/controllers/projects/design_management/designs/resized_image_controller_spec.rb'
- 'spec/controllers/projects/environments_controller_spec.rb'
- - 'spec/controllers/projects/feature_flags_controller_spec.rb'
- - 'spec/controllers/projects/grafana_api_controller_spec.rb'
- 'spec/controllers/projects/issues_controller_spec.rb'
- 'spec/controllers/projects/jobs_controller_spec.rb'
- 'spec/controllers/projects/merge_requests/creations_controller_spec.rb'
- - 'spec/controllers/projects/merge_requests/drafts_controller_spec.rb'
- - 'spec/controllers/projects/merge_requests_controller_spec.rb'
- 'spec/controllers/projects/milestones_controller_spec.rb'
- 'spec/controllers/projects/notes_controller_spec.rb'
- - 'spec/controllers/projects/packages/packages_controller_spec.rb'
- - 'spec/controllers/projects/pipeline_schedules_controller_spec.rb'
- 'spec/controllers/projects/pipelines_controller_spec.rb'
- 'spec/controllers/projects/project_members_controller_spec.rb'
- 'spec/controllers/projects/registry/repositories_controller_spec.rb'
- 'spec/controllers/projects/registry/tags_controller_spec.rb'
+ - 'spec/controllers/projects/tags_controller_spec.rb'
- 'spec/controllers/projects/web_ide_terminals_controller_spec.rb'
- 'spec/controllers/projects_controller_spec.rb'
- 'spec/factories/ci/builds.rb'
- 'spec/factories/packages/debian/file_metadatum.rb'
- - 'spec/features/gitlab_experiments_spec.rb'
- 'spec/frontend/fixtures/autocomplete_sources.rb'
- - 'spec/frontend/fixtures/blob.rb'
- - 'spec/frontend/fixtures/jobs.rb'
- - 'spec/frontend/fixtures/runner.rb'
- - 'spec/graphql/mutations/release_asset_links/create_spec.rb'
- - 'spec/graphql/resolvers/concerns/caching_array_resolver_spec.rb'
- - 'spec/graphql/resolvers/crm/organizations_resolver_spec.rb'
- 'spec/graphql/types/ci/detailed_status_type_spec.rb'
- - 'spec/helpers/access_tokens_helper_spec.rb'
- - 'spec/helpers/admin/application_settings/settings_helper_spec.rb'
- - 'spec/helpers/admin/deploy_key_helper_spec.rb'
- - 'spec/helpers/analytics/cycle_analytics_helper_spec.rb'
- - 'spec/helpers/ci/builds_helper_spec.rb'
- - 'spec/helpers/ci/jobs_helper_spec.rb'
- - 'spec/helpers/ci/pipeline_editor_helper_spec.rb'
- - 'spec/helpers/deploy_tokens_helper_spec.rb'
- - 'spec/helpers/groups/settings_helper_spec.rb'
- - 'spec/helpers/groups_helper_spec.rb'
- - 'spec/helpers/issuables_helper_spec.rb'
- - 'spec/helpers/namespaces_helper_spec.rb'
- - 'spec/helpers/page_layout_helper_spec.rb'
- - 'spec/helpers/projects/cluster_agents_helper_spec.rb'
- - 'spec/helpers/projects/pipeline_helper_spec.rb'
- - 'spec/helpers/releases_helper_spec.rb'
+ - 'spec/helpers/groups/observability_helper_spec.rb'
+ - 'spec/helpers/learn_gitlab_helper_spec.rb'
+ - 'spec/helpers/projects/pages_helper_spec.rb'
- 'spec/helpers/routing/pseudonymization_helper_spec.rb'
- - 'spec/helpers/search_helper_spec.rb'
- - 'spec/helpers/sorting_helper_spec.rb'
- - 'spec/initializers/direct_upload_support_spec.rb'
- - 'spec/lib/api/entities/bulk_imports/export_status_spec.rb'
- - 'spec/lib/api/entities/design_management/design_spec.rb'
- - 'spec/lib/api/entities/merge_request_approvals_spec.rb'
+ - 'spec/initializers/rack_multipart_patch_spec.rb'
- 'spec/lib/api/entities/personal_access_token_spec.rb'
- - 'spec/lib/atlassian/jira_connect/client_spec.rb'
- - 'spec/lib/backup/database_spec.rb'
- - 'spec/lib/backup/repositories_spec.rb'
- - 'spec/lib/banzai/filter/audio_link_filter_spec.rb'
- - 'spec/lib/banzai/filter/repository_link_filter_spec.rb'
- - 'spec/lib/banzai/filter/video_link_filter_spec.rb'
- 'spec/lib/bulk_imports/common/pipelines/milestones_pipeline_spec.rb'
- - 'spec/lib/bulk_imports/groups/pipelines/project_entities_pipeline_spec.rb'
- - 'spec/lib/bulk_imports/groups/pipelines/subgroup_entities_pipeline_spec.rb'
- 'spec/lib/bulk_imports/groups/stage_spec.rb'
- - 'spec/lib/bulk_imports/groups/transformers/group_attributes_transformer_spec.rb'
- 'spec/lib/bulk_imports/projects/pipelines/container_expiration_policy_pipeline_spec.rb'
- 'spec/lib/bulk_imports/projects/pipelines/project_feature_pipeline_spec.rb'
- 'spec/lib/container_registry/client_spec.rb'
- - 'spec/lib/feature/definition_spec.rb'
- - 'spec/lib/gitlab/alert_management/payload/base_spec.rb'
- - 'spec/lib/gitlab/analytics/cycle_analytics/aggregated/records_fetcher_spec.rb'
- - 'spec/lib/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb'
- - 'spec/lib/gitlab/analytics/cycle_analytics/records_fetcher_spec.rb'
- - 'spec/lib/gitlab/api_authentication/builder_spec.rb'
+ - 'spec/lib/gitlab/application_rate_limiter_spec.rb'
- 'spec/lib/gitlab/asciidoc_spec.rb'
- - 'spec/lib/gitlab/auth/ldap/config_spec.rb'
- - 'spec/lib/gitlab/auth/o_auth/user_spec.rb'
- - 'spec/lib/gitlab/auth/request_authenticator_spec.rb'
- - 'spec/lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata_spec.rb'
- 'spec/lib/gitlab/background_migration/migrate_u2f_webauthn_spec.rb'
- 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb'
- 'spec/lib/gitlab/bitbucket_import/importer_spec.rb'
- - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb'
- - 'spec/lib/gitlab/changes_list_spec.rb'
- - 'spec/lib/gitlab/checks/changes_access_spec.rb'
- - 'spec/lib/gitlab/ci/build/cache_spec.rb'
- - 'spec/lib/gitlab/ci/build/step_spec.rb'
- - 'spec/lib/gitlab/ci/config/entry/bridge_spec.rb'
- - 'spec/lib/gitlab/ci/config/entry/product/variables_spec.rb'
- - 'spec/lib/gitlab/ci/config/yaml/tags/resolver_spec.rb'
- 'spec/lib/gitlab/ci/config_spec.rb'
- 'spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb'
+ - 'spec/lib/gitlab/ci/parsers/coverage/sax_document_spec.rb'
- 'spec/lib/gitlab/ci/parsers/security/common_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/chain/populate_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/seed/build/cache_spec.rb'
- - 'spec/lib/gitlab/ci/reports/coverage_report_spec.rb'
- - 'spec/lib/gitlab/ci/reports/security/identifier_spec.rb'
- - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb'
- - 'spec/lib/gitlab/ci/reports/terraform_reports_spec.rb'
- 'spec/lib/gitlab/ci/yaml_processor_spec.rb'
- 'spec/lib/gitlab/config_checker/puma_rugged_checker_spec.rb'
- 'spec/lib/gitlab/data_builder/build_spec.rb'
- 'spec/lib/gitlab/data_builder/issuable_spec.rb'
- 'spec/lib/gitlab/data_builder/pipeline_spec.rb'
- - 'spec/lib/gitlab/database/load_balancing/setup_spec.rb'
- 'spec/lib/gitlab/database/migration_helpers_spec.rb'
- - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb'
- - 'spec/lib/gitlab/database_spec.rb'
- - 'spec/lib/gitlab/error_tracking/error_repository/open_api_strategy_spec.rb'
- - 'spec/lib/gitlab/error_tracking_spec.rb'
- 'spec/lib/gitlab/git/conflict/file_spec.rb'
- - 'spec/lib/gitlab/git/hook_env_spec.rb'
- - 'spec/lib/gitlab/git/repository_spec.rb'
- - 'spec/lib/gitlab/gitaly_client/operation_service_spec.rb'
- - 'spec/lib/gitlab/gitaly_client_spec.rb'
- - 'spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb'
- - 'spec/lib/gitlab/github_import/logger_spec.rb'
- - 'spec/lib/gitlab/github_import/object_counter_spec.rb'
- - 'spec/lib/gitlab/gpg_spec.rb'
- - 'spec/lib/gitlab/graphql/query_analyzers/ast/logger_analyzer_spec.rb'
- - 'spec/lib/gitlab/graphql/tracers/logger_tracer_spec.rb'
- - 'spec/lib/gitlab/graphql/tracers/timer_tracer_spec.rb'
- - 'spec/lib/gitlab/http_spec.rb'
- - 'spec/lib/gitlab/i18n_spec.rb'
- - 'spec/lib/gitlab/import/logger_spec.rb'
+ - 'spec/lib/gitlab/git/gitmodules_parser_spec.rb'
- 'spec/lib/gitlab/import_export/attributes_finder_spec.rb'
- 'spec/lib/gitlab/import_export/members_mapper_spec.rb'
- 'spec/lib/gitlab/instrumentation_helper_spec.rb'
- - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb'
- - 'spec/lib/gitlab/kubernetes/rollout_instances_spec.rb'
- - 'spec/lib/gitlab/legacy_github_import/label_formatter_spec.rb'
- - 'spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb'
- 'spec/lib/gitlab/metrics/subscribers/action_cable_spec.rb'
- - 'spec/lib/gitlab/middleware/multipart/handler_spec.rb'
- - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/order_by_columns_spec.rb'
- 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb'
- - 'spec/lib/gitlab/prometheus_client_spec.rb'
- - 'spec/lib/gitlab/push_options_spec.rb'
- - 'spec/lib/gitlab/submodule_links_spec.rb'
- - 'spec/lib/gitlab/usage_data/topology_spec.rb'
- - 'spec/lib/gitlab/utils_spec.rb'
- - 'spec/lib/gitlab/web_ide/config/entry/global_spec.rb'
+ - 'spec/lib/gitlab/sidekiq_migrate_jobs_spec.rb'
+ - 'spec/lib/gitlab/workhorse_spec.rb'
- 'spec/lib/mattermost/team_spec.rb'
- - 'spec/lib/microsoft_teams/activity_spec.rb'
- - 'spec/lib/peek/views/memory_spec.rb'
+ - 'spec/lib/peek/views/redis_detailed_spec.rb'
- 'spec/mailers/emails/merge_requests_spec.rb'
- - 'spec/models/active_session_spec.rb'
- - 'spec/models/analytics/cycle_analytics/aggregation_spec.rb'
- - 'spec/models/ci/pipeline_spec.rb'
- - 'spec/models/ci_platform_metric_spec.rb'
- - 'spec/models/clusters/applications/prometheus_spec.rb'
- - 'spec/models/event_spec.rb'
- - 'spec/models/gpg_key_spec.rb'
- - 'spec/models/instance_configuration_spec.rb'
- - 'spec/models/integrations/base_chat_notification_spec.rb'
- - 'spec/models/integrations/chat_message/deployment_message_spec.rb'
- - 'spec/models/integrations/chat_message/issue_message_spec.rb'
+ - 'spec/models/ci/build_spec.rb'
- 'spec/models/integrations/chat_message/merge_message_spec.rb'
- - 'spec/models/integrations/chat_message/note_message_spec.rb'
- - 'spec/models/integrations/chat_message/pipeline_message_spec.rb'
- - 'spec/models/integrations/chat_message/push_message_spec.rb'
- - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb'
- - 'spec/models/integrations/prometheus_spec.rb'
- - 'spec/models/loose_foreign_keys/modification_tracker_spec.rb'
- - 'spec/models/merge_request_diff_commit_spec.rb'
- - 'spec/models/note_spec.rb'
- - 'spec/models/remote_mirror_spec.rb'
+ - 'spec/models/pages/lookup_path_spec.rb'
+ - 'spec/requests/api/ci/pipelines_spec.rb'
- 'spec/requests/api/ci/runner/runners_post_spec.rb'
- 'spec/requests/api/commit_statuses_spec.rb'
- - 'spec/requests/api/feature_flags_spec.rb'
- - 'spec/requests/api/feature_flags_user_lists_spec.rb'
- 'spec/requests/api/graphql/ci/config_spec.rb'
- - 'spec/requests/api/graphql/ci/group_variables_spec.rb'
- - 'spec/requests/api/graphql/ci/instance_variables_spec.rb'
- - 'spec/requests/api/graphql/ci/project_variables_spec.rb'
- - 'spec/requests/api/graphql/group/milestones_spec.rb'
- 'spec/requests/api/graphql/metrics/dashboard/annotations_spec.rb'
- - 'spec/requests/api/graphql/mutations/timelogs/create_spec.rb'
- - 'spec/requests/api/graphql/project/cluster_agents_spec.rb'
- - 'spec/requests/api/graphql/project/release_spec.rb'
- - 'spec/requests/api/graphql/project_query_spec.rb'
- - 'spec/requests/api/internal/base_spec.rb'
- - 'spec/requests/api/merge_requests_spec.rb'
- - 'spec/requests/api/project_import_spec.rb'
- - 'spec/requests/api/project_snapshots_spec.rb'
- - 'spec/requests/api/projects_spec.rb'
+ - 'spec/requests/api/graphql/project/fork_details_spec.rb'
+ - 'spec/requests/api/ml/mlflow_spec.rb'
- 'spec/requests/api/releases_spec.rb'
- - 'spec/requests/api/repositories_spec.rb'
- - 'spec/requests/api/settings_spec.rb'
- 'spec/requests/api/task_completion_status_spec.rb'
- - 'spec/requests/api/unleash_spec.rb'
- - 'spec/requests/git_http_spec.rb'
- 'spec/requests/groups/email_campaigns_controller_spec.rb'
- - 'spec/requests/jira_authorizations_spec.rb'
- - 'spec/requests/jira_connect/installations_controller_spec.rb'
- - 'spec/requests/lfs_http_spec.rb'
- - 'spec/serializers/blob_entity_spec.rb'
- - 'spec/serializers/integrations/harbor_serializers/artifact_entity_spec.rb'
- - 'spec/serializers/integrations/harbor_serializers/repository_entity_spec.rb'
- - 'spec/serializers/integrations/harbor_serializers/tag_entity_spec.rb'
- - 'spec/services/bulk_imports/create_pipeline_trackers_service_spec.rb'
- - 'spec/services/ci/create_pipeline_service/custom_yaml_tags_spec.rb'
- - 'spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb'
- - 'spec/services/ci/create_pipeline_service_spec.rb'
- - 'spec/services/ci/find_exposed_artifacts_service_spec.rb'
- - 'spec/services/ci/play_manual_stage_service_spec.rb'
- - 'spec/services/ci/runners/reconcile_existing_runner_versions_service_spec.rb'
- - 'spec/services/clusters/agents/create_service_spec.rb'
- - 'spec/services/clusters/aws/authorize_role_service_spec.rb'
+ - 'spec/requests/projects/merge_requests/creations_spec.rb'
+ - 'spec/requests/pwa_controller_spec.rb'
+ - 'spec/rubocop/cop/usage_data/distinct_count_by_large_foreign_key_spec.rb'
+ - 'spec/rubocop/cop/usage_data/histogram_with_large_table_spec.rb'
+ - 'spec/rubocop/cop/usage_data/instrumentation_superclass_spec.rb'
+ - 'spec/rubocop/cop/usage_data/large_table_spec.rb'
+ - 'spec/services/ci/pipeline_artifacts/coverage_report_service_spec.rb'
+ - 'spec/services/ci/register_job_service_spec.rb'
- 'spec/services/clusters/update_service_spec.rb'
- - 'spec/services/commits/tag_service_spec.rb'
- - 'spec/services/database/consistency_check_service_spec.rb'
- - 'spec/services/git/branch_push_service_spec.rb'
- - 'spec/services/google_cloud/create_cloudsql_instance_service_spec.rb'
- - 'spec/services/import/fogbugz_service_spec.rb'
+ - 'spec/services/google_cloud/get_cloudsql_instances_service_spec.rb'
- 'spec/services/import/github_service_spec.rb'
- - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_spec.rb'
- - 'spec/services/markdown_content_rewriter_service_spec.rb'
- - 'spec/services/merge_requests/build_service_spec.rb'
- - 'spec/services/merge_requests/create_service_spec.rb'
- - 'spec/services/merge_requests/get_urls_service_spec.rb'
- - 'spec/services/merge_requests/refresh_service_spec.rb'
- - 'spec/services/merge_requests/update_service_spec.rb'
- 'spec/services/metrics/dashboard/transient_embed_service_spec.rb'
- 'spec/services/notes/render_service_spec.rb'
- 'spec/services/packages/debian/parse_debian822_service_spec.rb'
- 'spec/services/projects/container_repository/delete_tags_service_spec.rb'
- 'spec/services/projects/create_from_template_service_spec.rb'
- - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb'
- - 'spec/services/projects/operations/update_service_spec.rb'
- - 'spec/services/projects/update_service_spec.rb'
+ - 'spec/services/quick_actions/interpret_service_spec.rb'
- 'spec/services/service_ping/submit_service_ping_service_spec.rb'
- - 'spec/services/snippets/count_service_spec.rb'
- 'spec/sidekiq_cluster/sidekiq_cluster_spec.rb'
- - 'spec/support/atlassian/jira_connect/schemata.rb'
+ - 'spec/spam/concerns/has_spam_action_response_fields_spec.rb'
- 'spec/support/helpers/kubernetes_helpers.rb'
- - 'spec/support/helpers/login_helpers.rb'
- - 'spec/support/helpers/prometheus_helpers.rb'
- - 'spec/support/helpers/stub_object_storage.rb'
- 'spec/support/helpers/wiki_helpers.rb'
- 'spec/support/migrations_helpers/namespaces_helper.rb'
- 'spec/support/migrations_helpers/vulnerabilities_findings_helper.rb'
- - 'spec/support/shared_contexts/fixtures/analytics_shared_context.rb'
- 'spec/support/shared_contexts/lib/container_registry/client_shared_context.rb'
- - 'spec/support/shared_examples/graphql/spam_protection_shared_examples.rb'
- 'spec/support/shared_examples/harbor/artifacts_controller_shared_examples.rb'
- 'spec/support/shared_examples/harbor/repositories_controller_shared_examples.rb'
- 'spec/support/shared_examples/harbor/tags_controller_shared_examples.rb'
- - 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb'
- 'spec/support/shared_examples/models/clusters/prometheus_client_shared.rb'
- - 'spec/support/shared_examples/models/cycle_analytics_stage_shared_examples.rb'
- - 'spec/support/shared_examples/requests/rack_attack_shared_examples.rb'
- - 'spec/support_specs/graphql/arguments_spec.rb'
- - 'spec/support_specs/graphql/field_selection_spec.rb'
- - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb'
+ - 'spec/support/shared_examples/requests/api/npm_packages_shared_examples.rb'
+ - 'spec/tasks/gitlab/backup_rake_spec.rb'
- 'spec/tooling/lib/tooling/kubernetes_client_spec.rb'
- - 'spec/views/projects/issues/_issue.html.haml_spec.rb'
- - 'spec/workers/ci/runners/reconcile_existing_runner_versions_cron_worker_spec.rb'
- - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb'
+ - 'spec/views/layouts/_head.html.haml_spec.rb'
diff --git a/.rubocop_todo/layout/hash_alignment.yml b/.rubocop_todo/layout/hash_alignment.yml
index 7aa46e3fd05..f58e3fe0d60 100644
--- a/.rubocop_todo/layout/hash_alignment.yml
+++ b/.rubocop_todo/layout/hash_alignment.yml
@@ -1,6 +1,6 @@
---
# Cop supports --autocorrect.
Layout/HashAlignment:
+ Details: grace period
Exclude:
- 'ee/spec/lib/ee/gitlab/usage_data_spec.rb'
- - 'spec/serializers/environment_serializer_spec.rb'
diff --git a/.rubocop_todo/layout/line_continuation_leading_space.yml b/.rubocop_todo/layout/line_continuation_leading_space.yml
new file mode 100644
index 00000000000..14ab2e15857
--- /dev/null
+++ b/.rubocop_todo/layout/line_continuation_leading_space.yml
@@ -0,0 +1,75 @@
+---
+Layout/LineContinuationLeadingSpace:
+ Details: grace period
+ Exclude:
+ - 'app/graphql/resolvers/issues/base_resolver.rb'
+ - 'app/graphql/resolvers/work_items/types_resolver.rb'
+ - 'app/graphql/types/query_type.rb'
+ - 'app/helpers/application_settings_helper.rb'
+ - 'app/helpers/preferences_helper.rb'
+ - 'app/models/environment.rb'
+ - 'app/services/projects/container_repository/destroy_service.rb'
+ - 'config/initializers_before_autoloader/003_gc_compact.rb'
+ - 'ee/app/graphql/ee/mutations/issues/create.rb'
+ - 'ee/app/graphql/ee/types/merge_request_type.rb'
+ - 'ee/app/graphql/mutations/requirements_management/export_requirements.rb'
+ - 'ee/app/models/ci/minutes/notification.rb'
+ - 'ee/app/models/ee/group_group_link.rb'
+ - 'ee/app/models/ee/project_group_link.rb'
+ - 'ee/app/models/protected_environment.rb'
+ - 'ee/app/services/system_notes/epics_service.rb'
+ - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb'
+ - 'ee/lib/ee/gitlab/git_access.rb'
+ - 'ee/lib/slack/block_kit/app_home_opened.rb'
+ - 'ee/lib/tasks/gitlab/geo.rake'
+ - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb'
+ - 'ee/spec/features/gitlab_subscriptions/seat_count_alert_spec.rb'
+ - 'ee/spec/features/groups/members/manage_groups_spec.rb'
+ - 'ee/spec/features/pending_group_memberships_spec.rb'
+ - 'ee/spec/features/projects/members/manage_groups_spec.rb'
+ - 'ee/spec/graphql/mutations/requirements_management/export_requirements_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb'
+ - 'ee/spec/lib/gitlab/git_access_spec.rb'
+ - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_ci_environments_approval_required_spec.rb'
+ - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_deployment_approvals_metric_spec.rb'
+ - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb'
+ - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environments_required_approvals_average_metric_spec.rb'
+ - 'lib/gitlab/background_migration/populate_operation_visibility_permissions_from_operations.rb'
+ - 'lib/gitlab/ci/parsers/security/validators/schema_validator.rb'
+ - 'lib/gitlab/database/load_balancing/sidekiq_server_middleware.rb'
+ - 'lib/gitlab/database/partitioning_migration_helpers/index_helpers.rb'
+ - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb'
+ - 'lib/gitlab/github_import/importer/events/changed_reviewer.rb'
+ - 'lib/gitlab/import_export/project/import_task.rb'
+ - 'lib/gitlab/reference_counter.rb'
+ - 'lib/gitlab/tracking/standard_context.rb'
+ - 'qa/qa/specs/features/api/4_verify/api_variable_inheritance_with_forward_pipeline_variables_spec.rb'
+ - 'rubocop/cop/graphql/descriptions.rb'
+ - 'rubocop/cop/migration/add_columns_to_wide_tables.rb'
+ - 'rubocop/cop/migration/background_migrations.rb'
+ - 'rubocop/cop/migration/update_column_in_batches.rb'
+ - 'scripts/lib/glfm/parse_examples.rb'
+ - 'scripts/qa/testcases-check'
+ - 'spec/features/groups/show_spec.rb'
+ - 'spec/features/issues/create_issue_for_single_discussion_in_merge_request_spec.rb'
+ - 'spec/lib/gitlab/ci/ansi2html_spec.rb'
+ - 'spec/lib/gitlab/ci/parsers/sbom/validators/cyclonedx_schema_validator_spec.rb'
+ - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
+ - 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb'
+ - 'spec/lib/gitlab/reference_counter_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/count_bulk_imports_entities_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_direct_installations_count_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_proxy_installations_count_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_cta_clicked_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_sent_metric_spec.rb'
+ - 'spec/lib/system_check/incoming_email/imap_authentication_check_spec.rb'
+ - 'spec/models/integrations/chat_message/pipeline_message_spec.rb'
+ - 'spec/services/feature_flags/update_service_spec.rb'
+ - 'spec/services/issues/build_service_spec.rb'
+ - 'spec/support/matchers/have_gitlab_http_status.rb'
+ - 'spec/support/shared_examples/features/sidebar_shared_examples.rb'
+ - 'spec/support/shared_examples/lib/email/email_shared_examples.rb'
diff --git a/.rubocop_todo/layout/line_continuation_spacing.yml b/.rubocop_todo/layout/line_continuation_spacing.yml
new file mode 100644
index 00000000000..248922d7397
--- /dev/null
+++ b/.rubocop_todo/layout/line_continuation_spacing.yml
@@ -0,0 +1,224 @@
+---
+# Cop supports --autocorrect.
+Layout/LineContinuationSpacing:
+ Details: grace period
+ Exclude:
+ - 'app/controllers/concerns/controller_with_cross_project_access_check.rb'
+ - 'app/controllers/concerns/verifies_with_email.rb'
+ - 'app/controllers/projects/google_cloud/databases_controller.rb'
+ - 'app/graphql/gitlab_schema.rb'
+ - 'app/graphql/mutations/boards/issues/issue_move_list.rb'
+ - 'app/graphql/types/environment_type.rb'
+ - 'app/helpers/application_settings_helper.rb'
+ - 'app/helpers/projects_helper.rb'
+ - 'app/helpers/tags_helper.rb'
+ - 'app/helpers/tree_helper.rb'
+ - 'app/models/concerns/spammable.rb'
+ - 'app/models/environment.rb'
+ - 'app/models/integrations/base_third_party_wiki.rb'
+ - 'app/models/integrations/teamcity.rb'
+ - 'app/models/members/member_role.rb'
+ - 'app/models/work_items/parent_link.rb'
+ - 'app/services/feature_flags/update_service.rb'
+ - 'app/services/issues/build_service.rb'
+ - 'app/services/merge_requests/merge_service.rb'
+ - 'app/services/uploads/destroy_service.rb'
+ - 'app/services/users/email_verification/validate_token_service.rb'
+ - 'config/initializers_before_autoloader/003_gc_compact.rb'
+ - 'ee/app/components/namespaces/storage/pre_enforcement_alert_component.rb'
+ - 'ee/app/components/namespaces/storage/user_pre_enforcement_alert_component.rb'
+ - 'ee/app/controllers/ee/ldap/omniauth_callbacks_controller.rb'
+ - 'ee/app/controllers/users/identity_verification_controller.rb'
+ - 'ee/app/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create.rb'
+ - 'ee/app/graphql/mutations/requirements_management/export_requirements.rb'
+ - 'ee/app/graphql/mutations/security_policy/assign_security_policy_project.rb'
+ - 'ee/app/graphql/resolvers/security_orchestration/scan_execution_policy_resolver.rb'
+ - 'ee/app/graphql/resolvers/vulnerabilities_resolver.rb'
+ - 'ee/app/graphql/resolvers/vulnerability_severities_count_resolver.rb'
+ - 'ee/app/graphql/types/geo/geo_node_type.rb'
+ - 'ee/app/graphql/types/requirements_management/requirement_type.rb'
+ - 'ee/app/helpers/push_rules_helper.rb'
+ - 'ee/app/models/ee/epic.rb'
+ - 'ee/app/models/ee/group_group_link.rb'
+ - 'ee/app/models/ee/project_group_link.rb'
+ - 'ee/app/models/ee/vulnerability.rb'
+ - 'ee/app/models/incident_management/oncall_shift.rb'
+ - 'ee/app/services/audit_events/protected_branch_audit_event_service.rb'
+ - 'ee/app/services/boards/epic_lists/destroy_service.rb'
+ - 'ee/app/services/epics/epic_links/create_service.rb'
+ - 'ee/app/services/group_saml/saml_group_links/create_service.rb'
+ - 'ee/app/services/phone_verification/telesign_client/base_service.rb'
+ - 'ee/app/services/phone_verification/telesign_client/risk_score_service.rb'
+ - 'ee/app/services/phone_verification/users/send_verification_code_service.rb'
+ - 'ee/app/services/phone_verification/users/verify_code_service.rb'
+ - 'ee/lib/api/experiments.rb'
+ - 'ee/lib/api/ldap_group_links.rb'
+ - 'ee/lib/api/vulnerability_findings.rb'
+ - 'ee/lib/ee/gitlab/auth/ldap/access.rb'
+ - 'ee/lib/ee/gitlab/ci/pipeline/quota/activity.rb'
+ - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb'
+ - 'ee/lib/ee/gitlab/git_access.rb'
+ - 'ee/lib/tasks/gitlab/geo.rake'
+ - 'ee/spec/components/namespaces/free_user_cap/usage_quota_trial_alert_component_spec.rb'
+ - 'ee/spec/controllers/groups/group_members_controller_spec.rb'
+ - 'ee/spec/controllers/projects/security/configuration_controller_spec.rb'
+ - 'ee/spec/features/admin/admin_emails_spec.rb'
+ - 'ee/spec/features/admin/licenses/admin_adds_license_spec.rb'
+ - 'ee/spec/features/groups/group_overview_spec.rb'
+ - 'ee/spec/features/groups/members/manage_groups_spec.rb'
+ - 'ee/spec/features/groups_spec.rb'
+ - 'ee/spec/features/projects/members/manage_groups_spec.rb'
+ - 'ee/spec/features/protected_branches_spec.rb'
+ - 'ee/spec/features/protected_tags_spec.rb'
+ - 'ee/spec/features/registrations/email_confirmation_spec.rb'
+ - 'ee/spec/features/users/identity_verification_spec.rb'
+ - 'ee/spec/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create_spec.rb'
+ - 'ee/spec/graphql/mutations/audit_events/streaming/event_type_filters/destroy_spec.rb'
+ - 'ee/spec/graphql/mutations/audit_events/streaming/headers/destroy_spec.rb'
+ - 'ee/spec/graphql/mutations/requirements_management/export_requirements_spec.rb'
+ - 'ee/spec/helpers/ee/labels_helper_spec.rb'
+ - 'ee/spec/helpers/push_rules_helper_spec.rb'
+ - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb'
+ - 'ee/spec/lib/gitlab/git_access_spec.rb'
+ - 'ee/spec/mailers/ee/emails/identity_verification_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/epics/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/epics/update_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/issues/promote_to_epic_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/issues/set_epic_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/issues/set_weight_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/update_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/iterations/update_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/projects/initialize_product_analytics_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/projects/set_compliance_framework_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/quality_management/test_cases/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/requirements_management/create_requirement_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/security/finding/create_issue_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/users/abuse/namespace_bans/destroy_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/destroy_external_issue_link_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/finding_dismiss_spec.rb'
+ - 'ee/spec/requests/users/identity_verification_controller_spec.rb'
+ - 'ee/spec/services/boards/epic_lists/destroy_service_spec.rb'
+ - 'ee/spec/services/epic_issues/create_service_spec.rb'
+ - 'ee/spec/services/epics/epic_links/create_service_spec.rb'
+ - 'ee/spec/services/phone_verification/telesign_client/risk_score_service_spec.rb'
+ - 'ee/spec/services/phone_verification/telesign_client/send_verification_code_service_spec.rb'
+ - 'ee/spec/services/phone_verification/users/send_verification_code_service_spec.rb'
+ - 'ee/spec/services/security/security_orchestration_policies/ci_configuration_service_spec.rb'
+ - 'ee/spec/services/security/security_orchestration_policies/legacy_ci_configuration_service_spec.rb'
+ - 'ee/spec/views/compliance_management/compliance_framework/_project_settings.html.haml_spec.rb'
+ - 'ee/spec/workers/ee/issuable_export_csv_worker_spec.rb'
+ - 'lib/api/dependency_proxy.rb'
+ - 'lib/api/error_tracking/client_keys.rb'
+ - 'lib/api/error_tracking/project_settings.rb'
+ - 'lib/api/go_proxy.rb'
+ - 'lib/api/groups.rb'
+ - 'lib/api/issue_links.rb'
+ - 'lib/api/metrics/dashboard/annotations.rb'
+ - 'lib/api/ml/mlflow.rb'
+ - 'lib/gitlab/auth/user_access_denied_reason.rb'
+ - 'lib/gitlab/background_migration/populate_operation_visibility_permissions_from_operations.rb'
+ - 'lib/gitlab/checks/tag_check.rb'
+ - 'lib/gitlab/ci/parsers/security/validators/schema_validator.rb'
+ - 'lib/gitlab/config_checker/puma_rugged_checker.rb'
+ - 'lib/gitlab/database/background_migration/batched_migration_runner.rb'
+ - 'lib/gitlab/database/load_balancing/sidekiq_server_middleware.rb'
+ - 'lib/gitlab/database/migration_helpers.rb'
+ - 'lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers.rb'
+ - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base.rb'
+ - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces.rb'
+ - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_projects.rb'
+ - 'lib/gitlab/database/shared_model.rb'
+ - 'lib/gitlab/i18n/po_linter.rb'
+ - 'qa/qa/specs/features/ee/api/9_data_stores/elasticsearch/nightly_elasticsearch_test_spec.rb'
+ - 'qa/qa/support/matchers/eventually_matcher.rb'
+ - 'qa/qa/support/page_error_checker.rb'
+ - 'qa/qa/tools/test_resources_handler.rb'
+ - 'qa/spec/resource/user_spec.rb'
+ - 'qa/spec/support/page_error_checker_spec.rb'
+ - 'rubocop/cop/graphql/authorize_types.rb'
+ - 'rubocop/cop/graphql/descriptions.rb'
+ - 'rubocop/cop/graphql/graphql_name_position.rb'
+ - 'rubocop/cop/migration/background_migrations.rb'
+ - 'rubocop/cop/performance/ar_exists_and_present_blank.rb'
+ - 'rubocop/cop/redis_queue_usage.rb'
+ - 'scripts/create-pipeline-failure-incident.rb'
+ - 'scripts/generate-failed-pipeline-slack-message.rb'
+ - 'scripts/qa/testcases-check'
+ - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb'
+ - 'spec/features/issues/create_issue_for_single_discussion_in_merge_request_spec.rb'
+ - 'spec/features/projects/files/user_browses_files_spec.rb'
+ - 'spec/features/projects/files/user_creates_directory_spec.rb'
+ - 'spec/features/projects/files/user_creates_files_spec.rb'
+ - 'spec/features/projects/files/user_deletes_files_spec.rb'
+ - 'spec/features/projects/files/user_edits_files_spec.rb'
+ - 'spec/features/projects/files/user_replaces_files_spec.rb'
+ - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb'
+ - 'spec/features/u2f_spec.rb'
+ - 'spec/features/users/email_verification_on_login_spec.rb'
+ - 'spec/features/users/login_spec.rb'
+ - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb'
+ - 'spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb'
+ - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
+ - 'spec/lib/gitlab/ci/trace/stream_spec.rb'
+ - 'spec/lib/gitlab/closing_issue_extractor_spec.rb'
+ - 'spec/lib/gitlab/config_checker/puma_rugged_checker_spec.rb'
+ - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb'
+ - 'spec/lib/gitlab/git_access_spec.rb'
+ - 'spec/lib/gitlab/github_import/markdown_text_spec.rb'
+ - 'spec/lib/gitlab/github_import/representation/issue_event_spec.rb'
+ - 'spec/lib/gitlab/metrics/dashboard/stages/metric_endpoint_inserter_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/count_bulk_imports_entities_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_direct_installations_count_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_proxy_installations_count_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_cta_clicked_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_sent_metric_spec.rb'
+ - 'spec/lib/gitlab/utils/gzip_spec.rb'
+ - 'spec/lib/system_check/incoming_email/imap_authentication_check_spec.rb'
+ - 'spec/mailers/emails/identity_verification_spec.rb'
+ - 'spec/models/diff_note_spec.rb'
+ - 'spec/models/integrations/base_third_party_wiki_spec.rb'
+ - 'spec/models/integrations/chat_message/merge_message_spec.rb'
+ - 'spec/models/integrations/chat_message/push_message_spec.rb'
+ - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb'
+ - 'spec/models/member_spec.rb'
+ - 'spec/models/members/member_role_spec.rb'
+ - 'spec/models/operations/feature_flags_client_spec.rb'
+ - 'spec/models/project_spec.rb'
+ - 'spec/requests/api/graphql/mutations/clusters/agent_tokens/agent_tokens/create_spec.rb'
+ - 'spec/requests/api/graphql/mutations/clusters/agents/delete_spec.rb'
+ - 'spec/requests/api/graphql/mutations/uploads/delete_spec.rb'
+ - 'spec/requests/api/group_labels_spec.rb'
+ - 'spec/requests/api/groups_spec.rb'
+ - 'spec/requests/api/labels_spec.rb'
+ - 'spec/requests/api/projects_spec.rb'
+ - 'spec/requests/api/users_spec.rb'
+ - 'spec/requests/verifies_with_email_spec.rb'
+ - 'spec/services/feature_flags/update_service_spec.rb'
+ - 'spec/services/issues/build_service_spec.rb'
+ - 'spec/services/merge_requests/merge_service_spec.rb'
+ - 'spec/services/snippets/create_service_spec.rb'
+ - 'spec/services/uploads/destroy_service_spec.rb'
+ - 'spec/services/users/email_verification/validate_token_service_spec.rb'
+ - 'spec/services/users/migrate_records_to_ghost_user_service_spec.rb'
+ - 'spec/support/helpers/redis_without_keys.rb'
+ - 'spec/support/shared_examples/features/project_upload_files_shared_examples.rb'
+ - 'spec/support/shared_examples/harbor/artifacts_controller_shared_examples.rb'
+ - 'spec/support/shared_examples/harbor/tags_controller_shared_examples.rb'
+ - 'spec/support/shared_examples/models/diff_note_after_commit_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/diff_discussions_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/discussions_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/graphql/mutations/subscription_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/resolvable_discussions_shared_examples.rb'
+ - 'spec/uploaders/file_mover_spec.rb'
+ - 'spec/views/devise/shared/_signup_box.html.haml_spec.rb'
+ - 'spec/views/projects/issues/show.html.haml_spec.rb'
+ - 'spec/views/projects/pages/show.html.haml_spec.rb'
diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml
new file mode 100644
index 00000000000..b774d92d4ee
--- /dev/null
+++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml
@@ -0,0 +1,358 @@
+---
+# Cop supports --autocorrect.
+Layout/LineEndStringConcatenationIndentation:
+ Details: grace period
+ Exclude:
+ - 'app/controllers/admin/application_settings_controller.rb'
+ - 'app/controllers/concerns/verifies_with_email.rb'
+ - 'app/finders/snippets_finder.rb'
+ - 'app/graphql/mutations/ci/project_ci_cd_settings_update.rb'
+ - 'app/graphql/mutations/ci/runner/bulk_delete.rb'
+ - 'app/graphql/mutations/environments/canary_ingress/update.rb'
+ - 'app/graphql/resolvers/ci/runner_projects_resolver.rb'
+ - 'app/graphql/resolvers/projects_resolver.rb'
+ - 'app/graphql/types/ci/ci_cd_setting_type.rb'
+ - 'app/graphql/types/ci/config/include_type.rb'
+ - 'app/graphql/types/ci/runner_membership_filter_enum.rb'
+ - 'app/graphql/types/ci/runner_status_enum.rb'
+ - 'app/graphql/types/issue_type.rb'
+ - 'app/graphql/types/user_interface.rb'
+ - 'app/helpers/application_settings_helper.rb'
+ - 'app/helpers/members_helper.rb'
+ - 'app/helpers/preferences_helper.rb'
+ - 'app/helpers/projects/project_members_helper.rb'
+ - 'app/helpers/projects_helper.rb'
+ - 'app/mailers/emails/projects.rb'
+ - 'app/models/application_setting.rb'
+ - 'app/models/concerns/bulk_insert_safe.rb'
+ - 'app/models/concerns/spammable.rb'
+ - 'app/models/environment.rb'
+ - 'app/models/integrations/pivotaltracker.rb'
+ - 'app/models/members/member_role.rb'
+ - 'app/models/merge_request_diff_commit.rb'
+ - 'app/models/postgresql/replication_slot.rb'
+ - 'app/presenters/packages/npm/package_presenter.rb'
+ - 'app/services/commits/change_service.rb'
+ - 'app/services/concerns/ci/job_token_scope/edit_scope_validations.rb'
+ - 'app/services/feature_flags/update_service.rb'
+ - 'app/services/projects/after_rename_service.rb'
+ - 'app/services/projects/container_repository/destroy_service.rb'
+ - 'app/services/repositories/changelog_service.rb'
+ - 'app/services/users/email_verification/validate_token_service.rb'
+ - 'app/workers/run_pipeline_schedule_worker.rb'
+ - 'config/initializers/validate_database_config.rb'
+ - 'config/initializers/wikicloth_disable_lua_patch.rb'
+ - 'config/initializers/wikicloth_redos_patch.rb'
+ - 'config/initializers/wikicloth_ruby_3_patch.rb'
+ - 'config/initializers_before_autoloader/003_gc_compact.rb'
+ - 'danger/ci_templates/Dangerfile'
+ - 'danger/database/Dangerfile'
+ - 'db/post_migrate/20210606143426_add_index_for_container_registry_access_level.rb'
+ - 'db/post_migrate/20220425121410_add_temporary_index_for_backfill_integrations_enable_ssl_verification.rb'
+ - 'db/post_migrate/20220525131624_drop_temporary_index_for_backfill_integrations_enable_ssl_verification.rb'
+ - 'db/post_migrate/20220920081631_prepare_ci_builds_metadata_for_partitioning_primary_key.rb'
+ - 'ee/app/components/namespaces/free_user_cap/usage_quota_alert_component.rb'
+ - 'ee/app/controllers/admin/licenses_controller.rb'
+ - 'ee/app/controllers/concerns/insights_actions.rb'
+ - 'ee/app/controllers/ee/ldap/omniauth_callbacks_controller.rb'
+ - 'ee/app/controllers/users/identity_verification_controller.rb'
+ - 'ee/app/finders/geo/framework_registry_finder.rb'
+ - 'ee/app/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create.rb'
+ - 'ee/app/graphql/mutations/dast_scanner_profiles/create.rb'
+ - 'ee/app/graphql/mutations/issues/set_epic.rb'
+ - 'ee/app/graphql/mutations/issues/set_escalation_policy.rb'
+ - 'ee/app/graphql/mutations/issues/set_weight.rb'
+ - 'ee/app/graphql/mutations/requirements_management/export_requirements.rb'
+ - 'ee/app/graphql/mutations/security_policy/assign_security_policy_project.rb'
+ - 'ee/app/graphql/resolvers/analytics/contribution_analytics/contributions_resolver.rb'
+ - 'ee/app/graphql/resolvers/security_orchestration/scan_execution_policy_resolver.rb'
+ - 'ee/app/graphql/types/pipeline_security_report_finding_type.rb'
+ - 'ee/app/helpers/push_rules_helper.rb'
+ - 'ee/app/models/app_sec/fuzzing/api/ci_configuration.rb'
+ - 'ee/app/models/ci/minutes/notification.rb'
+ - 'ee/app/models/ee/group_group_link.rb'
+ - 'ee/app/models/ee/namespace/storage/notification.rb'
+ - 'ee/app/models/ee/vulnerability.rb'
+ - 'ee/app/services/boards/epic_lists/destroy_service.rb'
+ - 'ee/app/services/ee/admin/set_feature_flag_service.rb'
+ - 'ee/app/services/ee/auth/container_registry_authentication_service.rb'
+ - 'ee/app/services/ee/issues/move_service.rb'
+ - 'ee/app/services/ee/resource_access_tokens/revoke_service.rb'
+ - 'ee/app/services/merge_trains/create_pipeline_service.rb'
+ - 'ee/app/services/system_notes/epics_service.rb'
+ - 'ee/app/workers/concerns/elastic/migration_obsolete.rb'
+ - 'ee/elastic/migrate/20220613120500_migrate_commits_to_separate_index.rb'
+ - 'ee/lib/api/experiments.rb'
+ - 'ee/lib/api/ldap_group_links.rb'
+ - 'ee/lib/ee/gitlab/auth/ldap/access.rb'
+ - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb'
+ - 'ee/lib/ee/gitlab/git_access.rb'
+ - 'ee/lib/ee/gitlab/namespace_storage_size_error_message.rb'
+ - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb'
+ - 'ee/lib/slack/block_kit/app_home_opened.rb'
+ - 'ee/lib/tasks/gitlab/geo.rake'
+ - 'ee/spec/components/namespaces/free_user_cap/enforcement_alert_component_spec.rb'
+ - 'ee/spec/components/namespaces/free_user_cap/enforcement_at_limit_alert_component_spec.rb'
+ - 'ee/spec/components/namespaces/free_user_cap/non_owner_alert_component_spec.rb'
+ - 'ee/spec/components/namespaces/free_user_cap/notification_alert_component_spec.rb'
+ - 'ee/spec/components/namespaces/free_user_cap/usage_quota_alert_component_spec.rb'
+ - 'ee/spec/components/namespaces/free_user_cap/usage_quota_trial_alert_component_spec.rb'
+ - 'ee/spec/controllers/admin/licenses_controller_spec.rb'
+ - 'ee/spec/controllers/groups/group_members_controller_spec.rb'
+ - 'ee/spec/controllers/projects/security/configuration_controller_spec.rb'
+ - 'ee/spec/features/admin/admin_emails_spec.rb'
+ - 'ee/spec/features/admin/licenses/admin_adds_license_spec.rb'
+ - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb'
+ - 'ee/spec/features/groups/group_overview_spec.rb'
+ - 'ee/spec/features/groups/members/manage_groups_spec.rb'
+ - 'ee/spec/features/groups_spec.rb'
+ - 'ee/spec/features/pending_group_memberships_spec.rb'
+ - 'ee/spec/features/projects/members/manage_groups_spec.rb'
+ - 'ee/spec/features/registrations/email_confirmation_spec.rb'
+ - 'ee/spec/features/users/identity_verification_spec.rb'
+ - 'ee/spec/graphql/mutations/audit_events/streaming/event_type_filters/destroy_spec.rb'
+ - 'ee/spec/graphql/mutations/audit_events/streaming/headers/destroy_spec.rb'
+ - 'ee/spec/graphql/mutations/boards/lists/update_limit_metrics_spec.rb'
+ - 'ee/spec/helpers/ee/labels_helper_spec.rb'
+ - 'ee/spec/helpers/push_rules_helper_spec.rb'
+ - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/namespace_storage_size_error_message_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/api_security_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/api_security_latest_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/container_scanning_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/container_scanning_latest_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_latest_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/dast_api_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/dast_api_latest_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/dast_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/dast_latest_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/dependency_scanning_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/dependency_scanning_latest_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/license_scanning_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/license_scanning_latest_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/sast_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/sast_iac_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/sast_latest_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/secret_detection_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/secret_detection_latest_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/manual_quarterly_co_term_banner_spec.rb'
+ - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_deployment_approvals_metric_spec.rb'
+ - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb'
+ - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environments_required_approvals_average_metric_spec.rb'
+ - 'ee/spec/mailers/ee/emails/identity_verification_spec.rb'
+ - 'ee/spec/requests/api/analytics/product_analytics_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/boards/lists/update_limit_metrics_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/boards/update_epic_user_preferences_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/update_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/security/finding/create_issue_spec.rb'
+ - 'ee/spec/requests/users/identity_verification_controller_spec.rb'
+ - 'ee/spec/services/boards/epic_lists/destroy_service_spec.rb'
+ - 'ee/spec/services/ee/auth/container_registry_authentication_service_spec.rb'
+ - 'ee/spec/services/ee/resource_events/merge_into_notes_service_spec.rb'
+ - 'ee/spec/services/epics/epic_links/create_service_spec.rb'
+ - 'ee/spec/services/geo/container_repository_sync_spec.rb'
+ - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb'
+ - 'ee/spec/services/users/abuse/git_abuse/application_throttle_service_spec.rb'
+ - 'ee/spec/support/shared_examples/finders/geo/framework_registry_finder_shared_examples.rb'
+ - 'ee/spec/support/shared_examples/graphql/geo/geo_registries_resolver_shared_examples.rb'
+ - 'ee/spec/support/shared_examples/models/license_shared_examples.rb'
+ - 'ee/spec/views/compliance_management/compliance_framework/_project_settings.html.haml_spec.rb'
+ - 'ee/spec/views/groups/billings/index.html.haml_spec.rb'
+ - 'ee/spec/workers/ee/issuable_export_csv_worker_spec.rb'
+ - 'lib/api/ci/runners.rb'
+ - 'lib/api/dependency_proxy.rb'
+ - 'lib/api/error_tracking/client_keys.rb'
+ - 'lib/api/error_tracking/project_settings.rb'
+ - 'lib/api/go_proxy.rb'
+ - 'lib/api/helpers/pagination_strategies.rb'
+ - 'lib/api/issue_links.rb'
+ - 'lib/api/metrics/dashboard/annotations.rb'
+ - 'lib/backup/manager.rb'
+ - 'lib/banzai/filter/spaced_link_filter.rb'
+ - 'lib/feature/definition.rb'
+ - 'lib/gitlab/audit/type/definition.rb'
+ - 'lib/gitlab/auth.rb'
+ - 'lib/gitlab/background_migration/populate_operation_visibility_permissions_from_operations.rb'
+ - 'lib/gitlab/changelog/config.rb'
+ - 'lib/gitlab/checks/tag_check.rb'
+ - 'lib/gitlab/ci/parsers/security/validators/schema_validator.rb'
+ - 'lib/gitlab/ci/pipeline/chain/populate.rb'
+ - 'lib/gitlab/ci/pipeline/seed/build.rb'
+ - 'lib/gitlab/config_checker/puma_rugged_checker.rb'
+ - 'lib/gitlab/database/load_balancing/sidekiq_server_middleware.rb'
+ - 'lib/gitlab/database/migration_helpers.rb'
+ - 'lib/gitlab/database/migration_helpers/restrict_gitlab_schema.rb'
+ - 'lib/gitlab/database/migrations/background_migration_helpers.rb'
+ - 'lib/gitlab/database/migrations/batched_background_migration_helpers.rb'
+ - 'lib/gitlab/database/partitioning/partition_manager.rb'
+ - 'lib/gitlab/database/partitioning/sliding_list_strategy.rb'
+ - 'lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table.rb'
+ - 'lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers.rb'
+ - 'lib/gitlab/database/partitioning_migration_helpers/index_helpers.rb'
+ - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb'
+ - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb'
+ - 'lib/gitlab/database/schema_helpers.rb'
+ - 'lib/gitlab/database/shared_model.rb'
+ - 'lib/gitlab/github_import/importer/events/changed_reviewer.rb'
+ - 'lib/gitlab/graphql/authorize/authorize_resource.rb'
+ - 'lib/gitlab/i18n/po_linter.rb'
+ - 'lib/gitlab/import_export/project/import_task.rb'
+ - 'lib/gitlab/path_regex.rb'
+ - 'lib/gitlab/reference_counter.rb'
+ - 'lib/gitlab/regex.rb'
+ - 'lib/gitlab/seeders/ci/runner/runner_fleet_seeder.rb'
+ - 'lib/gitlab/slash_commands/presenters/run.rb'
+ - 'lib/gitlab/tracking/standard_context.rb'
+ - 'lib/tasks/gitlab/db/validate_config.rake'
+ - 'lib/tasks/gitlab/storage.rake'
+ - 'qa/qa/ee/page/project/settings/services/jira.rb'
+ - 'qa/qa/specs/features/api/4_verify/api_variable_inheritance_with_forward_pipeline_variables_spec.rb'
+ - 'qa/qa/support/matchers/eventually_matcher.rb'
+ - 'qa/qa/support/system_logs/kibana.rb'
+ - 'qa/qa/tools/revoke_user_personal_access_tokens.rb'
+ - 'qa/spec/support/page_error_checker_spec.rb'
+ - 'qa/spec/support/system_logs/kibana_spec.rb'
+ - 'rubocop/cop/active_record_association_reload.rb'
+ - 'rubocop/cop/api/grape_array_missing_coerce.rb'
+ - 'rubocop/cop/avoid_becomes.rb'
+ - 'rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb'
+ - 'rubocop/cop/database/establish_connection.rb'
+ - 'rubocop/cop/destroy_all.rb'
+ - 'rubocop/cop/gitlab/avoid_feature_get.rb'
+ - 'rubocop/cop/gitlab/change_timezone.rb'
+ - 'rubocop/cop/gitlab/keys_first_and_values_first.rb'
+ - 'rubocop/cop/gitlab/rails_logger.rb'
+ - 'rubocop/cop/gitlab/rspec/avoid_setup.rb'
+ - 'rubocop/cop/graphql/descriptions.rb'
+ - 'rubocop/cop/graphql/resolver_type.rb'
+ - 'rubocop/cop/group_public_or_visible_to_user.rb'
+ - 'rubocop/cop/ignored_columns.rb'
+ - 'rubocop/cop/inject_enterprise_edition_module.rb'
+ - 'rubocop/cop/migration/add_concurrent_index.rb'
+ - 'rubocop/cop/migration/add_limit_to_text_columns.rb'
+ - 'rubocop/cop/migration/create_table_with_foreign_keys.rb'
+ - 'rubocop/cop/migration/prevent_strings.rb'
+ - 'rubocop/cop/migration/remove_concurrent_index.rb'
+ - 'rubocop/cop/migration/update_column_in_batches.rb'
+ - 'rubocop/cop/migration/with_lock_retries_with_change.rb'
+ - 'rubocop/cop/performance/active_record_subtransaction_methods.rb'
+ - 'rubocop/cop/performance/active_record_subtransactions.rb'
+ - 'rubocop/cop/performance/ar_count_each.rb'
+ - 'rubocop/cop/performance/ar_exists_and_present_blank.rb'
+ - 'rubocop/cop/performance/readlines_each.rb'
+ - 'rubocop/cop/project_path_helper.rb'
+ - 'rubocop/cop/redis_queue_usage.rb'
+ - 'rubocop/cop/rspec/factory_bot/inline_association.rb'
+ - 'rubocop/cop/rspec/factory_bot/strategy_in_callback.rb'
+ - 'rubocop/cop/rspec/have_gitlab_http_status.rb'
+ - 'rubocop/cop/sidekiq_api_usage.rb'
+ - 'rubocop/cop/user_admin.rb'
+ - 'scripts/create-pipeline-failure-incident.rb'
+ - 'scripts/generate-failed-pipeline-slack-message.rb'
+ - 'scripts/lib/glfm/parse_examples.rb'
+ - 'scripts/lib/glfm/update_example_snapshots.rb'
+ - 'scripts/lib/glfm/update_specification.rb'
+ - 'scripts/lib/glfm/verify_all_generated_files_are_up_to_date.rb'
+ - 'scripts/packages/automated_cleanup.rb'
+ - 'spec/contracts/provider_specs/helpers/provider/contract_source_helper_spec.rb'
+ - 'spec/controllers/graphql_controller_spec.rb'
+ - 'spec/controllers/projects/deploy_keys_controller_spec.rb'
+ - 'spec/features/groups/show_spec.rb'
+ - 'spec/features/projects/files/user_browses_files_spec.rb'
+ - 'spec/features/projects/files/user_creates_directory_spec.rb'
+ - 'spec/features/projects/files/user_creates_files_spec.rb'
+ - 'spec/features/projects/files/user_deletes_files_spec.rb'
+ - 'spec/features/projects/files/user_replaces_files_spec.rb'
+ - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb'
+ - 'spec/features/projects/pipelines/pipeline_spec.rb'
+ - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb'
+ - 'spec/helpers/markup_helper_spec.rb'
+ - 'spec/lib/banzai/filter/inline_grafana_metrics_filter_spec.rb'
+ - 'spec/lib/banzai/filter/truncate_visible_filter_spec.rb'
+ - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb'
+ - 'spec/lib/gitlab/ci/ansi2html_spec.rb'
+ - 'spec/lib/gitlab/ci/parsers/sbom/validators/cyclonedx_schema_validator_spec.rb'
+ - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
+ - 'spec/lib/gitlab/ci/pipeline/chain/populate_spec.rb'
+ - 'spec/lib/gitlab/ci/status/bridge/factory_spec.rb'
+ - 'spec/lib/gitlab/ci/templates/Jobs/code_quality_gitlab_ci_yaml_spec.rb'
+ - 'spec/lib/gitlab/ci/templates/Jobs/sast_iac_gitlab_ci_yaml_spec.rb'
+ - 'spec/lib/gitlab/ci/templates/Jobs/sast_iac_latest_gitlab_ci_yaml_spec.rb'
+ - 'spec/lib/gitlab/ci/templates/Jobs/test_gitlab_ci_yaml_spec.rb'
+ - 'spec/lib/gitlab/ci/templates/npm_spec.rb'
+ - 'spec/lib/gitlab/ci/templates/themekit_gitlab_ci_yaml_spec.rb'
+ - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb'
+ - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb'
+ - 'spec/lib/gitlab/email/message/build_ios_app_guide_spec.rb'
+ - 'spec/lib/gitlab/email/message/in_product_marketing/helper_spec.rb'
+ - 'spec/lib/gitlab/github_import/markdown_text_spec.rb'
+ - 'spec/lib/gitlab/github_import/representation/issue_event_spec.rb'
+ - 'spec/lib/gitlab/insecure_key_fingerprint_spec.rb'
+ - 'spec/lib/gitlab/metrics/dashboard/stages/metric_endpoint_inserter_spec.rb'
+ - 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb'
+ - 'spec/lib/gitlab/redis/multi_store_spec.rb'
+ - 'spec/lib/gitlab/reference_counter_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/count_bulk_imports_entities_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_direct_installations_count_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_proxy_installations_count_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_cta_clicked_metric_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_sent_metric_spec.rb'
+ - 'spec/lib/gitlab/utils/gzip_spec.rb'
+ - 'spec/mailers/emails/identity_verification_spec.rb'
+ - 'spec/mailers/emails/projects_spec.rb'
+ - 'spec/models/active_session_spec.rb'
+ - 'spec/models/integrations/chat_message/note_message_spec.rb'
+ - 'spec/models/integrations/chat_message/pipeline_message_spec.rb'
+ - 'spec/models/integrations/chat_message/push_message_spec.rb'
+ - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb'
+ - 'spec/models/member_spec.rb'
+ - 'spec/models/members/member_role_spec.rb'
+ - 'spec/models/operations/feature_flags_client_spec.rb'
+ - 'spec/models/ssh_host_key_spec.rb'
+ - 'spec/presenters/ci/pipeline_presenter_spec.rb'
+ - 'spec/presenters/deploy_key_presenter_spec.rb'
+ - 'spec/presenters/key_presenter_spec.rb'
+ - 'spec/presenters/releases/link_presenter_spec.rb'
+ - 'spec/requests/api/graphql/mutations/ci/pipeline_schedule_delete_spec.rb'
+ - 'spec/requests/api/graphql/mutations/ci/pipeline_schedule_play_spec.rb'
+ - 'spec/requests/api/graphql/mutations/clusters/agents/delete_spec.rb'
+ - 'spec/requests/api/releases_spec.rb'
+ - 'spec/requests/api/users_spec.rb'
+ - 'spec/requests/self_monitoring_project_spec.rb'
+ - 'spec/rubocop/cop/api/grape_array_missing_coerce_spec.rb'
+ - 'spec/rubocop/cop/group_public_or_visible_to_user_spec.rb'
+ - 'spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb'
+ - 'spec/scripts/lib/glfm/update_example_snapshots_spec.rb'
+ - 'spec/serializers/pipeline_serializer_spec.rb'
+ - 'spec/services/alert_management/alerts/update_service_spec.rb'
+ - 'spec/services/ci/create_downstream_pipeline_service_spec.rb'
+ - 'spec/services/ci/create_pipeline_service/rules_spec.rb'
+ - 'spec/services/ci/create_pipeline_service_spec.rb'
+ - 'spec/services/ci/job_artifacts/delete_service_spec.rb'
+ - 'spec/services/preview_markdown_service_spec.rb'
+ - 'spec/services/prometheus/proxy_variable_substitution_service_spec.rb'
+ - 'spec/services/snippets/create_service_spec.rb'
+ - 'spec/services/users/email_verification/validate_token_service_spec.rb'
+ - 'spec/services/work_items/parent_links/create_service_spec.rb'
+ - 'spec/support/before_all_adapter.rb'
+ - 'spec/support/helpers/database/multiple_databases_helpers.rb'
+ - 'spec/support/helpers/redis_without_keys.rb'
+ - 'spec/support/matchers/have_gitlab_http_status.rb'
+ - 'spec/support/memory_instrumentation_helper.rb'
+ - 'spec/support/shared_examples/features/project_upload_files_shared_examples.rb'
+ - 'spec/support/shared_examples/lib/email/email_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/self_monitoring_shared_examples.rb'
+ - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb'
+ - 'spec/uploaders/file_mover_spec.rb'
+ - 'spec/views/devise/shared/_signup_box.html.haml_spec.rb'
+ - 'spec/views/projects/pages/show.html.haml_spec.rb'
+ - 'spec/workers/integrations/irker_worker_spec.rb'
diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml
index 07e7b374db2..b55a274d06b 100644
--- a/.rubocop_todo/layout/line_length.yml
+++ b/.rubocop_todo/layout/line_length.yml
@@ -17,7 +17,6 @@ Layout/LineLength:
- 'app/controllers/concerns/analytics/cycle_analytics/stage_actions.rb'
- 'app/controllers/concerns/clientside_preview_csp.rb'
- 'app/controllers/concerns/confirm_email_warning.rb'
- - 'app/controllers/concerns/cycle_analytics_params.rb'
- 'app/controllers/concerns/integrations/actions.rb'
- 'app/controllers/concerns/issuable_actions.rb'
- 'app/controllers/concerns/issuable_collections.rb'
@@ -43,7 +42,6 @@ Layout/LineLength:
- 'app/controllers/groups/settings/integrations_controller.rb'
- 'app/controllers/groups/settings/repository_controller.rb'
- 'app/controllers/groups_controller.rb'
- - 'app/controllers/import/available_namespaces_controller.rb'
- 'app/controllers/import/base_controller.rb'
- 'app/controllers/import/bitbucket_controller.rb'
- 'app/controllers/import/bitbucket_server_controller.rb'
@@ -314,7 +312,6 @@ Layout/LineLength:
- 'app/models/clusters/cluster.rb'
- 'app/models/commit_range.rb'
- 'app/models/commit_status.rb'
- - 'app/models/concerns/analytics/cycle_analytics/stage.rb'
- 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb'
- 'app/models/concerns/avatarable.rb'
- 'app/models/concerns/bulk_insert_safe.rb'
@@ -329,7 +326,6 @@ Layout/LineLength:
- 'app/models/concerns/enums/vulnerability.rb'
- 'app/models/concerns/fast_destroy_all.rb'
- 'app/models/concerns/group_descendant.rb'
- - 'app/models/concerns/has_user_type.rb'
- 'app/models/concerns/id_in_ordered.rb'
- 'app/models/concerns/ignorable_columns.rb'
- 'app/models/concerns/iid_routes.rb'
@@ -465,7 +461,6 @@ Layout/LineLength:
- 'app/models/wiki_page.rb'
- 'app/policies/base_policy.rb'
- 'app/policies/global_policy.rb'
- - 'app/policies/group_member_policy.rb'
- 'app/policies/group_policy.rb'
- 'app/policies/project_policy.rb'
- 'app/presenters/blob_presenter.rb'
@@ -520,12 +515,7 @@ Layout/LineLength:
- 'app/services/ci/runners/unregister_runner_service.rb'
- 'app/services/clusters/agent_tokens/create_service.rb'
- 'app/services/clusters/agents/delete_service.rb'
- - 'app/services/clusters/applications/check_progress_service.rb'
- - 'app/services/clusters/aws/finalize_creation_service.rb'
- - 'app/services/clusters/aws/verify_provision_status_service.rb'
- 'app/services/clusters/build_kubernetes_namespace_service.rb'
- - 'app/services/clusters/gcp/finalize_creation_service.rb'
- - 'app/services/clusters/gcp/verify_provision_status_service.rb'
- 'app/services/clusters/integrations/create_service.rb'
- 'app/services/clusters/integrations/prometheus_health_check_service.rb'
- 'app/services/clusters/kubernetes/create_or_update_service_account_service.rb'
@@ -717,7 +707,6 @@ Layout/LineLength:
- 'app/workers/merge_request_mergeability_check_worker.rb'
- 'app/workers/object_storage/migrate_uploads_worker.rb'
- 'app/workers/packages/maven/metadata/sync_worker.rb'
- - 'app/workers/personal_access_tokens/expired_notification_worker.rb'
- 'app/workers/pipeline_metrics_worker.rb'
- 'app/workers/repository_fork_worker.rb'
- 'app/workers/repository_import_worker.rb'
@@ -766,49 +755,6 @@ Layout/LineLength:
- 'danger/roulette/Dangerfile'
- 'danger/vue_shared_documentation/Dangerfile'
- 'danger/z_metadata/Dangerfile'
- - 'db/migrate/20210302103851_add_deployed_deployment_id_index_to_project_pages_metadata.rb'
- - 'db/migrate/20210302155904_remove_index_for_security_orchestration_policy.rb'
- - 'db/migrate/20210302160544_add_index_to_security_orchestration_policy.rb'
- - 'db/migrate/20210305031822_create_dast_site_profile_variables.rb'
- - 'db/migrate/20210305182855_create_ci_unit_test_failures.rb'
- - 'db/migrate/20210313045845_add_verification_indexes_to_snippet_repositories.rb'
- - 'db/migrate/20210316171009_create_packages_helm_file_metadata.rb'
- - 'db/migrate/20210317035357_create_dast_profiles_pipelines.rb'
- - 'db/migrate/20210317123054_add_throttle_package_registry_columns.rb'
- - 'db/migrate/20210323131543_add_external_approval_rule_foreign_key_to_status_check_responses.rb'
- - 'db/migrate/20210325152011_add_verification_indexes_to_ci_pipeline_artifacts.rb'
- - 'db/migrate/20210326190903_create_vulnerability_finding_evidences.rb'
- - 'db/migrate/20210409084242_create_index_on_notes_for_cherry_picked_merge_requests.rb'
- - 'db/migrate/20210412111213_create_security_orchestration_policy_rule_schedule.rb'
- - 'db/migrate/20210414133310_add_bulk_import_export_uploads_table.rb'
- - 'db/migrate/20210415142700_add_url_limit_to_pipeline_validation.rb'
- - 'db/migrate/20210415172516_create_vulnerability_finding_evidence_requests.rb'
- - 'db/migrate/20210416172516_create_vulnerability_finding_evidence_responses.rb'
- - 'db/migrate/20210420173030_add_verification_indexes_to_terraform_state_versions.rb'
- - 'db/migrate/20210420210642_recreate_index_for_project_deployments_with_environment_id_and_date_at.rb'
- - 'db/migrate/20210422142647_add_project_id_next_run_at_index_to_container_expiration_policies.rb'
- - 'db/migrate/20210422195929_create_elastic_reindexing_slices.rb'
- - 'db/migrate/20210423054022_create_dast_site_profiles_pipelines.rb'
- - 'db/migrate/20210423054537_add_dast_site_profile_id_fk_to_dast_site_profiles_pipelines.rb'
- - 'db/migrate/20210423054846_add_ci_pipeline_id_fk_to_dast_site_profiles_pipelines.rb'
- - 'db/migrate/20210423171304_re_order_fk_source_project_id_in_merge_requests.rb'
- - 'db/migrate/20210427062807_add_index_to_batched_migration_jobs_status.rb'
- - 'db/migrate/20210427094931_add_execution_order_index_to_batched_background_migration_jobs.rb'
- - 'db/migrate/20210429032320_add_escalation_rules.rb'
- - 'db/migrate/20210505170152_add_verification_indexes_to_merge_request_diff_details_table.rb'
- - 'db/migrate/20210506150833_create_vulnerability_finding_evidence_headers.rb'
- - 'db/migrate/20210511104929_add_epic_board_recent_visits_table.rb'
- - 'db/migrate/20210511165250_add_foreign_key_to_lfs_objects_projects.rb'
- - 'db/migrate/20210512120122_add_pending_builds_table.rb'
- - 'db/migrate/20210521073920_drop_devops_adoption_namespace_uniqueness.rb'
- - 'db/migrate/20210526181821_add_foreign_key_for_latest_pipeline_id_to_ci_pipelines.rb'
- - 'db/migrate/20210527194558_create_ci_job_token_project_scope_links.rb'
- - 'db/migrate/20210529164247_change_iterations_title_uniqueness_index.rb'
- - 'db/migrate/20210601123341_add_running_builds_table.rb'
- - 'db/migrate/20210601125410_add_runners_created_at_index.rb'
- - 'db/migrate/20210601132134_remove_partial_index_for_hashed_storage_migration.rb'
- - 'db/migrate/20210601133459_replace_runners_contacted_at_index.rb'
- - 'db/migrate/20210602122233_add_runners_description_index.rb'
- 'db/migrate/20210604032738_create_dast_site_profiles_builds.rb'
- 'db/migrate/20210604034354_add_dast_site_profile_id_fk_to_dast_site_profiles_builds.rb'
- 'db/migrate/20210604051330_create_dast_scanner_profiles_builds.rb'
@@ -912,16 +858,6 @@ Layout/LineLength:
- 'db/migrate/20220310101118_update_holder_name_limit.rb'
- 'db/migrate/20220314184209_add_group_fk_to_protected_environment_approval_rules.rb'
- 'db/migrate/20220314204009_add_approval_rule_fk_to_deployment_approvals.rb'
- - 'db/post_migrate/20210328214434_remove_temporary_index_from_vulnerabilities_table.rb'
- - 'db/post_migrate/20210401131948_move_container_registry_enabled_to_project_features2.rb'
- - 'db/post_migrate/20210402005225_add_source_and_level_index_on_notification_settings.rb'
- - 'db/post_migrate/20210407150240_confirm_support_bot_user.rb'
- - 'db/post_migrate/20210415155043_move_container_registry_enabled_to_project_features3.rb'
- - 'db/post_migrate/20210430121542_backfill_ci_build_trace_sections_for_bigint_conversion.rb'
- - 'db/post_migrate/20210505092746_create_partial_covering_index_for_pending_builds.rb'
- - 'db/post_migrate/20210513163904_cleanup_move_container_registry_enabled_to_project_feature.rb'
- - 'db/post_migrate/20210514063252_schedule_cleanup_orphaned_lfs_objects_projects.rb'
- - 'db/post_migrate/20210526160133_remove_segment_selections_table.rb'
- 'db/post_migrate/20210606143426_add_index_for_container_registry_access_level.rb'
- 'db/post_migrate/20210611080951_fix_missing_traversal_ids.rb'
- 'db/post_migrate/20210615234935_fix_batched_migrations_old_format_job_arguments.rb'
@@ -969,7 +905,6 @@ Layout/LineLength:
- 'db/post_migrate/20211112113300_remove_ci_pipeline_chat_data_fk_on_chat_names.rb'
- 'db/post_migrate/20211118194239_drop_invalid_remediations.rb'
- 'db/post_migrate/20211201101541_drop_clusters_applications_runners_ci_runners_fk.rb'
- - 'db/post_migrate/20211206162601_cleanup_after_add_primary_email_to_emails_if_user_confirmed.rb'
- 'db/post_migrate/20211207173510_remove_extra_finding_evidence_tables_foreign_keys.rb'
- 'db/post_migrate/20211207173511_remove_extra_finding_evidence_tables.rb'
- 'db/post_migrate/20211209103048_backfill_project_namespaces_for_group.rb'
@@ -1175,7 +1110,6 @@ Layout/LineLength:
- 'ee/app/helpers/billing_plans_helper.rb'
- 'ee/app/helpers/ee/application_helper.rb'
- 'ee/app/helpers/ee/button_helper.rb'
- - 'ee/app/helpers/ee/environments_helper.rb'
- 'ee/app/helpers/ee/feature_flags_helper.rb'
- 'ee/app/helpers/ee/geo_helper.rb'
- 'ee/app/helpers/ee/groups/analytics/cycle_analytics_helper.rb'
@@ -1213,7 +1147,6 @@ Layout/LineLength:
- 'ee/app/mailers/ee/emails/profile.rb'
- 'ee/app/mailers/ee/preview/notify_preview.rb'
- 'ee/app/mailers/emails/namespace_storage_usage_mailer.rb'
- - 'ee/app/models/analytics/cycle_analytics/group_stage.rb'
- 'ee/app/models/approval_merge_request_rule.rb'
- 'ee/app/models/approval_project_rule.rb'
- 'ee/app/models/approval_state.rb'
@@ -1429,7 +1362,6 @@ Layout/LineLength:
- 'ee/app/services/merge_trains/create_pipeline_service.rb'
- 'ee/app/services/merge_trains/refresh_merge_request_service.rb'
- 'ee/app/services/personal_access_tokens/rotation_verifier_service.rb'
- - 'ee/app/services/projects/licenses/create_policy_service.rb'
- 'ee/app/services/projects/mark_for_deletion_service.rb'
- 'ee/app/services/projects/update_mirror_service.rb'
- 'ee/app/services/resource_events/change_weight_service.rb'
@@ -1536,9 +1468,7 @@ Layout/LineLength:
- 'ee/lib/api/project_push_rule.rb'
- 'ee/lib/api/protected_environments.rb'
- 'ee/lib/api/resource_iteration_events.rb'
- - 'ee/lib/api/scim.rb'
- 'ee/lib/api/status_checks.rb'
- - 'ee/lib/api/vulnerability_findings.rb'
- 'ee/lib/api/vulnerability_issue_links.rb'
- 'ee/lib/ee/api/deployments.rb'
- 'ee/lib/ee/api/entities/application_setting.rb'
@@ -1590,7 +1520,6 @@ Layout/LineLength:
- 'ee/lib/ee/gitlab/ci/pipeline/chain/create_cross_database_associations.rb'
- 'ee/lib/ee/gitlab/ci/pipeline/chain/validate/after_config.rb'
- 'ee/lib/ee/gitlab/ci/pipeline/chain/validate/security_orchestration_policy.rb'
- - 'ee/lib/ee/gitlab/ci/reports/security/reports.rb'
- 'ee/lib/ee/gitlab/ci/status/build/manual.rb'
- 'ee/lib/ee/gitlab/git_access.rb'
- 'ee/lib/ee/gitlab/import_export/after_export_strategies/custom_template_export_import_strategy.rb'
@@ -1601,7 +1530,6 @@ Layout/LineLength:
- 'ee/lib/ee/gitlab/quick_actions/issue_actions.rb'
- 'ee/lib/ee/gitlab/rack_attack.rb'
- 'ee/lib/ee/gitlab/repository_size_checker.rb'
- - 'ee/lib/ee/gitlab/scim/deprovision_service.rb'
- 'ee/lib/ee/gitlab/usage_data.rb'
- 'ee/lib/ee/sidebars/groups/panel.rb'
- 'ee/lib/ee/sidebars/projects/menus/security_compliance_menu.rb'
@@ -1724,7 +1652,6 @@ Layout/LineLength:
- 'ee/spec/controllers/projects/subscriptions_controller_spec.rb'
- 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb'
- 'ee/spec/controllers/projects_controller_spec.rb'
- - 'ee/spec/controllers/registrations/welcome_controller_spec.rb'
- 'ee/spec/controllers/subscriptions/groups_controller_spec.rb'
- 'ee/spec/controllers/subscriptions_controller_spec.rb'
- 'ee/spec/elastic/migrate/migration_shared_examples.rb'
@@ -1859,7 +1786,6 @@ Layout/LineLength:
- 'ee/spec/finders/productivity_analytics_finder_spec.rb'
- 'ee/spec/finders/projects/integrations/jira/by_ids_finder_spec.rb'
- 'ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb'
- - 'ee/spec/finders/requirements_management/requirements_finder_spec.rb'
- 'ee/spec/finders/security/findings_finder_spec.rb'
- 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb'
- 'ee/spec/finders/security/training_providers/base_url_finder_spec.rb'
@@ -1979,7 +1905,6 @@ Layout/LineLength:
- 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb'
- 'ee/spec/helpers/ee/users/callouts_helper_spec.rb'
- 'ee/spec/helpers/ee/version_check_helper_spec.rb'
- - 'ee/spec/helpers/ee/welcome_helper_spec.rb'
- 'ee/spec/helpers/epics_helper_spec.rb'
- 'ee/spec/helpers/gitlab_subscriptions/upcoming_reconciliation_helper_spec.rb'
- 'ee/spec/helpers/groups/security_features_helper_spec.rb'
@@ -2040,14 +1965,12 @@ Layout/LineLength:
- 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb'
- 'ee/spec/lib/ee/gitlab/email/handler/service_desk_handler_spec.rb'
- 'ee/spec/lib/ee/gitlab/etag_caching/router/rails_spec.rb'
- - 'ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb'
- 'ee/spec/lib/ee/gitlab/gon_helper_spec.rb'
- 'ee/spec/lib/ee/gitlab/group_search_results_spec.rb'
- 'ee/spec/lib/ee/gitlab/import_export/project/tree_restorer_spec.rb'
- 'ee/spec/lib/ee/gitlab/import_export/wiki_repo_saver_spec.rb'
- 'ee/spec/lib/ee/gitlab/repo_path_spec.rb'
- 'ee/spec/lib/ee/gitlab/repository_size_checker_spec.rb'
- - 'ee/spec/lib/ee/gitlab/scim/deprovision_service_spec.rb'
- 'ee/spec/lib/ee/gitlab/security/scan_configuration_spec.rb'
- 'ee/spec/lib/ee/gitlab/url_builder_spec.rb'
- 'ee/spec/lib/ee/gitlab/usage/service_ping/payload_keys_processor_spec.rb'
@@ -2202,7 +2125,6 @@ Layout/LineLength:
- 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb'
- 'ee/spec/models/allowed_email_domain_spec.rb'
- 'ee/spec/models/analytics/cycle_analytics/group_level_spec.rb'
- - 'ee/spec/models/analytics/cycle_analytics/group_stage_spec.rb'
- 'ee/spec/models/analytics/devops_adoption/enabled_namespace_spec.rb'
- 'ee/spec/models/analytics/devops_adoption/snapshot_spec.rb'
- 'ee/spec/models/app_sec/fuzzing/coverage/corpus_spec.rb'
@@ -2266,7 +2188,6 @@ Layout/LineLength:
- 'ee/spec/models/ee/project_authorization_spec.rb'
- 'ee/spec/models/ee/protected_branch_spec.rb'
- 'ee/spec/models/ee/service_desk_setting_spec.rb'
- - 'ee/spec/models/ee/user_highest_role_spec.rb'
- 'ee/spec/models/ee/user_spec.rb'
- 'ee/spec/models/ee/vulnerability_spec.rb'
- 'ee/spec/models/elastic/migration_record_spec.rb'
@@ -2426,7 +2347,6 @@ Layout/LineLength:
- 'ee/spec/requests/api/graphql/project/incident_management/escalation_policies_spec.rb'
- 'ee/spec/requests/api/graphql/project/incident_management/escalation_policy/rules_spec.rb'
- 'ee/spec/requests/api/graphql/project/incident_management/oncall_shifts_spec.rb'
- - 'ee/spec/requests/api/graphql/project/issues_spec.rb'
- 'ee/spec/requests/api/graphql/project/pipeline/security_report_summary_spec.rb'
- 'ee/spec/requests/api/graphql/project/requirements_management/requirements_spec.rb'
- 'ee/spec/requests/api/graphql/project/vulnerability_severities_count_spec.rb'
@@ -2462,7 +2382,6 @@ Layout/LineLength:
- 'ee/spec/requests/api/related_epic_links_spec.rb'
- 'ee/spec/requests/api/releases_spec.rb'
- 'ee/spec/requests/api/resource_iteration_events_spec.rb'
- - 'ee/spec/requests/api/scim_spec.rb'
- 'ee/spec/requests/api/search_spec.rb'
- 'ee/spec/requests/api/settings_spec.rb'
- 'ee/spec/requests/api/status_checks_spec.rb'
@@ -2587,7 +2506,6 @@ Layout/LineLength:
- 'ee/spec/services/ee/issues/move_service_spec.rb'
- 'ee/spec/services/ee/issues/update_service_spec.rb'
- 'ee/spec/services/ee/members/destroy_service_spec.rb'
- - 'ee/spec/services/ee/merge_requests/after_create_service_spec.rb'
- 'ee/spec/services/ee/merge_requests/create_from_vulnerability_data_service_spec.rb'
- 'ee/spec/services/ee/merge_requests/post_merge_service_spec.rb'
- 'ee/spec/services/ee/merge_requests/refresh_service_spec.rb'
@@ -2803,7 +2721,6 @@ Layout/LineLength:
- 'ee/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb'
- 'ee/spec/views/operations/environments.html.haml_spec.rb'
- 'ee/spec/views/projects/security/discover/show.html.haml_spec.rb'
- - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb'
- 'ee/spec/views/shared/_mirror_status.html.haml_spec.rb'
- 'ee/spec/views/shared/_namespace_user_cap_reached_alert.html.haml_spec.rb'
- 'ee/spec/views/shared/billings/_eoa_bronze_plan_banner.html.haml_spec.rb'
@@ -2830,7 +2747,6 @@ Layout/LineLength:
- 'ee/spec/workers/geo/destroy_worker_spec.rb'
- 'ee/spec/workers/geo/project_sync_worker_spec.rb'
- 'ee/spec/workers/geo/prune_event_log_worker_spec.rb'
- - 'ee/spec/workers/geo/registry_sync_worker_spec.rb'
- 'ee/spec/workers/geo/repositories_clean_up_worker_spec.rb'
- 'ee/spec/workers/geo/repository_shard_sync_worker_spec.rb'
- 'ee/spec/workers/geo/repository_verification/primary/shard_worker_spec.rb'
@@ -3037,7 +2953,6 @@ Layout/LineLength:
- 'lib/gitlab/auth/o_auth/user.rb'
- 'lib/gitlab/auth/saml/auth_hash.rb'
- 'lib/gitlab/auth/user_access_denied_reason.rb'
- - 'lib/gitlab/background_migration/add_primary_email_to_emails_if_user_confirmed.rb'
- 'lib/gitlab/background_migration/backfill_issue_search_data.rb'
- 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb'
- 'lib/gitlab/background_migration/backfill_snippet_repositories.rb'
@@ -3086,7 +3001,6 @@ Layout/LineLength:
- 'lib/gitlab/ci/config/entry/trigger.rb'
- 'lib/gitlab/ci/config/external/file/project.rb'
- 'lib/gitlab/ci/config/external/file/remote.rb'
- - 'lib/gitlab/ci/config/external/mapper.rb'
- 'lib/gitlab/ci/parsers/coverage/cobertura.rb'
- 'lib/gitlab/ci/parsers/coverage/sax_document.rb'
- 'lib/gitlab/ci/parsers/security/common.rb'
@@ -3101,7 +3015,6 @@ Layout/LineLength:
- 'lib/gitlab/ci/pipeline/seed/build.rb'
- 'lib/gitlab/ci/reports/codequality_reports.rb'
- 'lib/gitlab/ci/reports/security/finding.rb'
- - 'lib/gitlab/ci/reports/security/reports.rb'
- 'lib/gitlab/ci/reports/test_case.rb'
- 'lib/gitlab/ci/reports/test_suite.rb'
- 'lib/gitlab/ci/reports/test_suite_comparer.rb'
@@ -3156,7 +3069,6 @@ Layout/LineLength:
- 'lib/gitlab/database/reflection.rb'
- 'lib/gitlab/database/reindexing.rb'
- 'lib/gitlab/database/reindexing/coordinator.rb'
- - 'lib/gitlab/database/reindexing/grafana_notifier.rb'
- 'lib/gitlab/database/reindexing/reindex_concurrently.rb'
- 'lib/gitlab/database/schema_migrations/context.rb'
- 'lib/gitlab/database/similarity_score.rb'
@@ -3310,7 +3222,6 @@ Layout/LineLength:
- 'lib/gitlab/quick_actions/relate_actions.rb'
- 'lib/gitlab/rack_attack.rb'
- 'lib/gitlab/redis/wrapper.rb'
- - 'lib/gitlab/reference_extractor.rb'
- 'lib/gitlab/regex.rb'
- 'lib/gitlab/relative_positioning/item_context.rb'
- 'lib/gitlab/repository_size_error_message.rb'
@@ -3427,15 +3338,9 @@ Layout/LineLength:
- 'qa/qa/resource/protected_branch.rb'
- 'qa/qa/resource/registry_repository.rb'
- 'qa/qa/resource/repository/push.rb'
- - 'qa/qa/resource/reusable.rb'
- - 'qa/qa/resource/reusable_collection.rb'
- - 'qa/qa/resource/reusable_group.rb'
- - 'qa/qa/resource/reusable_project.rb'
- - 'qa/qa/resource/runner.rb'
- 'qa/qa/resource/snippet.rb'
- 'qa/qa/resource/wiki/group_page.rb'
- 'qa/qa/runtime/api/repository_storage_moves.rb'
- - 'qa/qa/runtime/application_settings.rb'
- 'qa/qa/runtime/env.rb'
- 'qa/qa/runtime/feature.rb'
- 'qa/qa/runtime/fixtures.rb'
@@ -3550,9 +3455,7 @@ Layout/LineLength:
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/license_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/free_trial_spec.rb'
- - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb'
- - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/upgrade_group_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/user_registration_billing_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb'
@@ -3633,7 +3536,6 @@ Layout/LineLength:
- 'scripts/changed-feature-flags'
- 'scripts/failed_tests.rb'
- 'scripts/flaky_examples/prune-old-flaky-examples'
- - 'scripts/lib/gitlab.rb'
- 'scripts/lint_templates_bash.rb'
- 'scripts/no-dir-check'
- 'scripts/perf/query_limiting_report.rb'
@@ -3674,7 +3576,6 @@ Layout/LineLength:
- 'spec/controllers/groups/settings/applications_controller_spec.rb'
- 'spec/controllers/groups/settings/integrations_controller_spec.rb'
- 'spec/controllers/groups_controller_spec.rb'
- - 'spec/controllers/import/available_namespaces_controller_spec.rb'
- 'spec/controllers/import/bitbucket_controller_spec.rb'
- 'spec/controllers/import/bitbucket_server_controller_spec.rb'
- 'spec/controllers/import/bulk_imports_controller_spec.rb'
@@ -3748,7 +3649,6 @@ Layout/LineLength:
- 'spec/db/schema_spec.rb'
- 'spec/deprecation_toolkit_env.rb'
- 'spec/experiments/concerns/project_commit_count_spec.rb'
- - 'spec/factories/ci/builds.rb'
- 'spec/factories/ci/job_artifacts.rb'
- 'spec/factories/ci/pipelines.rb'
- 'spec/factories/ci/reports/codequality_degradations.rb'
@@ -3844,7 +3744,6 @@ Layout/LineLength:
- 'spec/features/markdown/gitlab_flavored_markdown_spec.rb'
- 'spec/features/markdown/metrics_spec.rb'
- 'spec/features/merge_request/batch_comments_spec.rb'
- - 'spec/features/merge_request/maintainer_edits_fork_spec.rb'
- 'spec/features/merge_request/user_accepts_merge_request_spec.rb'
- 'spec/features/merge_request/user_allows_commits_from_memebers_who_can_merge_spec.rb'
- 'spec/features/merge_request/user_assigns_themselves_spec.rb'
@@ -3965,7 +3864,6 @@ Layout/LineLength:
- 'spec/features/security/project/snippet/public_access_spec.rb'
- 'spec/features/signed_commits_spec.rb'
- 'spec/features/snippets/embedded_snippet_spec.rb'
- - 'spec/features/snippets/spam_snippets_spec.rb'
- 'spec/features/snippets/user_edits_snippet_spec.rb'
- 'spec/features/task_lists_spec.rb'
- 'spec/features/unsubscribe_links_spec.rb'
@@ -4176,7 +4074,6 @@ Layout/LineLength:
- 'spec/helpers/users_helper_spec.rb'
- 'spec/helpers/visibility_level_helper_spec.rb'
- 'spec/helpers/webpack_helper_spec.rb'
- - 'spec/helpers/wiki_helper_spec.rb'
- 'spec/helpers/wiki_page_version_helper_spec.rb'
- 'spec/initializers/00_rails_disable_joins_spec.rb'
- 'spec/initializers/6_validations_spec.rb'
@@ -4304,7 +4201,6 @@ Layout/LineLength:
- 'spec/lib/gitlab/auth/user_access_denied_reason_spec.rb'
- 'spec/lib/gitlab/auth_spec.rb'
- 'spec/lib/gitlab/authorized_keys_spec.rb'
- - 'spec/lib/gitlab/background_migration/add_primary_email_to_emails_if_user_confirmed_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_issue_search_data_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_member_namespace_for_group_members_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb'
@@ -4388,7 +4284,6 @@ Layout/LineLength:
- 'spec/lib/gitlab/ci/pipeline_object_hierarchy_spec.rb'
- 'spec/lib/gitlab/ci/reports/codequality_mr_diff_spec.rb'
- 'spec/lib/gitlab/ci/reports/security/flag_spec.rb'
- - 'spec/lib/gitlab/ci/reports/security/reports_spec.rb'
- 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb'
- 'spec/lib/gitlab/ci/reports/security/vulnerability_reports_comparer_spec.rb'
- 'spec/lib/gitlab/ci/runner_upgrade_check_spec.rb'
@@ -4458,7 +4353,6 @@ Layout/LineLength:
- 'spec/lib/gitlab/database/query_analyzer_spec.rb'
- 'spec/lib/gitlab/database/query_analyzers/prevent_cross_database_modification_spec.rb'
- 'spec/lib/gitlab/database/query_analyzers/restrict_allowed_schemas_spec.rb'
- - 'spec/lib/gitlab/database/reindexing/grafana_notifier_spec.rb'
- 'spec/lib/gitlab/database/reindexing/reindex_concurrently_spec.rb'
- 'spec/lib/gitlab/database/reindexing_spec.rb'
- 'spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base_spec.rb'
@@ -4555,7 +4449,6 @@ Layout/LineLength:
- 'spec/lib/gitlab/import_export/base/relation_object_saver_spec.rb'
- 'spec/lib/gitlab/import_export/command_line_util_spec.rb'
- 'spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb'
- - 'spec/lib/gitlab/import_export/group/legacy_tree_restorer_spec.rb'
- 'spec/lib/gitlab/import_export/import_failure_service_spec.rb'
- 'spec/lib/gitlab/import_export/importer_spec.rb'
- 'spec/lib/gitlab/import_export/json/ndjson_reader_spec.rb'
@@ -4663,7 +4556,6 @@ Layout/LineLength:
- 'spec/lib/gitlab/search_results_spec.rb'
- 'spec/lib/gitlab/serializer/pagination_spec.rb'
- 'spec/lib/gitlab/serverless/service_spec.rb'
- - 'spec/lib/gitlab/shell_spec.rb'
- 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb'
- 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb'
- 'spec/lib/gitlab/sidekiq_logging/structured_logger_spec.rb'
@@ -4755,10 +4647,6 @@ Layout/LineLength:
- 'spec/mailers/emails/releases_spec.rb'
- 'spec/mailers/emails/service_desk_spec.rb'
- 'spec/mailers/notify_spec.rb'
- - 'spec/migrations/20210423160427_schedule_drop_invalid_vulnerabilities_spec.rb'
- - 'spec/migrations/20210511142748_schedule_drop_invalid_vulnerabilities2_spec.rb'
- - 'spec/migrations/20210514063252_schedule_cleanup_orphaned_lfs_objects_projects_spec.rb'
- - 'spec/migrations/20210601073400_fix_total_stage_in_vsa_spec.rb'
- 'spec/migrations/20210610153556_delete_legacy_operations_feature_flags_spec.rb'
- 'spec/migrations/2021061716138_cascade_delete_freeze_periods_spec.rb'
- 'spec/migrations/20210713042000_fix_ci_sources_pipelines_index_names_spec.rb'
@@ -4789,19 +4677,11 @@ Layout/LineLength:
- 'spec/migrations/add_upvotes_count_index_to_issues_spec.rb'
- 'spec/migrations/backfill_all_project_namespaces_spec.rb'
- 'spec/migrations/backfill_cadence_id_for_boards_scoped_to_iteration_spec.rb'
- - 'spec/migrations/backfill_clusters_integration_prometheus_enabled_spec.rb'
- - 'spec/migrations/backfill_escalation_policies_for_oncall_schedules_spec.rb'
- - 'spec/migrations/backfill_nuget_temporary_packages_to_processing_status_spec.rb'
- 'spec/migrations/backfill_project_namespaces_for_group_spec.rb'
- - 'spec/migrations/cleanup_after_add_primary_email_to_emails_if_user_confirmed_spec.rb'
- 'spec/migrations/cleanup_after_fixing_issue_when_admin_changed_primary_email_spec.rb'
- - 'spec/migrations/cleanup_move_container_registry_enabled_to_project_feature_spec.rb'
- - 'spec/migrations/confirm_support_bot_user_spec.rb'
- - 'spec/migrations/delete_security_findings_without_uuid_spec.rb'
- 'spec/migrations/finalize_project_namespaces_backfill_spec.rb'
- 'spec/migrations/fix_and_backfill_project_namespaces_for_projects_with_duplicate_name_spec.rb'
- 'spec/migrations/fix_batched_migrations_old_format_job_arguments_spec.rb'
- - 'spec/migrations/populate_dismissal_information_for_vulnerabilities_spec.rb'
- 'spec/migrations/re_schedule_latest_pipeline_id_population_with_all_security_related_artifact_types_spec.rb'
- 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_features_spec.rb'
- 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_with_new_features_spec.rb'
@@ -4810,11 +4690,8 @@ Layout/LineLength:
- 'spec/migrations/rename_services_to_integrations_spec.rb'
- 'spec/migrations/replace_external_wiki_triggers_spec.rb'
- 'spec/migrations/reset_severity_levels_to_new_default_spec.rb'
- - 'spec/migrations/schedule_add_primary_email_to_emails_if_user_confirmed_spec.rb'
- 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb'
- 'spec/migrations/schedule_update_timelogs_null_spent_at_spec.rb'
- - 'spec/migrations/schedule_update_timelogs_project_id_spec.rb'
- - 'spec/migrations/schedule_update_users_where_two_factor_auth_required_from_group_spec.rb'
- 'spec/migrations/update_invalid_member_states_spec.rb'
- 'spec/models/active_session_spec.rb'
- 'spec/models/acts_as_taggable_on/tag_spec.rb'
@@ -4837,12 +4714,9 @@ Layout/LineLength:
- 'spec/models/ci/build_spec.rb'
- 'spec/models/ci/build_trace_chunk_spec.rb'
- 'spec/models/ci/daily_build_group_report_result_spec.rb'
- - 'spec/models/ci/freeze_period_status_spec.rb'
- 'spec/models/ci/group_variable_spec.rb'
- 'spec/models/ci/instance_variable_spec.rb'
- 'spec/models/ci/job_artifact_spec.rb'
- - 'spec/models/ci/job_token/scope_spec.rb'
- - 'spec/models/ci/pipeline_schedule_spec.rb'
- 'spec/models/ci/pipeline_spec.rb'
- 'spec/models/ci/processable_spec.rb'
- 'spec/models/ci/ref_spec.rb'
@@ -4864,7 +4738,6 @@ Layout/LineLength:
- 'spec/models/concerns/clusters/agents/authorization_config_scopes_spec.rb'
- 'spec/models/concerns/deployment_platform_spec.rb'
- 'spec/models/concerns/group_descendant_spec.rb'
- - 'spec/models/concerns/has_user_type_spec.rb'
- 'spec/models/concerns/id_in_ordered_spec.rb'
- 'spec/models/concerns/ignorable_columns_spec.rb'
- 'spec/models/concerns/integrations/has_data_fields_spec.rb'
@@ -5128,7 +5001,6 @@ Layout/LineLength:
- 'spec/requests/api/graphql/project/container_repositories_spec.rb'
- 'spec/requests/api/graphql/project/issue/designs/designs_spec.rb'
- 'spec/requests/api/graphql/project/jira_import_spec.rb'
- - 'spec/requests/api/graphql/project/jobs_spec.rb'
- 'spec/requests/api/graphql/project/milestones_spec.rb'
- 'spec/requests/api/graphql/project/pipeline_spec.rb'
- 'spec/requests/api/graphql/project/project_statistics_spec.rb'
@@ -5174,7 +5046,6 @@ Layout/LineLength:
- 'spec/requests/api/npm_project_packages_spec.rb'
- 'spec/requests/api/nuget_group_packages_spec.rb'
- 'spec/requests/api/nuget_project_packages_spec.rb'
- - 'spec/requests/api/oauth_tokens_spec.rb'
- 'spec/requests/api/pages/internal_access_spec.rb'
- 'spec/requests/api/pages/private_access_spec.rb'
- 'spec/requests/api/pages/public_access_spec.rb'
@@ -5225,10 +5096,8 @@ Layout/LineLength:
- 'spec/requests/projects/incident_management/pagerduty_incidents_spec.rb'
- 'spec/requests/projects/issue_links_controller_spec.rb'
- 'spec/requests/projects/issues/discussions_spec.rb'
- - 'spec/requests/projects/issues_controller_spec.rb'
- 'spec/requests/projects/merge_requests/content_spec.rb'
- 'spec/requests/projects/merge_requests/context_commit_diffs_spec.rb'
- - 'spec/requests/projects/merge_requests_controller_spec.rb'
- 'spec/requests/projects/merge_requests_discussions_spec.rb'
- 'spec/requests/projects/merge_requests_spec.rb'
- 'spec/requests/projects/metrics/dashboards/builder_spec.rb'
@@ -5320,8 +5189,6 @@ Layout/LineLength:
- 'spec/services/ci/test_failure_history_service_spec.rb'
- 'spec/services/ci/unlock_artifacts_service_spec.rb'
- 'spec/services/ci/update_pending_build_service_spec.rb'
- - 'spec/services/clusters/aws/fetch_credentials_service_spec.rb'
- - 'spec/services/clusters/aws/provision_service_spec.rb'
- 'spec/services/clusters/create_service_spec.rb'
- 'spec/services/clusters/integrations/prometheus_health_check_service_spec.rb'
- 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb'
@@ -5501,8 +5368,6 @@ Layout/LineLength:
- 'spec/services/projects/import_export/export_service_spec.rb'
- 'spec/services/projects/import_service_spec.rb'
- 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb'
- - 'spec/services/projects/lfs_pointers/lfs_import_service_spec.rb'
- - 'spec/services/projects/lfs_pointers/lfs_object_download_list_service_spec.rb'
- 'spec/services/projects/operations/update_service_spec.rb'
- 'spec/services/projects/overwrite_project_service_spec.rb'
- 'spec/services/projects/transfer_service_spec.rb'
@@ -5622,7 +5487,6 @@ Layout/LineLength:
- 'spec/support/shared_examples/controllers/set_sort_order_from_user_preference_shared_examples.rb'
- 'spec/support/shared_examples/controllers/wiki_actions_shared_examples.rb'
- 'spec/support/shared_examples/features/2fa_shared_examples.rb'
- - 'spec/support/shared_examples/features/container_registry_shared_examples.rb'
- 'spec/support/shared_examples/features/discussion_comments_shared_example.rb'
- 'spec/support/shared_examples/features/editable_merge_request_shared_examples.rb'
- 'spec/support/shared_examples/features/error_tracking_shared_example.rb'
@@ -5748,7 +5612,6 @@ Layout/LineLength:
- 'spec/support/shared_examples/uploaders/upload_type_shared_examples.rb'
- 'spec/support/shared_examples/views/registration_features_prompt_shared_examples.rb'
- 'spec/support/shared_examples/workers/concerns/dependency_proxy/cleanup_worker_shared_examples.rb'
- - 'spec/support/shared_examples/workers/concerns/git_garbage_collect_methods_shared_examples.rb'
- 'spec/support/shared_examples/workers/gitlab/jira_import/jira_import_workers_shared_examples.rb'
- 'spec/support/shared_examples/workers/project_export_shared_examples.rb'
- 'spec/support_specs/database/prevent_cross_joins_spec.rb'
@@ -5826,7 +5689,6 @@ Layout/LineLength:
- 'spec/views/shared/milestones/_issuable.html.haml_spec.rb'
- 'spec/views/shared/projects/_project.html.haml_spec.rb'
- 'spec/views/shared/snippets/_snippet.html.haml_spec.rb'
- - 'spec/views/shared/ssh_keys/_key_details.html.haml_spec.rb'
- 'spec/views/shared/wikis/_sidebar.html.haml_spec.rb'
- 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb'
- 'spec/workers/authorized_project_update/project_recalculate_per_user_worker_spec.rb'
diff --git a/.rubocop_todo/layout/parameter_alignment.yml b/.rubocop_todo/layout/parameter_alignment.yml
new file mode 100644
index 00000000000..4fafbab6024
--- /dev/null
+++ b/.rubocop_todo/layout/parameter_alignment.yml
@@ -0,0 +1,18 @@
+---
+# Cop supports --autocorrect.
+Layout/ParameterAlignment:
+ Details: grace period
+ Exclude:
+ - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb'
+ - 'lib/gitlab/cross_project_access.rb'
+ - 'lib/gitlab/data_builder/push.rb'
+ - 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb'
+ - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb'
+ - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb'
+ - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb'
+ - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb'
+ - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb'
+ - 'spec/support/helpers/content_security_policy_helpers.rb'
+ - 'spec/support/helpers/migrations_helpers/vulnerabilities_helper.rb'
+ - 'spec/support/helpers/repo_helpers.rb'
+ - 'spec/support/helpers/stub_object_storage.rb'
diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml
index 73b8a354a58..2fbdf69e5e3 100644
--- a/.rubocop_todo/layout/space_in_lambda_literal.yml
+++ b/.rubocop_todo/layout/space_in_lambda_literal.yml
@@ -24,7 +24,6 @@ Layout/SpaceInLambdaLiteral:
- 'app/models/clusters/cluster.rb'
- 'app/models/clusters/kubernetes_namespace.rb'
- 'app/models/commit_status.rb'
- - 'app/models/concerns/analytics/cycle_analytics/stage.rb'
- 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb'
- 'app/models/concerns/approvable.rb'
- 'app/models/concerns/ci/artifactable.rb'
@@ -173,7 +172,6 @@ Layout/SpaceInLambdaLiteral:
- 'app/workers/process_commit_worker.rb'
- 'config/initializers/deprecations.rb'
- 'config/routes/project.rb'
- - 'db/post_migrate/20210303121224_update_gitlab_subscriptions_start_at_post_eoa.rb'
- 'ee/app/controllers/groups/analytics/coverage_reports_controller.rb'
- 'ee/app/controllers/projects/on_demand_scans_controller.rb'
- 'ee/app/controllers/projects/security/dast_site_profiles_controller.rb'
diff --git a/.rubocop_todo/lint/ambiguous_regexp_literal.yml b/.rubocop_todo/lint/ambiguous_regexp_literal.yml
new file mode 100644
index 00000000000..d0160d620d5
--- /dev/null
+++ b/.rubocop_todo/lint/ambiguous_regexp_literal.yml
@@ -0,0 +1,96 @@
+---
+# Cop supports --autocorrect.
+Lint/AmbiguousRegexpLiteral:
+ Details: grace period
+ Exclude:
+ - 'ee/lib/ee/gitlab/auth/ldap/group.rb'
+ - 'ee/spec/controllers/groups/sso_controller_spec.rb'
+ - 'ee/spec/controllers/projects/mirrors_controller_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/ci/status/build/manual_spec.rb'
+ - 'ee/spec/lib/gitlab/insights/executors/dora_executor_spec.rb'
+ - 'ee/spec/lib/gitlab/web_ide/config/entry/schema_spec.rb'
+ - 'ee/spec/lib/gitlab/web_ide/config/entry/schemas_spec.rb'
+ - 'ee/spec/mailers/ee/emails/profile_spec.rb'
+ - 'ee/spec/models/push_rule_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/destroy_spec.rb'
+ - 'ee/spec/serializers/pipeline_serializer_spec.rb'
+ - 'ee/spec/services/analytics/cycle_analytics/aggregator_service_spec.rb'
+ - 'ee/spec/services/ee/members/create_service_spec.rb'
+ - 'ee/spec/services/group_saml/saml_group_links/create_service_spec.rb'
+ - 'ee/spec/views/admin/dashboard/index.html.haml_spec.rb'
+ - 'ee/spec/views/admin/users/_credit_card_info.html.haml_spec.rb'
+ - 'ee/spec/views/admin/users/show.html.haml_spec.rb'
+ - 'ee/spec/views/shared/_clone_panel.html.haml_spec.rb'
+ - 'lib/api/features.rb'
+ - 'qa/spec/page/element_spec.rb'
+ - 'spec/components/pajamas/avatar_component_spec.rb'
+ - 'spec/features/atom/users_spec.rb'
+ - 'spec/features/issues/user_creates_branch_and_merge_request_spec.rb'
+ - 'spec/features/issues/user_creates_issue_spec.rb'
+ - 'spec/features/merge_request/user_merges_when_pipeline_succeeds_spec.rb'
+ - 'spec/helpers/labels_helper_spec.rb'
+ - 'spec/helpers/users_helper_spec.rb'
+ - 'spec/helpers/visibility_level_helper_spec.rb'
+ - 'spec/initializers/direct_upload_support_spec.rb'
+ - 'spec/initializers/validate_database_config_spec.rb'
+ - 'spec/lib/banzai/filter/references/label_reference_filter_spec.rb'
+ - 'spec/lib/feature_spec.rb'
+ - 'spec/lib/gitlab/auth/user_access_denied_reason_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/bridge_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/image_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/imageable_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/job_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/key_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/policy_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/ports_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/processable_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/reports/coverage_report_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/root_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/service_spec.rb'
+ - 'spec/lib/gitlab/ci/config/entry/trigger_spec.rb'
+ - 'spec/lib/gitlab/ci/pipeline/chain/create_spec.rb'
+ - 'spec/lib/gitlab/ci/pipeline/chain/validate/abilities_spec.rb'
+ - 'spec/lib/gitlab/ci/status/build/manual_spec.rb'
+ - 'spec/lib/gitlab/composer/version_index_spec.rb'
+ - 'spec/lib/gitlab/config/entry/validator_spec.rb'
+ - 'spec/lib/gitlab/config/entry/validators_spec.rb'
+ - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb'
+ - 'spec/lib/gitlab/database/migration_helpers/v2_spec.rb'
+ - 'spec/lib/gitlab/database/migration_helpers_spec.rb'
+ - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb'
+ - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb'
+ - 'spec/lib/gitlab/database/partitioning_spec.rb'
+ - 'spec/lib/gitlab/database/query_analyzers/prevent_cross_database_modification_spec.rb'
+ - 'spec/lib/gitlab/gitaly_client/with_feature_flag_actors_spec.rb'
+ - 'spec/lib/gitlab/kubernetes/helm/v2/base_command_spec.rb'
+ - 'spec/lib/gitlab/kubernetes/helm/v3/base_command_spec.rb'
+ - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/array_scope_columns_spec.rb'
+ - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb'
+ - 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb'
+ - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job_spec.rb'
+ - 'spec/lib/gitlab/usage/metrics/aggregates/sources/postgres_hll_spec.rb'
+ - 'spec/lib/gitlab/utils/strong_memoize_spec.rb'
+ - 'spec/lib/gitlab/web_ide/config/entry/global_spec.rb'
+ - 'spec/lib/gitlab/web_ide/config/entry/terminal_spec.rb'
+ - 'spec/lib/object_storage/direct_upload_spec.rb'
+ - 'spec/mailers/devise_mailer_spec.rb'
+ - 'spec/mailers/emails/profile_spec.rb'
+ - 'spec/models/concerns/as_cte_spec.rb'
+ - 'spec/models/concerns/sortable_spec.rb'
+ - 'spec/models/concerns/spammable_spec.rb'
+ - 'spec/models/group_spec.rb'
+ - 'spec/requests/api/deployments_spec.rb'
+ - 'spec/requests/api/graphql/gitlab_schema_spec.rb'
+ - 'spec/requests/api/helpers_spec.rb'
+ - 'spec/scripts/lib/glfm/update_specification_spec.rb'
+ - 'spec/serializers/commit_entity_spec.rb'
+ - 'spec/services/loose_foreign_keys/cleaner_service_spec.rb'
+ - 'spec/services/snippets/repository_validation_service_spec.rb'
+ - 'spec/services/system_notes/merge_requests_service_spec.rb'
+ - 'spec/support/shared_examples/features/content_editor_shared_examples.rb'
+ - 'spec/support/shared_examples/lib/gitlab/sql/set_operator_shared_examples.rb'
+ - 'spec/support_specs/database/multiple_databases_helpers_spec.rb'
+ - 'spec/tasks/gitlab/gitaly_rake_spec.rb'
+ - 'spec/tasks/gitlab/workhorse_rake_spec.rb'
+ - 'spec/views/admin/dashboard/index.html.haml_spec.rb'
+ - 'spec/views/devise/sessions/new.html.haml_spec.rb'
diff --git a/.rubocop_todo/lint/missing_cop_enable_directive.yml b/.rubocop_todo/lint/missing_cop_enable_directive.yml
index e0b2afe8256..d4091e27353 100644
--- a/.rubocop_todo/lint/missing_cop_enable_directive.yml
+++ b/.rubocop_todo/lint/missing_cop_enable_directive.yml
@@ -144,12 +144,10 @@ Lint/MissingCopEnableDirective:
- 'ee/app/workers/groups/export_memberships_worker.rb'
- 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb'
- 'ee/lib/api/ldap_group_links.rb'
- - 'ee/lib/api/scim.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb'
- 'ee/lib/ee/gitlab/usage_data.rb'
- 'ee/lib/gitlab/spdx/license.rb'
- - 'ee/spec/controllers/projects/legacy_pipelines_controller_spec.rb'
- 'ee/spec/helpers/groups/security_features_helper_spec.rb'
- 'ee/spec/helpers/projects/security/discover_helper_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/delete_invalid_epic_issues_spec.rb'
diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml
index a2dd002b54f..146d7ce164f 100644
--- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml
+++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml
@@ -73,7 +73,6 @@ Lint/RedundantCopDisableDirective:
- 'config/initializers/warden.rb'
- 'config/initializers/wikicloth_ruby_3_patch.rb'
- 'config/routes/api.rb'
- - 'db/migrate/20210303193544_add_concurrent_fields_to_bulk_imports_trackers.rb'
- 'db/migrate/20210917134321_remove_temporary_index_for_project_topics_on_taggings.rb'
- 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb'
- 'db/migrate/20220316022505_create_namespace_details.rb'
@@ -125,7 +124,6 @@ Lint/RedundantCopDisableDirective:
- 'ee/lib/analytics/merge_request_metrics_calculator.rb'
- 'ee/lib/api/audit_events.rb'
- 'ee/lib/api/dora/metrics.rb'
- - 'ee/lib/api/scim.rb'
- 'ee/lib/ee/api/entities/analytics/code_review/merge_request.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_epic_cache_counts.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_scanners.rb'
@@ -136,7 +134,6 @@ Lint/RedundantCopDisableDirective:
- 'ee/lib/gitlab/elastic/bool_expr.rb'
- 'ee/lib/gitlab/spdx/license.rb'
- 'ee/lib/gitlab/status_page/storage/object.rb'
- - 'ee/spec/contracts/provider/pact_helpers/project/merge_request/show/suggested_reviewers_helper.rb'
- 'ee/spec/elastic/migrate/20221026082700_backfill_users_spec.rb'
- 'ee/spec/features/boards/user_visits_board_spec.rb'
- 'ee/spec/features/groups/settings/domain_verification_spec.rb'
diff --git a/.rubocop_todo/migration/background_migration_base_class.yml b/.rubocop_todo/migration/background_migration_base_class.yml
index 56b6a4294d4..9f5fb15289b 100644
--- a/.rubocop_todo/migration/background_migration_base_class.yml
+++ b/.rubocop_todo/migration/background_migration_base_class.yml
@@ -1,7 +1,6 @@
---
Migration/BackgroundMigrationBaseClass:
Exclude:
- - 'lib/gitlab/background_migration/add_primary_email_to_emails_if_user_confirmed.rb'
- 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb'
- 'lib/gitlab/background_migration/backfill_draft_status_on_merge_requests.rb'
- 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb'
diff --git a/.rubocop_todo/migration/background_migration_record.yml b/.rubocop_todo/migration/background_migration_record.yml
index 567926e33a2..ec2b9fb6d6a 100644
--- a/.rubocop_todo/migration/background_migration_record.yml
+++ b/.rubocop_todo/migration/background_migration_record.yml
@@ -12,7 +12,6 @@ Migration/BackgroundMigrationRecord:
- 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb'
- 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb'
- - 'lib/gitlab/background_migration/add_primary_email_to_emails_if_user_confirmed.rb'
- 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb'
- 'lib/gitlab/background_migration/backfill_draft_status_on_merge_requests.rb'
- 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb'
diff --git a/.rubocop_todo/migration/background_migrations.yml b/.rubocop_todo/migration/background_migrations.yml
index 2219f37901d..fbafbb66289 100644
--- a/.rubocop_todo/migration/background_migrations.yml
+++ b/.rubocop_todo/migration/background_migrations.yml
@@ -1,17 +1,6 @@
---
Migration/BackgroundMigrations:
Exclude:
- - 'db/migrate/20210519154058_schedule_update_users_where_two_factor_auth_required_from_group.rb'
- - 'db/post_migrate/20210302074524_backfill_namespace_statistics_with_wiki_size.rb'
- - 'db/post_migrate/20210304133508_schedule_remove_duplicate_vulnerabilities_findings2.rb'
- - 'db/post_migrate/20210415155043_move_container_registry_enabled_to_project_features3.rb'
- - 'db/post_migrate/20210423160427_schedule_drop_invalid_vulnerabilities.rb'
- - 'db/post_migrate/20210427212034_schedule_update_timelogs_project_id.rb'
- - 'db/post_migrate/20210506065000_schedule_backfill_traversal_ids.rb'
- - 'db/post_migrate/20210511095658_schedule_migrate_project_taggings_context_from_tags_to_topics.rb'
- - 'db/post_migrate/20210511142748_schedule_drop_invalid_vulnerabilities2.rb'
- - 'db/post_migrate/20210514063252_schedule_cleanup_orphaned_lfs_objects_projects.rb'
- - 'db/post_migrate/20210518074332_schedule_disable_expiration_policies_linked_to_no_container_images.rb'
- 'db/post_migrate/20210604070207_retry_backfill_traversal_ids.rb'
- 'db/post_migrate/20210611080951_fix_missing_traversal_ids.rb'
- 'db/post_migrate/20210701111909_backfill_issues_upvotes_count.rb'
@@ -26,7 +15,6 @@ Migration/BackgroundMigrations:
- 'db/post_migrate/20210901153324_slice_merge_request_diff_commit_migrations.rb'
- 'db/post_migrate/20210909104800_reschedule_extract_project_topics_into_separate_table_2.rb'
- 'db/post_migrate/20211004110927_schedule_fix_first_mentioned_in_commit_at_job.rb'
- - 'db/post_migrate/20211004120135_schedule_add_primary_email_to_emails_if_user_confirmed.rb'
- 'db/post_migrate/20211005010101_rereschedule_delete_orphaned_deployments.rb'
- 'db/post_migrate/20211005194425_schedule_requirements_migration.rb'
- 'db/post_migrate/20211006060436_schedule_populate_topics_total_projects_count_cache.rb'
diff --git a/.rubocop_todo/naming/heredoc_delimiter_naming.yml b/.rubocop_todo/naming/heredoc_delimiter_naming.yml
index d57905c8607..d10fac78cef 100644
--- a/.rubocop_todo/naming/heredoc_delimiter_naming.yml
+++ b/.rubocop_todo/naming/heredoc_delimiter_naming.yml
@@ -113,7 +113,6 @@ Naming/HeredocDelimiterNaming:
- 'spec/models/integrations/asana_spec.rb'
- 'spec/models/ssh_host_key_spec.rb'
- 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb'
- - 'spec/services/ci/after_requeue_job_service_spec.rb'
- 'spec/services/ci/create_downstream_pipeline_service_spec.rb'
- 'spec/services/ci/create_pipeline_service/cache_spec.rb'
- 'spec/services/ci/create_pipeline_service/evaluate_runner_tags_spec.rb'
diff --git a/.rubocop_todo/performance/concurrent_monotonic_time.yml b/.rubocop_todo/performance/concurrent_monotonic_time.yml
new file mode 100644
index 00000000000..0e55eaf4a18
--- /dev/null
+++ b/.rubocop_todo/performance/concurrent_monotonic_time.yml
@@ -0,0 +1,6 @@
+---
+# Cop supports --autocorrect.
+Performance/ConcurrentMonotonicTime:
+ Details: grace period
+ Exclude:
+ - 'lib/gitlab/database/connection_timer.rb'
diff --git a/.rubocop_todo/performance/flat_map.yml b/.rubocop_todo/performance/flat_map.yml
new file mode 100644
index 00000000000..32dce1bf317
--- /dev/null
+++ b/.rubocop_todo/performance/flat_map.yml
@@ -0,0 +1,38 @@
+---
+# Cop supports --autocorrect.
+Performance/FlatMap:
+ Details: grace period
+ Exclude:
+ - 'app/presenters/packages/nuget/service_index_presenter.rb'
+ - 'app/services/projects/apple_target_platform_detector_service.rb'
+ - 'ee/app/models/burndown.rb'
+ - 'ee/app/models/geo_node_status.rb'
+ - 'ee/app/serializers/dashboard_environments_serializer.rb'
+ - 'ee/app/services/elastic/process_bookkeeping_service.rb'
+ - 'ee/lib/elastic/latest/issue_class_proxy.rb'
+ - 'ee/spec/lib/elastic/latest/user_class_proxy_spec.rb'
+ - 'ee/spec/models/analytics/issues_analytics_spec.rb'
+ - 'ee/spec/requests/api/members_spec.rb'
+ - 'ee/spec/support/helpers/license_scanning_report_helpers.rb'
+ - 'ee/spec/support/shared_examples/finders/security/findings_finder_shared_examples.rb'
+ - 'lib/gitlab/ci/pipeline/chain/create_deployments.rb'
+ - 'lib/gitlab/ci/pipeline/chain/ensure_environments.rb'
+ - 'lib/gitlab/ci/pipeline/chain/ensure_resource_groups.rb'
+ - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb'
+ - 'lib/gitlab/diff/file_collection/base.rb'
+ - 'lib/gitlab/instrumentation/redis_cluster_validator.rb'
+ - 'lib/gitlab/testing/request_inspector_middleware.rb'
+ - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb'
+ - 'qa/qa/resource/base.rb'
+ - 'qa/qa/tools/ci/non_empty_suites.rb'
+ - 'spec/controllers/projects/issues_controller_spec.rb'
+ - 'spec/lib/bulk_imports/groups/stage_spec.rb'
+ - 'spec/lib/bulk_imports/projects/stage_spec.rb'
+ - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb'
+ - 'spec/models/ci/pipeline_spec.rb'
+ - 'spec/requests/api/graphql/ci/pipelines_spec.rb'
+ - 'spec/requests/api/projects_spec.rb'
+ - 'spec/services/ci/create_pipeline_service/evaluate_runner_tags_spec.rb'
+ - 'spec/services/git/process_ref_changes_service_spec.rb'
+ - 'spec/support/shared_examples/models/with_debian_distributions_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/graphql/issue_list_shared_examples.rb'
diff --git a/.rubocop_todo/performance/map_compact.yml b/.rubocop_todo/performance/map_compact.yml
new file mode 100644
index 00000000000..57ebe251798
--- /dev/null
+++ b/.rubocop_todo/performance/map_compact.yml
@@ -0,0 +1,148 @@
+---
+# Cop supports --autocorrect.
+Performance/MapCompact:
+ Details: grace period
+ Exclude:
+ - 'app/graphql/resolvers/concerns/resolves_ids.rb'
+ - 'app/graphql/resolvers/todos_resolver.rb'
+ - 'app/helpers/issuables_description_templates_helper.rb'
+ - 'app/helpers/notifications_helper.rb'
+ - 'app/models/ci/build_dependencies.rb'
+ - 'app/models/ci/pipeline.rb'
+ - 'app/models/ci/runner.rb'
+ - 'app/models/ci_platform_metric.rb'
+ - 'app/models/concerns/mentionable/reference_regexes.rb'
+ - 'app/models/concerns/pg_full_text_searchable.rb'
+ - 'app/models/container_repository.rb'
+ - 'app/models/design_management/design_at_version.rb'
+ - 'app/models/design_management/version.rb'
+ - 'app/models/environment.rb'
+ - 'app/models/environment_status.rb'
+ - 'app/models/instance_configuration.rb'
+ - 'app/models/integrations/chat_message/pipeline_message.rb'
+ - 'app/models/repository.rb'
+ - 'app/models/resource_label_event.rb'
+ - 'app/models/snippet_repository.rb'
+ - 'app/models/web_ide_terminal.rb'
+ - 'app/presenters/packages/conan/package_presenter.rb'
+ - 'app/presenters/packages/nuget/packages_metadata_presenter.rb'
+ - 'app/presenters/packages/nuget/search_results_presenter.rb'
+ - 'app/serializers/analytics/cycle_analytics/event_entity.rb'
+ - 'app/services/auth/container_registry_authentication_service.rb'
+ - 'app/services/events/render_service.rb'
+ - 'app/services/feature_flags/update_service.rb'
+ - 'app/services/git/base_hooks_service.rb'
+ - 'app/services/google_cloud/fetch_google_ip_list_service.rb'
+ - 'app/services/jira_import/start_import_service.rb'
+ - 'app/services/jira_import/users_mapper_service.rb'
+ - 'app/services/labels/available_labels_service.rb'
+ - 'app/services/merge_requests/get_urls_service.rb'
+ - 'app/services/merge_requests/pushed_branches_service.rb'
+ - 'app/services/merge_requests/update_service.rb'
+ - 'app/services/packages/maven/find_or_create_package_service.rb'
+ - 'app/services/projects/container_repository/third_party/delete_tags_service.rb'
+ - 'app/services/projects/update_statistics_service.rb'
+ - 'app/services/quick_actions/interpret_service.rb'
+ - 'app/services/repositories/changelog_service.rb'
+ - 'app/services/todos/allowed_target_filter_service.rb'
+ - 'config/initializers/trusted_proxies.rb'
+ - 'config/initializers/wikicloth_redos_patch.rb'
+ - 'ee/app/finders/security/findings_finder.rb'
+ - 'ee/app/graphql/ee/types/issue_connection_type.rb'
+ - 'ee/app/models/app_sec/fuzzing/api/ci_configuration.rb'
+ - 'ee/app/models/burndown.rb'
+ - 'ee/app/models/concerns/ee/project_security_scanners_information.rb'
+ - 'ee/app/models/concerns/elastic/application_versioned_search.rb'
+ - 'ee/app/models/gitlab_subscriptions/features.rb'
+ - 'ee/app/models/sca/license_compliance.rb'
+ - 'ee/app/services/app_sec/dast/profiles/create_associations_service.rb'
+ - 'ee/app/services/app_sec/dast/scan_configs/fetch_service.rb'
+ - 'ee/app/services/epic_issues/create_service.rb'
+ - 'ee/app/services/members/activate_service.rb'
+ - 'ee/app/services/security/override_uuids_service.rb'
+ - 'ee/app/services/security/store_scan_service.rb'
+ - 'ee/app/services/upcoming_reconciliations/update_service.rb'
+ - 'ee/app/services/vulnerabilities/findings/find_or_create_from_security_finding_service.rb'
+ - 'ee/app/workers/geo/scheduler/scheduler_worker.rb'
+ - 'ee/db/fixtures/development/30_customizable_cycle_analytics.rb'
+ - 'ee/lib/ee/api/entities/experiment.rb'
+ - 'ee/lib/ee/banzai/filter/references/iteration_reference_filter.rb'
+ - 'ee/lib/ee/gitlab/auth/ldap/person.rb'
+ - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb'
+ - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb'
+ - 'ee/lib/elastic/latest/repository_instance_proxy.rb'
+ - 'ee/lib/gitlab/alert_management/alert_payload_field_extractor.rb'
+ - 'ee/lib/gitlab/ci/parsers/security/dast.rb'
+ - 'ee/lib/gitlab/ci/reports/license_scanning/report.rb'
+ - 'ee/lib/gitlab/ci/reports/metrics/reports_comparer.rb'
+ - 'ee/lib/gitlab/search/aggregation_parser.rb'
+ - 'ee/spec/models/analytics/issues_analytics_spec.rb'
+ - 'ee/spec/models/member_spec.rb'
+ - 'ee/spec/requests/api/audit_events_spec.rb'
+ - 'ee/spec/requests/api/search_spec.rb'
+ - 'haml_lint/linter/no_plain_nodes.rb'
+ - 'lib/api/entities/feature.rb'
+ - 'lib/api/entities/project.rb'
+ - 'lib/api/helpers/common_helpers.rb'
+ - 'lib/atlassian/jira_connect/client.rb'
+ - 'lib/atlassian/jira_connect/serializers/feature_flag_entity.rb'
+ - 'lib/banzai/filter/image_link_filter.rb'
+ - 'lib/banzai/filter/references/design_reference_filter.rb'
+ - 'lib/banzai/filter/references/label_reference_filter.rb'
+ - 'lib/banzai/filter/references/milestone_reference_filter.rb'
+ - 'lib/banzai/reference_parser/issuable_parser.rb'
+ - 'lib/error_tracking/sentry_client/pagination_parser.rb'
+ - 'lib/gitaly/server.rb'
+ - 'lib/gitlab/analytics/cycle_analytics/aggregated/records_fetcher.rb'
+ - 'lib/gitlab/analytics/usage_trends/workers_argument_builder.rb'
+ - 'lib/gitlab/auth/ip_rate_limiter.rb'
+ - 'lib/gitlab/background_migration/backfill_project_repositories.rb'
+ - 'lib/gitlab/changes_list.rb'
+ - 'lib/gitlab/checks/changes_access.rb'
+ - 'lib/gitlab/ci/parsers/security/common.rb'
+ - 'lib/gitlab/ci/reports/security/aggregated_report.rb'
+ - 'lib/gitlab/ci/reports/security/finding.rb'
+ - 'lib/gitlab/ci/reports/test_suite_summary.rb'
+ - 'lib/gitlab/config/entry/validators.rb'
+ - 'lib/gitlab/database/load_balancing/service_discovery.rb'
+ - 'lib/gitlab/database/obsolete_ignored_columns.rb'
+ - 'lib/gitlab/email/receiver.rb'
+ - 'lib/gitlab/git/commit.rb'
+ - 'lib/gitlab/git/conflict/file.rb'
+ - 'lib/gitlab/git/rugged_impl/commit.rb'
+ - 'lib/gitlab/github_import/importer/pull_requests/review_request_importer.rb'
+ - 'lib/gitlab/issuable/clone/copy_resource_events_service.rb'
+ - 'lib/gitlab/issues/rebalancing/state.rb'
+ - 'lib/gitlab/jira_import/metadata_collector.rb'
+ - 'lib/gitlab/json_cache.rb'
+ - 'lib/gitlab/language_detection.rb'
+ - 'lib/gitlab/legacy_github_import/importer.rb'
+ - 'lib/gitlab/private_commit_email.rb'
+ - 'lib/gitlab/sql/pattern.rb'
+ - 'lib/gitlab/url_blocker.rb'
+ - 'lib/gitlab/verify/batch_verifier.rb'
+ - 'qa/qa/page/component/issuable/sidebar.rb'
+ - 'qa/qa/specs/features/api/1_manage/migration/gitlab_migration_large_project_spec.rb'
+ - 'qa/qa/support/formatters/test_metrics_formatter.rb'
+ - 'qa/qa/tools/ci/ff_changes.rb'
+ - 'scripts/lint_templates_bash.rb'
+ - 'spec/controllers/every_controller_spec.rb'
+ - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb'
+ - 'spec/lib/api/every_api_endpoint_spec.rb'
+ - 'spec/lib/banzai/pipeline/plain_markdown_pipeline_spec.rb'
+ - 'spec/lib/gitlab/conflict/file_spec.rb'
+ - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb'
+ - 'spec/lib/gitlab/import_export/references_configuration_spec.rb'
+ - 'spec/models/deployment_spec.rb'
+ - 'spec/models/network/graph_spec.rb'
+ - 'spec/models/repository_spec.rb'
+ - 'spec/requests/api/commits_spec.rb'
+ - 'spec/requests/api/groups_spec.rb'
+ - 'spec/requests/lfs_http_spec.rb'
+ - 'spec/serializers/diff_file_entity_spec.rb'
+ - 'spec/services/projects/container_repository/third_party/cleanup_tags_service_spec.rb'
+ - 'spec/support/helpers/dns_helpers.rb'
+ - 'spec/support/helpers/graphql_helpers.rb'
+ - 'spec/support/shared_examples/features/navbar_shared_examples.rb'
+ - 'spec/support/shared_examples/lib/gitlab/config/inheritable_shared_examples.rb'
+ - 'spec/support/shared_examples/models/label_note_shared_examples.rb'
diff --git a/.rubocop_todo/performance/redundant_equality_comparison_block.yml b/.rubocop_todo/performance/redundant_equality_comparison_block.yml
new file mode 100644
index 00000000000..44da9710249
--- /dev/null
+++ b/.rubocop_todo/performance/redundant_equality_comparison_block.yml
@@ -0,0 +1,23 @@
+---
+# Cop supports --autocorrect.
+Performance/RedundantEqualityComparisonBlock:
+ Details: grace period
+ Exclude:
+ - 'app/graphql/types/work_item_id_type.rb'
+ - 'app/models/concerns/group_descendant.rb'
+ - 'app/models/concerns/id_in_ordered.rb'
+ - 'app/models/todo.rb'
+ - 'app/validators/feature_flag_strategies_validator.rb'
+ - 'ee/app/helpers/ee/dashboard_helper.rb'
+ - 'ee/lib/compliance_management/merge_request_approval_settings/resolver.rb'
+ - 'ee/lib/elastic/latest/user_instance_proxy.rb'
+ - 'ee/lib/gitlab/geo/geo_node_status_check.rb'
+ - 'ee/spec/lib/ee/sidebars/projects/panel_spec.rb'
+ - 'lib/gitlab/ci/config/yaml/tags/reference.rb'
+ - 'lib/gitlab/config/entry/validators.rb'
+ - 'lib/gitlab/i18n/translation_entry.rb'
+ - 'lib/gitlab/push_options.rb'
+ - 'lib/gitlab/utils/delegator_override.rb'
+ - 'lib/gitlab/view/presenter/base.rb'
+ - 'spec/lib/object_storage/direct_upload_spec.rb'
+ - 'spec/support/import_export/project_tree_expectations.rb'
diff --git a/.rubocop_todo/performance/redundant_split_regexp_argument.yml b/.rubocop_todo/performance/redundant_split_regexp_argument.yml
new file mode 100644
index 00000000000..0c0e12480d5
--- /dev/null
+++ b/.rubocop_todo/performance/redundant_split_regexp_argument.yml
@@ -0,0 +1,8 @@
+---
+# Cop supports --autocorrect.
+Performance/RedundantSplitRegexpArgument:
+ Details: grace period
+ Exclude:
+ - 'lib/file_size_validator.rb'
+ - 'lib/gitlab/git/raw_diff_change.rb'
+ - 'lib/kramdown/converter/commonmark.rb'
diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml
index 0a652631e0b..2b01db2e440 100644
--- a/.rubocop_todo/rails/file_path.yml
+++ b/.rubocop_todo/rails/file_path.yml
@@ -8,8 +8,6 @@ Rails/FilePath:
- 'app/models/concerns/cross_database_modification.rb'
- 'app/models/release_highlight.rb'
- 'app/serializers/review_app_setup_entity.rb'
- - 'app/services/clusters/aws/fetch_credentials_service.rb'
- - 'app/services/clusters/aws/provision_service.rb'
- 'app/services/metrics/sample_metrics_service.rb'
- 'app/services/projects/readme_renderer_service.rb'
- 'config/environments/development.rb'
@@ -17,7 +15,6 @@ Rails/FilePath:
- 'config/initializers/7_prometheus_metrics.rb'
- 'config/initializers/lograge.rb'
- 'config/initializers_before_autoloader/001_fast_gettext.rb'
- - 'db/migrate/20210517144856_require_snapshot_namespace.rb'
- 'db/post_migrate/20210630025020_migrate_push_event_payloads_event_id_back_to_integer_for_gitlab_com.rb'
- 'ee/app/helpers/ee/application_helper.rb'
- 'ee/app/services/security/security_orchestration_policies/project_create_service.rb'
@@ -126,8 +123,6 @@ Rails/FilePath:
- 'spec/requests/api/internal/mail_room_spec.rb'
- 'spec/requests/api/usage_data_queries_spec.rb'
- 'spec/serializers/review_app_setup_entity_spec.rb'
- - 'spec/services/clusters/aws/fetch_credentials_service_spec.rb'
- - 'spec/services/clusters/aws/provision_service_spec.rb'
- 'spec/services/metrics/sample_metrics_service_spec.rb'
- 'spec/support/helpers/doc_url_helper.rb'
- 'spec/support/helpers/test_env.rb'
diff --git a/.rubocop_todo/rails/inverse_of.yml b/.rubocop_todo/rails/inverse_of.yml
index a1f49aaf2f5..5ec863fdb25 100644
--- a/.rubocop_todo/rails/inverse_of.yml
+++ b/.rubocop_todo/rails/inverse_of.yml
@@ -29,10 +29,10 @@ Rails/InverseOf:
- 'app/models/clusters/project.rb'
- 'app/models/commit_signatures/x509_commit_signature.rb'
- 'app/models/commit_status.rb'
- - 'app/models/concerns/analytics/cycle_analytics/stage.rb'
- 'app/models/concerns/awardable.rb'
- 'app/models/concerns/commit_signature.rb'
- 'app/models/concerns/with_uploads.rb'
+ - 'app/models/concerns/work_item_resource_event.rb'
- 'app/models/custom_emoji.rb'
- 'app/models/customer_relations/contact.rb'
- 'app/models/customer_relations/organization.rb'
@@ -70,8 +70,6 @@ Rails/InverseOf:
- 'app/models/work_item.rb'
- 'app/models/x509_certificate.rb'
- 'ee/app/models/allowed_email_domain.rb'
- - 'ee/app/models/analytics/cycle_analytics/group_stage.rb'
- - 'ee/app/models/analytics/cycle_analytics/group_value_stream.rb'
- 'ee/app/models/analytics/devops_adoption/enabled_namespace.rb'
- 'ee/app/models/analytics/devops_adoption/snapshot.rb'
- 'ee/app/models/audit_events/external_audit_event_destination.rb'
diff --git a/.rubocop_todo/rails/negate_include.yml b/.rubocop_todo/rails/negate_include.yml
index 74f469f325b..14e5ceae628 100644
--- a/.rubocop_todo/rails/negate_include.yml
+++ b/.rubocop_todo/rails/negate_include.yml
@@ -51,6 +51,5 @@ Rails/NegateInclude:
- 'spec/lib/gitlab/metrics/dashboard/stages/metric_endpoint_inserter_spec.rb'
- 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb'
- 'spec/support/matchers/pushed_frontend_feature_flags_matcher.rb'
- - 'spec/support/shared_contexts/markdown_golden_master_shared_examples.rb'
- 'spec/uploaders/object_storage_spec.rb'
- 'tooling/danger/specs.rb'
diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml
index e094a3397a6..307e6f59800 100644
--- a/.rubocop_todo/rails/pluck.yml
+++ b/.rubocop_todo/rails/pluck.yml
@@ -49,7 +49,6 @@ Rails/Pluck:
- 'ee/spec/graphql/types/vulnerability_scanner_type_spec.rb'
- 'ee/spec/helpers/ee/geo_helper_spec.rb'
- 'ee/spec/helpers/ee/operations_helper_spec.rb'
- - 'ee/spec/lib/ee/gitlab/import_export/group/legacy_tree_saver_spec.rb'
- 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb'
- 'ee/spec/lib/gitlab/custom_file_templates_spec.rb'
- 'ee/spec/lib/gitlab/spdx/catalogue_spec.rb'
@@ -186,7 +185,6 @@ Rails/Pluck:
- 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb'
- 'spec/lib/gitlab/git/blame_spec.rb'
- 'spec/lib/gitlab/git/conflict/parser_spec.rb'
- - 'spec/lib/gitlab/import_export/group/legacy_tree_saver_spec.rb'
- 'spec/lib/gitlab/import_export/project/sample/relation_tree_restorer_spec.rb'
- 'spec/lib/gitlab/import_export/project/tree_saver_spec.rb'
- 'spec/lib/gitlab/language_detection_spec.rb'
@@ -285,14 +283,12 @@ Rails/Pluck:
- 'spec/serializers/stage_entity_spec.rb'
- 'spec/services/ci/compare_test_reports_service_spec.rb'
- 'spec/services/ci/pipeline_processing/atomic_processing_service/status_collection_spec.rb'
- - 'spec/services/clusters/applications/prometheus_config_service_spec.rb'
- 'spec/services/issues/export_csv_service_spec.rb'
- 'spec/services/metrics/dashboard/custom_metric_embed_service_spec.rb'
- 'spec/services/projects/participants_service_spec.rb'
- 'spec/support/helpers/api_helpers.rb'
- 'spec/support/helpers/graphql_helpers.rb'
- 'spec/support/matchers/background_migrations_matchers.rb'
- - 'spec/support/shared_contexts/markdown_golden_master_shared_examples.rb'
- 'spec/support/shared_examples/graphql/mutation_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/container_repositories_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/custom_attributes_shared_examples.rb'
diff --git a/.rubocop_todo/rails/redundant_foreign_key.yml b/.rubocop_todo/rails/redundant_foreign_key.yml
index 3251429876e..3a7c4a3754e 100644
--- a/.rubocop_todo/rails/redundant_foreign_key.yml
+++ b/.rubocop_todo/rails/redundant_foreign_key.yml
@@ -18,7 +18,6 @@ Rails/RedundantForeignKey:
- 'app/models/clusters/concerns/application_core.rb'
- 'app/models/clusters/integrations/prometheus.rb'
- 'app/models/commit_signatures/x509_commit_signature.rb'
- - 'app/models/concerns/analytics/cycle_analytics/stage.rb'
- 'app/models/concerns/commit_signature.rb'
- 'app/models/concerns/integrations/base_data_fields.rb'
- 'app/models/group.rb'
diff --git a/.rubocop_todo/rspec/any_instance_of.yml b/.rubocop_todo/rspec/any_instance_of.yml
index f24fbbfbed2..e589d9ed9c6 100644
--- a/.rubocop_todo/rspec/any_instance_of.yml
+++ b/.rubocop_todo/rspec/any_instance_of.yml
@@ -2,24 +2,7 @@
# Cop supports --autocorrect.
RSpec/AnyInstanceOf:
Exclude:
- - 'ee/spec/controllers/admin/geo/nodes_controller_spec.rb'
- - 'ee/spec/controllers/ee/groups_controller_spec.rb'
- - 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb'
- - 'ee/spec/controllers/groups/epics/notes_controller_spec.rb'
- - 'ee/spec/controllers/groups/omniauth_callbacks_controller_spec.rb'
- - 'ee/spec/controllers/oauth/geo_auth_controller_spec.rb'
- - 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb'
- - 'ee/spec/controllers/projects/merge_requests_controller_spec.rb'
- - 'ee/spec/controllers/projects/path_locks_controller_spec.rb'
- - 'ee/spec/controllers/projects_controller_spec.rb'
- - 'ee/spec/controllers/subscriptions_controller_spec.rb'
- - 'ee/spec/features/admin/admin_audit_logs_spec.rb'
- - 'ee/spec/features/admin/admin_reset_pipeline_minutes_spec.rb'
- - 'ee/spec/features/admin/admin_users_spec.rb'
- - 'ee/spec/features/ci_shared_runner_warnings_spec.rb'
- - 'ee/spec/features/groups/group_settings_spec.rb'
- 'ee/spec/features/issues/form_spec.rb'
- - 'ee/spec/features/merge_request/user_creates_merge_request_spec.rb'
- 'ee/spec/features/projects/new_project_spec.rb'
- 'ee/spec/features/registrations/welcome_spec.rb'
- 'ee/spec/features/security/project/internal_access_spec.rb'
@@ -378,7 +361,6 @@ RSpec/AnyInstanceOf:
- 'spec/workers/build_hooks_worker_spec.rb'
- 'spec/workers/ci/build_schedule_worker_spec.rb'
- 'spec/workers/ci/daily_build_group_report_results_worker_spec.rb'
- - 'spec/workers/cluster_provision_worker_spec.rb'
- 'spec/workers/clusters/cleanup/project_namespace_worker_spec.rb'
- 'spec/workers/clusters/cleanup/service_account_worker_spec.rb'
- 'spec/workers/concerns/project_import_options_spec.rb'
@@ -398,4 +380,3 @@ RSpec/AnyInstanceOf:
- 'spec/workers/pipeline_schedule_worker_spec.rb'
- 'spec/workers/project_cache_worker_spec.rb'
- 'spec/workers/stage_update_worker_spec.rb'
- - 'spec/workers/wait_for_cluster_creation_worker_spec.rb'
diff --git a/.rubocop_todo/rspec/capybara/visibility_matcher.yml b/.rubocop_todo/rspec/capybara/visibility_matcher.yml
index f9e8c982903..5f35e5d90f7 100644
--- a/.rubocop_todo/rspec/capybara/visibility_matcher.yml
+++ b/.rubocop_todo/rspec/capybara/visibility_matcher.yml
@@ -46,7 +46,6 @@ RSpec/Capybara/VisibilityMatcher:
- 'spec/features/projects/issues/design_management/user_views_designs_with_svg_xss_spec.rb'
- 'spec/features/projects/jobs_spec.rb'
- 'spec/features/projects/network_graph_spec.rb'
- - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb'
- 'spec/features/projects/pipelines/pipeline_spec.rb'
- 'spec/features/projects/settings/lfs_settings_spec.rb'
- 'spec/features/projects/settings/packages_settings_spec.rb'
diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml
index 5a01f229482..ccadc31c974 100644
--- a/.rubocop_todo/rspec/context_wording.yml
+++ b/.rubocop_todo/rspec/context_wording.yml
@@ -47,7 +47,6 @@ RSpec/ContextWording:
- 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb'
- 'ee/spec/controllers/projects/integrations/zentao/issues_controller_spec.rb'
- 'ee/spec/controllers/projects/issues_controller_spec.rb'
- - 'ee/spec/controllers/projects/legacy_pipelines_controller_spec.rb'
- 'ee/spec/controllers/projects/merge_requests/creations_controller_spec.rb'
- 'ee/spec/controllers/projects/merge_requests_controller_spec.rb'
- 'ee/spec/controllers/projects/mirrors_controller_spec.rb'
@@ -59,7 +58,6 @@ RSpec/ContextWording:
- 'ee/spec/controllers/projects/settings/repository_controller_spec.rb'
- 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb'
- 'ee/spec/controllers/projects_controller_spec.rb'
- - 'ee/spec/controllers/registrations/welcome_controller_spec.rb'
- 'ee/spec/controllers/repositories/git_http_controller_spec.rb'
- 'ee/spec/controllers/security/dashboard_controller_spec.rb'
- 'ee/spec/controllers/security/vulnerabilities_controller_spec.rb'
@@ -156,7 +154,6 @@ RSpec/ContextWording:
- 'ee/spec/features/projects/milestones/milestone_spec.rb'
- 'ee/spec/features/projects/new_project_from_template_spec.rb'
- 'ee/spec/features/projects/new_project_spec.rb'
- - 'ee/spec/features/projects/pipelines/legacy_pipeline_spec.rb'
- 'ee/spec/features/projects/pipelines/pipeline_spec.rb'
- 'ee/spec/features/projects/push_rules_spec.rb'
- 'ee/spec/features/projects/quality/test_case_create_spec.rb'
@@ -284,7 +281,6 @@ RSpec/ContextWording:
- 'ee/spec/helpers/ee/operations_helper_spec.rb'
- 'ee/spec/helpers/ee/personal_access_tokens_helper_spec.rb'
- 'ee/spec/helpers/ee/projects/security/api_fuzzing_configuration_helper_spec.rb'
- - 'ee/spec/helpers/ee/welcome_helper_spec.rb'
- 'ee/spec/helpers/groups/security_features_helper_spec.rb'
- 'ee/spec/helpers/license_helper_spec.rb'
- 'ee/spec/helpers/license_monitoring_helper_spec.rb'
@@ -335,8 +331,6 @@ RSpec/ContextWording:
- 'ee/spec/lib/ee/gitlab/group_search_results_spec.rb'
- 'ee/spec/lib/ee/gitlab/hook_data/group_member_builder_spec.rb'
- 'ee/spec/lib/ee/gitlab/hook_data/user_builder_spec.rb'
- - 'ee/spec/lib/ee/gitlab/import_export/group/legacy_tree_restorer_spec.rb'
- - 'ee/spec/lib/ee/gitlab/import_export/group/legacy_tree_saver_spec.rb'
- 'ee/spec/lib/ee/gitlab/import_export/group/tree_restorer_spec.rb'
- 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb'
- 'ee/spec/lib/ee/gitlab/import_export/project/tree_saver_spec.rb'
@@ -441,7 +435,6 @@ RSpec/ContextWording:
- 'ee/spec/migrations/schedule_requirements_migration_spec.rb'
- 'ee/spec/models/alert_management/alert_payload_field_spec.rb'
- 'ee/spec/models/allowed_email_domain_spec.rb'
- - 'ee/spec/models/analytics/cycle_analytics/group_stage_spec.rb'
- 'ee/spec/models/analytics/cycle_analytics/project_stage_spec.rb'
- 'ee/spec/models/application_setting_spec.rb'
- 'ee/spec/models/approval_merge_request_rule_spec.rb'
@@ -639,7 +632,6 @@ RSpec/ContextWording:
- 'ee/spec/requests/api/projects_spec.rb'
- 'ee/spec/requests/api/protected_branches_spec.rb'
- 'ee/spec/requests/api/releases_spec.rb'
- - 'ee/spec/requests/api/scim_spec.rb'
- 'ee/spec/requests/api/search_spec.rb'
- 'ee/spec/requests/api/settings_spec.rb'
- 'ee/spec/requests/api/status_checks_spec.rb'
@@ -926,7 +918,6 @@ RSpec/ContextWording:
- 'ee/spec/views/layouts/nav/sidebar/_push_rules_link.html.haml_spec.rb'
- 'ee/spec/views/profiles/preferences/show.html.haml_spec.rb'
- 'ee/spec/views/projects/security/discover/show.html.haml_spec.rb'
- - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb'
- 'ee/spec/views/search/_category.html.haml_spec.rb'
- 'ee/spec/views/shared/_clone_panel.html.haml_spec.rb'
- 'ee/spec/views/shared/_kerberos_clone_button.html.haml_spec.rb'
@@ -984,7 +975,6 @@ RSpec/ContextWording:
- 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/license_spec.rb'
- - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/free_tier_group_namespace_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb'
@@ -1121,7 +1111,6 @@ RSpec/ContextWording:
- 'spec/controllers/projects/tree_controller_spec.rb'
- 'spec/controllers/projects/web_ide_terminals_controller_spec.rb'
- 'spec/controllers/projects_controller_spec.rb'
- - 'spec/controllers/registrations/welcome_controller_spec.rb'
- 'spec/controllers/registrations_controller_spec.rb'
- 'spec/controllers/root_controller_spec.rb'
- 'spec/controllers/search_controller_spec.rb'
@@ -1328,8 +1317,6 @@ RSpec/ContextWording:
- 'spec/features/projects/packages_spec.rb'
- 'spec/features/projects/pages/user_edits_settings_spec.rb'
- 'spec/features/projects/pipeline_schedules_spec.rb'
- - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb'
- - 'spec/features/projects/pipelines/legacy_pipelines_spec.rb'
- 'spec/features/projects/pipelines/pipeline_spec.rb'
- 'spec/features/projects/pipelines/pipelines_spec.rb'
- 'spec/features/projects/releases/user_views_releases_spec.rb'
@@ -1974,8 +1961,6 @@ RSpec/ContextWording:
- 'spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb'
- 'spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb'
- 'spec/lib/gitlab/import_export/file_importer_spec.rb'
- - 'spec/lib/gitlab/import_export/group/legacy_tree_restorer_spec.rb'
- - 'spec/lib/gitlab/import_export/group/legacy_tree_saver_spec.rb'
- 'spec/lib/gitlab/import_export/group/object_builder_spec.rb'
- 'spec/lib/gitlab/import_export/group/relation_factory_spec.rb'
- 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb'
@@ -2342,7 +2327,6 @@ RSpec/ContextWording:
- 'spec/models/internal_id_spec.rb'
- 'spec/models/issue/metrics_spec.rb'
- 'spec/models/issue_assignee_spec.rb'
- - 'spec/models/issue_collection_spec.rb'
- 'spec/models/issue_spec.rb'
- 'spec/models/jira_import_state_spec.rb'
- 'spec/models/key_spec.rb'
@@ -2725,7 +2709,6 @@ RSpec/ContextWording:
- 'spec/services/branches/validate_new_service_spec.rb'
- 'spec/services/bulk_create_integration_service_spec.rb'
- 'spec/services/chat_names/find_user_service_spec.rb'
- - 'spec/services/ci/after_requeue_job_service_spec.rb'
- 'spec/services/ci/append_build_trace_service_spec.rb'
- 'spec/services/ci/archive_trace_service_spec.rb'
- 'spec/services/ci/compare_test_reports_service_spec.rb'
@@ -2759,16 +2742,8 @@ RSpec/ContextWording:
- 'spec/services/clusters/agent_tokens/track_usage_service_spec.rb'
- 'spec/services/clusters/agents/delete_expired_events_service_spec.rb'
- 'spec/services/clusters/agents/refresh_authorization_service_spec.rb'
- - 'spec/services/clusters/applications/install_service_spec.rb'
- - 'spec/services/clusters/applications/upgrade_service_spec.rb'
- - 'spec/services/clusters/aws/authorize_role_service_spec.rb'
- - 'spec/services/clusters/aws/fetch_credentials_service_spec.rb'
- - 'spec/services/clusters/aws/finalize_creation_service_spec.rb'
- - 'spec/services/clusters/aws/provision_service_spec.rb'
- - 'spec/services/clusters/aws/verify_provision_status_service_spec.rb'
- 'spec/services/clusters/build_kubernetes_namespace_service_spec.rb'
- 'spec/services/clusters/create_service_spec.rb'
- - 'spec/services/clusters/gcp/finalize_creation_service_spec.rb'
- 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb'
- 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb'
- 'spec/services/clusters/management/validate_management_project_permissions_service_spec.rb'
@@ -3074,7 +3049,6 @@ RSpec/ContextWording:
- 'spec/support/shared_contexts/lib/gitlab/sidekiq_logging/structured_logger_shared_context.rb'
- 'spec/support/shared_contexts/lib/gitlab/sidekiq_middleware/server_metrics_shared_context.rb'
- 'spec/support/shared_contexts/mailers/notify_shared_context.rb'
- - 'spec/support/shared_contexts/markdown_golden_master_shared_examples.rb'
- 'spec/support/shared_contexts/merge_request_create_shared_context.rb'
- 'spec/support/shared_contexts/merge_request_edit_shared_context.rb'
- 'spec/support/shared_contexts/merge_requests_allowing_collaboration_shared_context.rb'
diff --git a/.rubocop_todo/rspec/described_class.yml b/.rubocop_todo/rspec/described_class.yml
index 729423d8abd..b60fca01288 100644
--- a/.rubocop_todo/rspec/described_class.yml
+++ b/.rubocop_todo/rspec/described_class.yml
@@ -145,7 +145,6 @@ RSpec/DescribedClass:
- 'spec/lib/sidebars/panel_spec.rb'
- 'spec/mailers/emails/service_desk_spec.rb'
- 'spec/metrics_server/metrics_server_spec.rb'
- - 'spec/migrations/remove_records_without_group_from_webhooks_table_spec.rb'
- 'spec/models/active_session_spec.rb'
- 'spec/models/alert_management/alert_spec.rb'
- 'spec/models/application_record_spec.rb'
diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml
index 23bb61a5d68..24db05a5004 100644
--- a/.rubocop_todo/rspec/expect_change.yml
+++ b/.rubocop_todo/rspec/expect_change.yml
@@ -81,7 +81,6 @@ RSpec/ExpectChange:
- 'ee/spec/requests/groups/protected_environments_controller_spec.rb'
- 'ee/spec/requests/groups_controller_spec.rb'
- 'ee/spec/requests/registrations/project_creation_spec.rb'
- - 'ee/spec/requests/registrations_controller_spec.rb'
- 'ee/spec/services/app_sec/dast/scanner_profiles/create_service_spec.rb'
- 'ee/spec/services/app_sec/dast/scans/run_service_spec.rb'
- 'ee/spec/services/app_sec/dast/site_profiles/create_service_spec.rb'
@@ -291,7 +290,6 @@ RSpec/ExpectChange:
- 'spec/migrations/20221018050323_add_objective_and_keyresult_to_work_item_types_spec.rb'
- 'spec/migrations/20221018193635_ensure_task_note_renaming_background_migration_finished_spec.rb'
- 'spec/migrations/20221102090940_create_next_ci_partitions_record_spec.rb'
- - 'spec/migrations/backfill_escalation_policies_for_oncall_schedules_spec.rb'
- 'spec/migrations/cleanup_mr_attention_request_todos_spec.rb'
- 'spec/migrations/cleanup_vulnerability_state_transitions_with_same_from_state_to_state_spec.rb'
- 'spec/migrations/delete_migrate_shared_vulnerability_scanners_spec.rb'
diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml
index aa0f5f005d7..7fc5bdbdb6d 100644
--- a/.rubocop_todo/rspec/expect_in_hook.yml
+++ b/.rubocop_todo/rspec/expect_in_hook.yml
@@ -25,7 +25,6 @@ RSpec/ExpectInHook:
- 'ee/spec/helpers/ee/integrations_helper_spec.rb'
- 'ee/spec/helpers/ee/issues_helper_spec.rb'
- 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb'
- - 'ee/spec/helpers/ee/welcome_helper_spec.rb'
- 'ee/spec/helpers/kerberos_helper_spec.rb'
- 'ee/spec/helpers/vulnerabilities_helper_spec.rb'
- 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb'
@@ -302,7 +301,6 @@ RSpec/ExpectInHook:
- 'spec/lib/sidebars/projects/menus/external_wiki_menu_spec.rb'
- 'spec/mailers/emails/service_desk_spec.rb'
- 'spec/metrics_server/metrics_server_spec.rb'
- - 'spec/migrations/20210406144743_backfill_total_tuple_count_for_batched_migrations_spec.rb'
- 'spec/models/ability_spec.rb'
- 'spec/models/application_setting_spec.rb'
- 'spec/models/ci/build_spec.rb'
@@ -387,9 +385,6 @@ RSpec/ExpectInHook:
- 'spec/services/ci/job_artifacts/destroy_all_expired_service_spec.rb'
- 'spec/services/ci/job_artifacts/destroy_batch_service_spec.rb'
- 'spec/services/ci/register_job_service_spec.rb'
- - 'spec/services/clusters/applications/install_service_spec.rb'
- - 'spec/services/clusters/applications/upgrade_service_spec.rb'
- - 'spec/services/clusters/aws/fetch_credentials_service_spec.rb'
- 'spec/services/clusters/integrations/prometheus_health_check_service_spec.rb'
- 'spec/services/container_expiration_policies/cleanup_service_spec.rb'
- 'spec/services/dependency_proxy/find_cached_manifest_service_spec.rb'
diff --git a/.rubocop_todo/rspec/factory_bot/avoid_create.yml b/.rubocop_todo/rspec/factory_bot/avoid_create.yml
index 3201d5a8370..c4a64f505f1 100644
--- a/.rubocop_todo/rspec/factory_bot/avoid_create.yml
+++ b/.rubocop_todo/rspec/factory_bot/avoid_create.yml
@@ -224,7 +224,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'ee/spec/views/projects/edit.html.haml_spec.rb'
- 'ee/spec/views/projects/issues/show.html.haml_spec.rb'
- 'ee/spec/views/projects/on_demand_scans/index.html.haml_spec.rb'
- - 'ee/spec/views/projects/pipelines/_tabs_content.html.haml_spec.rb'
- 'ee/spec/views/projects/project_members/index.html.haml_spec.rb'
- 'ee/spec/views/projects/security/corpus_management/show.html.haml_spec.rb'
- 'ee/spec/views/projects/security/dast_profiles/show.html.haml_spec.rb'
diff --git a/.rubocop_todo/rspec/hooks_before_examples.yml b/.rubocop_todo/rspec/hooks_before_examples.yml
index 333687e1cc4..a6291452db8 100644
--- a/.rubocop_todo/rspec/hooks_before_examples.yml
+++ b/.rubocop_todo/rspec/hooks_before_examples.yml
@@ -42,5 +42,4 @@ RSpec/HooksBeforeExamples:
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb'
- - 'qa/spec/resource/reusable_collection_spec.rb'
- 'qa/spec/specs/runner_spec.rb'
diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml
index b1b4a6c16ce..d57eb938567 100644
--- a/.rubocop_todo/rspec/instance_variable.yml
+++ b/.rubocop_todo/rspec/instance_variable.yml
@@ -113,7 +113,6 @@ RSpec/InstanceVariable:
- 'spec/lib/gitlab/git/diff_spec.rb'
- 'spec/lib/gitlab/git/repository_spec.rb'
- 'spec/lib/gitlab/http_spec.rb'
- - 'spec/lib/gitlab/import_export/group/legacy_tree_restorer_spec.rb'
- 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb'
- 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb'
- 'spec/lib/gitlab/patch/prependable_spec.rb'
diff --git a/.rubocop_todo/rspec/multiple_memoized_helpers.yml b/.rubocop_todo/rspec/multiple_memoized_helpers.yml
index e939abd2886..708543510a2 100644
--- a/.rubocop_todo/rspec/multiple_memoized_helpers.yml
+++ b/.rubocop_todo/rspec/multiple_memoized_helpers.yml
@@ -17,7 +17,6 @@ RSpec/MultipleMemoizedHelpers:
- 'spec/finders/user_recent_events_finder_spec.rb'
- 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb'
- 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb'
- - 'spec/migrations/backfill_escalation_policies_for_oncall_schedules_spec.rb'
- 'spec/models/event_spec.rb'
- 'spec/models/milestone_spec.rb'
- 'spec/models/packages/package_file_spec.rb'
diff --git a/.rubocop_todo/rspec/repeated_example_group_body.yml b/.rubocop_todo/rspec/repeated_example_group_body.yml
index 93cbe77765a..a0981240d48 100644
--- a/.rubocop_todo/rspec/repeated_example_group_body.yml
+++ b/.rubocop_todo/rspec/repeated_example_group_body.yml
@@ -22,7 +22,6 @@ RSpec/RepeatedExampleGroupBody:
- 'spec/features/issues/spam_akismet_issue_creation_spec.rb'
- 'spec/features/merge_request/user_sees_closing_issues_message_spec.rb'
- 'spec/features/projects/commit/cherry_pick_spec.rb'
- - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb'
- 'spec/features/security/project/private_access_spec.rb'
- 'spec/finders/packages/nuget/package_finder_spec.rb'
- 'spec/helpers/gitlab_routing_helper_spec.rb'
diff --git a/.rubocop_todo/rspec/repeated_example_group_description.yml b/.rubocop_todo/rspec/repeated_example_group_description.yml
index 826ac2a6838..27eea044e6c 100644
--- a/.rubocop_todo/rspec/repeated_example_group_description.yml
+++ b/.rubocop_todo/rspec/repeated_example_group_description.yml
@@ -36,7 +36,6 @@ RSpec/RepeatedExampleGroupDescription:
- 'spec/features/merge_request/user_sees_merge_widget_spec.rb'
- 'spec/features/projects/jobs_spec.rb'
- 'spec/features/projects/new_project_spec.rb'
- - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb'
- 'spec/features/security/project/private_access_spec.rb'
- 'spec/finders/ci/pipelines_for_merge_request_finder_spec.rb'
- 'spec/frontend/fixtures/startup_css.rb'
diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml
index 8fa03c775be..b880f995669 100644
--- a/.rubocop_todo/rspec/verified_doubles.yml
+++ b/.rubocop_todo/rspec/verified_doubles.yml
@@ -746,7 +746,6 @@ RSpec/VerifiedDoubles:
- 'spec/mailers/emails/service_desk_spec.rb'
- 'spec/mailers/notify_spec.rb'
- 'spec/metrics_server/metrics_server_spec.rb'
- - 'spec/migrations/20210406144743_backfill_total_tuple_count_for_batched_migrations_spec.rb'
- 'spec/models/active_session_spec.rb'
- 'spec/models/application_record_spec.rb'
- 'spec/models/badge_spec.rb'
@@ -890,9 +889,6 @@ RSpec/VerifiedDoubles:
- 'spec/services/ci/test_failure_history_service_spec.rb'
- 'spec/services/ci/update_build_queue_service_spec.rb'
- 'spec/services/ci/update_build_state_service_spec.rb'
- - 'spec/services/clusters/aws/finalize_creation_service_spec.rb'
- - 'spec/services/clusters/aws/provision_service_spec.rb'
- - 'spec/services/clusters/aws/verify_provision_status_service_spec.rb'
- 'spec/services/clusters/build_kubernetes_namespace_service_spec.rb'
- 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb'
- 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb'
diff --git a/.rubocop_todo/security/io_methods.yml b/.rubocop_todo/security/io_methods.yml
index 936bb21d5dc..445afcabb89 100644
--- a/.rubocop_todo/security/io_methods.yml
+++ b/.rubocop_todo/security/io_methods.yml
@@ -3,4 +3,3 @@
Security/IoMethods:
Details: grace period
Exclude:
- - 'db/migrate/20210301200959_init_schema.rb'
diff --git a/.rubocop_todo/style/accessor_grouping.yml b/.rubocop_todo/style/accessor_grouping.yml
index a5586813885..2eb60c08170 100644
--- a/.rubocop_todo/style/accessor_grouping.yml
+++ b/.rubocop_todo/style/accessor_grouping.yml
@@ -55,7 +55,6 @@ Style/AccessorGrouping:
- 'lib/gitlab/git/commit.rb'
- 'lib/gitlab/graphql/connection_redaction.rb'
- 'lib/gitlab/http_io.rb'
- - 'lib/gitlab/import_export/group/legacy_tree_restorer.rb'
- 'lib/gitlab/import_export/project/tree_restorer.rb'
- 'lib/gitlab/sidekiq_daemon/monitor.rb'
- 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb'
diff --git a/.rubocop_todo/style/bare_percent_literals.yml b/.rubocop_todo/style/bare_percent_literals.yml
index e98660024db..0380a2e97b8 100644
--- a/.rubocop_todo/style/bare_percent_literals.yml
+++ b/.rubocop_todo/style/bare_percent_literals.yml
@@ -59,8 +59,6 @@ Style/BarePercentLiterals:
- 'spec/features/projects/badges/pipeline_badge_spec.rb'
- 'spec/features/projects/issuable_templates_spec.rb'
- 'spec/features/projects/jobs_spec.rb'
- - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb'
- - 'spec/features/projects/pipelines/legacy_pipelines_spec.rb'
- 'spec/features/projects/pipelines/pipeline_spec.rb'
- 'spec/features/projects/pipelines/pipelines_spec.rb'
- 'spec/features/uploads/user_uploads_avatar_to_group_spec.rb'
diff --git a/.rubocop_todo/style/class_and_module_children.yml b/.rubocop_todo/style/class_and_module_children.yml
index 2303c5a1652..38116899ccd 100644
--- a/.rubocop_todo/style/class_and_module_children.yml
+++ b/.rubocop_todo/style/class_and_module_children.yml
@@ -78,7 +78,6 @@ Style/ClassAndModuleChildren:
- 'app/controllers/groups/milestones_controller.rb'
- 'app/controllers/groups/runners_controller.rb'
- 'app/controllers/groups/uploads_controller.rb'
- - 'app/controllers/import/available_namespaces_controller.rb'
- 'app/controllers/import/base_controller.rb'
- 'app/controllers/import/bitbucket_controller.rb'
- 'app/controllers/import/bitbucket_server_controller.rb'
@@ -450,7 +449,6 @@ Style/ClassAndModuleChildren:
- 'ee/app/helpers/projects/security/dast_profiles_helper.rb'
- 'ee/app/helpers/projects/security/discover_helper.rb'
- 'ee/app/helpers/projects/security/sast_configuration_helper.rb'
- - 'ee/app/models/analytics/cycle_analytics/group_value_stream.rb'
- 'ee/app/models/analytics/devops_adoption.rb'
- 'ee/app/models/analytics/devops_adoption/enabled_namespace.rb'
- 'ee/app/models/analytics/devops_adoption/snapshot.rb'
diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml
index 0c7eb5c0d92..a876b9361cb 100644
--- a/.rubocop_todo/style/empty_method.yml
+++ b/.rubocop_todo/style/empty_method.yml
@@ -49,7 +49,6 @@ Style/EmptyMethod:
- 'app/controllers/projects/terraform_controller.rb'
- 'app/controllers/projects/triggers_controller.rb'
- 'app/controllers/pwa_controller.rb'
- - 'app/controllers/registrations/welcome_controller.rb'
- 'app/controllers/search_controller.rb'
- 'app/experiments/security_actions_continuous_onboarding_experiment.rb'
- 'app/graphql/resolvers/concerns/caching_array_resolver.rb'
@@ -73,11 +72,8 @@ Style/EmptyMethod:
- 'app/services/issuable_base_service.rb'
- 'app/services/projects/transfer_service.rb'
- 'app/workers/namespaces/root_statistics_worker.rb'
- - 'db/migrate/20210420012444_change_web_hook_events_default.rb'
- - 'db/migrate/20210507191949_add_remove_on_issue_close_to_labels.rb'
- 'db/migrate/20210729123101_confirm_security_bot.rb'
- 'db/migrate/20211012134316_clean_up_migrate_merge_request_diff_commit_users.rb'
- - 'db/post_migrate/20210511095658_schedule_migrate_project_taggings_context_from_tags_to_topics.rb'
- 'db/post_migrate/20210730170823_schedule_security_setting_creation.rb'
- 'db/post_migrate/20210823132600_remove_duplicate_dast_site_tokens.rb'
- 'db/post_migrate/20210826171758_initialize_throttle_unauthenticated_api_columns.rb'
diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml
index c1ba754edca..d18cd4d24a8 100644
--- a/.rubocop_todo/style/format_string.yml
+++ b/.rubocop_todo/style/format_string.yml
@@ -3,22 +3,6 @@
Style/FormatString:
Exclude:
- 'app/components/diffs/overflow_warning_component.rb'
- - 'app/controllers/admin/application_settings_controller.rb'
- - 'app/controllers/admin/groups_controller.rb'
- - 'app/controllers/admin/impersonation_tokens_controller.rb'
- - 'app/controllers/admin/projects_controller.rb'
- - 'app/controllers/admin/spam_logs_controller.rb'
- - 'app/controllers/admin/topics_controller.rb'
- - 'app/controllers/admin/users_controller.rb'
- - 'app/controllers/concerns/access_tokens_actions.rb'
- - 'app/controllers/concerns/confirm_email_warning.rb'
- - 'app/controllers/concerns/enforces_two_factor_authentication.rb'
- - 'app/controllers/concerns/integrations/actions.rb'
- - 'app/controllers/concerns/membership_actions.rb'
- - 'app/controllers/concerns/redirects_for_missing_path_on_tree.rb'
- - 'app/controllers/concerns/spammable_actions/akismet_mark_as_spam_action.rb'
- - 'app/controllers/concerns/verifies_with_email.rb'
- - 'app/controllers/groups/settings/ci_cd_controller.rb'
- 'app/controllers/import/bitbucket_server_controller.rb'
- 'app/controllers/import/bulk_imports_controller.rb'
- 'app/controllers/import/fogbugz_controller.rb'
@@ -137,14 +121,6 @@ Style/FormatString:
- 'app/serializers/build_details_entity.rb'
- 'app/services/alert_management/alerts/update_service.rb'
- 'app/services/boards/lists/base_create_service.rb'
- - 'app/services/clusters/applications/check_progress_service.rb'
- - 'app/services/clusters/applications/install_service.rb'
- - 'app/services/clusters/applications/upgrade_service.rb'
- - 'app/services/clusters/aws/authorize_role_service.rb'
- - 'app/services/clusters/aws/finalize_creation_service.rb'
- - 'app/services/clusters/aws/verify_provision_status_service.rb'
- - 'app/services/clusters/gcp/finalize_creation_service.rb'
- - 'app/services/clusters/gcp/verify_provision_status_service.rb'
- 'app/services/concerns/update_repository_storage_methods.rb'
- 'app/services/concerns/validates_classification_label.rb'
- 'app/services/gravatar_service.rb'
@@ -259,7 +235,6 @@ Style/FormatString:
- 'ee/lib/ee/gitlab/quick_actions/epic_actions.rb'
- 'ee/lib/ee/gitlab/quick_actions/issue_actions.rb'
- 'ee/lib/ee/gitlab/quick_actions/issue_and_merge_request_actions.rb'
- - 'ee/lib/ee/gitlab/scim/deprovision_service.rb'
- 'ee/lib/gitlab/analytics/cycle_analytics/stage_events/issue_label_added.rb'
- 'ee/lib/gitlab/analytics/cycle_analytics/stage_events/issue_label_removed.rb'
- 'ee/lib/gitlab/analytics/cycle_analytics/stage_events/merge_request_label_added.rb'
@@ -348,7 +323,6 @@ Style/FormatString:
- 'spec/models/integrations/datadog_spec.rb'
- 'spec/models/serverless/domain_spec.rb'
- 'spec/requests/api/graphql/project/jira_projects_spec.rb'
- - 'spec/services/clusters/applications/upgrade_service_spec.rb'
- 'spec/services/groups/import_export/export_service_spec.rb'
- 'spec/services/projects/import_export/export_service_spec.rb'
- 'spec/support/helpers/javascript_fixtures_helpers.rb'
diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml
index 59aa38fc9f5..586f146c2ba 100644
--- a/.rubocop_todo/style/guard_clause.yml
+++ b/.rubocop_todo/style/guard_clause.yml
@@ -89,7 +89,6 @@ Style/GuardClause:
- 'app/models/clusters/cluster.rb'
- 'app/models/clusters/platforms/kubernetes.rb'
- 'app/models/commit_range.rb'
- - 'app/models/concerns/analytics/cycle_analytics/stage.rb'
- 'app/models/concerns/avatarable.rb'
- 'app/models/concerns/bulk_insert_safe.rb'
- 'app/models/concerns/cache_markdown_field.rb'
@@ -173,7 +172,6 @@ Style/GuardClause:
- 'app/services/ci/runners/register_runner_service.rb'
- 'app/services/ci/update_build_queue_service.rb'
- 'app/services/clusters/agent_tokens/track_usage_service.rb'
- - 'app/services/clusters/aws/fetch_credentials_service.rb'
- 'app/services/commits/commit_patch_service.rb'
- 'app/services/commits/create_service.rb'
- 'app/services/concerns/alert_management/alert_processing.rb'
@@ -274,7 +272,6 @@ Style/GuardClause:
- 'config/initializers/postgresql_cte.rb'
- 'config/object_store_settings.rb'
- 'danger/feature_flag/Dangerfile'
- - 'db/migrate/20210302212623_rename_vuln_fingerprints_indexes.rb'
- 'db/migrate/20210707095545_add_status_to_merge_request_cleanup_schedules.rb'
- 'db/migrate/20210816095826_add_unique_index_on_dast_profile_to_dast_profile_schedules.rb'
- 'db/migrate/20210816192041_add_invites_email_success_to_member.rb'
@@ -647,7 +644,6 @@ Style/GuardClause:
- 'qa/qa/resource/api_fabricator.rb'
- 'qa/qa/resource/package.rb'
- 'qa/qa/resource/registry_repository.rb'
- - 'qa/qa/resource/reusable.rb'
- 'qa/qa/resource/user_gpg.rb'
- 'qa/qa/runtime/feature.rb'
- 'qa/qa/runtime/search.rb'
diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml
index 5804fda39e1..515a9ddad6a 100644
--- a/.rubocop_todo/style/if_unless_modifier.yml
+++ b/.rubocop_todo/style/if_unless_modifier.yml
@@ -243,9 +243,6 @@ Style/IfUnlessModifier:
- 'app/services/ci/runners/reconcile_existing_runner_versions_service.rb'
- 'app/services/ci/runners/register_runner_service.rb'
- 'app/services/ci/update_build_state_service.rb'
- - 'app/services/clusters/applications/base_service.rb'
- - 'app/services/clusters/aws/fetch_credentials_service.rb'
- - 'app/services/clusters/gcp/provision_service.rb'
- 'app/services/clusters/update_service.rb'
- 'app/services/commits/commit_patch_service.rb'
- 'app/services/commits/create_service.rb'
@@ -407,7 +404,6 @@ Style/IfUnlessModifier:
- 'db/migrate/20210818061156_remove_project_profile_compound_index_from_dast_profile_schedules.rb'
- 'db/migrate/20210909184349_add_index_package_id_id_on_package_files.rb'
- 'db/migrate/20220324175325_add_key_data_to_secure_files.rb'
- - 'db/post_migrate/20210505092746_create_partial_covering_index_for_pending_builds.rb'
- 'db/post_migrate/20210629101712_remove_deprecated_modsecurity_columns.rb'
- 'db/post_migrate/20210713042000_fix_ci_sources_pipelines_index_names.rb'
- 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb'
@@ -631,7 +627,6 @@ Style/IfUnlessModifier:
- 'ee/lib/ee/gitlab/quick_actions/epic_actions.rb'
- 'ee/lib/ee/gitlab/quick_actions/issue_actions.rb'
- 'ee/lib/ee/gitlab/repository_size_checker.rb'
- - 'ee/lib/ee/gitlab/scim/deprovision_service.rb'
- 'ee/lib/ee/gitlab/usage_data.rb'
- 'ee/lib/ee/sidebars/groups/menus/settings_menu.rb'
- 'ee/lib/ee/sidebars/projects/menus/analytics_menu.rb'
@@ -1018,8 +1013,6 @@ Style/IfUnlessModifier:
- 'qa/qa/page/view.rb'
- 'qa/qa/resource/registry_repository.rb'
- 'qa/qa/resource/repository/push.rb'
- - 'qa/qa/resource/reusable_collection.rb'
- - 'qa/qa/resource/runner.rb'
- 'qa/qa/resource/snippet.rb'
- 'qa/qa/runtime/application_settings.rb'
- 'qa/qa/runtime/gpg.rb'
diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml
index 2f042829e35..b2c466353df 100644
--- a/.rubocop_todo/style/percent_literal_delimiters.yml
+++ b/.rubocop_todo/style/percent_literal_delimiters.yml
@@ -176,29 +176,11 @@ Style/PercentLiteralDelimiters:
- 'config/initializers_before_autoloader/000_inflections.rb'
- 'config/object_store_settings.rb'
- 'config/spring.rb'
- - 'db/migrate/20210317210338_add_valid_runner_registrars.rb'
- - 'db/migrate/20210420120734_initialize_conversion_of_ci_job_artifacts_to_bigint.rb'
- - 'db/migrate/20210426094524_initialize_conversion_of_ci_builds_to_bigint.rb'
- - 'db/migrate/20210427045604_initialize_conversion_of_ci_build_trace_chunks_to_bigint.rb'
- - 'db/migrate/20210427084924_initialize_conversion_of_ci_builds_runner_session_to_bigint.rb'
- - 'db/migrate/20210427094931_add_execution_order_index_to_batched_background_migration_jobs.rb'
- - 'db/migrate/20210520133032_initialize_conversion_of_taggings_to_bigint.rb'
- - 'db/migrate/20210520133440_backfill_taggings_for_bigint_conversion.rb'
- - 'db/migrate/20210525085158_initialize_conversion_of_deployments_to_bigint.rb'
- - 'db/migrate/20210525085325_backfill_deployments_for_bigint_conversion.rb'
- - 'db/migrate/20210525100539_initialize_conversion_of_geo_job_artifact_deleted_events_to_bigint.rb'
- - 'db/migrate/20210525100603_backfill_geo_job_artifact_deleted_events_for_bigint_conversion.rb'
- 'db/migrate/20210608072312_initialize_conversion_of_ci_stages_to_bigint.rb'
- 'db/migrate/20210608072346_backfill_ci_stages_for_bigint_conversion.rb'
- 'db/migrate/20210621044000_rename_services_indexes_to_integrations.rb'
- 'db/migrate/20210709085759_index_batched_migration_jobs_by_max_value.rb'
- 'db/migrate/20210928155022_improve_index_for_error_tracking.rb'
- - 'db/post_migrate/20210329102724_add_new_trail_plans.rb'
- - 'db/post_migrate/20210420121149_backfill_conversion_of_ci_job_artifacts.rb'
- - 'db/post_migrate/20210426094549_backfill_ci_builds_for_bigint_conversion.rb'
- - 'db/post_migrate/20210427045711_backfill_ci_build_trace_chunks_for_bigint_conversion.rb'
- - 'db/post_migrate/20210427085020_backfill_ci_builds_runner_session_for_bigint_conversion.rb'
- - 'db/post_migrate/20210520012430_backfill_pk_conversion_for_self_managed.rb'
- 'db/post_migrate/20210823142036_drop_temporary_trigger_for_ci_job_artifacts.rb'
- 'db/post_migrate/20210826171758_initialize_throttle_unauthenticated_api_columns.rb'
- 'db/post_migrate/20210906130643_drop_temporary_columns_and_triggers_for_taggings.rb'
@@ -291,7 +273,6 @@ Style/PercentLiteralDelimiters:
- 'ee/spec/controllers/groups/scim_oauth_controller_spec.rb'
- 'ee/spec/controllers/groups/sso_controller_spec.rb'
- 'ee/spec/controllers/projects/issues_controller_spec.rb'
- - 'ee/spec/controllers/projects/legacy_pipelines_controller_spec.rb'
- 'ee/spec/controllers/projects/pipelines_controller_spec.rb'
- 'ee/spec/controllers/projects/security/configuration_controller_spec.rb'
- 'ee/spec/elastic_integration/global_search_spec.rb'
@@ -323,7 +304,6 @@ Style/PercentLiteralDelimiters:
- 'ee/spec/helpers/ee/geo_helper_spec.rb'
- 'ee/spec/helpers/ee/labels_helper_spec.rb'
- 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb'
- - 'ee/spec/helpers/ee/welcome_helper_spec.rb'
- 'ee/spec/helpers/merge_requests_helper_spec.rb'
- 'ee/spec/helpers/subscriptions_helper_spec.rb'
- 'ee/spec/helpers/vulnerabilities_helper_spec.rb'
@@ -410,9 +390,7 @@ Style/PercentLiteralDelimiters:
- 'ee/spec/requests/api/graphql/project/alert_management/http_integrations_spec.rb'
- 'ee/spec/requests/api/internal/base_spec.rb'
- 'ee/spec/requests/api/issues_spec.rb'
- - 'ee/spec/requests/api/markdown_golden_master_spec.rb'
- 'ee/spec/requests/api/merge_requests_spec.rb'
- - 'ee/spec/requests/api/scim_spec.rb'
- 'ee/spec/requests/api/wikis_spec.rb'
- 'ee/spec/requests/lfs_locks_api_spec.rb'
- 'ee/spec/serializers/merge_request_widget_entity_spec.rb'
@@ -628,7 +606,6 @@ Style/PercentLiteralDelimiters:
- 'spec/controllers/projects/pipelines_controller_spec.rb'
- 'spec/controllers/projects/settings/ci_cd_controller_spec.rb'
- 'spec/controllers/projects_controller_spec.rb'
- - 'spec/controllers/registrations/welcome_controller_spec.rb'
- 'spec/controllers/search_controller_spec.rb'
- 'spec/controllers/snippets_controller_spec.rb'
- 'spec/db/docs_spec.rb'
@@ -656,8 +633,6 @@ Style/PercentLiteralDelimiters:
- 'spec/features/projects/integrations/user_activates_jira_spec.rb'
- 'spec/features/projects/jobs_spec.rb'
- 'spec/features/projects/labels/issues_sorted_by_priority_spec.rb'
- - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb'
- - 'spec/features/projects/pipelines/legacy_pipelines_spec.rb'
- 'spec/features/projects/pipelines/pipeline_spec.rb'
- 'spec/features/projects/pipelines/pipelines_spec.rb'
- 'spec/features/tags/developer_views_tags_spec.rb'
@@ -918,8 +893,6 @@ Style/PercentLiteralDelimiters:
- 'spec/lib/unnested_in_filters/dsl_spec.rb'
- 'spec/lib/unnested_in_filters/rewriter_spec.rb'
- 'spec/metrics_server/metrics_server_spec.rb'
- - 'spec/migrations/add_new_trail_plans_spec.rb'
- - 'spec/migrations/change_web_hook_events_default_spec.rb'
- 'spec/migrations/reset_severity_levels_to_new_default_spec.rb'
- 'spec/models/alert_management/http_integration_spec.rb'
- 'spec/models/appearance_spec.rb'
@@ -1112,7 +1085,6 @@ Style/PercentLiteralDelimiters:
- 'spec/support/prometheus/additional_metrics_shared_examples.rb'
- 'spec/support/prometheus/metric_builders.rb'
- 'spec/support/shared_contexts/graphql/resolvers/runners_resolver_shared_context.rb'
- - 'spec/support/shared_contexts/markdown_golden_master_shared_examples.rb'
- 'spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb'
- 'spec/support/shared_examples/controllers/metrics_dashboard_shared_examples.rb'
- 'spec/support/shared_examples/controllers/wiki_actions_shared_examples.rb'
diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml
index ec9aaac85dc..ae19cf458be 100644
--- a/.rubocop_todo/style/redundant_self.yml
+++ b/.rubocop_todo/style/redundant_self.yml
@@ -188,7 +188,6 @@ Style/RedundantSelf:
- 'config/initializers/active_record_keyset_pagination.rb'
- 'config/initializers/forbid_sidekiq_in_transactions.rb'
- 'config/initializers/mail_encoding_patch.rb'
- - 'db/post_migrate/20210329102724_add_new_trail_plans.rb'
- 'db/post_migrate/20211029102822_add_open_source_plan.rb'
- 'ee/app/graphql/resolvers/geo/registries_resolver.rb'
- 'ee/app/models/approval_merge_request_rule.rb'
@@ -412,7 +411,6 @@ Style/RedundantSelf:
- 'qa/qa/resource/events/project.rb'
- 'qa/qa/resource/personal_access_token.rb'
- 'qa/qa/resource/protected_branch.rb'
- - 'qa/qa/resource/reusable.rb'
- 'qa/qa/resource/user_gpg.rb'
- 'qa/qa/runtime/release.rb'
- 'qa/qa/scenario/bootable.rb'
diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml
index 91eb45f73cf..91376f61e4c 100644
--- a/.rubocop_todo/style/string_concatenation.yml
+++ b/.rubocop_todo/style/string_concatenation.yml
@@ -22,7 +22,6 @@ Style/StringConcatenation:
- 'app/models/wiki.rb'
- 'app/models/wiki_page.rb'
- 'app/presenters/snippet_blob_presenter.rb'
- - 'app/services/clusters/gcp/finalize_creation_service.rb'
- 'app/services/feature_flags/update_service.rb'
- 'app/services/packages/composer/version_parser_service.rb'
- 'app/services/packages/debian/generate_distribution_key_service.rb'
@@ -35,7 +34,6 @@ Style/StringConcatenation:
- 'config/initializers/1_settings.rb'
- 'config/settings.rb'
- 'config/spring.rb'
- - 'db/migrate/20210412111213_create_security_orchestration_policy_rule_schedule.rb'
- 'ee/app/controllers/admin/elasticsearch_controller.rb'
- 'ee/app/finders/ee/issuables/label_filter.rb'
- 'ee/app/helpers/ee/geo_helper.rb'
@@ -271,7 +269,6 @@ Style/StringConcatenation:
- 'spec/requests/users_controller_spec.rb'
- 'spec/routing/git_http_routing_spec.rb'
- 'spec/services/ci/find_exposed_artifacts_service_spec.rb'
- - 'spec/services/clusters/gcp/finalize_creation_service_spec.rb'
- 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb'
- 'spec/services/error_tracking/list_projects_service_spec.rb'
- 'spec/services/groups/update_service_spec.rb'
diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml
index 074b400c4bb..4bcd310b899 100644
--- a/.rubocop_todo/style/symbol_proc.yml
+++ b/.rubocop_todo/style/symbol_proc.yml
@@ -2,26 +2,8 @@
# Cop supports --autocorrect.
Style/SymbolProc:
Exclude:
- - 'app/controllers/admin/users_controller.rb'
- - 'app/controllers/concerns/renders_blob.rb'
- - 'app/controllers/import/bitbucket_controller.rb'
- - 'app/controllers/import/bitbucket_server_controller.rb'
- - 'app/controllers/profiles/avatars_controller.rb'
- - 'app/controllers/profiles/two_factor_auths_controller.rb'
- 'app/controllers/profiles_controller.rb'
- - 'app/finders/packages/go/version_finder.rb'
- - 'app/graphql/mutations/commits/create.rb'
- - 'app/graphql/mutations/concerns/mutations/work_items/widgetable.rb'
- - 'app/graphql/mutations/jira_import/start.rb'
- - 'app/graphql/types/work_items/widgets/description_type.rb'
- - 'app/helpers/graph_helper.rb'
- - 'app/models/ci/build_metadata.rb'
- - 'app/models/ci/build_trace_chunk.rb'
- 'app/models/ci/pipeline.rb'
- - 'app/models/clusters/concerns/provider_status.rb'
- - 'app/models/commit.rb'
- - 'app/models/concerns/board_recent_visit.rb'
- - 'app/models/concerns/resolvable_discussion.rb'
- 'app/models/container_repository.rb'
- 'app/models/deployment.rb'
- 'app/models/discussion.rb'
@@ -84,8 +66,6 @@ Style/SymbolProc:
- 'config/initializers/doorkeeper_openid_connect.rb'
- 'config/initializers/mail_encoding_patch.rb'
- 'config/settings.rb'
- - 'db/migrate/20210318134427_delete_security_findings_without_uuid.rb'
- - 'db/migrate/20210503105845_add_project_value_stream_id_to_project_stages.rb'
- 'db/post_migrate/20220119094503_populate_audit_event_streaming_verification_token.rb'
- 'db/post_migrate/20220803042352_cleanup_mr_attention_request_todos.rb'
- 'ee/app/helpers/ee/mirror_helper.rb'