diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-06-20 11:10:13 +0000 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-06-20 11:10:13 +0000 |
| commit | 0ea3fcec397b69815975647f5e2aa5fe944a8486 (patch) | |
| tree | 7979381b89d26011bcf9bdc989a40fcc2f1ed4ff /.rubocop_todo | |
| parent | 72123183a20411a36d607d70b12d57c484394c8e (diff) | |
| download | gitlab-ce-0ea3fcec397b69815975647f5e2aa5fe944a8486.tar.gz | |
Add latest changes from gitlab-org/gitlab@15-1-stable-eev15.1.0-rc42
Diffstat (limited to '.rubocop_todo')
58 files changed, 525 insertions, 367 deletions
diff --git a/.rubocop_todo/cop/static_translation_definition.yml b/.rubocop_todo/cop/static_translation_definition.yml new file mode 100644 index 00000000000..22f5070d07c --- /dev/null +++ b/.rubocop_todo/cop/static_translation_definition.yml @@ -0,0 +1,20 @@ +--- +Cop/StaticTranslationDefinition: + Exclude: + - 'app/models/application_setting.rb' + - 'app/models/diff_viewer/image.rb' + - 'app/models/diff_viewer/rich.rb' + - 'app/models/diff_viewer/simple.rb' + - 'app/models/group_group_link.rb' + - 'app/models/jira_import_state.rb' + - 'app/models/member.rb' + - 'app/models/project.rb' + - 'app/models/project_group_link.rb' + - 'app/models/user.rb' + - 'app/models/users/banned_user.rb' + - 'ee/app/models/allowed_email_domain.rb' + - 'ee/app/models/dast/site_profile_secret_variable.rb' + - 'ee/app/models/group_merge_request_approval_setting.rb' + - 'ee/app/models/incident_management/escalation_policy.rb' + - 'ee/app/models/incident_management/escalation_rule.rb' + - 'ee/app/models/vulnerabilities/read.rb' diff --git a/.rubocop_todo/cop/user_admin.yml b/.rubocop_todo/cop/user_admin.yml index 5f0f7213950..ab5f76a002d 100644 --- a/.rubocop_todo/cop/user_admin.yml +++ b/.rubocop_todo/cop/user_admin.yml @@ -26,7 +26,6 @@ Cop/UserAdmin: - app/models/protected_branch.rb - app/models/user.rb - app/policies/note_policy.rb - - app/serializers/deploy_key_entity.rb - app/services/auth/container_registry_authentication_service.rb - app/services/emails/create_service.rb - app/services/projects/enable_deploy_key_service.rb diff --git a/.rubocop_todo/fips/md5.yml b/.rubocop_todo/fips/md5.yml new file mode 100644 index 00000000000..ef9e8fdde62 --- /dev/null +++ b/.rubocop_todo/fips/md5.yml @@ -0,0 +1,25 @@ +--- +Fips/MD5: + Exclude: + - 'app/experiments/application_experiment.rb' + - 'app/models/concerns/checksummable.rb' + - 'app/services/gravatar_service.rb' + - 'app/services/packages/debian/generate_distribution_service.rb' + - 'app/services/packages/go/create_package_service.rb' + - 'app/services/packages/maven/metadata/append_package_file_service.rb' + - 'app/services/packages/rubygems/create_gemspec_service.rb' + - 'config/application.rb' + - 'config/initializers/wikicloth_redos_patch.rb' + - 'ee/app/models/license.rb' + - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' + - 'lib/tasks/migrate/setup_postgresql.rake' + - 'qa/qa/specs/features/api/3_create/repository/project_archive_compare_spec.rb' + - 'spec/controllers/invites_controller_spec.rb' + - 'spec/lib/gitlab/ci/trace/archive_spec.rb' + - 'spec/lib/gitlab/ci/trace/remote_checksum_spec.rb' + - 'spec/models/concerns/checksummable_spec.rb' + - 'spec/services/gravatar_service_spec.rb' + - 'spec/support/matchers/match_file.rb' + - 'spec/support/shared_examples/services/packages/debian/generate_distribution_shared_examples.rb' + - 'spec/tooling/rspec_flaky/example_spec.rb' + - 'tooling/rspec_flaky/example.rb' diff --git a/.rubocop_todo/fips/open_ssl.yml b/.rubocop_todo/fips/open_ssl.yml new file mode 100644 index 00000000000..03a551112ab --- /dev/null +++ b/.rubocop_todo/fips/open_ssl.yml @@ -0,0 +1,222 @@ +--- +# Cop supports --auto-correct. +Fips/OpenSSL: + Exclude: + - 'app/controllers/application_controller.rb' + - 'app/controllers/concerns/authenticates_with_two_factor.rb' + - 'app/controllers/projects/merge_requests/diffs_controller.rb' + - 'app/controllers/projects/merge_requests_controller.rb' + - 'app/helpers/application_helper.rb' + - 'app/models/ci/artifact_blob.rb' + - 'app/models/concerns/analytics/cycle_analytics/stage.rb' + - 'app/models/concerns/checksummable.rb' + - 'app/models/concerns/token_authenticatable_strategies/encryption_helper.rb' + - 'app/models/diff_discussion.rb' + - 'app/models/discussion.rb' + - 'app/models/legacy_diff_note.rb' + - 'app/models/namespace.rb' + - 'app/models/note.rb' + - 'app/models/performance_monitoring/prometheus_panel.rb' + - 'app/models/protected_branch.rb' + - 'app/models/release_highlight.rb' + - 'app/models/repository.rb' + - 'app/models/resource_event.rb' + - 'app/models/snippet.rb' + - 'app/models/storage/hashed.rb' + - 'app/models/token_with_iv.rb' + - 'app/presenters/packages/composer/packages_presenter.rb' + - 'app/services/ci/build_report_result_service.rb' + - 'app/services/metrics/dashboard/transient_embed_service.rb' + - 'app/services/packages/debian/generate_distribution_service.rb' + - 'app/services/packages/go/create_package_service.rb' + - 'app/services/packages/maven/metadata/append_package_file_service.rb' + - 'app/services/packages/rubygems/create_gemspec_service.rb' + - 'app/services/pages/migrate_legacy_storage_to_deployment_service.rb' + - 'app/services/projects/lfs_pointers/lfs_download_service.rb' + - 'app/uploaders/ci/secure_file_uploader.rb' + - 'config/initializers/doorkeeper_openid_connect.rb' + - 'config/initializers/session_store.rb' + - 'config/settings.rb' + - 'db/post_migrate/20210731132939_backfill_stage_event_hash.rb' + - 'ee/app/models/storage_shard.rb' + - 'ee/app/services/elastic/bookkeeping_shard_service.rb' + - 'ee/app/services/security/track_scan_service.rb' + - 'ee/app/services/vulnerabilities/create_service_base.rb' + - 'ee/app/services/vulnerabilities/manually_create_service.rb' + - 'ee/app/services/vulnerabilities/starboard_vulnerability_create_service.rb' + - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' + - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' + - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' + - 'ee/lib/gitlab/analytics/cycle_analytics/stage_events/label_based_stage_event.rb' + - 'ee/lib/gitlab/ci/reports/dependency_list/dependency.rb' + - 'ee/lib/gitlab/ci/reports/security/remediation.rb' + - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' + - 'ee/spec/factories/vulnerabilities/feedback.rb' + - 'ee/spec/factories/vulnerabilities/finding_signatures.rb' + - 'ee/spec/factories/vulnerabilities/remediations.rb' + - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' + - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' + - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/issue_label_added_spec.rb' + - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/issue_label_removed_spec.rb' + - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/merge_request_label_added_spec.rb' + - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/merge_request_label_removed_spec.rb' + - 'ee/spec/lib/gitlab/ci/reports/security/locations/cluster_image_scanning_spec.rb' + - 'ee/spec/lib/gitlab/ci/reports/security/locations/container_scanning_spec.rb' + - 'ee/spec/lib/gitlab/ci/reports/security/locations/dast_spec.rb' + - 'ee/spec/lib/gitlab/ci/reports/security/locations/dependency_scanning_spec.rb' + - 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb' + - 'ee/spec/models/merge_train_spec.rb' + - 'ee/spec/models/resource_weight_event_spec.rb' + - 'ee/spec/models/vulnerabilities/finding_signature_spec.rb' + - 'ee/spec/models/vulnerabilities/finding_spec.rb' + - 'ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb' + - 'ee/spec/services/merge_trains/check_status_service_spec.rb' + - 'ee/spec/services/projects/alerting/notify_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_identifiers_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_remediations_spec.rb' + - 'ee/spec/services/security/override_uuids_service_spec.rb' + - 'ee/spec/services/security/track_scan_service_spec.rb' + - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' + - 'ee/spec/support/matchers/locked_schema.rb' + - 'lib/api/files.rb' + - 'lib/api/maven_packages.rb' + - 'lib/atlassian/jira_connect/serializers/branch_entity.rb' + - 'lib/container_registry/client.rb' + - 'lib/extracts_path.rb' + - 'lib/gitlab/alert_management/fingerprint.rb' + - 'lib/gitlab/analytics/cycle_analytics/stage_events/stage_event.rb' + - 'lib/gitlab/background_migration/backfill_note_discussion_id.rb' + - 'lib/gitlab/background_migration/backfill_project_repositories.rb' + - 'lib/gitlab/ci/pipeline/seed/build/cache.rb' + - 'lib/gitlab/ci/reports/security/finding.rb' + - 'lib/gitlab/ci/reports/security/finding_signature.rb' + - 'lib/gitlab/ci/reports/security/identifier.rb' + - 'lib/gitlab/ci/reports/security/locations/base.rb' + - 'lib/gitlab/ci/reports/test_case.rb' + - 'lib/gitlab/color.rb' + - 'lib/gitlab/composer/version_index.rb' + - 'lib/gitlab/crypto_helper.rb' + - 'lib/gitlab/database/migration_helpers.rb' + - 'lib/gitlab/database/migration_helpers/v2.rb' + - 'lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers.rb' + - 'lib/gitlab/database/schema_helpers.rb' + - 'lib/gitlab/database/schema_migrations/migrations.rb' + - 'lib/gitlab/database/unidirectional_copy_trigger.rb' + - 'lib/gitlab/diff/file.rb' + - 'lib/gitlab/diff/formatters/base_formatter.rb' + - 'lib/gitlab/diff/position.rb' + - 'lib/gitlab/experimentation/controller_concern.rb' + - 'lib/gitlab/git.rb' + - 'lib/gitlab/git/branch.rb' + - 'lib/gitlab/git/lfs_pointer_file.rb' + - 'lib/gitlab/git/tag.rb' + - 'lib/gitlab/hashed_path.rb' + - 'lib/gitlab/insecure_key_fingerprint.rb' + - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' + - 'lib/gitlab/slug/environment.rb' + - 'lib/gitlab/verify/job_artifacts.rb' + - 'lib/json_web_token/rsa_token.rb' + - 'lib/tasks/gitlab/assets.rake' + - 'lib/tasks/tanuki_emoji.rake' + - 'qa/qa/service/praefect_manager.rb' + - 'qa/qa/specs/features/browser_ui/6_release/deploy_key/clone_using_deploy_key_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' + - 'scripts/security-harness' + - 'spec/components/diffs/stats_component_spec.rb' + - 'spec/controllers/projects/blob_controller_spec.rb' + - 'spec/factories/ci/job_artifacts.rb' + - 'spec/factories/ci/reports/security/finding_keys.rb' + - 'spec/factories/ci/unit_test.rb' + - 'spec/factories/commit_signature/gpg_signature.rb' + - 'spec/factories/commit_signature/ssh_signature.rb' + - 'spec/factories/commit_signature/x509_commit_signature.rb' + - 'spec/factories/design_management/designs.rb' + - 'spec/factories/diff_position.rb' + - 'spec/factories/gitaly/commit.rb' + - 'spec/factories/merge_request_context_commit.rb' + - 'spec/factories/merge_request_context_commit_diff_file.rb' + - 'spec/factories/merge_request_diff_commits.rb' + - 'spec/factories/merge_request_diffs.rb' + - 'spec/factories/pages_deployments.rb' + - 'spec/factories/sequences.rb' + - 'spec/factories/token_with_ivs.rb' + - 'spec/features/file_uploads/git_lfs_spec.rb' + - 'spec/features/merge_request/user_sees_diff_spec.rb' + - 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb' + - 'spec/finders/merge_requests/oldest_per_commit_finder_spec.rb' + - 'spec/lib/gitlab/alert_management/fingerprint_spec.rb' + - 'spec/lib/gitlab/alert_management/payload/base_spec.rb' + - 'spec/lib/gitlab/alert_management/payload/generic_spec.rb' + - 'spec/lib/gitlab/alert_management/payload/prometheus_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_note_discussion_id_spec.rb' + - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' + - 'spec/lib/gitlab/ci/reports/security/finding_signature_spec.rb' + - 'spec/lib/gitlab/ci/reports/security/locations/sast_spec.rb' + - 'spec/lib/gitlab/ci/reports/security/locations/secret_detection_spec.rb' + - 'spec/lib/gitlab/ci/reports/test_case_spec.rb' + - 'spec/lib/gitlab/crypto_helper_spec.rb' + - 'spec/lib/gitlab/database/migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/schema_migrations/migrations_spec.rb' + - 'spec/lib/gitlab/diff/file_spec.rb' + - 'spec/lib/gitlab/diff/position_spec.rb' + - 'spec/lib/gitlab/diff/position_tracer/image_strategy_spec.rb' + - 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb' + - 'spec/lib/gitlab/experimentation/controller_concern_spec.rb' + - 'spec/lib/gitlab/git/branch_spec.rb' + - 'spec/lib/gitlab/git/tag_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job_spec.rb' + - 'spec/lib/gitlab/slug/environment_spec.rb' + - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' + - 'spec/migrations/20220524074947_finalize_backfill_null_note_discussion_ids_spec.rb' + - 'spec/migrations/delete_security_findings_without_uuid_spec.rb' + - 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb' + - 'spec/models/ci/artifact_blob_spec.rb' + - 'spec/models/ci/job_artifact_spec.rb' + - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/ci/secure_file_spec.rb' + - 'spec/models/ci/unit_test_spec.rb' + - 'spec/models/concerns/checksummable_spec.rb' + - 'spec/models/concerns/token_authenticatable_strategies/encryption_helper_spec.rb' + - 'spec/models/design_management/version_spec.rb' + - 'spec/models/diff_discussion_spec.rb' + - 'spec/models/discussion_spec.rb' + - 'spec/models/lfs_object_spec.rb' + - 'spec/models/merge_request_diff_spec.rb' + - 'spec/models/merge_request_spec.rb' + - 'spec/models/note_spec.rb' + - 'spec/models/pages_deployment_spec.rb' + - 'spec/models/performance_monitoring/prometheus_panel_spec.rb' + - 'spec/models/project_spec.rb' + - 'spec/models/release_highlight_spec.rb' + - 'spec/models/repository_spec.rb' + - 'spec/models/token_with_iv_spec.rb' + - 'spec/models/upload_spec.rb' + - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' + - 'spec/requests/api/ci/secure_files_spec.rb' + - 'spec/requests/openid_connect_spec.rb' + - 'spec/services/dependency_proxy/find_cached_manifest_service_spec.rb' + - 'spec/services/dependency_proxy/head_manifest_service_spec.rb' + - 'spec/services/dependency_proxy/request_token_service_spec.rb' + - 'spec/services/import_export_clean_up_service_spec.rb' + - 'spec/services/pages/migrate_legacy_storage_to_deployment_service_spec.rb' + - 'spec/services/projects/after_rename_service_spec.rb' + - 'spec/services/projects/create_service_spec.rb' + - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' + - 'spec/support/helpers/workhorse_helpers.rb' + - 'spec/support/migrations_helpers/vulnerabilities_findings_helper.rb' + - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/cycle_analytics/event_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/position_formatters_shared_examples.rb' + - 'spec/support/shared_examples/services/alert_management/alert_processing/alert_firing_shared_examples.rb' + - 'spec/support/shared_examples/services/alert_management/alert_processing/alert_recovery_shared_examples.rb' + - 'spec/support/shared_examples/services/metrics/dashboard_shared_examples.rb' + - 'spec/support/shared_examples/services/packages/debian/generate_distribution_shared_examples.rb' + - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' + - 'spec/support/trace/trace_helpers.rb' + - 'spec/uploaders/ci/secure_file_uploader_spec.rb' + - 'spec/uploaders/job_artifact_uploader_spec.rb' + - 'spec/validators/sha_validator_spec.rb' + - 'spec/workers/update_head_pipeline_for_merge_request_worker_spec.rb' diff --git a/.rubocop_todo/fips/sha1.yml b/.rubocop_todo/fips/sha1.yml new file mode 100644 index 00000000000..934805c86d4 --- /dev/null +++ b/.rubocop_todo/fips/sha1.yml @@ -0,0 +1,111 @@ +--- +Fips/SHA1: + Exclude: + - 'app/controllers/application_controller.rb' + - 'app/helpers/application_helper.rb' + - 'app/models/ci/artifact_blob.rb' + - 'app/models/diff_discussion.rb' + - 'app/models/discussion.rb' + - 'app/models/legacy_diff_note.rb' + - 'app/models/note.rb' + - 'app/models/protected_branch.rb' + - 'app/models/repository.rb' + - 'app/models/resource_event.rb' + - 'app/services/packages/go/create_package_service.rb' + - 'app/services/packages/maven/metadata/append_package_file_service.rb' + - 'app/services/packages/rubygems/create_gemspec_service.rb' + - 'ee/app/models/storage_shard.rb' + - 'ee/app/services/vulnerabilities/create_service_base.rb' + - 'ee/app/services/vulnerabilities/manually_create_service.rb' + - 'ee/app/services/vulnerabilities/starboard_vulnerability_create_service.rb' + - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' + - 'ee/spec/factories/vulnerabilities/feedback.rb' + - 'ee/spec/factories/vulnerabilities/finding_signatures.rb' + - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' + - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' + - 'ee/spec/lib/gitlab/ci/reports/security/locations/cluster_image_scanning_spec.rb' + - 'ee/spec/lib/gitlab/ci/reports/security/locations/container_scanning_spec.rb' + - 'ee/spec/lib/gitlab/ci/reports/security/locations/dast_spec.rb' + - 'ee/spec/lib/gitlab/ci/reports/security/locations/dependency_scanning_spec.rb' + - 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb' + - 'ee/spec/models/merge_train_spec.rb' + - 'ee/spec/models/resource_weight_event_spec.rb' + - 'ee/spec/models/vulnerabilities/finding_signature_spec.rb' + - 'ee/spec/models/vulnerabilities/finding_spec.rb' + - 'ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb' + - 'ee/spec/services/merge_trains/check_status_service_spec.rb' + - 'ee/spec/services/projects/alerting/notify_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_identifiers_spec.rb' + - 'ee/spec/services/security/override_uuids_service_spec.rb' + - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' + - 'lib/extracts_path.rb' + - 'lib/gitlab/alert_management/fingerprint.rb' + - 'lib/gitlab/background_migration/backfill_note_discussion_id.rb' + - 'lib/gitlab/ci/pipeline/seed/build/cache.rb' + - 'lib/gitlab/ci/reports/security/finding.rb' + - 'lib/gitlab/ci/reports/security/finding_signature.rb' + - 'lib/gitlab/ci/reports/security/identifier.rb' + - 'lib/gitlab/ci/reports/security/locations/base.rb' + - 'lib/gitlab/diff/file.rb' + - 'lib/gitlab/diff/formatters/base_formatter.rb' + - 'lib/gitlab/diff/position.rb' + - 'lib/gitlab/git.rb' + - 'lib/gitlab/git/branch.rb' + - 'lib/gitlab/git/tag.rb' + - 'qa/qa/specs/features/browser_ui/6_release/deploy_key/clone_using_deploy_key_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' + - 'spec/components/diffs/stats_component_spec.rb' + - 'spec/controllers/projects/blob_controller_spec.rb' + - 'spec/factories/ci/reports/security/finding_keys.rb' + - 'spec/factories/commit_signature/gpg_signature.rb' + - 'spec/factories/commit_signature/ssh_signature.rb' + - 'spec/factories/commit_signature/x509_commit_signature.rb' + - 'spec/factories/design_management/designs.rb' + - 'spec/factories/diff_position.rb' + - 'spec/factories/gitaly/commit.rb' + - 'spec/factories/merge_request_context_commit.rb' + - 'spec/factories/merge_request_context_commit_diff_file.rb' + - 'spec/factories/merge_request_diff_commits.rb' + - 'spec/factories/merge_request_diffs.rb' + - 'spec/factories/sequences.rb' + - 'spec/features/merge_request/user_sees_diff_spec.rb' + - 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb' + - 'spec/finders/merge_requests/oldest_per_commit_finder_spec.rb' + - 'spec/lib/gitlab/alert_management/fingerprint_spec.rb' + - 'spec/lib/gitlab/alert_management/payload/base_spec.rb' + - 'spec/lib/gitlab/alert_management/payload/generic_spec.rb' + - 'spec/lib/gitlab/alert_management/payload/prometheus_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_note_discussion_id_spec.rb' + - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' + - 'spec/lib/gitlab/ci/reports/security/finding_signature_spec.rb' + - 'spec/lib/gitlab/ci/reports/security/locations/sast_spec.rb' + - 'spec/lib/gitlab/ci/reports/security/locations/secret_detection_spec.rb' + - 'spec/lib/gitlab/diff/file_spec.rb' + - 'spec/lib/gitlab/diff/position_spec.rb' + - 'spec/lib/gitlab/diff/position_tracer/image_strategy_spec.rb' + - 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb' + - 'spec/lib/gitlab/git/branch_spec.rb' + - 'spec/lib/gitlab/git/tag_spec.rb' + - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' + - 'spec/migrations/20220524074947_finalize_backfill_null_note_discussion_ids_spec.rb' + - 'spec/migrations/delete_security_findings_without_uuid_spec.rb' + - 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb' + - 'spec/models/ci/artifact_blob_spec.rb' + - 'spec/models/ci/job_artifact_spec.rb' + - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/design_management/version_spec.rb' + - 'spec/models/diff_discussion_spec.rb' + - 'spec/models/discussion_spec.rb' + - 'spec/models/merge_request_diff_spec.rb' + - 'spec/models/merge_request_spec.rb' + - 'spec/models/note_spec.rb' + - 'spec/models/repository_spec.rb' + - 'spec/support/migrations_helpers/vulnerabilities_findings_helper.rb' + - 'spec/support/shared_examples/lib/gitlab/position_formatters_shared_examples.rb' + - 'spec/support/shared_examples/services/alert_management/alert_processing/alert_firing_shared_examples.rb' + - 'spec/support/shared_examples/services/alert_management/alert_processing/alert_recovery_shared_examples.rb' + - 'spec/validators/sha_validator_spec.rb' + - 'spec/workers/update_head_pipeline_for_merge_request_worker_spec.rb' diff --git a/.rubocop_todo/gitlab/delegate_predicate_methods.yml b/.rubocop_todo/gitlab/delegate_predicate_methods.yml index 7ed3fc3e4fb..854cd3e0a83 100644 --- a/.rubocop_todo/gitlab/delegate_predicate_methods.yml +++ b/.rubocop_todo/gitlab/delegate_predicate_methods.yml @@ -2,6 +2,5 @@ Gitlab/DelegatePredicateMethods: Exclude: - app/models/clusters/cluster.rb - - app/models/concerns/integrations/base_data_fields.rb - app/models/project.rb - ee/app/models/concerns/ee/ci/metadatable.rb diff --git a/.rubocop_todo/gitlab/feature_available_usage.yml b/.rubocop_todo/gitlab/feature_available_usage.yml index 2a0975a6e9b..168edd94f90 100644 --- a/.rubocop_todo/gitlab/feature_available_usage.yml +++ b/.rubocop_todo/gitlab/feature_available_usage.yml @@ -25,7 +25,6 @@ Gitlab/FeatureAvailableUsage: - ee/app/controllers/projects/subscriptions_controller.rb - ee/app/finders/autocomplete/vulnerabilities_autocomplete_finder.rb - ee/app/finders/clusters/agents_finder.rb - - ee/app/finders/ee/alert_management/alerts_finder.rb - ee/app/finders/ee/alert_management/http_integrations_finder.rb - ee/app/graphql/ee/types/group_type.rb - ee/app/graphql/mutations/dast/profiles/create.rb diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index 0f974bc5002..23ff86ba289 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -500,8 +500,6 @@ Gitlab/NamespacedClass: - 'app/serializers/current_board_entity.rb' - 'app/serializers/current_board_serializer.rb' - 'app/serializers/current_user_entity.rb' - - 'app/serializers/deploy_key_entity.rb' - - 'app/serializers/deploy_key_serializer.rb' - 'app/serializers/deploy_keys_project_entity.rb' - 'app/serializers/deployment_cluster_entity.rb' - 'app/serializers/deployment_entity.rb' @@ -614,10 +612,6 @@ Gitlab/NamespacedClass: - 'app/serializers/route_entity.rb' - 'app/serializers/route_serializer.rb' - 'app/serializers/runner_entity.rb' - - 'app/serializers/service_event_entity.rb' - - 'app/serializers/service_event_serializer.rb' - - 'app/serializers/service_field_entity.rb' - - 'app/serializers/service_field_serializer.rb' - 'app/serializers/stage_entity.rb' - 'app/serializers/stage_serializer.rb' - 'app/serializers/suggestion_entity.rb' @@ -774,7 +768,6 @@ Gitlab/NamespacedClass: - 'app/workers/error_tracking_issue_link_worker.rb' - 'app/workers/expire_build_artifacts_worker.rb' - 'app/workers/expire_job_cache_worker.rb' - - 'app/workers/expire_pipeline_cache_worker.rb' - 'app/workers/export_csv_worker.rb' - 'app/workers/external_service_reactive_caching_worker.rb' - 'app/workers/file_hook_worker.rb' @@ -788,7 +781,6 @@ Gitlab/NamespacedClass: - 'app/workers/import_export_project_cleanup_worker.rb' - 'app/workers/import_issues_csv_worker.rb' - 'app/workers/invalid_gpg_signature_update_worker.rb' - - 'app/workers/irker_worker.rb' - 'app/workers/issuable_export_csv_worker.rb' - 'app/workers/issue_due_scheduler_worker.rb' - 'app/workers/issue_placement_worker.rb' @@ -798,7 +790,6 @@ Gitlab/NamespacedClass: - 'app/workers/merge_request_mergeability_check_worker.rb' - 'app/workers/merge_worker.rb' - 'app/workers/migrate_external_diffs_worker.rb' - - 'app/workers/namespaceless_project_destroy_worker.rb' - 'app/workers/new_issue_worker.rb' - 'app/workers/new_merge_request_worker.rb' - 'app/workers/new_note_worker.rb' @@ -818,10 +809,8 @@ Gitlab/NamespacedClass: - 'app/workers/post_receive.rb' - 'app/workers/process_commit_worker.rb' - 'app/workers/project_cache_worker.rb' - - 'app/workers/project_daily_statistics_worker.rb' - 'app/workers/project_destroy_worker.rb' - 'app/workers/project_export_worker.rb' - - 'app/workers/project_service_worker.rb' - 'app/workers/propagate_integration_group_worker.rb' - 'app/workers/propagate_integration_inherit_descendant_worker.rb' - 'app/workers/propagate_integration_inherit_worker.rb' @@ -1024,7 +1013,6 @@ Gitlab/NamespacedClass: - 'ee/app/serializers/group_analytics_serializer.rb' - 'ee/app/serializers/group_vulnerability_autocomplete_entity.rb' - 'ee/app/serializers/group_vulnerability_autocomplete_serializer.rb' - - 'ee/app/serializers/invited_group_entity.rb' - 'ee/app/serializers/invited_group_serializer.rb' - 'ee/app/serializers/iteration_serializer.rb' - 'ee/app/serializers/license_entity.rb' @@ -1089,7 +1077,6 @@ Gitlab/NamespacedClass: - 'ee/app/workers/project_import_schedule_worker.rb' - 'ee/app/workers/project_template_export_worker.rb' - 'ee/app/workers/refresh_license_compliance_checks_worker.rb' - - 'ee/app/workers/repository_push_audit_event_worker.rb' - 'ee/app/workers/repository_update_mirror_worker.rb' - 'ee/app/workers/scan_security_report_secrets_worker.rb' - 'ee/app/workers/set_user_status_based_on_user_cap_setting_worker.rb' @@ -1109,7 +1096,6 @@ Gitlab/NamespacedClass: - 'ee/lib/gitlab/items_collection.rb' - 'ee/lib/gitlab/manual_banner.rb' - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb' - - 'ee/lib/gitlab/manual_renewal_banner.rb' - 'ee/lib/gitlab/pagination_delegate.rb' - 'ee/lib/gitlab/path_locks_finder.rb' - 'ee/lib/gitlab/proxy.rb' @@ -1225,7 +1211,6 @@ Gitlab/NamespacedClass: - 'lib/gitlab/object_hierarchy.rb' - 'lib/gitlab/omniauth_initializer.rb' - 'lib/gitlab/otp_key_rotator.rb' - - 'lib/gitlab/pages_transfer.rb' - 'lib/gitlab/pipeline_scope_counts.rb' - 'lib/gitlab/polling_interval.rb' - 'lib/gitlab/process_memory_cache.rb' @@ -1279,7 +1264,6 @@ Gitlab/NamespacedClass: - 'lib/gitlab/unicode.rb' - 'lib/gitlab/untrusted_regexp.rb' - 'lib/gitlab/untrusted_regexp/ruby_syntax.rb' - - 'lib/gitlab/updated_notes_paginator.rb' - 'lib/gitlab/uploads_transfer.rb' - 'lib/gitlab/url_blocker.rb' - 'lib/gitlab/url_builder.rb' diff --git a/.rubocop_todo/graphql/ordered_arguments.yml b/.rubocop_todo/graphql/ordered_arguments.yml deleted file mode 100644 index 1a30490e893..00000000000 --- a/.rubocop_todo/graphql/ordered_arguments.yml +++ /dev/null @@ -1,6 +0,0 @@ ---- -GraphQL/OrderedArguments: - Exclude: - - app/graphql/resolvers/base_issues_resolver.rb - - app/graphql/resolvers/design_management/designs_resolver.rb - - app/graphql/resolvers/design_management/version/design_at_version_resolver.rb diff --git a/.rubocop_todo/graphql/ordered_fields.yml b/.rubocop_todo/graphql/ordered_fields.yml index b6ddd018f4e..b7135d7aabb 100644 --- a/.rubocop_todo/graphql/ordered_fields.yml +++ b/.rubocop_todo/graphql/ordered_fields.yml @@ -1,55 +1,12 @@ --- GraphQL/OrderedFields: Exclude: - - app/graphql/types/ci/runner_platform_type.rb - app/graphql/types/ci/runner_type.rb - - app/graphql/types/ci/stage_type.rb - - app/graphql/types/ci/status_action_type.rb - - app/graphql/types/ci/template_type.rb - - app/graphql/types/commit_type.rb - - app/graphql/types/container_expiration_policy_type.rb - - app/graphql/types/container_repository_tag_type.rb - app/graphql/types/container_repository_type.rb - - app/graphql/types/dependency_proxy/blob_type.rb - - app/graphql/types/dependency_proxy/image_ttl_group_policy_type.rb - app/graphql/types/dependency_proxy/manifest_type.rb - - app/graphql/types/design_management/design_collection_type.rb - - app/graphql/types/diff_refs_type.rb - - app/graphql/types/diff_stats_summary_type.rb - - app/graphql/types/diff_stats_type.rb - - app/graphql/types/error_tracking/sentry_detailed_error_type.rb - - app/graphql/types/error_tracking/sentry_error_collection_type.rb - - app/graphql/types/error_tracking/sentry_error_frequency_type.rb - - app/graphql/types/error_tracking/sentry_error_stack_trace_context_type.rb - - app/graphql/types/error_tracking/sentry_error_stack_trace_entry_type.rb - app/graphql/types/merge_request_type.rb - - app/graphql/types/metadata/kas_type.rb - - app/graphql/types/metadata_type.rb - - app/graphql/types/namespace/package_settings_type.rb - - app/graphql/types/namespace_type.rb - - app/graphql/types/notes/diff_position_type.rb - - app/graphql/types/notes/discussion_type.rb - - app/graphql/types/notes/note_type.rb - - app/graphql/types/packages/nuget/metadatum_type.rb - - app/graphql/types/packages/package_dependency_link_type.rb - - app/graphql/types/packages/package_file_type.rb - - app/graphql/types/packages/package_tag_type.rb - - app/graphql/types/packages/package_type.rb - app/graphql/types/project_statistics_type.rb - - app/graphql/types/project_type.rb - - app/graphql/types/projects/services/jira_project_type.rb - - app/graphql/types/release_asset_link_type.rb - - app/graphql/types/release_links_type.rb - app/graphql/types/release_type.rb - - app/graphql/types/repository_type.rb - app/graphql/types/root_storage_statistics_type.rb - - app/graphql/types/task_completion_status.rb - - app/graphql/types/tree/blob_type.rb - - ee/app/graphql/types/epic_type.rb - - ee/app/graphql/types/geo/geo_node_type.rb - - ee/app/graphql/types/requirements_management/requirement_states_count_type.rb - - ee/app/graphql/types/scan_execution_policy_type.rb - ee/app/graphql/types/scan_type.rb - - ee/app/graphql/types/scanned_resource_type.rb - - ee/app/graphql/types/security_report_summary_section_type.rb - ee/app/graphql/types/timebox_report_type.rb diff --git a/.rubocop_todo/graphql/resolver_method_length.yml b/.rubocop_todo/graphql/resolver_method_length.yml index 6fd8d41c548..e2183bb0894 100644 --- a/.rubocop_todo/graphql/resolver_method_length.yml +++ b/.rubocop_todo/graphql/resolver_method_length.yml @@ -3,5 +3,4 @@ GraphQL/ResolverMethodLength: Exclude: - app/graphql/types/ci/detailed_status_type.rb - app/graphql/types/ci/runner_type.rb - - app/graphql/types/ci/stage_type.rb - - app/graphql/types/packages/package_type.rb + - app/graphql/types/ci/stage_type.rb
\ No newline at end of file diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index 7ac7915b325..e889a05ad36 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -293,7 +293,6 @@ Layout/ArgumentAlignment: - 'ee/app/controllers/subscriptions_controller.rb' - 'ee/app/finders/geo/registry_finder.rb' - 'ee/app/graphql/ee/mutations/boards/issues/issue_move_list.rb' - - 'ee/app/graphql/ee/mutations/ci/ci_cd_settings_update.rb' - 'ee/app/graphql/ee/types/ci/pipeline_type.rb' - 'ee/app/graphql/ee/types/deprecated_mutations.rb' - 'ee/app/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create.rb' @@ -395,7 +394,6 @@ Layout/ArgumentAlignment: - 'ee/spec/features/uncompleted_learn_gitlab_link_spec.rb' - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' - 'ee/spec/frontend/fixtures/search.rb' - - 'ee/spec/graphql/mutations/incident_management/timeline_event/create_spec.rb' - 'ee/spec/graphql/mutations/requirements_management/export_requirements_spec.rb' - 'ee/spec/helpers/billing_plans_helper_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' @@ -780,7 +778,6 @@ Layout/ArgumentAlignment: - 'spec/lib/gitlab/usage/metrics/query_spec.rb' - 'spec/lib/gitlab/usage_data_counters/designs_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/snippet_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/static_site_editor_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/wiki_page_counter_spec.rb' - 'spec/lib/gitlab/usage_data_queries_spec.rb' - 'spec/lib/mattermost/session_spec.rb' diff --git a/.rubocop_todo/layout/hash_alignment.yml b/.rubocop_todo/layout/hash_alignment.yml index 32c4ddbced4..2125c032437 100644 --- a/.rubocop_todo/layout/hash_alignment.yml +++ b/.rubocop_todo/layout/hash_alignment.yml @@ -483,7 +483,6 @@ Layout/HashAlignment: - 'lib/backup/gitaly_backup.rb' - 'lib/banzai/filter/references/abstract_reference_filter.rb' - 'lib/banzai/reference_redactor.rb' - - 'lib/bulk_imports/projects/pipelines/project_attributes_pipeline.rb' - 'lib/gitlab/abuse.rb' - 'lib/gitlab/access.rb' - 'lib/gitlab/application_rate_limiter.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index a9200ee9fba..16d22183345 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -102,7 +102,6 @@ Layout/LineLength: - 'app/controllers/projects/pipelines_controller.rb' - 'app/controllers/projects/prometheus/metrics_controller.rb' - 'app/controllers/projects/raw_controller.rb' - - 'app/controllers/projects/services_controller.rb' - 'app/controllers/projects/settings/ci_cd_controller.rb' - 'app/controllers/projects/settings/operations_controller.rb' - 'app/controllers/projects/settings/repository_controller.rb' @@ -384,7 +383,6 @@ Layout/LineLength: - 'app/models/concerns/redis_cacheable.rb' - 'app/models/concerns/restricted_signup.rb' - 'app/models/concerns/routable.rb' - - 'app/models/concerns/sha256_attribute.rb' - 'app/models/concerns/shardable.rb' - 'app/models/concerns/sortable.rb' - 'app/models/concerns/storage/legacy_namespace.rb' @@ -433,7 +431,6 @@ Layout/LineLength: - 'app/models/integrations/flowdock.rb' - 'app/models/integrations/hangouts_chat.rb' - 'app/models/integrations/harbor.rb' - - 'app/models/integrations/irker.rb' - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/mattermost.rb' @@ -531,7 +528,6 @@ Layout/LineLength: - 'app/serializers/base_discussion_entity.rb' - 'app/serializers/build_details_entity.rb' - 'app/serializers/ci/pipeline_entity.rb' - - 'app/serializers/deploy_key_entity.rb' - 'app/serializers/deployment_cluster_entity.rb' - 'app/serializers/deployment_entity.rb' - 'app/serializers/diff_file_base_entity.rb' @@ -591,7 +587,6 @@ Layout/LineLength: - 'app/services/compare_service.rb' - 'app/services/concerns/base_service_utility.rb' - 'app/services/concerns/exclusive_lease_guard.rb' - - 'app/services/concerns/members/bulk_create_users.rb' - 'app/services/concerns/merge_requests/assigns_merge_params.rb' - 'app/services/concerns/rate_limited_service.rb' - 'app/services/concerns/schedule_bulk_repository_shard_moves_methods.rb' @@ -652,7 +647,6 @@ Layout/LineLength: - 'app/services/members/approve_access_request_service.rb' - 'app/services/members/destroy_service.rb' - 'app/services/members/invitation_reminder_email_service.rb' - - 'app/services/members/mailgun/process_webhook_service.rb' - 'app/services/members/update_service.rb' - 'app/services/merge_requests/add_context_service.rb' - 'app/services/merge_requests/assign_issues_service.rb' @@ -770,7 +764,6 @@ Layout/LineLength: - 'app/views/projects/merge_requests/index.atom.builder' - 'app/workers/analytics/usage_trends/counter_job_worker.rb' - 'app/workers/background_migration/single_database_worker.rb' - - 'app/workers/clusters/applications/deactivate_service_worker.rb' - 'app/workers/concerns/application_worker.rb' - 'app/workers/concerns/each_shard_worker.rb' - 'app/workers/concerns/limited_capacity/worker.rb' @@ -799,7 +792,6 @@ Layout/LineLength: - 'app/workers/packages/maven/metadata/sync_worker.rb' - 'app/workers/personal_access_tokens/expired_notification_worker.rb' - 'app/workers/pipeline_metrics_worker.rb' - - 'app/workers/quality/test_data_cleanup_worker.rb' - 'app/workers/repository_fork_worker.rb' - 'app/workers/repository_import_worker.rb' - 'app/workers/ssh_keys/expired_notification_worker.rb' @@ -835,7 +827,6 @@ Layout/LineLength: - 'config/initializers/wikicloth_redos_patch.rb' - 'config/initializers/zz_metrics.rb' - 'config/object_store_settings.rb' - - 'config/puma.rb' - 'config/routes.rb' - 'config/routes/admin.rb' - 'config/routes/api.rb' @@ -1001,7 +992,6 @@ Layout/LineLength: - 'db/migrate/20220310101118_update_holder_name_limit.rb' - 'db/migrate/20220314184209_add_group_fk_to_protected_environment_approval_rules.rb' - 'db/migrate/20220314204009_add_approval_rule_fk_to_deployment_approvals.rb' - - 'db/optional_migrations/composite_primary_keys.rb' - 'db/post_migrate/20210328214434_remove_temporary_index_from_vulnerabilities_table.rb' - 'db/post_migrate/20210401131948_move_container_registry_enabled_to_project_features2.rb' - 'db/post_migrate/20210402005225_add_source_and_level_index_on_notification_settings.rb' @@ -1181,7 +1171,6 @@ Layout/LineLength: - 'ee/app/controllers/projects/requirements_management/requirements_controller.rb' - 'ee/app/controllers/projects/security/policies_controller.rb' - 'ee/app/controllers/projects/security/vulnerabilities/notes_controller.rb' - - 'ee/app/controllers/projects/threat_monitoring_controller.rb' - 'ee/app/controllers/registrations/groups_controller.rb' - 'ee/app/controllers/registrations/groups_projects_controller.rb' - 'ee/app/controllers/subscriptions_controller.rb' @@ -1329,7 +1318,6 @@ Layout/LineLength: - 'ee/app/helpers/projects/security/dast_configuration_helper.rb' - 'ee/app/helpers/projects/security/dast_profiles_helper.rb' - 'ee/app/helpers/projects/security/discover_helper.rb' - - 'ee/app/helpers/projects/security/policies_helper.rb' - 'ee/app/helpers/push_rules_helper.rb' - 'ee/app/helpers/seats_count_alert_helper.rb' - 'ee/app/helpers/security_helper.rb' @@ -1529,7 +1517,6 @@ Layout/LineLength: - 'ee/app/services/ee/users/update_service.rb' - 'ee/app/services/elastic/cluster_reindexing_service.rb' - 'ee/app/services/elastic/indexing_control_service.rb' - - 'ee/app/services/epic_links/create_service.rb' - 'ee/app/services/epic_links/list_service.rb' - 'ee/app/services/epics/issue_promote_service.rb' - 'ee/app/services/epics/update_service.rb' @@ -1823,7 +1810,6 @@ Layout/LineLength: - 'ee/lib/gitlab/geo/jwt_request_decoder.rb' - 'ee/lib/gitlab/geo/log_cursor/events/repository_created_event.rb' - 'ee/lib/gitlab/geo/registry_batcher.rb' - - 'ee/lib/gitlab/geo/replication/base_downloader.rb' - 'ee/lib/gitlab/geo/replication/base_transfer.rb' - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' - 'ee/lib/gitlab/geo/replicator.rb' @@ -3101,7 +3087,6 @@ Layout/LineLength: - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' - 'ee/spec/views/shared/_mirror_status.html.haml_spec.rb' - 'ee/spec/views/shared/_namespace_user_cap_reached_alert.html.haml_spec.rb' - - 'ee/spec/views/shared/_user_over_limit_free_plan_alert.html.haml_spec.rb' - 'ee/spec/views/shared/access_tokens/_table.html.haml_spec.rb' - 'ee/spec/views/shared/billings/_eoa_bronze_plan_banner.html.haml_spec.rb' - 'ee/spec/views/shared/billings/_trial_status.html.haml_spec.rb' @@ -3316,7 +3301,6 @@ Layout/LineLength: - 'lib/bulk_imports/common/pipelines/wiki_pipeline.rb' - 'lib/bulk_imports/common/transformers/prohibited_attributes_transformer.rb' - 'lib/bulk_imports/groups/loaders/group_loader.rb' - - 'lib/bulk_imports/projects/pipelines/project_attributes_pipeline.rb' - 'lib/bulk_imports/projects/pipelines/project_pipeline.rb' - 'lib/bulk_imports/projects/pipelines/repository_pipeline.rb' - 'lib/bulk_imports/projects/transformers/project_attributes_transformer.rb' @@ -3467,11 +3451,9 @@ Layout/LineLength: - 'lib/gitlab/database/migrations/runner.rb' - 'lib/gitlab/database/migrations/test_background_runner.rb' - 'lib/gitlab/database/partitioning/detached_partition_dropper.rb' - - 'lib/gitlab/database/partitioning/partition_manager.rb' - 'lib/gitlab/database/partitioning/partition_monitoring.rb' - 'lib/gitlab/database/partitioning/replace_table.rb' - 'lib/gitlab/database/partitioning/single_numeric_list_partition.rb' - - 'lib/gitlab/database/partitioning/sliding_list_strategy.rb' - 'lib/gitlab/database/partitioning/time_partition.rb' - 'lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table.rb' - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' @@ -3684,7 +3666,6 @@ Layout/LineLength: - 'lib/gitlab/slash_commands/issue_new.rb' - 'lib/gitlab/sql/pattern.rb' - 'lib/gitlab/ssh_public_key.rb' - - 'lib/gitlab/static_site_editor/config/generated_config.rb' - 'lib/gitlab/subscription_portal.rb' - 'lib/gitlab/tracking.rb' - 'lib/gitlab/tracking/destinations/snowplow.rb' @@ -4207,7 +4188,6 @@ Layout/LineLength: - 'spec/controllers/projects/serverless/functions_controller_spec.rb' - 'spec/controllers/projects/service_desk_controller_spec.rb' - 'spec/controllers/projects/service_ping_controller_spec.rb' - - 'spec/controllers/projects/services_controller_spec.rb' - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - 'spec/controllers/projects/settings/operations_controller_spec.rb' - 'spec/controllers/projects/settings/repository_controller_spec.rb' @@ -4247,7 +4227,6 @@ Layout/LineLength: - 'spec/factories/project_members.rb' - 'spec/factories/projects.rb' - 'spec/factories/usage_data.rb' - - 'spec/factories_spec.rb' - 'spec/features/action_cable_logging_spec.rb' - 'spec/features/admin/admin_abuse_reports_spec.rb' - 'spec/features/admin/admin_mode/login_spec.rb' @@ -4791,12 +4770,10 @@ Layout/LineLength: - 'spec/lib/bulk_imports/groups/loaders/group_loader_spec.rb' - 'spec/lib/bulk_imports/groups/pipelines/group_pipeline_spec.rb' - 'spec/lib/bulk_imports/groups/pipelines/subgroup_entities_pipeline_spec.rb' - - 'spec/lib/bulk_imports/groups/stage_spec.rb' - 'spec/lib/bulk_imports/ndjson_pipeline_spec.rb' - 'spec/lib/bulk_imports/pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/external_pull_requests_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' - - 'spec/lib/bulk_imports/projects/pipelines/project_attributes_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_feature_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/protected_branches_pipeline_spec.rb' @@ -4999,7 +4976,6 @@ Layout/LineLength: - 'spec/lib/gitlab/database/partitioning/monthly_strategy_spec.rb' - 'spec/lib/gitlab/database/partitioning/partition_manager_spec.rb' - 'spec/lib/gitlab/database/partitioning/partition_monitoring_spec.rb' - - 'spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/index_helpers_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/database/postgres_foreign_key_spec.rb' @@ -5903,7 +5879,6 @@ Layout/LineLength: - 'spec/serializers/paginated_diff_entity_spec.rb' - 'spec/serializers/pipeline_serializer_spec.rb' - 'spec/serializers/review_app_setup_entity_spec.rb' - - 'spec/serializers/service_field_entity_spec.rb' - 'spec/services/alert_management/alerts/update_service_spec.rb' - 'spec/services/alert_management/create_alert_issue_service_spec.rb' - 'spec/services/alert_management/http_integrations/create_service_spec.rb' @@ -6224,7 +6199,6 @@ Layout/LineLength: - 'spec/support/helpers/global_id_deprecation_helpers.rb' - 'spec/support/helpers/graphql_helpers.rb' - 'spec/support/helpers/javascript_fixtures_helpers.rb' - - 'spec/support/helpers/jira_service_helper.rb' - 'spec/support/helpers/kubernetes_helpers.rb' - 'spec/support/helpers/lets_encrypt_helpers.rb' - 'spec/support/helpers/live_debugger.rb' @@ -6512,8 +6486,6 @@ Layout/LineLength: - 'spec/workers/ci/ref_delete_unlock_artifacts_worker_spec.rb' - 'spec/workers/ci/resource_groups/assign_resource_from_resource_group_worker_spec.rb' - 'spec/workers/cluster_wait_for_app_update_worker_spec.rb' - - 'spec/workers/clusters/applications/activate_service_worker_spec.rb' - - 'spec/workers/clusters/applications/deactivate_service_worker_spec.rb' - 'spec/workers/clusters/integrations/check_prometheus_health_worker_spec.rb' - 'spec/workers/concerns/application_worker_spec.rb' - 'spec/workers/concerns/project_import_options_spec.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index 2377553ccdb..e633f51209d 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -168,7 +168,6 @@ Layout/SpaceInLambdaLiteral: - 'app/serializers/review_app_setup_entity.rb' - 'app/serializers/rollout_status_entity.rb' - 'app/serializers/runner_entity.rb' - - 'app/serializers/service_event_entity.rb' - 'app/serializers/stage_entity.rb' - 'app/serializers/test_case_entity.rb' - 'app/serializers/test_suite_entity.rb' diff --git a/.rubocop_todo/layout/space_inside_block_braces.yml b/.rubocop_todo/layout/space_inside_block_braces.yml index b3830147692..961b27f26e7 100644 --- a/.rubocop_todo/layout/space_inside_block_braces.yml +++ b/.rubocop_todo/layout/space_inside_block_braces.yml @@ -407,7 +407,6 @@ Layout/SpaceInsideBlockBraces: - 'spec/initializers/trusted_proxies_spec.rb' - 'spec/lib/api/entities/ci/job_request/image_spec.rb' - 'spec/lib/api/entities/ci/job_request/port_spec.rb' - - 'spec/lib/api/helpers/sse_helpers_spec.rb' - 'spec/lib/api/helpers_spec.rb' - 'spec/lib/banzai/cross_project_reference_spec.rb' - 'spec/lib/banzai/filter/broadcast_message_placeholders_filter_spec.rb' diff --git a/.rubocop_todo/lint/missing_cop_enable_directive.yml b/.rubocop_todo/lint/missing_cop_enable_directive.yml index 589f98c9e02..4c1c8430204 100644 --- a/.rubocop_todo/lint/missing_cop_enable_directive.yml +++ b/.rubocop_todo/lint/missing_cop_enable_directive.yml @@ -156,7 +156,6 @@ Lint/MissingCopEnableDirective: - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - - 'lib/gitlab/background_migration/migrate_stage_status.rb' - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' @@ -182,7 +181,6 @@ Lint/MissingCopEnableDirective: - 'lib/gitlab/patch/action_cable_redis_listener.rb' - 'lib/gitlab/patch/prependable.rb' - 'lib/gitlab/project_search_results.rb' - - 'lib/gitlab/task_helpers.rb' - 'lib/gitlab/testing/request_blocker_middleware.rb' - 'lib/gitlab/testing/request_inspector_middleware.rb' - 'lib/gitlab/testing/robots_blocker_middleware.rb' @@ -192,4 +190,4 @@ Lint/MissingCopEnableDirective: - 'spec/support/capybara.rb' - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/google_api/cloud_platform_helpers.rb' - - 'tooling/danger/product_intelligence.rb' + - 'tooling/danger/product_intelligence.rb'
\ No newline at end of file diff --git a/.rubocop_todo/lint/mixed_regexp_capture_types.yml b/.rubocop_todo/lint/mixed_regexp_capture_types.yml index f9872fdbd7f..3dcb9427ef8 100644 --- a/.rubocop_todo/lint/mixed_regexp_capture_types.yml +++ b/.rubocop_todo/lint/mixed_regexp_capture_types.yml @@ -10,7 +10,6 @@ Lint/MixedRegexpCaptureTypes: - 'lib/gitlab/diff/suggestions_parser.rb' - 'lib/gitlab/github_import/representation/note.rb' - 'lib/gitlab/metrics/system.rb' - - 'lib/gitlab/request_profiler/profile.rb' - 'lib/gitlab/slash_commands/issue_move.rb' - 'lib/gitlab/slash_commands/issue_new.rb' - - 'lib/gitlab/slash_commands/run.rb' + - 'lib/gitlab/slash_commands/run.rb'
\ No newline at end of file diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index 83901a6843e..d058e23109b 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -6,22 +6,6 @@ Lint/RedundantCopDisableDirective: # REVEAL_RUBOCOP_TODO environment variable. Enabled: false Exclude: - - 'app/controllers/admin/dashboard_controller.rb' - - 'app/controllers/concerns/enforces_two_factor_authentication.rb' - - 'app/controllers/concerns/integrations/actions.rb' - - 'app/controllers/concerns/issues_calendar.rb' - - 'app/controllers/concerns/snippets_actions.rb' - - 'app/controllers/concerns/wiki_actions.rb' - - 'app/controllers/groups/autocomplete_sources_controller.rb' - - 'app/controllers/groups/labels_controller.rb' - - 'app/controllers/import/fogbugz_controller.rb' - - 'app/controllers/import/github_controller.rb' - - 'app/controllers/projects/issues_controller.rb' - - 'app/controllers/projects/jobs_controller.rb' - - 'app/controllers/projects/pipeline_schedules_controller.rb' - - 'app/controllers/projects/pipelines/tests_controller.rb' - - 'app/controllers/search_controller.rb' - - 'app/controllers/sessions_controller.rb' - 'app/finders/autocomplete/acts_as_taggable_on/tags_finder.rb' - 'app/finders/autocomplete/move_to_project_finder.rb' - 'app/finders/autocomplete/routes_finder.rb' diff --git a/.rubocop_todo/migration/background_migrations.yml b/.rubocop_todo/migration/background_migrations.yml new file mode 100644 index 00000000000..17548ef6b87 --- /dev/null +++ b/.rubocop_todo/migration/background_migrations.yml @@ -0,0 +1,83 @@ +--- +Migration/BackgroundMigrations: + Exclude: + - 'ee/db/geo/post_migrate/20220202101354_migrate_job_artifact_registry.rb' + - 'db/post_migrate/20220506124021_schedule_populate_requirements_issue_id.rb' + - 'db/post_migrate/20220502173045_reset_too_many_tags_skipped_registry_imports.rb' + - 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb' + - 'db/post_migrate/20220420214703_schedule_backfill_draft_status_on_merge_requests_corrected_regex.rb' + - 'db/post_migrate/20220420061450_backfill_null_note_discussion_ids.rb' + - 'db/post_migrate/20220407163559_schedule_purging_stale_security_scans.rb' + - 'db/post_migrate/20220331133802_schedule_backfill_topics_title.rb' + - 'db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb' + - 'db/post_migrate/20220328100456_schedule20220328_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' + - 'db/post_migrate/20220324081709_fix_and_backfill_project_namespaces_for_projects_with_duplicate_name.rb' + - 'db/post_migrate/20220324032250_migrate_shimo_confluence_service_category.rb' + - 'db/post_migrate/20220316202640_populate_container_repositories_migration_plan.rb' + - 'db/post_migrate/20220315171129_cleanup_draft_data_from_faulty_regex.rb' + - 'db/migrate/20210519154058_schedule_update_users_where_two_factor_auth_required_from_group.rb' + - 'db/post_migrate/20210302150310_schedule_migrate_pages_to_zip_storage.rb' + - 'db/post_migrate/20210304133508_schedule_remove_duplicate_vulnerabilities_findings2.rb' + - 'db/post_migrate/20210415155043_move_container_registry_enabled_to_project_features3.rb' + - 'db/post_migrate/20210421163509_schedule_update_jira_tracker_data_deployment_type_based_on_url.rb' + - 'db/post_migrate/20210423160427_schedule_drop_invalid_vulnerabilities.rb' + - 'db/post_migrate/20210427212034_schedule_update_timelogs_project_id.rb' + - 'db/post_migrate/20210506065000_schedule_backfill_traversal_ids.rb' + - 'db/post_migrate/20210511095658_schedule_migrate_project_taggings_context_from_tags_to_topics.rb' + - 'db/post_migrate/20210511142748_schedule_drop_invalid_vulnerabilities2.rb' + - 'db/post_migrate/20210514063252_schedule_cleanup_orphaned_lfs_objects_projects.rb' + - 'db/post_migrate/20210518074332_schedule_disable_expiration_policies_linked_to_no_container_images.rb' + - 'db/post_migrate/20210611080951_fix_missing_traversal_ids.rb' + - 'db/post_migrate/20210701111909_backfill_issues_upvotes_count.rb' + - 'db/post_migrate/20210722010101_reschedule_delete_orphaned_deployments.rb' + - 'db/post_migrate/20210729163312_re_schedule_latest_pipeline_id_population_with_all_security_related_artifact_types.rb' + - 'db/post_migrate/20210730104800_schedule_extract_project_topics_into_separate_table.rb' + - 'db/post_migrate/20210730170823_schedule_security_setting_creation.rb' + - 'db/post_migrate/20210816183304_schedule_copy_ci_builds_columns_to_security_scans2.rb' + - 'db/post_migrate/20210818185845_backfill_projects_with_coverage.rb' + - 'db/post_migrate/20211004110927_schedule_fix_first_mentioned_in_commit_at_job.rb' + - 'db/post_migrate/20211004120135_schedule_add_primary_email_to_emails_if_user_confirmed.rb' + - 'db/post_migrate/20211005194425_schedule_requirements_migration.rb' + - 'db/post_migrate/20211006060436_schedule_populate_topics_total_projects_count_cache.rb' + - 'db/post_migrate/20211007155221_schedule_populate_status_column_of_security_scans.rb' + - 'db/post_migrate/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3.rb' + - 'db/post_migrate/20211102114802_update_vulnerability_occurrences_location.rb' + - 'db/post_migrate/20211110151350_schedule_drop_invalid_security_findings.rb' + - 'db/post_migrate/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' + - 'db/post_migrate/20211118194239_drop_invalid_remediations.rb' + - 'db/post_migrate/20211208122200_schedule_backfill_ci_namespace_mirrors.rb' + - 'db/post_migrate/20211208122201_schedule_backfill_ci_project_mirrors.rb' + - 'db/post_migrate/20211209203821_convert_stringified_raw_metadata_hash_to_json.rb' + - 'db/post_migrate/20211210140629_encrypt_static_object_token.rb' + - 'db/post_migrate/20211215090620_schedule_update_timelogs_null_spent_at.rb' + - 'db/post_migrate/20220107064845_populate_vulnerability_reads.rb' + - 'db/post_migrate/20220110171049_schedule_populate_test_reports_issue_id.rb' + - 'db/post_migrate/20220125122640_schedule_populate_topics_non_private_projects_count.rb' + - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' + - 'db/post_migrate/20220204194347_encrypt_integration_properties.rb' + - 'db/post_migrate/20220208115439_start_backfill_ci_queuing_tables.rb' + - 'db/post_migrate/20220215190020_rerun_convert_stringified_raw_metadata_hash_to_json.rb' + - 'db/post_migrate/20220308115219_schedule_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' + - 'db/post_migrate/20220308115502_schedule_reset_duplicate_ci_runners_token_values_on_projects.rb' + - 'db/post_migrate/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4.rb' + - 'db/post_migrate/20210604070207_retry_backfill_traversal_ids.rb' + - 'db/post_migrate/20210708130419_reschedule_merge_request_diff_users_background_migration.rb' + - 'db/post_migrate/20210823113259_steal_merge_request_diff_commit_users_migration.rb' + - 'db/post_migrate/20210825193652_backfill_cadence_id_for_boards_scoped_to_iteration.rb' + - 'db/post_migrate/20210830104800_reschedule_extract_project_topics_into_separate_table.rb' + - 'db/post_migrate/20210901153324_slice_merge_request_diff_commit_migrations.rb' + - 'db/post_migrate/20210909104800_reschedule_extract_project_topics_into_separate_table_2.rb' + - 'db/post_migrate/20211005010101_rereschedule_delete_orphaned_deployments.rb' + - 'db/post_migrate/20211028155449_schedule_fix_merge_request_diff_commit_users_migration.rb' + - 'db/post_migrate/20211208171402_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb' + - 'db/post_migrate/20220113111440_schedule_fix_incorrect_max_seats_used.rb' + - 'db/post_migrate/20220118204039_self_managed_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb' + - 'db/post_migrate/20220204095121_backfill_namespace_statistics_with_dependency_proxy_size.rb' + - 'db/post_migrate/20220212120735_schedule_fix_incorrect_max_seats_used2.rb' + - 'db/post_migrate/20220223124428_schedule_merge_topics_with_same_name.rb' + - 'db/post_migrate/20210302074524_backfill_namespace_statistics_with_wiki_size.rb' + - 'lib/gitlab/database/migrations/background_migration_helpers.rb' + - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' + - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' + - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/test_background_runner_spec.rb' diff --git a/.rubocop_todo/naming/heredoc_delimiter_naming.yml b/.rubocop_todo/naming/heredoc_delimiter_naming.yml index 86d9ae2f24d..c1d058240a4 100644 --- a/.rubocop_todo/naming/heredoc_delimiter_naming.yml +++ b/.rubocop_todo/naming/heredoc_delimiter_naming.yml @@ -105,7 +105,6 @@ Naming/HeredocDelimiterNaming: - 'spec/lib/gitlab/patch/database_config_spec.rb' - 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb' - 'spec/lib/gitlab/quick_actions/substitution_definition_spec.rb' - - 'spec/lib/gitlab/static_site_editor/config/file_config_spec.rb' - 'spec/lib/gitlab/web_ide/config_spec.rb' - 'spec/lib/gitlab/webpack/file_loader_spec.rb' - 'spec/lib/gitlab/webpack/graphql_known_operations_spec.rb' diff --git a/.rubocop_todo/naming/rescued_exceptions_variable_name.yml b/.rubocop_todo/naming/rescued_exceptions_variable_name.yml index 8d4d2da29ac..0e753a53dc3 100644 --- a/.rubocop_todo/naming/rescued_exceptions_variable_name.yml +++ b/.rubocop_todo/naming/rescued_exceptions_variable_name.yml @@ -86,7 +86,6 @@ Naming/RescuedExceptionsVariableName: - 'app/workers/namespaces/schedule_aggregation_worker.rb' - 'app/workers/packages/go/sync_packages_worker.rb' - 'app/workers/project_destroy_worker.rb' - - 'app/workers/project_service_worker.rb' - 'app/workers/projects/git_garbage_collect_worker.rb' - 'app/workers/remove_expired_members_worker.rb' - 'app/workers/users/create_statistics_worker.rb' diff --git a/.rubocop_todo/performance/active_record_subtransaction_methods.yml b/.rubocop_todo/performance/active_record_subtransaction_methods.yml index ada27f99eb9..2644f08c4d1 100644 --- a/.rubocop_todo/performance/active_record_subtransaction_methods.yml +++ b/.rubocop_todo/performance/active_record_subtransaction_methods.yml @@ -1,62 +1,50 @@ --- Performance/ActiveRecordSubtransactionMethods: Exclude: - - app/controllers/clusters/clusters_controller.rb - - app/controllers/repositories/lfs_storage_controller.rb - - app/controllers/search_controller.rb - - app/models/application_record.rb - - app/models/ci/ref.rb - - app/models/container_repository.rb - - app/models/design_management/design_collection.rb - - app/models/error_tracking/error.rb - - app/models/external_pull_request.rb - - app/models/merge_request.rb - - app/models/plan.rb - - app/models/project.rb - - app/models/shard.rb - - app/models/x509_certificate.rb - - app/models/x509_commit_signature.rb - - app/models/x509_issuer.rb - - app/models/concerns/commit_signature.rb - - app/services/bulk_imports/relation_export_service.rb - - app/services/ci/update_build_state_service.rb - - app/services/event_create_service.rb - - app/services/groups/import_export/import_service.rb - - app/services/lfs/file_transformer.rb - - app/services/merge_requests/approval_service.rb - - app/services/namespaces/statistics_refresher_service.rb - - app/services/packages/rubygems/create_dependencies_service.rb - - app/services/packages/rubygems/metadata_extraction_service.rb - - app/services/projects/create_service.rb - - app/services/projects/lfs_pointers/lfs_download_service.rb - - app/services/service_desk_settings/update_service.rb - - app/services/service_ping/submit_service.rb - - app/services/terraform/remote_state_handler.rb - - app/workers/namespaces/schedule_aggregation_worker.rb - - app/workers/project_export_worker.rb - - db/migrate/20200212014653_rename_security_dashboard_feature_flag_to_instance_security_dashboard.rb - - db/post_migrate/20200214034836_remove_security_dashboard_feature_flag.rb - - db/post_migrate/20210824174615_prepare_ci_builds_metadata_and_ci_build_async_indexes.rb - - ee/app/models/ci/minutes/namespace_monthly_usage.rb - - ee/app/models/ci/minutes/project_monthly_usage.rb - - ee/app/models/concerns/deprecated_approvals_before_merge.rb - - ee/app/models/ee/iteration.rb - - ee/app/models/ee/plan.rb - - ee/app/models/elastic/index_setting.rb - - ee/app/models/gitlab_subscription.rb - - ee/app/models/software_license.rb - - ee/app/services/boards/user_preferences/update_service.rb - - ee/app/services/ci/minutes/update_project_and_namespace_usage_service.rb - - ee/app/services/ee/analytics/cycle_analytics/stages/base_service.rb - - ee/app/services/security/store_report_service.rb - - ee/app/services/security/store_scan_service.rb - - ee/app/workers/import_software_licenses_worker.rb - - ee/db/fixtures/production/027_plans.rb - - ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb - - ee/lib/gitlab/elastic/indexer.rb - - lib/gitlab/ci/pipeline/seed/environment.rb - - lib/gitlab/ci/pipeline/seed/processable/resource_group.rb - - lib/gitlab/ci/trace/chunked_io.rb - - lib/gitlab/composer/cache.rb - - lib/gitlab/database/async_indexes/migration_helpers.rb - - lib/gitlab/issuables_count_for_state.rb + - 'app/controllers/repositories/lfs_storage_controller.rb' + - 'app/controllers/search_controller.rb' + - 'app/models/application_record.rb' + - 'app/models/ci/ref.rb' + - 'app/models/concerns/commit_signature.rb' + - 'app/models/container_repository.rb' + - 'app/models/design_management/design_collection.rb' + - 'app/models/error_tracking/error.rb' + - 'app/models/external_pull_request.rb' + - 'app/models/plan.rb' + - 'app/models/project.rb' + - 'app/models/shard.rb' + - 'app/models/x509_certificate.rb' + - 'app/models/x509_issuer.rb' + - 'app/services/bulk_imports/relation_export_service.rb' + - 'app/services/ci/update_build_state_service.rb' + - 'app/services/event_create_service.rb' + - 'app/services/groups/import_export/import_service.rb' + - 'app/services/lfs/file_transformer.rb' + - 'app/services/merge_requests/approval_service.rb' + - 'app/services/namespaces/statistics_refresher_service.rb' + - 'app/services/packages/rubygems/create_dependencies_service.rb' + - 'app/services/projects/create_service.rb' + - 'app/services/projects/lfs_pointers/lfs_download_service.rb' + - 'app/services/service_desk_settings/update_service.rb' + - 'app/services/terraform/remote_state_handler.rb' + - 'app/workers/namespaces/schedule_aggregation_worker.rb' + - 'app/workers/project_export_worker.rb' + - 'ee/app/models/ci/minutes/project_monthly_usage.rb' + - 'ee/app/models/concerns/deprecated_approvals_before_merge.rb' + - 'ee/app/models/ee/plan.rb' + - 'ee/app/models/elastic/index_setting.rb' + - 'ee/app/models/gitlab_subscription.rb' + - 'ee/app/models/software_license.rb' + - 'ee/app/services/boards/user_preferences/update_service.rb' + - 'ee/app/services/ci/minutes/update_project_and_namespace_usage_service.rb' + - 'ee/app/services/ee/analytics/cycle_analytics/stages/base_service.rb' + - 'ee/app/services/security/store_scan_service.rb' + - 'ee/app/workers/import_software_licenses_worker.rb' + - 'ee/db/fixtures/production/027_plans.rb' + - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' + - 'ee/lib/gitlab/elastic/indexer.rb' + - 'lib/gitlab/ci/pipeline/seed/environment.rb' + - 'lib/gitlab/ci/pipeline/seed/processable/resource_group.rb' + - 'lib/gitlab/ci/trace/chunked_io.rb' + - 'lib/gitlab/composer/cache.rb' + - 'lib/gitlab/issuables_count_for_state.rb' diff --git a/.rubocop_todo/performance/block_given_with_explicit_block.yml b/.rubocop_todo/performance/block_given_with_explicit_block.yml index ae61c5a86e6..ff1f5e568ea 100644 --- a/.rubocop_todo/performance/block_given_with_explicit_block.yml +++ b/.rubocop_todo/performance/block_given_with_explicit_block.yml @@ -12,7 +12,6 @@ Performance/BlockGivenWithExplicitBlock: - 'app/helpers/tab_helper.rb' - 'app/services/base_count_service.rb' - 'app/services/error_tracking/base_service.rb' - - 'app/services/projects/open_issues_count_service.rb' - 'app/services/users/update_service.rb' - 'ee/lib/elastic/latest/query_context.rb' - 'ee/lib/gitlab/geo.rb' @@ -35,7 +34,6 @@ Performance/BlockGivenWithExplicitBlock: - 'lib/gitlab/usage_data_queries.rb' - 'lib/gitlab/utils/usage_data.rb' - 'qa/qa/page/view.rb' - - 'qa/qa/runtime/browser.rb' - 'spec/lib/api/helpers/authentication_spec.rb' - 'spec/lib/gitlab/slash_commands/deploy_spec.rb' - 'spec/support/helpers/graphql_helpers.rb' diff --git a/.rubocop_todo/performance/constant_regexp.yml b/.rubocop_todo/performance/constant_regexp.yml index fb2b7d6ef49..4ed40db498f 100644 --- a/.rubocop_todo/performance/constant_regexp.yml +++ b/.rubocop_todo/performance/constant_regexp.yml @@ -28,5 +28,4 @@ Performance/ConstantRegexp: - 'scripts/perf/query_limiting_report.rb' - 'scripts/validate_migration_schema' - 'spec/models/concerns/token_authenticatable_spec.rb' - - 'spec/scripts/lib/glfm/update_specification_spec.rb' - 'spec/services/notes/copy_service_spec.rb' diff --git a/.rubocop_todo/performance/rubyzip.yml b/.rubocop_todo/performance/rubyzip.yml index a0752fa51cd..c49fae8bbab 100644 --- a/.rubocop_todo/performance/rubyzip.yml +++ b/.rubocop_todo/performance/rubyzip.yml @@ -1,5 +1,5 @@ --- Performance/Rubyzip: Exclude: - - app/services/packages/nuget/metadata_extraction_service.rb - - lib/gitlab/ci/artifact_file_reader.rb + - 'app/services/packages/nuget/metadata_extraction_service.rb' + - 'lib/gitlab/ci/artifact_file_reader.rb' diff --git a/.rubocop_todo/performance/string_include.yml b/.rubocop_todo/performance/string_include.yml index cb6e566094e..f477593c02a 100644 --- a/.rubocop_todo/performance/string_include.yml +++ b/.rubocop_todo/performance/string_include.yml @@ -10,6 +10,5 @@ Performance/StringInclude: - 'lib/gitlab/database/migration_helpers.rb' - 'lib/kramdown/parser/atlassian_document_format.rb' - 'lib/prometheus/pid_provider.rb' - - 'qa/qa/specs/runner.rb' - 'spec/features/projects/jobs_spec.rb' - 'spec/spec_helper.rb' diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml index 58fa6d6255d..1c442dcdec7 100644 --- a/.rubocop_todo/rails/file_path.yml +++ b/.rubocop_todo/rails/file_path.yml @@ -31,7 +31,6 @@ Rails/FilePath: - 'ee/db/fixtures/development/32_compliance_report_violations.rb' - 'ee/lib/ee/feature/definition.rb' - 'ee/lib/ee/gitlab/usage/metric_definition.rb' - - 'ee/lib/generators/geo_migration/geo_migration_generator.rb' - 'ee/lib/gitlab/geo/health_check.rb' - 'ee/lib/tasks/gitlab/seed/metrics.rake' - 'ee/spec/db/production/license_spec.rb' @@ -46,7 +45,6 @@ Rails/FilePath: - 'ee/spec/requests/api/experiments_spec.rb' - 'ee/spec/services/ee/merge_requests/refresh_service_spec.rb' - 'ee/spec/support/factory_bot.rb' - - 'ee/spec/uploaders/every_gitlab_uploader_spec.rb' - 'ee/spec/validators/json_schema_validator_spec.rb' - 'lib/api/api.rb' - 'lib/error_tracking/collector/payload_validator.rb' diff --git a/.rubocop_todo/rails/lexically_scoped_action_filter.yml b/.rubocop_todo/rails/lexically_scoped_action_filter.yml index 84b85f76c68..9edc8f7ce58 100644 --- a/.rubocop_todo/rails/lexically_scoped_action_filter.yml +++ b/.rubocop_todo/rails/lexically_scoped_action_filter.yml @@ -36,7 +36,6 @@ Rails/LexicallyScopedActionFilter: - 'app/controllers/projects/project_members_controller.rb' - 'app/controllers/projects/prometheus/alerts_controller.rb' - 'app/controllers/projects/releases_controller.rb' - - 'app/controllers/projects/service_hook_logs_controller.rb' - 'app/controllers/projects/snippets_controller.rb' - 'app/controllers/projects/tags_controller.rb' - 'app/controllers/projects/todos_controller.rb' diff --git a/.rubocop_todo/rails/mailer_name.yml b/.rubocop_todo/rails/mailer_name.yml deleted file mode 100644 index 17e55c178f7..00000000000 --- a/.rubocop_todo/rails/mailer_name.yml +++ /dev/null @@ -1,5 +0,0 @@ ---- -# Cop supports --auto-correct. -Rails/MailerName: - Exclude: - - 'app/mailers/notify.rb' diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml index 608801085d4..860b772d913 100644 --- a/.rubocop_todo/rails/pluck.yml +++ b/.rubocop_todo/rails/pluck.yml @@ -15,13 +15,10 @@ Rails/Pluck: - 'app/services/ci/pipeline_processing/atomic_processing_service/status_collection.rb' - 'app/services/feature_flags/update_service.rb' - 'app/services/pod_logs/base_service.rb' - - 'app/services/prometheus/create_default_alerts_service.rb' - 'ee/app/graphql/mutations/incident_management/oncall_rotation/base.rb' - 'ee/app/models/boards/epic_list.rb' - - 'ee/app/models/vulnerabilities/finding.rb' - 'ee/app/services/concerns/incident_management/oncall_rotations/shared_rotation_logic.rb' - 'ee/app/workers/geo/container_repository_sync_dispatch_worker.rb' - - 'ee/app/workers/geo/file_download_dispatch_worker.rb' - 'ee/app/workers/geo/registry_sync_worker.rb' - 'ee/app/workers/geo/repository_shard_sync_worker.rb' - 'ee/app/workers/geo/repository_verification/secondary/shard_worker.rb' diff --git a/.rubocop_todo/rails/redundant_foreign_key.yml b/.rubocop_todo/rails/redundant_foreign_key.yml index 6b2300ba792..db6e6cedc89 100644 --- a/.rubocop_todo/rails/redundant_foreign_key.yml +++ b/.rubocop_todo/rails/redundant_foreign_key.yml @@ -52,7 +52,6 @@ Rails/RedundantForeignKey: - 'ee/app/models/incident_management/oncall_shift.rb' - 'ee/app/models/incident_management/pending_escalations/alert.rb' - 'ee/app/models/incident_management/pending_escalations/issue.rb' - - 'ee/app/models/incident_management/timeline_event.rb' - 'ee/app/models/issuable_metric_image.rb' - 'ee/app/models/security/orchestration_policy_configuration.rb' - 'ee/app/models/security/orchestration_policy_rule_schedule.rb' diff --git a/.rubocop_todo/rails/skips_model_validations.yml b/.rubocop_todo/rails/skips_model_validations.yml index e6402ef27f2..75a0d49862e 100644 --- a/.rubocop_todo/rails/skips_model_validations.yml +++ b/.rubocop_todo/rails/skips_model_validations.yml @@ -103,11 +103,9 @@ Rails/SkipsModelValidations: - 'app/services/keys/last_used_service.rb' - 'app/services/labels/promote_service.rb' - 'app/services/labels/transfer_service.rb' - - 'app/services/merge_requests/base_service.rb' - 'app/services/merge_requests/bulk_remove_attention_requested_service.rb' - 'app/services/merge_requests/cleanup_refs_service.rb' - 'app/services/merge_requests/ff_merge_service.rb' - - 'app/services/merge_requests/handle_assignees_change_service.rb' - 'app/services/merge_requests/merge_service.rb' - 'app/services/merge_requests/rebase_service.rb' - 'app/services/merge_requests/reopen_service.rb' @@ -150,7 +148,6 @@ Rails/SkipsModelValidations: - 'app/workers/concerns/dependency_proxy/expireable.rb' - 'app/workers/concerns/packages/cleanup_artifact_worker.rb' - 'app/workers/container_expiration_policy_worker.rb' - - 'app/workers/namespaceless_project_destroy_worker.rb' - 'app/workers/packages/helm/extraction_worker.rb' - 'app/workers/packages/nuget/extraction_worker.rb' - 'app/workers/packages/rubygems/extraction_worker.rb' @@ -223,7 +220,6 @@ Rails/SkipsModelValidations: - 'ee/app/services/ee/users/migrate_to_ghost_user_service.rb' - 'ee/app/services/epics/strategies/due_date_inherited_strategy.rb' - 'ee/app/services/epics/strategies/start_date_inherited_strategy.rb' - - 'ee/app/services/geo/job_artifact_deleted_event_store.rb' - 'ee/app/services/geo/repository_verification_reset.rb' - 'ee/app/services/incident_management/oncall_rotations/edit_service.rb' - 'ee/app/services/incident_management/oncall_rotations/remove_participant_service.rb' @@ -292,9 +288,6 @@ Rails/SkipsModelValidations: - 'ee/spec/lib/gitlab/custom_file_templates_spec.rb' - 'ee/spec/lib/gitlab/geo/geo_tasks_spec.rb' - 'ee/spec/lib/gitlab/geo/jwt_request_decoder_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/file_downloader_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/job_artifact_downloader_spec.rb' - 'ee/spec/lib/gitlab/geo/signed_data_spec.rb' - 'ee/spec/lib/gitlab/git_access_spec.rb' - 'ee/spec/models/application_setting_spec.rb' @@ -306,7 +299,6 @@ Rails/SkipsModelValidations: - 'ee/spec/models/ee/groups/feature_setting_spec.rb' - 'ee/spec/models/ee/iteration_spec.rb' - 'ee/spec/models/ee/iterations/cadence_spec.rb' - - 'ee/spec/models/ee/key_spec.rb' - 'ee/spec/models/ee/namespace_limit_spec.rb' - 'ee/spec/models/ee/vulnerability_spec.rb' - 'ee/spec/models/geo_node_spec.rb' @@ -349,7 +341,6 @@ Rails/SkipsModelValidations: - 'ee/spec/services/epic_issues/update_service_spec.rb' - 'ee/spec/services/epics/issue_promote_service_spec.rb' - 'ee/spec/services/epics/update_service_spec.rb' - - 'ee/spec/services/geo/file_download_service_spec.rb' - 'ee/spec/services/geo/file_registry_removal_service_spec.rb' - 'ee/spec/services/geo/hashed_storage_migration_service_spec.rb' - 'ee/spec/services/groups/create_service_spec.rb' @@ -380,7 +371,6 @@ Rails/SkipsModelValidations: - 'ee/spec/workers/import_software_licenses_worker_spec.rb' - 'ee/spec/workers/iterations/roll_over_issues_worker_spec.rb' - 'ee/spec/workers/iterations_update_status_worker_spec.rb' - - 'ee/spec/workers/network_policy_metrics_worker_spec.rb' - 'ee/spec/workers/security/orchestration_policy_rule_schedule_namespace_worker_spec.rb' - 'ee/spec/workers/security/orchestration_policy_rule_schedule_worker_spec.rb' - 'ee/spec/workers/update_all_mirrors_worker_spec.rb' @@ -485,9 +475,7 @@ Rails/SkipsModelValidations: - 'spec/features/projects/diffs/diff_show_spec.rb' - 'spec/features/projects/features_visibility_spec.rb' - 'spec/features/projects/fork_spec.rb' - - 'spec/features/projects/jobs/user_browses_jobs_spec.rb' - 'spec/features/projects/jobs_spec.rb' - - 'spec/features/projects/members/invite_group_spec.rb' - 'spec/features/projects/milestones/milestone_spec.rb' - 'spec/features/projects/pipeline_schedules_spec.rb' - 'spec/features/projects/pipelines/pipeline_spec.rb' diff --git a/.rubocop_todo/rails/time_zone.yml b/.rubocop_todo/rails/time_zone.yml index ff97dfeb444..48e559312f8 100644 --- a/.rubocop_todo/rails/time_zone.yml +++ b/.rubocop_todo/rails/time_zone.yml @@ -6,7 +6,6 @@ Rails/TimeZone: - ee/lib/delay.rb - ee/lib/gitlab/elastic/helper.rb - ee/lib/gitlab/elastic/indexer.rb - - ee/lib/gitlab/geo/base_request.rb - ee/lib/gitlab/geo/event_gap_tracking.rb - ee/lib/gitlab/geo/log_cursor/events/design_repository_updated_event.rb - ee/lib/gitlab/geo/log_cursor/events/repository_updated_event.rb @@ -17,11 +16,9 @@ Rails/TimeZone: - ee/spec/lib/ee/gitlab/ci/pipeline/quota/job_activity_spec.rb - ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb - ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary_spec.rb - - ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_time_summary_spec.rb - ee/spec/lib/gitlab/auth/ldap/access_spec.rb - ee/spec/lib/gitlab/auth/smartcard/san_extension_spec.rb - ee/spec/lib/gitlab/auth/smartcard/session_spec.rb - - ee/spec/lib/gitlab/background_migration/fix_orphan_promoted_issues_spec.rb - ee/spec/lib/gitlab/ci/pipeline/chain/limit/job_activity_spec.rb - ee/spec/lib/gitlab/elastic/client_spec.rb - ee/spec/lib/gitlab/geo/base_request_spec.rb @@ -31,8 +28,6 @@ Rails/TimeZone: - ee/spec/lib/gitlab/geo/log_cursor/events/event_spec.rb - ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_attachments_event_spec.rb - ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_migrated_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/job_artifact_deleted_event_spec.rb - - ee/spec/lib/gitlab/geo/log_cursor/events/lfs_object_deleted_event_spec.rb - ee/spec/lib/gitlab/geo/log_cursor/events/repositories_changed_event_spec.rb - ee/spec/lib/gitlab/geo/log_cursor/events/repository_created_event_spec.rb - ee/spec/lib/gitlab/geo/log_cursor/events/repository_deleted_event_spec.rb @@ -51,23 +46,17 @@ Rails/TimeZone: - lib/gitlab/auth/ldap/access.rb - lib/gitlab/chaos.rb - lib/gitlab/checks/timed_logger.rb - - lib/gitlab/ci/ansi2json/line.rb - - lib/gitlab/ci/pipeline/chain/sequence.rb - lib/gitlab/ci/pipeline/duration.rb - - lib/gitlab/cycle_analytics/summary/deployment_frequency.rb - lib/gitlab/database.rb - lib/gitlab/external_authorization/access.rb - lib/gitlab/external_authorization/cache.rb - lib/gitlab/gitaly_client.rb - lib/gitlab/gitaly_client/ref_service.rb - lib/gitlab/github_import/representation.rb - - lib/gitlab/grape_logging/loggers/queue_duration_logger.rb - lib/gitlab/health_checks/base_abstract_check.rb - lib/gitlab/import_export.rb - lib/gitlab/instrumentation/elasticsearch_transport.rb - - lib/gitlab/instrumentation/redis_interceptor.rb - lib/gitlab/instrumentation_helper.rb - - lib/gitlab/kubernetes/helm/certificate.rb - lib/gitlab/lfs_token.rb - lib/gitlab/loop_helpers.rb - lib/gitlab/phabricator_import/representation/task.rb @@ -80,8 +69,6 @@ Rails/TimeZone: - lib/json_web_token/token.rb - lib/object_storage/direct_upload.rb - lib/quality/seeders/issues.rb - - tooling/rspec_flaky/flaky_example.rb - - tooling/rspec_flaky/report.rb - lib/tasks/gitlab/assets.rake - lib/tasks/gitlab/backup.rake - lib/tasks/gitlab/cleanup.rake @@ -91,14 +78,11 @@ Rails/TimeZone: - spec/lib/gitlab/app_json_logger_spec.rb - spec/lib/gitlab/app_text_logger_spec.rb - spec/lib/gitlab/auth/current_user_mode_spec.rb - - spec/lib/gitlab/background_migration/recalculate_project_authorizations_spec.rb - - spec/lib/gitlab/background_migration/wrongfully_confirmed_email_unconfirmer_spec.rb - spec/lib/gitlab/bitbucket_import/importer_spec.rb - spec/lib/gitlab/bitbucket_server_import/importer_spec.rb - spec/lib/gitlab/checks/timed_logger_spec.rb - spec/lib/gitlab/ci/cron_parser_spec.rb - spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb - - spec/lib/gitlab/cycle_analytics/usage_data_spec.rb - spec/lib/gitlab/data_builder/note_spec.rb - spec/lib/gitlab/database/background_migration_job_spec.rb - spec/lib/gitlab/database_spec.rb @@ -111,7 +95,6 @@ Rails/TimeZone: - spec/lib/gitlab/git/commit_spec.rb - spec/lib/gitlab/git/repository_spec.rb - spec/lib/gitlab/git_access_spec.rb - - spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb - spec/lib/gitlab/github_import/importer/issue_importer_spec.rb - spec/lib/gitlab/github_import/importer/issues_importer_spec.rb - spec/lib/gitlab/github_import/importer/milestones_importer_spec.rb @@ -132,19 +115,14 @@ Rails/TimeZone: - spec/lib/gitlab/lfs_token_spec.rb - spec/lib/gitlab/log_timestamp_formatter_spec.rb - spec/lib/gitlab/middleware/rails_queue_duration_spec.rb - - spec/lib/gitlab/omniauth_logging/json_formatter_spec.rb - spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb - spec/lib/gitlab/phabricator_import/representation/task_spec.rb - spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb - spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb - spec/lib/gitlab/prometheus/queries/validate_query_spec.rb - spec/lib/gitlab/sidekiq_logging/json_formatter_spec.rb - - spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/until_executing_spec.rb - spec/lib/gitlab/updated_notes_paginator_spec.rb - spec/lib/gitlab/utils/json_size_estimator_spec.rb - spec/lib/gitlab/x509/signature_spec.rb - spec/lib/grafana/time_window_spec.rb - spec/lib/json_web_token/hmac_token_spec.rb - - spec/tooling/rspec_flaky/flaky_example_spec.rb - - spec/tooling/rspec_flaky/listener_spec.rb - - spec/tooling/rspec_flaky/report_spec.rb diff --git a/.rubocop_todo/rspec/any_instance_of.yml b/.rubocop_todo/rspec/any_instance_of.yml index 32bf03b18ad..399d1751687 100644 --- a/.rubocop_todo/rspec/any_instance_of.yml +++ b/.rubocop_todo/rspec/any_instance_of.yml @@ -152,8 +152,8 @@ RSpec/AnyInstanceOf: - spec/controllers/projects/labels_controller_spec.rb - spec/controllers/projects/merge_requests_controller_spec.rb - spec/controllers/projects/pipelines_controller_spec.rb - - spec/controllers/projects/service_hook_logs_controller_spec.rb - - spec/controllers/projects/services_controller_spec.rb + - spec/controllers/projects/settings/integration_hook_logs_controller_spec.rb + - spec/controllers/projects/settings/integrations_controller_spec.rb - spec/controllers/projects/tags_controller_spec.rb - spec/controllers/registrations/experience_levels_controller_spec.rb - spec/controllers/registrations_controller_spec.rb @@ -177,7 +177,6 @@ RSpec/AnyInstanceOf: - spec/features/projects/jobs_spec.rb - spec/features/projects/navbar_spec.rb - spec/features/projects/pages_spec.rb - - spec/features/projects/services/user_activates_mattermost_slash_command_spec.rb - spec/features/projects/settings/service_desk_setting_spec.rb - spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb - spec/features/snippets/embedded_snippet_spec.rb @@ -485,7 +484,6 @@ RSpec/AnyInstanceOf: - spec/workers/expire_pipeline_cache_worker_spec.rb - spec/workers/group_export_worker_spec.rb - spec/workers/group_import_worker_spec.rb - - spec/workers/namespaceless_project_destroy_worker_spec.rb - spec/workers/namespaces/root_statistics_worker_spec.rb - spec/workers/new_note_worker_spec.rb - spec/workers/object_pool/create_worker_spec.rb diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 8734fca753f..0e313122b09 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -824,7 +824,6 @@ RSpec/ContextWording: - 'ee/spec/serializers/member_user_entity_spec.rb' - 'ee/spec/serializers/merge_request_widget_entity_spec.rb' - 'ee/spec/serializers/project_mirror_entity_spec.rb' - - 'ee/spec/serializers/service_field_entity_spec.rb' - 'ee/spec/serializers/vulnerabilities/finding_entity_spec.rb' - 'ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/consistency_check_service_spec.rb' @@ -1053,7 +1052,6 @@ RSpec/ContextWording: - 'ee/spec/services/vulnerability_exports/export_service_spec.rb' - 'ee/spec/services/vulnerability_external_issue_links/create_service_spec.rb' - 'ee/spec/support/features/manual_quarterly_co_term_banner_examples.rb' - - 'ee/spec/support/features/manual_renewal_banner_examples.rb' - 'ee/spec/support/protected_tags/access_control_shared_examples.rb' - 'ee/spec/support/shared_contexts/audit_event_not_licensed_shared_context.rb' - 'ee/spec/support/shared_contexts/audit_event_queue_shared_context.rb' @@ -1383,7 +1381,6 @@ RSpec/ContextWording: - 'spec/controllers/projects/settings/repository_controller_spec.rb' - 'spec/controllers/projects/snippets_controller_spec.rb' - 'spec/controllers/projects/starrers_controller_spec.rb' - - 'spec/controllers/projects/static_site_editor_controller_spec.rb' - 'spec/controllers/projects/tags_controller_spec.rb' - 'spec/controllers/projects/todos_controller_spec.rb' - 'spec/controllers/projects/tree_controller_spec.rb' @@ -2511,7 +2508,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/spamcheck/client_spec.rb' - 'spec/lib/gitlab/sql/pattern_spec.rb' - 'spec/lib/gitlab/ssh_public_key_spec.rb' - - 'spec/lib/gitlab/static_site_editor/config/file_config/entry/mount_spec.rb' - 'spec/lib/gitlab/submodule_links_spec.rb' - 'spec/lib/gitlab/subscription_portal_spec.rb' - 'spec/lib/gitlab/suggestions/commit_message_spec.rb' @@ -3197,8 +3193,6 @@ RSpec/ContextWording: - 'spec/serializers/merge_request_widget_entity_spec.rb' - 'spec/serializers/paginated_diff_entity_spec.rb' - 'spec/serializers/pipeline_details_entity_spec.rb' - - 'spec/serializers/service_event_entity_spec.rb' - - 'spec/serializers/service_field_entity_spec.rb' - 'spec/serializers/stage_entity_spec.rb' - 'spec/serializers/user_serializer_spec.rb' - 'spec/services/access_token_validation_service_spec.rb' @@ -3513,7 +3507,6 @@ RSpec/ContextWording: - 'spec/services/spam/ham_service_spec.rb' - 'spec/services/spam/spam_action_service_spec.rb' - 'spec/services/spam/spam_verdict_service_spec.rb' - - 'spec/services/static_site_editor/config_service_spec.rb' - 'spec/services/submodules/update_service_spec.rb' - 'spec/services/suggestions/apply_service_spec.rb' - 'spec/services/suggestions/create_service_spec.rb' @@ -3855,7 +3848,6 @@ RSpec/ContextWording: - 'spec/views/projects/hooks/edit.html.haml_spec.rb' - 'spec/views/projects/hooks/index.html.haml_spec.rb' - 'spec/views/projects/pipeline_schedules/_pipeline_schedule.html.haml_spec.rb' - - 'spec/views/projects/services/edit.html.haml_spec.rb' - 'spec/views/projects/settings/operations/show.html.haml_spec.rb' - 'spec/views/projects/tags/index.html.haml_spec.rb' - 'spec/views/projects/tree/show.html.haml_spec.rb' @@ -3878,9 +3870,6 @@ RSpec/ContextWording: - 'spec/workers/cleanup_container_repository_worker_spec.rb' - 'spec/workers/cluster_update_app_worker_spec.rb' - 'spec/workers/clusters/agents/delete_expired_events_worker_spec.rb' - - 'spec/workers/clusters/applications/activate_service_worker_spec.rb' - - 'spec/workers/clusters/applications/deactivate_service_worker_spec.rb' - - 'spec/workers/clusters/applications/wait_for_uninstall_app_worker_spec.rb' - 'spec/workers/concerns/application_worker_spec.rb' - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' - 'spec/workers/container_expiration_policy_worker_spec.rb' @@ -3898,12 +3887,10 @@ RSpec/ContextWording: - 'spec/workers/group_import_worker_spec.rb' - 'spec/workers/incident_management/process_alert_worker_v2_spec.rb' - 'spec/workers/integrations/create_external_cross_reference_worker_spec.rb' - - 'spec/workers/irker_worker_spec.rb' - 'spec/workers/issue_placement_worker_spec.rb' - 'spec/workers/issues/placement_worker_spec.rb' - 'spec/workers/merge_requests/delete_source_branch_worker_spec.rb' - 'spec/workers/metrics/dashboard/prune_old_annotations_worker_spec.rb' - - 'spec/workers/namespaceless_project_destroy_worker_spec.rb' - 'spec/workers/packages/composer/cache_update_worker_spec.rb' - 'spec/workers/packages/go/sync_packages_worker_spec.rb' - 'spec/workers/packages/maven/metadata/sync_worker_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index a015db8ae36..09a6f5e6192 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -188,7 +188,6 @@ RSpec/ExpectInHook: - 'spec/lib/backup/manager_spec.rb' - 'spec/lib/banzai/reference_redactor_spec.rb' - 'spec/lib/bulk_imports/ndjson_pipeline_spec.rb' - - 'spec/lib/bulk_imports/projects/pipelines/project_attributes_pipeline_spec.rb' - 'spec/lib/container_registry/gitlab_api_client_spec.rb' - 'spec/lib/file_size_validator_spec.rb' - 'spec/lib/gitlab/alert_management/fingerprint_spec.rb' diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml index 6c147d22808..7489aca5b51 100644 --- a/.rubocop_todo/rspec/instance_variable.yml +++ b/.rubocop_todo/rspec/instance_variable.yml @@ -158,7 +158,6 @@ RSpec/InstanceVariable: - spec/models/group_spec.rb - spec/models/integrations/assembla_spec.rb - spec/models/integrations/campfire_spec.rb - - spec/models/integrations/irker_spec.rb - spec/models/member_spec.rb - spec/models/members/project_member_spec.rb - spec/models/namespace_spec.rb diff --git a/.rubocop_todo/rspec/predicate_matcher.yml b/.rubocop_todo/rspec/predicate_matcher.yml index 0d55c9b858e..ebd11aeb449 100644 --- a/.rubocop_todo/rspec/predicate_matcher.yml +++ b/.rubocop_todo/rspec/predicate_matcher.yml @@ -503,7 +503,6 @@ RSpec/PredicateMatcher: - 'spec/validators/namespace_path_validator_spec.rb' - 'spec/validators/project_path_validator_spec.rb' - 'spec/workers/bulk_imports/entity_worker_spec.rb' - - 'spec/workers/bulk_imports/pipeline_worker_spec.rb' - 'spec/workers/ci/delete_objects_worker_spec.rb' - 'spec/workers/concerns/worker_attributes_spec.rb' - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' diff --git a/.rubocop_todo/rspec/return_from_stub.yml b/.rubocop_todo/rspec/return_from_stub.yml index da5ed01cafa..2fb01b855be 100644 --- a/.rubocop_todo/rspec/return_from_stub.yml +++ b/.rubocop_todo/rspec/return_from_stub.yml @@ -286,7 +286,6 @@ RSpec/ReturnFromStub: - 'spec/services/projects/in_product_marketing_campaign_emails_service_spec.rb' - 'spec/services/projects/update_remote_mirror_service_spec.rb' - 'spec/services/projects/update_service_spec.rb' - - 'spec/services/static_site_editor/config_service_spec.rb' - 'spec/services/suggestions/apply_service_spec.rb' - 'spec/services/suggestions/create_service_spec.rb' - 'spec/services/verify_pages_domain_service_spec.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index 26b82a3f473..a69ab9198b1 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -79,8 +79,6 @@ RSpec/VerifiedDoubles: - ee/spec/lib/gitlab/geo/log_cursor/lease_spec.rb - ee/spec/lib/gitlab/geo/oauth/logout_token_spec.rb - ee/spec/lib/gitlab/geo/oauth/session_spec.rb - - ee/spec/lib/gitlab/geo/replication/job_artifact_retriever_spec.rb - - ee/spec/lib/gitlab/geo/replication/job_artifact_transfer_spec.rb - ee/spec/lib/gitlab/geo/replicator_spec.rb - ee/spec/lib/gitlab/geo_spec.rb - ee/spec/lib/gitlab/git_access_spec.rb @@ -91,7 +89,6 @@ RSpec/VerifiedDoubles: - ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb - ee/spec/lib/gitlab/subscription_portal/clients/rest_spec.rb - ee/spec/lib/sidebars/groups/menus/analytics_menu_spec.rb - - ee/spec/lib/system_check/app/elasticsearch_check_spec.rb - ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb - ee/spec/models/app_sec/fuzzing/api/ci_configuration_spec.rb - ee/spec/models/approvable_spec.rb @@ -111,7 +108,6 @@ RSpec/VerifiedDoubles: - ee/spec/presenters/group_member_presenter_spec.rb - ee/spec/presenters/merge_request_approver_presenter_spec.rb - ee/spec/presenters/project_member_presenter_spec.rb - - ee/spec/requests/api/alert_management_alerts_spec.rb - ee/spec/requests/api/geo_spec.rb - ee/spec/requests/api/graphql/mutations/dast_site_profiles/delete_spec.rb - ee/spec/requests/api/internal/base_spec.rb @@ -142,11 +138,9 @@ RSpec/VerifiedDoubles: - ee/spec/serializers/issuable_sidebar_extras_entity_spec.rb - ee/spec/serializers/issues/linked_issue_feature_flag_entity_spec.rb - ee/spec/serializers/linked_feature_flag_issue_entity_spec.rb - - ee/spec/serializers/merge_request_compliance_entity_spec.rb - ee/spec/serializers/merge_request_poll_widget_entity_spec.rb - ee/spec/serializers/merge_request_sidebar_basic_entity_spec.rb - ee/spec/serializers/merge_request_widget_entity_spec.rb - - ee/spec/serializers/service_field_entity_spec.rb - ee/spec/serializers/test_reports_comparer_serializer_spec.rb - ee/spec/serializers/user_analytics_entity_spec.rb - ee/spec/serializers/vulnerabilities/feedback_entity_spec.rb @@ -174,9 +168,6 @@ RSpec/VerifiedDoubles: - ee/spec/services/ee/merge_requests/refresh_service_spec.rb - ee/spec/services/ee/notification_service_spec.rb - ee/spec/services/ee/post_receive_service_spec.rb - - ee/spec/services/ee/service_ping/build_payload_service_spec.rb - - ee/spec/services/ee/service_ping/permit_data_categories_service_spec.rb - - ee/spec/services/ee/service_ping/service_ping_settings_spec.rb - ee/spec/services/geo/blob_download_service_spec.rb - ee/spec/services/geo/graphql_request_service_spec.rb - ee/spec/services/geo/node_status_request_service_spec.rb @@ -382,7 +373,6 @@ RSpec/VerifiedDoubles: - spec/lib/api/helpers/graphql_helpers_spec.rb - spec/lib/api/helpers/pagination_spec.rb - spec/lib/api/helpers/pagination_strategies_spec.rb - - spec/lib/api/helpers/sse_helpers_spec.rb - spec/lib/api/helpers/variables_helpers_spec.rb - spec/lib/api/helpers_spec.rb - spec/lib/atlassian/jira_connect/client_spec.rb @@ -832,7 +822,6 @@ RSpec/VerifiedDoubles: - spec/models/application_record_spec.rb - spec/models/badge_spec.rb - spec/models/badges/project_badge_spec.rb - - spec/models/bulk_imports/export_status_spec.rb - spec/models/ci/build_spec.rb - spec/models/ci/build_trace_chunk_spec.rb - spec/models/ci/commit_with_pipeline_spec.rb @@ -961,8 +950,6 @@ RSpec/VerifiedDoubles: - spec/serializers/prometheus_alert_entity_spec.rb - spec/serializers/review_app_setup_entity_spec.rb - spec/serializers/runner_entity_spec.rb - - spec/serializers/service_event_entity_spec.rb - - spec/serializers/service_field_entity_spec.rb - spec/serializers/stage_entity_spec.rb - spec/serializers/suggestion_entity_spec.rb - spec/serializers/test_reports_comparer_serializer_spec.rb @@ -1045,8 +1032,6 @@ RSpec/VerifiedDoubles: - spec/services/repositories/changelog_service_spec.rb - spec/services/search_service_spec.rb - spec/services/service_ping/build_payload_service_spec.rb - - spec/services/service_ping/permit_data_categories_service_spec.rb - - spec/services/service_ping/service_ping_settings_spec.rb - spec/services/service_ping/submit_service_ping_service_spec.rb - spec/services/snippets/update_repository_storage_service_spec.rb - spec/services/spam/akismet_mark_as_spam_service_spec.rb @@ -1054,7 +1039,6 @@ RSpec/VerifiedDoubles: - spec/services/spam/ham_service_spec.rb - spec/services/spam/spam_action_service_spec.rb - spec/services/spam/spam_params_spec.rb - - spec/services/static_site_editor/config_service_spec.rb - spec/services/system_note_service_spec.rb - spec/services/system_notes/commit_service_spec.rb - spec/services/system_notes/issuables_service_spec.rb @@ -1130,7 +1114,6 @@ RSpec/VerifiedDoubles: - spec/views/shared/milestones/_issuables.html.haml_spec.rb - spec/views/shared/wikis/_sidebar.html.haml_spec.rb - spec/workers/bulk_imports/export_request_worker_spec.rb - - spec/workers/bulk_imports/pipeline_worker_spec.rb - spec/workers/chat_notification_worker_spec.rb - spec/workers/ci/build_prepare_worker_spec.rb - spec/workers/ci/create_cross_project_pipeline_worker_spec.rb @@ -1162,8 +1145,6 @@ RSpec/VerifiedDoubles: - spec/workers/gitlab/github_import/stage/import_repository_worker_spec.rb - spec/workers/gitlab_performance_bar_stats_worker_spec.rb - spec/workers/invalid_gpg_signature_update_worker_spec.rb - - spec/workers/irker_worker_spec.rb - - spec/workers/issue_rebalancing_worker_spec.rb - spec/workers/issues/rebalancing_worker_spec.rb - spec/workers/merge_request_mergeability_check_worker_spec.rb - spec/workers/new_issue_worker_spec.rb diff --git a/.rubocop_todo/style/bare_percent_literals.yml b/.rubocop_todo/style/bare_percent_literals.yml index 658c6c22baa..104ead817d5 100644 --- a/.rubocop_todo/style/bare_percent_literals.yml +++ b/.rubocop_todo/style/bare_percent_literals.yml @@ -10,7 +10,6 @@ Style/BarePercentLiterals: - 'app/models/integrations/datadog.rb' - 'app/services/feature_flags/base_service.rb' - 'app/services/repositories/base_service.rb' - - 'app/services/repositories/destroy_rollback_service.rb' - 'app/services/repositories/destroy_service.rb' - 'ee/app/services/jira/jql_builder_service.rb' - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' diff --git a/.rubocop_todo/style/class_and_module_children.yml b/.rubocop_todo/style/class_and_module_children.yml index 9d89acfb394..fab05667adb 100644 --- a/.rubocop_todo/style/class_and_module_children.yml +++ b/.rubocop_todo/style/class_and_module_children.yml @@ -220,14 +220,11 @@ Style/ClassAndModuleChildren: - 'app/controllers/projects/runner_projects_controller.rb' - 'app/controllers/projects/runners_controller.rb' - 'app/controllers/projects/service_desk_controller.rb' - - 'app/controllers/projects/service_hook_logs_controller.rb' - 'app/controllers/projects/service_ping_controller.rb' - - 'app/controllers/projects/services_controller.rb' - 'app/controllers/projects/snippets/application_controller.rb' - 'app/controllers/projects/snippets/blobs_controller.rb' - 'app/controllers/projects/snippets_controller.rb' - 'app/controllers/projects/starrers_controller.rb' - - 'app/controllers/projects/static_site_editor_controller.rb' - 'app/controllers/projects/tags/releases_controller.rb' - 'app/controllers/projects/tags_controller.rb' - 'app/controllers/projects/templates_controller.rb' @@ -354,9 +351,7 @@ Style/ClassAndModuleChildren: - 'app/serializers/merge_requests/pipeline_entity.rb' - 'app/services/projects/branches_by_mode_service.rb' - 'app/services/repositories/base_service.rb' - - 'app/services/repositories/destroy_rollback_service.rb' - 'app/services/repositories/destroy_service.rb' - - 'app/services/repositories/shell_destroy_service.rb' - 'app/uploaders/dependency_proxy/file_uploader.rb' - 'app/uploaders/packages/composer/cache_uploader.rb' - 'app/uploaders/packages/debian/component_file_uploader.rb' diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index 9bca01015aa..aa3972a0b22 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -53,7 +53,7 @@ Style/EmptyMethod: - 'app/controllers/projects/pipeline_schedules_controller.rb' - 'app/controllers/projects/product_analytics_controller.rb' - 'app/controllers/projects/runners_controller.rb' - - 'app/controllers/projects/services_controller.rb' + - 'app/controllers/projects/settings/integrations_controller.rb' - 'app/controllers/projects/settings/packages_and_registries_controller.rb' - 'app/controllers/projects/tags/releases_controller.rb' - 'app/controllers/projects/terraform_controller.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index 82ece4dd3bd..a9065bb5932 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -41,7 +41,6 @@ Style/FormatString: - 'app/controllers/projects/merge_requests_controller.rb' - 'app/controllers/projects/performance_monitoring/dashboards_controller.rb' - 'app/controllers/projects/pipeline_schedules_controller.rb' - - 'app/controllers/projects/services_controller.rb' - 'app/controllers/projects/settings/ci_cd_controller.rb' - 'app/controllers/projects_controller.rb' - 'app/controllers/search_controller.rb' @@ -109,7 +108,6 @@ Style/FormatString: - 'app/models/integrations/external_wiki.rb' - 'app/models/integrations/flowdock.rb' - 'app/models/integrations/hangouts_chat.rb' - - 'app/models/integrations/irker.rb' - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/mattermost.rb' @@ -184,7 +182,6 @@ Style/FormatString: - 'config/initializers/rack_lineprof.rb' - 'danger/roulette/Dangerfile' - 'ee/app/components/billing/plan_component.rb' - - 'ee/app/components/namespaces/preview_free_user_cap_alert_component.rb' - 'ee/app/controllers/admin/elasticsearch_controller.rb' - 'ee/app/controllers/admin/geo/application_controller.rb' - 'ee/app/controllers/admin/geo/projects_controller.rb' @@ -237,7 +234,6 @@ Style/FormatString: - 'ee/app/services/merge_requests/create_from_vulnerability_data_service.rb' - 'ee/app/services/namespaces/check_excess_storage_size_service.rb' - 'ee/app/services/namespaces/check_storage_size_service.rb' - - 'ee/app/services/network_policies/responses.rb' - 'ee/app/services/security/security_orchestration_policies/policy_configuration_validation_service.rb' - 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb' - 'ee/app/services/timebox_report_service.rb' @@ -265,7 +261,6 @@ Style/FormatString: - 'ee/lib/gitlab/expiring_subscription_message.rb' - 'ee/lib/gitlab/geo.rb' - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb' - - 'ee/lib/gitlab/manual_renewal_banner.rb' - 'ee/lib/gitlab/vulnerabilities/container_scanning_vulnerability.rb' - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/spec/controllers/admin/licenses_controller_spec.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index 12eda8abf13..c7109639677 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -60,7 +60,6 @@ Style/GuardClause: - 'app/finders/ci/runners_finder.rb' - 'app/finders/deployments_finder.rb' - 'app/finders/group_members_finder.rb' - - 'app/finders/projects/serverless/functions_finder.rb' - 'app/finders/snippets_finder.rb' - 'app/graphql/mutations/concerns/mutations/spam_protection.rb' - 'app/graphql/mutations/design_management/delete.rb' @@ -73,7 +72,6 @@ Style/GuardClause: - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - 'app/graphql/resolvers/projects/jira_projects_resolver.rb' - 'app/graphql/types/ci/job_type.rb' - - 'app/graphql/types/concerns/find_closest.rb' - 'app/helpers/admin/user_actions_helper.rb' - 'app/helpers/appearances_helper.rb' - 'app/helpers/application_helper.rb' @@ -135,7 +133,6 @@ Style/GuardClause: - 'app/models/integrations/datadog.rb' - 'app/models/integrations/emails_on_push.rb' - 'app/models/integrations/harbor.rb' - - 'app/models/integrations/irker.rb' - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/pipelines_email.rb' @@ -236,7 +233,6 @@ Style/GuardClause: - 'app/services/post_receive_service.rb' - 'app/services/projects/after_rename_service.rb' - 'app/services/projects/create_service.rb' - - 'app/services/projects/destroy_rollback_service.rb' - 'app/services/projects/destroy_service.rb' - 'app/services/projects/hashed_storage/rollback_service.rb' - 'app/services/projects/import_export/export_service.rb' @@ -247,7 +243,6 @@ Style/GuardClause: - 'app/services/projects/update_service.rb' - 'app/services/protected_branches/legacy_api_update_service.rb' - 'app/services/snippets/repository_validation_service.rb' - - 'app/services/static_site_editor/config_service.rb' - 'app/services/todo_service.rb' - 'app/services/users/build_service.rb' - 'app/services/users/update_service.rb' @@ -465,7 +460,6 @@ Style/GuardClause: - 'ee/lib/gitlab/insights/serializers/chartjs/multi_series_serializer.rb' - 'ee/lib/gitlab/insights/validators/params_validator.rb' - 'ee/lib/omni_auth/strategies/group_saml.rb' - - 'ee/lib/pseudonymizer/dumper.rb' - 'ee/spec/features/billings/billing_plans_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' @@ -547,7 +541,6 @@ Style/GuardClause: - 'lib/gitlab/database/partitioning/sliding_list_strategy.rb' - 'lib/gitlab/database/postgresql_adapter/force_disconnectable_mixin.rb' - 'lib/gitlab/database/query_analyzers/restrict_allowed_schemas.rb' - - 'lib/gitlab/diff/custom_diff.rb' - 'lib/gitlab/diff/file.rb' - 'lib/gitlab/diff/highlight.rb' - 'lib/gitlab/diff/highlight_cache.rb' @@ -582,7 +575,6 @@ Style/GuardClause: - 'lib/gitlab/graphql/pagination/keyset/conditions/null_condition.rb' - 'lib/gitlab/graphql/pagination/keyset/order_info.rb' - 'lib/gitlab/graphql/pagination/keyset/query_builder.rb' - - 'lib/gitlab/graphql/query_analyzers/recursion_analyzer.rb' - 'lib/gitlab/i18n/metadata_entry.rb' - 'lib/gitlab/i18n/po_linter.rb' - 'lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb' diff --git a/.rubocop_todo/style/if_inside_else.yml b/.rubocop_todo/style/if_inside_else.yml index fcddbae74fc..3ce6e5ec704 100644 --- a/.rubocop_todo/style/if_inside_else.yml +++ b/.rubocop_todo/style/if_inside_else.yml @@ -14,7 +14,6 @@ Style/IfInsideElse: - 'app/models/ci/build.rb' - 'app/models/namespace.rb' - 'app/presenters/project_presenter.rb' - - 'app/services/service_ping/build_payload_service.rb' - 'app/services/system_notes/commit_service.rb' - 'app/services/task_list_toggle_service.rb' - 'app/services/user_project_access_changed_service.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 7bbc62d4c27..645fc5f764c 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -8,7 +8,6 @@ Style/IfUnlessModifier: - 'app/channels/graphql_channel.rb' - 'app/controllers/admin/application_settings_controller.rb' - 'app/controllers/admin/projects_controller.rb' - - 'app/controllers/admin/requests_profiles_controller.rb' - 'app/controllers/admin/runners_controller.rb' - 'app/controllers/admin/users_controller.rb' - 'app/controllers/application_controller.rb' @@ -57,7 +56,6 @@ Style/IfUnlessModifier: - 'app/controllers/projects/protected_refs_controller.rb' - 'app/controllers/projects/releases_controller.rb' - 'app/controllers/projects/runners_controller.rb' - - 'app/controllers/projects/services_controller.rb' - 'app/controllers/registrations_controller.rb' - 'app/controllers/repositories/git_http_controller.rb' - 'app/controllers/repositories/lfs_api_controller.rb' @@ -204,7 +202,6 @@ Style/IfUnlessModifier: - 'app/models/integrations/base_chat_notification.rb' - 'app/models/integrations/datadog.rb' - 'app/models/integrations/harbor.rb' - - 'app/models/integrations/irker.rb' - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/pushover.rb' @@ -381,13 +378,11 @@ Style/IfUnlessModifier: - 'app/services/projects/update_repository_storage_service.rb' - 'app/services/resource_access_tokens/create_service.rb' - 'app/services/resource_events/change_labels_service.rb' - - 'app/services/service_ping/devops_report_service.rb' - 'app/services/snippets/create_service.rb' - 'app/services/snippets/destroy_service.rb' - 'app/services/snippets/repository_validation_service.rb' - 'app/services/spam/spam_action_service.rb' - 'app/services/spam/spam_verdict_service.rb' - - 'app/services/static_site_editor/config_service.rb' - 'app/services/system_notes/issuables_service.rb' - 'app/services/tags/destroy_service.rb' - 'app/services/two_factor/destroy_service.rb' @@ -416,7 +411,6 @@ Style/IfUnlessModifier: - 'app/views/projects/merge_requests/index.atom.builder' - 'app/workers/authorized_project_update/user_refresh_from_replica_worker.rb' - 'app/workers/auto_devops/disable_worker.rb' - - 'app/workers/bulk_imports/pipeline_worker.rb' - 'app/workers/cleanup_container_repository_worker.rb' - 'app/workers/concerns/application_worker.rb' - 'app/workers/concerns/packages/cleanup_artifact_worker.rb' @@ -424,7 +418,6 @@ Style/IfUnlessModifier: - 'app/workers/concerns/worker_attributes.rb' - 'app/workers/database/batched_background_migration/single_database_worker.rb' - 'app/workers/file_hook_worker.rb' - - 'app/workers/issue_rebalancing_worker.rb' - 'app/workers/issues/rebalancing_worker.rb' - 'app/workers/merge_request_mergeability_check_worker.rb' - 'app/workers/object_storage/migrate_uploads_worker.rb' @@ -501,7 +494,6 @@ Style/IfUnlessModifier: - 'ee/app/controllers/projects/push_rules_controller.rb' - 'ee/app/controllers/projects/settings/slacks_controller.rb' - 'ee/app/controllers/trials_controller.rb' - - 'ee/app/finders/ee/alert_management/alerts_finder.rb' - 'ee/app/finders/iterations_finder.rb' - 'ee/app/finders/merge_trains_finder.rb' - 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb' @@ -614,8 +606,6 @@ Style/IfUnlessModifier: - 'ee/app/services/ee/users/update_service.rb' - 'ee/app/services/elastic/indexing_control_service.rb' - 'ee/app/services/elastic/process_bookkeeping_service.rb' - - 'ee/app/services/epic_links/create_service.rb' - - 'ee/app/services/epic_links/update_service.rb' - 'ee/app/services/epics/base_service.rb' - 'ee/app/services/epics/create_service.rb' - 'ee/app/services/epics/update_dates_service.rb' @@ -723,7 +713,6 @@ Style/IfUnlessModifier: - 'ee/lib/gitlab/geo/log_cursor/daemon.rb' - 'ee/lib/gitlab/geo/log_cursor/events/repository_deleted_event.rb' - 'ee/lib/gitlab/geo/oauth/logout_token.rb' - - 'ee/lib/gitlab/geo/replication/base_transfer.rb' - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'ee/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate.rb' @@ -739,13 +728,10 @@ Style/IfUnlessModifier: - 'ee/lib/gitlab/usage/metrics/instrumentations/count_users_creating_ci_builds_metric.rb' - 'ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb' - 'ee/lib/omni_auth/strategies/group_saml.rb' - - 'ee/lib/pseudonymizer/dumper.rb' - - 'ee/lib/pseudonymizer/uploader.rb' - 'ee/lib/sidebars/groups/menus/administration_menu.rb' - 'ee/lib/sidebars/groups/menus/analytics_menu.rb' - 'ee/lib/sidebars/groups/menus/security_compliance_menu.rb' - 'ee/lib/tasks/geo.rake' - - 'ee/lib/tasks/gitlab/db.rake' - 'ee/lib/tasks/gitlab/geo.rake' - 'ee/lib/tasks/gitlab/seed/insights.rake' - 'ee/spec/controllers/subscriptions_controller_spec.rb' @@ -949,7 +935,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/database/reindexing/reindex_concurrently.rb' - 'lib/gitlab/database/transaction/observer.rb' - 'lib/gitlab/database/with_lock_retries.rb' - - 'lib/gitlab/diff/custom_diff.rb' - 'lib/gitlab/diff/formatters/base_formatter.rb' - 'lib/gitlab/diff/rendered/notebook/diff_file.rb' - 'lib/gitlab/elasticsearch/logs/lines.rb' @@ -1158,7 +1143,6 @@ Style/IfUnlessModifier: - 'rubocop/cop/ignored_columns.rb' - 'rubocop/cop/migration/add_limit_to_text_columns.rb' - 'rubocop/cop/migration/add_reference.rb' - - 'rubocop/cop/migration/hash_index.rb' - 'rubocop/cop/migration/remove_column.rb' - 'rubocop/cop/migration/sidekiq_queue_migrate.rb' - 'rubocop/cop/performance/ar_exists_and_present_blank.rb' @@ -1180,7 +1164,6 @@ Style/IfUnlessModifier: - 'spec/factories/projects.rb' - 'spec/factories/protected_tags.rb' - 'spec/factories/users.rb' - - 'spec/factories_spec.rb' - 'spec/features/admin/admin_users_spec.rb' - 'spec/features/merge_request/batch_comments_spec.rb' - 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb' diff --git a/.rubocop_todo/style/next.yml b/.rubocop_todo/style/next.yml index e1f9b927db6..ba2bd293696 100644 --- a/.rubocop_todo/style/next.yml +++ b/.rubocop_todo/style/next.yml @@ -5,7 +5,6 @@ Style/Next: # Temporarily disabled due to too many offenses Enabled: false Exclude: - - 'app/finders/projects/serverless/functions_finder.rb' - 'app/models/preloaders/environments/deployment_preloader.rb' - 'app/models/route.rb' - 'app/services/authorized_project_update/find_records_due_for_refresh_service.rb' diff --git a/.rubocop_todo/style/numeric_literal_prefix.yml b/.rubocop_todo/style/numeric_literal_prefix.yml index b469a68ff5a..ea0b028d11c 100644 --- a/.rubocop_todo/style/numeric_literal_prefix.yml +++ b/.rubocop_todo/style/numeric_literal_prefix.yml @@ -10,16 +10,12 @@ Style/NumericLiteralPrefix: - 'config/initializers/01_secret_token.rb' - 'config/initializers/1_settings.rb' - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' - - 'ee/lib/gitlab/geo/replication/base_transfer.rb' - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb' - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/job_artifact_transfer_spec.rb' - 'ee/spec/migrations/schedule_trace_expiry_removal_spec.rb' - 'ee/spec/models/analytics/devops_adoption/snapshot_spec.rb' - - 'ee/spec/models/ci/minutes/quota_spec.rb' - 'ee/spec/models/ee/group_spec.rb' - 'ee/spec/models/gitlab/seat_link_data_spec.rb' - 'ee/spec/services/incident_management/oncall_schedules/update_service_spec.rb' diff --git a/.rubocop_todo/style/open_struct_use.yml b/.rubocop_todo/style/open_struct_use.yml index e6af3b7bf24..15e4539072d 100644 --- a/.rubocop_todo/style/open_struct_use.yml +++ b/.rubocop_todo/style/open_struct_use.yml @@ -1,21 +1,12 @@ --- Style/OpenStructUse: Exclude: - - ee/spec/features/projects/new_project_spec.rb - - ee/spec/finders/template_finder_spec.rb - - ee/spec/helpers/ee/blob_helper_spec.rb - - ee/spec/lib/gitlab/auth/group_saml/failure_handler_spec.rb - - ee/spec/lib/gitlab/legacy_github_import/project_creator_spec.rb - - lib/gitlab/testing/request_inspector_middleware.rb - - spec/factories/wiki_pages.rb - - spec/graphql/mutations/branches/create_spec.rb - - spec/graphql/mutations/clusters/agent_tokens/create_spec.rb - - spec/graphql/mutations/clusters/agents/create_spec.rb - - spec/graphql/mutations/clusters/agents/delete_spec.rb - - spec/graphql/mutations/commits/create_spec.rb - - spec/helpers/application_settings_helper_spec.rb - - spec/helpers/profiles_helper_spec.rb - - spec/lib/gitlab/gitaly_client/blobs_stitcher_spec.rb - - spec/lib/gitlab/gitaly_client/diff_stitcher_spec.rb - - spec/services/system_note_service_spec.rb - - spec/support/helpers/repo_helpers.rb + - 'ee/spec/features/projects/new_project_spec.rb' + - 'ee/spec/finders/template_finder_spec.rb' + - 'ee/spec/helpers/ee/blob_helper_spec.rb' + - 'ee/spec/lib/gitlab/auth/group_saml/failure_handler_spec.rb' + - 'spec/factories/wiki_pages.rb' + - 'spec/helpers/profiles_helper_spec.rb' + - 'spec/lib/gitlab/gitaly_client/blobs_stitcher_spec.rb' + - 'spec/lib/gitlab/gitaly_client/diff_stitcher_spec.rb' + - 'spec/support/helpers/repo_helpers.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index bf50c4c1922..487e0e7cd20 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -117,7 +117,6 @@ Style/PercentLiteralDelimiters: - 'app/models/integrations/external_wiki.rb' - 'app/models/integrations/field.rb' - 'app/models/integrations/flowdock.rb' - - 'app/models/integrations/irker.rb' - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/packagist.rb' @@ -178,7 +177,6 @@ Style/PercentLiteralDelimiters: - 'app/services/projects/update_service.rb' - 'app/services/prometheus/proxy_service.rb' - 'app/services/repositories/base_service.rb' - - 'app/services/repositories/destroy_rollback_service.rb' - 'app/services/repositories/destroy_service.rb' - 'app/services/repository_archive_clean_up_service.rb' - 'app/services/resource_access_tokens/create_service.rb' @@ -192,7 +190,6 @@ Style/PercentLiteralDelimiters: - 'app/validators/addressable_url_validator.rb' - 'app/validators/gitlab/zoom_url_validator.rb' - 'app/validators/json_schema_validator.rb' - - 'app/workers/irker_worker.rb' - 'app/workers/members_destroyer/unassign_issuables_worker.rb' - 'app/workers/projects/record_target_platforms_worker.rb' - 'config/application.rb' @@ -229,7 +226,6 @@ Style/PercentLiteralDelimiters: - 'db/migrate/20210621044000_rename_services_indexes_to_integrations.rb' - 'db/migrate/20210709085759_index_batched_migration_jobs_by_max_value.rb' - 'db/migrate/20210928155022_improve_index_for_error_tracking.rb' - - 'db/optional_migrations/composite_primary_keys.rb' - 'db/post_migrate/20210329102724_add_new_trail_plans.rb' - 'db/post_migrate/20210420121149_backfill_conversion_of_ci_job_artifacts.rb' - 'db/post_migrate/20210426094549_backfill_ci_builds_for_bigint_conversion.rb' @@ -296,7 +292,6 @@ Style/PercentLiteralDelimiters: - 'ee/lib/api/managed_licenses.rb' - 'ee/lib/api/status_checks.rb' - 'ee/lib/api/visual_review_discussions.rb' - - 'ee/lib/banzai/pipeline/incident_management/timeline_event_pipeline.rb' - 'ee/lib/ee/api/helpers/members_helpers.rb' - 'ee/lib/ee/api/helpers/projects_helpers.rb' - 'ee/lib/ee/api/search.rb' @@ -308,7 +303,6 @@ Style/PercentLiteralDelimiters: - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' - 'ee/lib/ee/gitlab/ci/parsers/security/validators/schema_validator.rb' - 'ee/lib/ee/gitlab/etag_caching/router/rails.rb' - - 'ee/lib/ee/gitlab/integrations/sti_type.rb' - 'ee/lib/ee/gitlab/middleware/read_only/controller.rb' - 'ee/lib/ee/gitlab/path_regex.rb' - 'ee/lib/ee/gitlab/uploads/migration_helper.rb' @@ -319,7 +313,6 @@ Style/PercentLiteralDelimiters: - 'ee/lib/elastic/latest/git_class_proxy.rb' - 'ee/lib/elastic/latest/project_instance_proxy.rb' - 'ee/lib/elastic/latest/snippet_class_proxy.rb' - - 'ee/lib/gitlab/alert_management/payload/cilium.rb' - 'ee/lib/gitlab/auth/group_saml/auth_hash.rb' - 'ee/lib/gitlab/ci/parsers/security/formatters/dast.rb' - 'ee/lib/gitlab/geo.rb' @@ -371,7 +364,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/lib/banzai/filter/references/epic_reference_filter_spec.rb' - 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb' - 'ee/spec/lib/banzai/filter/references/vulnerability_reference_filters_spec.rb' - - 'ee/spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb' - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/config_spec.rb' @@ -561,7 +553,6 @@ Style/PercentLiteralDelimiters: - 'lib/gitlab/gitaly_client/diff.rb' - 'lib/gitlab/gitaly_client/wiki_page.rb' - 'lib/gitlab/graphql/pagination/keyset/order_info.rb' - - 'lib/gitlab/graphql/query_analyzers/recursion_analyzer.rb' - 'lib/gitlab/hotlinking_detector.rb' - 'lib/gitlab/import_export/command_line_util.rb' - 'lib/gitlab/import_export/file_importer.rb' @@ -648,10 +639,6 @@ Style/PercentLiteralDelimiters: - 'rubocop/migration_helpers.rb' - 'scripts/qa/testcases-check' - 'scripts/regenerate-schema' - - 'shared/packages/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b/packages/57/files/67/package.gemspec' - - 'shared/packages/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b/packages/6/files/5/package.gemspec' - - 'shared/packages/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b/packages/7/files/7/package.gemspec' - - 'shared/packages/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b/packages/88/files/91/package.gemspec' - 'sidekiq_cluster/cli.rb' - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/commands/sidekiq_cluster/cli_spec.rb' @@ -676,7 +663,6 @@ Style/PercentLiteralDelimiters: - 'spec/controllers/projects/performance_monitoring/dashboards_controller_spec.rb' - 'spec/controllers/projects/pipelines_controller_spec.rb' - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - - 'spec/controllers/projects/static_site_editor_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' - 'spec/controllers/registrations/welcome_controller_spec.rb' - 'spec/controllers/search_controller_spec.rb' @@ -898,7 +884,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/jira_import/issue_serializer_spec.rb' - 'spec/lib/gitlab/jira_import/labels_importer_spec.rb' - 'spec/lib/gitlab/kubernetes/kubectl_cmd_spec.rb' - - 'spec/lib/gitlab/kubernetes/network_policy_spec.rb' - 'spec/lib/gitlab/kubernetes/role_spec.rb' - 'spec/lib/gitlab/language_data_spec.rb' - 'spec/lib/gitlab/markup_helper_spec.rb' @@ -1001,7 +986,6 @@ Style/PercentLiteralDelimiters: - 'spec/models/integrations/bamboo_spec.rb' - 'spec/models/integrations/buildkite_spec.rb' - 'spec/models/integrations/campfire_spec.rb' - - 'spec/models/integrations/irker_spec.rb' - 'spec/models/integrations/jira_spec.rb' - 'spec/models/integrations/teamcity_spec.rb' - 'spec/models/issue_spec.rb' diff --git a/.rubocop_todo/style/redundant_interpolation.yml b/.rubocop_todo/style/redundant_interpolation.yml index fb190ff2100..0d3651eb7b2 100644 --- a/.rubocop_todo/style/redundant_interpolation.yml +++ b/.rubocop_todo/style/redundant_interpolation.yml @@ -77,7 +77,6 @@ Style/RedundantInterpolation: - 'qa/qa/resource/events/base.rb' - 'qa/qa/service/praefect_manager.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_multiple_files_from_a_project_spec.rb' - - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/parent_child_pipelines_dependent_relationship_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb' - 'qa/qa/tools/generate_perf_testdata.rb' diff --git a/.rubocop_todo/style/redundant_regexp_escape.yml b/.rubocop_todo/style/redundant_regexp_escape.yml index 1a88f62ab64..969a23601ca 100644 --- a/.rubocop_todo/style/redundant_regexp_escape.yml +++ b/.rubocop_todo/style/redundant_regexp_escape.yml @@ -35,7 +35,6 @@ Style/RedundantRegexpEscape: - 'ee/lib/gitlab/geo/git_ssh_proxy.rb' - 'ee/lib/gitlab/return_to_location.rb' - 'ee/spec/features/read_only_spec.rb' - - 'ee/spec/helpers/seats_count_alert_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/usage_data_counters/hll_redis_counter_spec.rb' - 'ee/spec/mailers/notify_spec.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index e363f83761b..1aba23c90ae 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -260,7 +260,6 @@ Style/RedundantSelf: - 'ee/lib/elastic/latest/note_config.rb' - 'ee/lib/elastic/migration.rb' - 'ee/lib/gem_extensions/elasticsearch/model/indexing/instance_methods.rb' - - 'ee/lib/gitlab/alert_management/payload/cilium.rb' - 'ee/lib/gitlab/analytics/cycle_analytics/summary/base_time.rb' - 'ee/lib/gitlab/auth/group_saml/response_check.rb' - 'ee/lib/gitlab/auth/group_saml/user.rb' @@ -277,7 +276,6 @@ Style/RedundantSelf: - 'ee/lib/gitlab/geo/oauth/logout_state.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'ee/lib/gitlab/template/custom_template.rb' - - 'ee/lib/system_check/app/elasticsearch_check.rb' - 'ee/spec/helpers/ee/feature_flags_helper_spec.rb' - 'ee/spec/helpers/ee/graph_helper_spec.rb' - 'ee/spec/models/geo/deleted_project_spec.rb' @@ -365,8 +363,6 @@ Style/RedundantSelf: - 'lib/gitlab/instrumentation/redis_base.rb' - 'lib/gitlab/jira_import.rb' - 'lib/gitlab/jwt_token.rb' - - 'lib/gitlab/kubernetes/cilium_network_policy.rb' - - 'lib/gitlab/kubernetes/network_policy.rb' - 'lib/gitlab/logger.rb' - 'lib/gitlab/marker_range.rb' - 'lib/gitlab/memory/instrumentation.rb' diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml index 23a16f928f5..8c8dbf86b1c 100644 --- a/.rubocop_todo/style/string_concatenation.yml +++ b/.rubocop_todo/style/string_concatenation.yml @@ -301,11 +301,9 @@ Style/StringConcatenation: - 'spec/services/packages/helm/extract_file_metadata_service_spec.rb' - 'spec/services/packages/helm/process_file_service_spec.rb' - 'spec/services/projects/create_service_spec.rb' - - 'spec/services/projects/destroy_rollback_service_spec.rb' - 'spec/services/projects/destroy_service_spec.rb' - 'spec/services/projects/download_service_spec.rb' - 'spec/services/push_event_payload_service_spec.rb' - - 'spec/services/repositories/destroy_rollback_service_spec.rb' - 'spec/services/repositories/destroy_service_spec.rb' - 'spec/services/snippets/bulk_destroy_service_spec.rb' - 'spec/services/snippets/update_service_spec.rb' @@ -317,7 +315,6 @@ Style/StringConcatenation: - 'spec/support/helpers/git_helpers.rb' - 'spec/support/helpers/gitaly_setup.rb' - 'spec/support/helpers/javascript_fixtures_helpers.rb' - - 'spec/support/helpers/jira_service_helper.rb' - 'spec/support/helpers/kubernetes_helpers.rb' - 'spec/support/helpers/stub_configuration.rb' - 'spec/support/helpers/workhorse_helpers.rb' diff --git a/.rubocop_todo/style/string_literals_in_interpolation.yml b/.rubocop_todo/style/string_literals_in_interpolation.yml index 3f3cb007306..cded81afa7f 100644 --- a/.rubocop_todo/style/string_literals_in_interpolation.yml +++ b/.rubocop_todo/style/string_literals_in_interpolation.yml @@ -24,7 +24,6 @@ Style/StringLiteralsInInterpolation: - 'ee/app/models/license.rb' - 'ee/app/services/epics/tree_reorder_service.rb' - 'ee/lib/gitlab/elastic/helper.rb' - - 'ee/lib/pseudonymizer/pager.rb' - 'ee/spec/features/admin/admin_settings_spec.rb' - 'lib/api/helpers/snippets_helpers.rb' - 'lib/api/validations/validators/check_assignees_count.rb' @@ -54,7 +53,6 @@ Style/StringLiteralsInInterpolation: - 'qa/qa/specs/helpers/context_selector.rb' - 'qa/qa/tools/generate_perf_testdata.rb' - 'rubocop/cop/migration/prevent_index_creation.rb' - - 'spec/controllers/projects/serverless/functions_controller_spec.rb' - 'spec/features/commits_spec.rb' - 'spec/features/dashboard/merge_requests_spec.rb' - 'spec/features/users/login_spec.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index 12e20553e1a..5e3aa10d9e5 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -113,7 +113,6 @@ Style/SymbolProc: - 'ee/app/workers/geo/batch/project_registry_worker.rb' - 'ee/app/workers/geo/sync_timeout_cron_worker.rb' - 'ee/app/workers/geo/verification_cron_worker.rb' - - 'ee/app/workers/repository_push_audit_event_worker.rb' - 'ee/lib/api/entities/pending_member.rb' - 'ee/lib/api/related_epic_links.rb' - 'ee/lib/ee/api/entities/audit_event.rb' |