diff options
author | Luke Bennett <lukeeeebennettplus@gmail.com> | 2018-04-10 15:57:00 +0100 |
---|---|---|
committer | Luke Bennett <lukeeeebennettplus@gmail.com> | 2018-04-10 15:57:00 +0100 |
commit | 19f14cfe8210239800a1027569715f4f8d6699be (patch) | |
tree | 3f2e97acc029e234167e5444b03f11ede10246c6 | |
parent | eae553f8164496b59fa2036a6fc2e8571dba2dcd (diff) | |
download | gitlab-ce-19f14cfe8210239800a1027569715f4f8d6699be.tar.gz |
remove sideeffects, init per page
-rw-r--r-- | app/assets/javascripts/milestone.js | 1 | ||||
-rw-r--r-- | app/assets/javascripts/pages/dashboard/milestones/show/index.js | 2 | ||||
-rw-r--r-- | app/assets/javascripts/pages/groups/milestones/show/index.js | 7 |
3 files changed, 8 insertions, 2 deletions
diff --git a/app/assets/javascripts/milestone.js b/app/assets/javascripts/milestone.js index 23231ba5649..d3697eb0999 100644 --- a/app/assets/javascripts/milestone.js +++ b/app/assets/javascripts/milestone.js @@ -5,7 +5,6 @@ import { mouseenter, debouncedMouseleave, togglePopover } from './shared/popover export default class Milestone { constructor() { - Milestone.initDeprecationMessage(); this.bindTabsSwitching(); // Load merge request tab if it is active diff --git a/app/assets/javascripts/pages/dashboard/milestones/show/index.js b/app/assets/javascripts/pages/dashboard/milestones/show/index.js index 397149aaa9e..8b529585898 100644 --- a/app/assets/javascripts/pages/dashboard/milestones/show/index.js +++ b/app/assets/javascripts/pages/dashboard/milestones/show/index.js @@ -6,4 +6,6 @@ document.addEventListener('DOMContentLoaded', () => { new Milestone(); // eslint-disable-line no-new new Sidebar(); // eslint-disable-line no-new new MountMilestoneSidebar(); // eslint-disable-line no-new + + Milestone.initDeprecationMessage(); }); diff --git a/app/assets/javascripts/pages/groups/milestones/show/index.js b/app/assets/javascripts/pages/groups/milestones/show/index.js index 88f40b5278e..74cc4ba42c1 100644 --- a/app/assets/javascripts/pages/groups/milestones/show/index.js +++ b/app/assets/javascripts/pages/groups/milestones/show/index.js @@ -1,3 +1,8 @@ import initMilestonesShow from '~/pages/milestones/shared/init_milestones_show'; +import Milestone from '~/milestone'; -document.addEventListener('DOMContentLoaded', initMilestonesShow); +document.addEventListener('DOMContentLoaded', () => { + initMilestonesShow(); + + Milestone.initDeprecationMessage(); +}); |