diff options
| author | Mike Greiling <mike@pixelcog.com> | 2018-06-06 15:48:54 -0500 |
|---|---|---|
| committer | Mike Greiling <mike@pixelcog.com> | 2018-06-06 15:48:54 -0500 |
| commit | af261c1b314058c3aefef3377b9f7f8a20701481 (patch) | |
| tree | f7364a518e02ef24d0acc7d760d452a39ee05faf | |
| parent | ff582303a8340fdd4d7fc3c7fb32b07c4c2270fa (diff) | |
| download | gitlab-ce-af261c1b314058c3aefef3377b9f7f8a20701481.tar.gz | |
attach a single event handler to detect radio button changes instead of one per input
| -rw-r--r-- | app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js | 16 | ||||
| -rw-r--r-- | app/views/projects/settings/ci_cd/_autodevops_form.html.haml | 2 |
2 files changed, 9 insertions, 9 deletions
diff --git a/app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js b/app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js index 6d227177cb4..152f76ff7af 100644 --- a/app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js +++ b/app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js @@ -24,15 +24,15 @@ document.addEventListener('DOMContentLoaded', () => { }); // hide extra auto devops settings based on data-attributes - const autoDevOpsSettings = document.querySelectorAll('input[data-hide-extra-settings]'); + const autoDevOpsSettings = document.querySelector('.js-auto-devops-settings'); const autoDevOpsExtraSettings = document.querySelector('.js-extra-settings'); - autoDevOpsSettings.forEach(input => { - input.addEventListener('click', () => - autoDevOpsExtraSettings.classList.toggle( - 'hidden', - input.dataset.hideExtraSettings === 'true', - ), - ); + autoDevOpsSettings.addEventListener('click', event => { + const targetData = event.target && event.target.dataset; + if (targetData.hideExtraSettings === 'true') { + autoDevOpsExtraSettings.classList.add('hidden'); + } else if (targetData.hideExtraSettings === 'false') { + autoDevOpsExtraSettings.classList.remove('hidden'); + } }); }); diff --git a/app/views/projects/settings/ci_cd/_autodevops_form.html.haml b/app/views/projects/settings/ci_cd/_autodevops_form.html.haml index 12a60400a42..c3e10a93456 100644 --- a/app/views/projects/settings/ci_cd/_autodevops_form.html.haml +++ b/app/views/projects/settings/ci_cd/_autodevops_form.html.haml @@ -2,7 +2,7 @@ .col-lg-12 = form_for @project, url: project_settings_ci_cd_path(@project) do |f| = form_errors(@project) - %fieldset.builds-feature.auto-devops-settings + %fieldset.builds-feature.js-auto-devops-settings .form-group - message = auto_devops_warning_message(@project) - ci_file_formatted = '<code>.gitlab-ci.yml</code>'.html_safe |