diff options
| author | Zeger-Jan van de Weg <git@zjvandeweg.nl> | 2019-02-18 07:14:16 +0000 |
|---|---|---|
| committer | mfluharty <mfluharty@gitlab.com> | 2019-02-20 11:20:33 -0700 |
| commit | 7ea01377acdcede52772e4731d710a670d20f938 (patch) | |
| tree | b0a098ac381c60f867cc9fc282eae95b0d2c5636 | |
| parent | d71f1784d23eac3b2e42c6fd5825f193aff244b8 (diff) | |
| download | gitlab-ce-7ea01377acdcede52772e4731d710a670d20f938.tar.gz | |
Improve language
| -rw-r--r-- | doc/development/code_review.md | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 09d0e0267bc..1b591c7c322 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -139,10 +139,11 @@ as the maintainer to ultimately approve and merge it. Try to review in a timely manner; doing so allows everyone involved in the merge request to iterate faster as the context is fresh in memory. Further, this -improves contributors' experiences significantly. Provided full availability; -reviewing within two work days should be the aim. If you don't think you'll be -able to review a merge request within that time, let the author know as soon as -possible. +improves contributors' experiences significantly. Reviewers should aim to review +within two working days from the date they were assigned the merge request. If +you don't think you'll be able to review a merge request within that time, let +the author know as soon as possible. When the author of the merge request has not +heard anything after two days, a new reviewer should be assigned. Maintainers should check before merging if the merge request is approved by the required approvers. |