summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFabio Papa <fabtheman@gmail.com>2019-06-25 21:59:10 -0700
committerFabio Papa <fabtheman@gmail.com>2019-07-19 14:04:18 -0700
commit302316dac8c19160e52929c03bf54e34fb9f678e (patch)
treee4209d095100898829c2be16b4c5a1a6166c1f13
parent0c0314803cccaa997289ef27f9170412c6a471f8 (diff)
downloadgitlab-ce-302316dac8c19160e52929c03bf54e34fb9f678e.tar.gz
Add examples specing the setting to choose who can create subgroups
This setting is at the group level only. The default is specified to be maintainers and owners. **Specs only**, all failing.
-rw-r--r--spec/factories/groups.rb1
-rw-r--r--spec/support/shared_contexts/policies/group_policy_shared_context.rb16
2 files changed, 7 insertions, 10 deletions
diff --git a/spec/factories/groups.rb b/spec/factories/groups.rb
index b67ab955ffc..947392b4fbc 100644
--- a/spec/factories/groups.rb
+++ b/spec/factories/groups.rb
@@ -5,6 +5,7 @@ FactoryBot.define do
type 'Group'
owner nil
project_creation_level ::Gitlab::Access::MAINTAINER_PROJECT_ACCESS
+ subgroup_creation_level ::Gitlab::Access::OWNER_SUBGROUP_ACCESS
after(:create) do |group|
if group.owner
diff --git a/spec/support/shared_contexts/policies/group_policy_shared_context.rb b/spec/support/shared_contexts/policies/group_policy_shared_context.rb
index 5a55bbac788..74389c4d82b 100644
--- a/spec/support/shared_contexts/policies/group_policy_shared_context.rb
+++ b/spec/support/shared_contexts/policies/group_policy_shared_context.rb
@@ -19,15 +19,10 @@ RSpec.shared_context 'GroupPolicy context' do
let(:reporter_permissions) { [:admin_label] }
let(:developer_permissions) { [:admin_milestone] }
let(:maintainer_permissions) do
- [
- :create_projects,
- :read_cluster,
- :create_cluster,
- :update_cluster,
- :admin_cluster,
- :add_cluster,
- (Gitlab::Database.postgresql? ? :create_subgroup : nil)
- ].compact
+ %i[
+ create_projects
+ read_cluster create_cluster update_cluster admin_cluster add_cluster
+ ]
end
let(:owner_permissions) do
[
@@ -35,7 +30,8 @@ RSpec.shared_context 'GroupPolicy context' do
:admin_namespace,
:admin_group_member,
:change_visibility_level,
- :set_note_created_at
+ :set_note_created_at,
+ (Gitlab::Database.postgresql? ? :create_subgroup : nil)
].compact
end