diff options
| author | Mark Lapierre <mlapierre@gitlab.com> | 2019-07-08 00:22:38 +0000 |
|---|---|---|
| committer | Mark Lapierre <mlapierre@gitlab.com> | 2019-07-08 00:22:38 +0000 |
| commit | b102e24aea9d913924c927cc54ec3519ded246ca (patch) | |
| tree | c45678bbc9ebeeddb77db1e0f2dd9a46a1fa4187 | |
| parent | 59c2415f19057aa985463cb186263a2ee94cce74 (diff) | |
| parent | 7c8ce1fe1733761a444c9a203c04ce4853137847 (diff) | |
| download | gitlab-ce-b102e24aea9d913924c927cc54ec3519ded246ca.tar.gz | |
Merge branch 'qa/refactor-plan-issues-check-mentions-for-xss-spec' into 'master'
Refactor end-to-end test
See merge request gitlab-org/gitlab-ce!30421
| -rw-r--r-- | qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb b/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb index 013cea0a40e..5eceeb9661c 100644 --- a/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb +++ b/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb @@ -9,12 +9,12 @@ module QA Runtime::Browser.visit(:gitlab, Page::Main::Login) Page::Main::Login.perform(&:sign_in_using_credentials) - user = Resource::User.fabricate! do |user| + user = Resource::User.fabricate_via_api! do |user| user.name = "eve <img src=x onerror=alert(2)<img src=x onerror=alert(1)>" user.password = "test1234" end - project = Resource::Project.fabricate! do |resource| + project = Resource::Project.fabricate_via_api! do |resource| resource.name = 'xss-test-for-mentions-project' end project.visit! @@ -24,10 +24,11 @@ module QA page.add_member(user.username) end - Resource::Issue.fabricate_via_browser_ui! do |issue| + issue = Resource::Issue.fabricate_via_api! do |issue| issue.title = issue_title issue.project = project end + issue.visit! Page::Project::Issue::Show.perform do |show_page| show_page.select_all_activities_filter |