diff options
| author | Bryce Johnson <bryce@gitlab.com> | 2016-10-25 16:30:14 +0000 |
|---|---|---|
| committer | Bryce Johnson <bryce@gitlab.com> | 2016-10-26 19:12:34 +0200 |
| commit | f285f4790ff4a2188fbac75fc4a70b7f31c740bb (patch) | |
| tree | 06dd56e398f061429ff082cf4a7e0bae73a4ff1e | |
| parent | 2fc359a506b5997cb65b6d5f2f5c85df98fd1c69 (diff) | |
| download | gitlab-ce-f285f4790ff4a2188fbac75fc4a70b7f31c740bb.tar.gz | |
Add ES array methods as cause of Phantom.js errors.
| -rw-r--r-- | doc/development/frontend.md | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/doc/development/frontend.md b/doc/development/frontend.md index 56c8516508e..54890989ea1 100644 --- a/doc/development/frontend.md +++ b/doc/development/frontend.md @@ -224,13 +224,18 @@ For our currently-supported browsers, see our [requirements][requirements]. [scss-style-guide]: scss_styleguide.md [requirements]: ../install/requirements.md#supported-web-browsers -## Common Errors +## Gotchas -### Rspec (Capybara/Poltergeist) chokes on general JavaScript errors +### Phantom.JS (used by Teaspoon & Rspec) chokes, returning vague JavaScript errors If you see very generic JavaScript errors (e.g. `jQuery is undefined`) being thrown in tests, but can't reproduce them manually, you may have included `ES6`-style JavaScript in files that don't have the `.js.es6` file extension. Either use ES5-friendly JavaScript or rename the file you're -working in (`git mv <file>.js> <file.js.es6>`). +working in (`git mv <file.js> <file.js.es6>`). + +Similar errors will be thrown if you're using +any of the [array methods introduced in ES6](http://www.2ality.com/2014/05/es6-array-methods.html) +whether or not you've updated the file extension. + |