summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Eastwood <contact@ericeastwood.com>2017-03-02 16:33:29 -0600
committerEric Eastwood <contact@ericeastwood.com>2017-03-06 12:54:46 -0600
commite8b3ac433f8cc8ca171ef9d45b0f3fe72649a82e (patch)
tree4001d47b204008f723624c22051000b7f3bff9d1
parenta8140d5c01de1f0558a9fc53d90d38c5a1188f80 (diff)
downloadgitlab-ce-e8b3ac433f8cc8ca171ef9d45b0f3fe72649a82e.tar.gz
Fix emoji cut-off line-height
Maintain emoji line-height in it's context to avoid cut-off, (Windows 10) http://i.imgur.com/xmdOLgv.png This also allows us to get rid of the small bodge for the cut-off in Safari
-rw-r--r--app/assets/stylesheets/framework/awards.scss2
-rw-r--r--app/assets/stylesheets/framework/emojis.scss2
-rw-r--r--app/assets/stylesheets/pages/notes.scss3
3 files changed, 3 insertions, 4 deletions
diff --git a/app/assets/stylesheets/framework/awards.scss b/app/assets/stylesheets/framework/awards.scss
index 6c0d5de0a99..f363affa46c 100644
--- a/app/assets/stylesheets/framework/awards.scss
+++ b/app/assets/stylesheets/framework/awards.scss
@@ -99,6 +99,8 @@
padding: 5px 6px;
outline: 0;
+ line-height: 1;
+
&.disabled {
cursor: default;
diff --git a/app/assets/stylesheets/framework/emojis.scss b/app/assets/stylesheets/framework/emojis.scss
index 680703cb4b1..0a8bc95590e 100644
--- a/app/assets/stylesheets/framework/emojis.scss
+++ b/app/assets/stylesheets/framework/emojis.scss
@@ -1,6 +1,6 @@
gl-emoji {
display: inline-block;
+ display: inline-flex;
vertical-align: middle;
font-size: 1.5em;
- line-height: 1;
}
diff --git a/app/assets/stylesheets/pages/notes.scss b/app/assets/stylesheets/pages/notes.scss
index 237312f3398..00f5f2645b3 100644
--- a/app/assets/stylesheets/pages/notes.scss
+++ b/app/assets/stylesheets/pages/notes.scss
@@ -188,9 +188,6 @@ ul.notes {
.note-body {
overflow-x: auto;
overflow-y: hidden;
- // Help with emoji cut-off (most noticable in Safari)
- // See https://i.imgur.com/0dg87Y9.png
- padding-top: 1px;
.note-text {
word-wrap: break-word;