summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Kozono <mkozono@gmail.com>2017-05-03 12:01:44 -0700
committerMichael Kozono <mkozono@gmail.com>2017-05-05 12:12:49 -0700
commitfc061c2ecd2e292383017c703220bfb22d0d6dce (patch)
tree46345a721098efa1556a62706e47f2eb2f0bb7db
parent03144e1c0f2ba41a7570850b69d5029bc2619fd2 (diff)
downloadgitlab-ce-fc061c2ecd2e292383017c703220bfb22d0d6dce.tar.gz
Fix Rubocop failures
-rw-r--r--db/migrate/20170427215854_create_redirect_routes.rb1
-rw-r--r--spec/controllers/groups_controller_spec.rb8
-rw-r--r--spec/features/projects/features_visibility_spec.rb4
3 files changed, 6 insertions, 7 deletions
diff --git a/db/migrate/20170427215854_create_redirect_routes.rb b/db/migrate/20170427215854_create_redirect_routes.rb
index 57b79a0267f..2bf086b3e30 100644
--- a/db/migrate/20170427215854_create_redirect_routes.rb
+++ b/db/migrate/20170427215854_create_redirect_routes.rb
@@ -1,5 +1,4 @@
class CreateRedirectRoutes < ActiveRecord::Migration
-
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
diff --git a/spec/controllers/groups_controller_spec.rb b/spec/controllers/groups_controller_spec.rb
index 3398878f330..d86bf1a3d0e 100644
--- a/spec/controllers/groups_controller_spec.rb
+++ b/spec/controllers/groups_controller_spec.rb
@@ -144,13 +144,13 @@ describe GroupsController do
it 'does not 404' do
delete :destroy, id: group.to_param.upcase
- expect(response).to_not have_http_status(404)
+ expect(response).not_to have_http_status(404)
end
it 'does not redirect to the correct casing' do
delete :destroy, id: group.to_param.upcase
- expect(response).to_not redirect_to(group_path(group.to_param))
+ expect(response).not_to redirect_to(group_path(group.to_param))
end
end
@@ -190,13 +190,13 @@ describe GroupsController do
it 'does not 404' do
post :update, id: group.to_param.upcase, group: { path: 'new_path' }
- expect(response).to_not have_http_status(404)
+ expect(response).not_to have_http_status(404)
end
it 'does not redirect to the correct casing' do
post :update, id: group.to_param.upcase, group: { path: 'new_path' }
- expect(response).to_not redirect_to(group_path(group.to_param))
+ expect(response).not_to redirect_to(group_path(group.to_param))
end
end
diff --git a/spec/features/projects/features_visibility_spec.rb b/spec/features/projects/features_visibility_spec.rb
index a6ca0f4131a..e1781cf320a 100644
--- a/spec/features/projects/features_visibility_spec.rb
+++ b/spec/features/projects/features_visibility_spec.rb
@@ -68,7 +68,7 @@ describe 'Edit Project Settings', feature: true do
end
describe 'project features visibility pages' do
- let(:tools) {
+ let(:tools) do
{
builds: namespace_project_pipelines_path(project.namespace, project),
issues: namespace_project_issues_path(project.namespace, project),
@@ -76,7 +76,7 @@ describe 'Edit Project Settings', feature: true do
snippets: namespace_project_snippets_path(project.namespace, project),
merge_requests: namespace_project_merge_requests_path(project.namespace, project),
}
- }
+ end
context 'normal user' do
before do