summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacob Schatz <jschatz@gitlab.com>2017-02-03 19:32:01 +0000
committerJacob Schatz <jschatz@gitlab.com>2017-02-03 19:32:01 +0000
commitb9c57808c8df69bf4dcfbada4bf4389befa0f3e2 (patch)
treec6aeb5d920fe7a6cdd7689d14bc8a67fc2c6134d
parentd5a9e934815471096010844c647ec523ad4e82a9 (diff)
parent7c29f03e23c0a87b1dc9dacda173f40de17378eb (diff)
downloadgitlab-ce-b9c57808c8df69bf4dcfbada4bf4389befa0f3e2.tar.gz
Merge branch '26825-diff-unfolding-within-merge-request-changes-tab-triggers-two-ajax-requests' into 'master'
Resolve diff unfolding redundant ajax request Closes #26825 See merge request !8630
-rw-r--r--app/assets/javascripts/diff.js.es611
1 files changed, 7 insertions, 4 deletions
diff --git a/app/assets/javascripts/diff.js.es6 b/app/assets/javascripts/diff.js.es6
index 35a029194d0..8741674b2d1 100644
--- a/app/assets/javascripts/diff.js.es6
+++ b/app/assets/javascripts/diff.js.es6
@@ -4,6 +4,7 @@
(() => {
const UNFOLD_COUNT = 20;
+ let isBound = false;
class Diff {
constructor() {
@@ -17,10 +18,12 @@
$('.content-wrapper .container-fluid').removeClass('container-limited');
}
- $(document)
- .off('click', '.js-unfold, .diff-line-num a')
- .on('click', '.js-unfold', this.handleClickUnfold.bind(this))
- .on('click', '.diff-line-num a', this.handleClickLineNum.bind(this));
+ if (!isBound) {
+ $(document)
+ .on('click', '.js-unfold', this.handleClickUnfold.bind(this))
+ .on('click', '.diff-line-num a', this.handleClickLineNum.bind(this));
+ isBound = true;
+ }
this.openAnchoredDiff();
}