diff options
author | Małgorzata Ksionek <meksionek@gmail.com> | 2019-05-29 11:08:36 +0200 |
---|---|---|
committer | Małgorzata Ksionek <mksionek@gitlab.com> | 2019-06-14 13:26:27 +0200 |
commit | 6b8594397d59baa397d4d73c76ec711cb033a9f4 (patch) | |
tree | 2c64767f395dd99c61aa77598c490192d7a36d57 | |
parent | e791385ecc1d57bcf9fc6c27f5d6604e36e929f9 (diff) | |
download | gitlab-ce-6b8594397d59baa397d4d73c76ec711cb033a9f4.tar.gz |
Comment out failing plan stage query - need rethink
-rw-r--r-- | lib/gitlab/cycle_analytics/issue_base_query.rb | 4 | ||||
-rw-r--r-- | lib/gitlab/cycle_analytics/plan_base_query.rb | 18 | ||||
-rw-r--r-- | spec/lib/gitlab/cycle_analytics/issue_stage_spec.rb | 4 |
3 files changed, 13 insertions, 13 deletions
diff --git a/lib/gitlab/cycle_analytics/issue_base_query.rb b/lib/gitlab/cycle_analytics/issue_base_query.rb index 25a177d2104..6dd72bbd7f0 100644 --- a/lib/gitlab/cycle_analytics/issue_base_query.rb +++ b/lib/gitlab/cycle_analytics/issue_base_query.rb @@ -8,9 +8,9 @@ module Gitlab .project(issue_table[:project_id].as("project_id")) .where(issue_table[:project_id].in(project_ids)) .where(issue_table[:created_at].gteq(@options[:from])) # rubocop:disable Gitlab/ModuleWithInstanceVariables - .where((issue_metrics_table[:first_added_to_board_at]).not_eq(nil).or(issue_metrics_table[:first_associated_with_milestone_at].not_eq(nil))) + .where(issue_metrics_table[:first_added_to_board_at].not_eq(nil).or(issue_metrics_table[:first_associated_with_milestone_at].not_eq(nil))) - query + query end end end diff --git a/lib/gitlab/cycle_analytics/plan_base_query.rb b/lib/gitlab/cycle_analytics/plan_base_query.rb index d0a17353b79..760f7025c67 100644 --- a/lib/gitlab/cycle_analytics/plan_base_query.rb +++ b/lib/gitlab/cycle_analytics/plan_base_query.rb @@ -3,16 +3,16 @@ module Gitlab module CycleAnalytics module PlanBaseQuery - def stage_query(project_ids) - query = issue_table.join(issue_metrics_table).on(issue_table[:id].eq(issue_metrics_table[:issue_id])) - .project(issue_table[:project_id].as("project_id")) - .where(issue_table[:project_id].in(project_ids)) - .where(issue_table[:created_at].gteq(@options[:from])) # rubocop:disable Gitlab/ModuleWithInstanceVariables - .where((issue_metrics_table[:first_added_to_board_at]).not_eq(nil).or(issue_metrics_table[:first_associated_with_milestone_at].not_eq(nil))) - .where(issue_metrics_table[:first_mentioned_in_commit_at].not_eq(nil)) + # def stage_query(project_ids) + # query = issue_table.join(issue_metrics_table).on(issue_table[:id].eq(issue_metrics_table[:issue_id])) + # .project(issue_table[:project_id].as("project_id")) + # .where(issue_table[:project_id].in(project_ids)) + # .where(issue_table[:created_at].gteq(@options[:from])) # rubocop:disable Gitlab/ModuleWithInstanceVariables + # .where((issue_metrics_table[:first_added_to_board_at]).not_eq(nil).or(issue_metrics_table[:first_associated_with_milestone_at].not_eq(nil))) + # .where(issue_metrics_table[:first_mentioned_in_commit_at].not_eq(nil)) - query - end + # query + # end end end end diff --git a/spec/lib/gitlab/cycle_analytics/issue_stage_spec.rb b/spec/lib/gitlab/cycle_analytics/issue_stage_spec.rb index 984f26123dc..d73c874a4c2 100644 --- a/spec/lib/gitlab/cycle_analytics/issue_stage_spec.rb +++ b/spec/lib/gitlab/cycle_analytics/issue_stage_spec.rb @@ -32,8 +32,8 @@ describe Gitlab::CycleAnalytics::IssueStage do it 'exposes issues with metrics' do result = stage.events - expect(result.count).to eq(2) - expect(result.map{ |event| event[:title] }).to include(issue_1.title, issue_2.title) + expect(result.count).to eq(3) + expect(result.map{ |event| event[:title] }).to include(issue_1.title, issue_2.title, issue_3.title) end end end |