diff options
author | Małgorzata Ksionek <mksionek@gitlab.com> | 2019-05-31 18:49:49 +0200 |
---|---|---|
committer | Małgorzata Ksionek <mksionek@gitlab.com> | 2019-06-14 13:26:27 +0200 |
commit | e66e823166e2cb8a51489f05240ea1837067dc11 (patch) | |
tree | b416ac5680b51f4dcb66b74f1e80ce06e53a123c | |
parent | 8da1422fcdcfcedc31025a21ac38bae91a0d4059 (diff) | |
download | gitlab-ce-e66e823166e2cb8a51489f05240ea1837067dc11.tar.gz |
Add spec for code stage
-rw-r--r-- | spec/lib/gitlab/cycle_analytics/code_stage_spec.rb | 36 | ||||
-rw-r--r-- | spec/lib/gitlab/cycle_analytics/issue_stage_spec.rb | 2 | ||||
-rw-r--r-- | spec/lib/gitlab/cycle_analytics/plan_stage_spec.rb | 2 |
3 files changed, 38 insertions, 2 deletions
diff --git a/spec/lib/gitlab/cycle_analytics/code_stage_spec.rb b/spec/lib/gitlab/cycle_analytics/code_stage_spec.rb index e8fc67acf05..a353fe417e3 100644 --- a/spec/lib/gitlab/cycle_analytics/code_stage_spec.rb +++ b/spec/lib/gitlab/cycle_analytics/code_stage_spec.rb @@ -4,5 +4,41 @@ require 'lib/gitlab/cycle_analytics/shared_stage_spec' describe Gitlab::CycleAnalytics::CodeStage do let(:stage_name) { :code } + let(:project) { create(:project) } + let!(:issue_1) { create(:issue, project: project, created_at: 90.minutes.ago) } + let!(:issue_2) { create(:issue, project: project, created_at: 60.minutes.ago) } + let!(:issue_3) { create(:issue, project: project, created_at: 60.minutes.ago) } + let!(:mr_1) { create(:merge_request, source_project: project, created_at: 15.minutes.ago) } + let!(:mr_2) { create(:merge_request, source_project: project, created_at: 10.minutes.ago, source_branch: 'A') } + let!(:mr_3) { create(:merge_request, source_project: project, created_at: 10.minutes.ago, source_branch: 'B') } + let(:stage) { described_class.new(project: project, options: { from: 2.days.ago, current_user: project.creator }) } + + before do + issue_1.metrics.update!(first_associated_with_milestone_at: 60.minutes.ago, first_mentioned_in_commit_at: 45.minutes.ago) + issue_2.metrics.update!(first_added_to_board_at: 60.minutes.ago, first_mentioned_in_commit_at: 40.minutes.ago) + issue_3.metrics.update!(first_added_to_board_at: 60.minutes.ago, first_mentioned_in_commit_at: 40.minutes.ago) + create(:merge_requests_closing_issues, merge_request: mr_1, issue: issue_1) + create(:merge_requests_closing_issues, merge_request: mr_2, issue: issue_2) + end + it_behaves_like 'base stage' + + describe '#median' do + around do |example| + Timecop.freeze { example.run } + end + + it 'counts median from issues with metrics' do + expect(stage.median).to eq(HALF_AN_HOUR_IN_SECONDS) + end + end + + describe '#events' do + it 'exposes merge requests that closes issues' do + result = stage.events + + expect(result.count).to eq(2) + expect(result.map { |event| event[:title] }).to contain_exactly(mr_1.title, mr_2.title) + end + end end diff --git a/spec/lib/gitlab/cycle_analytics/issue_stage_spec.rb b/spec/lib/gitlab/cycle_analytics/issue_stage_spec.rb index e5374d83d7f..d76da20d6a5 100644 --- a/spec/lib/gitlab/cycle_analytics/issue_stage_spec.rb +++ b/spec/lib/gitlab/cycle_analytics/issue_stage_spec.rb @@ -33,7 +33,7 @@ describe Gitlab::CycleAnalytics::IssueStage do result = stage.events expect(result.count).to eq(3) - expect(result.map { |event| event[:title] }).to include(issue_1.title, issue_2.title, issue_3.title) + expect(result.map { |event| event[:title] }).to contain_exactly(issue_1.title, issue_2.title, issue_3.title) end end end diff --git a/spec/lib/gitlab/cycle_analytics/plan_stage_spec.rb b/spec/lib/gitlab/cycle_analytics/plan_stage_spec.rb index 401dfa2057b..2787f983198 100644 --- a/spec/lib/gitlab/cycle_analytics/plan_stage_spec.rb +++ b/spec/lib/gitlab/cycle_analytics/plan_stage_spec.rb @@ -33,7 +33,7 @@ describe Gitlab::CycleAnalytics::PlanStage do result = stage.events expect(result.count).to eq(2) - expect(result.map { |event| event[:title] }).to include(issue_1.title, issue_2.title) + expect(result.map { |event| event[:title] }).to contain_exactly(issue_1.title, issue_2.title) end end end |