summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrett Walker <bwalker@gitlab.com>2017-10-30 14:31:18 +0100
committerBrett Walker <bwalker@gitlab.com>2017-10-31 16:01:16 +0100
commit4763aaedac151c64882f5d0a500cb85100b50b95 (patch)
tree178201f05bfec87ab65db5e2c4eec3c40c745cf9
parenteef16a66dad3886b5ec567596be30d08b37c7df9 (diff)
downloadgitlab-ce-4763aaedac151c64882f5d0a500cb85100b50b95.tar.gz
enhance spec
-rw-r--r--spec/lib/gitlab/middleware/read_only_spec.rb14
1 files changed, 13 insertions, 1 deletions
diff --git a/spec/lib/gitlab/middleware/read_only_spec.rb b/spec/lib/gitlab/middleware/read_only_spec.rb
index 56ea3cf63b5..86be06ff595 100644
--- a/spec/lib/gitlab/middleware/read_only_spec.rb
+++ b/spec/lib/gitlab/middleware/read_only_spec.rb
@@ -83,6 +83,13 @@ describe Gitlab::Middleware::ReadOnly do
expect(subject).to disallow_request
end
+ it 'expects POST of new file that looks like an LFS batch url to be disallowed' do
+ response = request.post('/root/gitlab-ce/new/master/app/info/lfs/objects/batch')
+
+ expect(response).to be_a_redirect
+ expect(subject).to disallow_request
+ end
+
context 'whitelisted requests' do
it 'expects DELETE request to logout to be allowed' do
response = request.delete('/users/sign_out')
@@ -112,11 +119,16 @@ describe Gitlab::Middleware::ReadOnly do
expect(subject).not_to disallow_request
end
- it 'xexpects a POST request to git-upload-pack URL to be allowed' do
+ it 'expects requests to sidekiq admin to be allowed' do
response = request.post('/admin/sidekiq')
expect(response).not_to be_a_redirect
expect(subject).not_to disallow_request
+
+ response = request.get('/admin/sidekiq')
+
+ expect(response).not_to be_a_redirect
+ expect(subject).not_to disallow_request
end
end
end