diff options
| author | Rémy Coutable <remy@rymai.me> | 2017-08-01 14:01:49 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2017-08-01 14:01:49 +0000 |
| commit | e753444c7341bb9c327aaf7db69a4e612bff0449 (patch) | |
| tree | a8f600b49de156793cf8fad0918e85c72ee34b6d | |
| parent | 1814fef814d2b21d0a4aaa3482233ed8777875ab (diff) | |
| parent | 0430007ec86b7761cdaac2a0ba5d735264d63148 (diff) | |
| download | gitlab-ce-e753444c7341bb9c327aaf7db69a4e612bff0449.tar.gz | |
Merge branch 'doc_code_review' into 'master'
Add code review guidelines related to Build [CI skip].
See merge request !13223
| -rw-r--r-- | doc/development/code_review.md | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index e3f37616757..64a89976300 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -11,6 +11,8 @@ There are a few rules to get your merge request accepted: **approved by a [frontend maintainer][projects]**. 1. If your merge request includes frontend and backend changes [^1], it must be **approved by a [frontend and a backend maintainer][projects]**. + 1. If your merge request includes a new dependency or a filesystem change, it must + be **approved by a [Build team member][team]**. See [how to work with the Build team][build handbook] for more details. 1. To lower the amount of merge requests maintainers need to review, you can ask or assign any [reviewers][projects] for a first review. 1. If you need some guidance (e.g. it's your first merge request), feel free @@ -194,3 +196,4 @@ Largely based on the [thoughtbot code review guide]. [projects]: https://about.gitlab.com/handbook/engineering/projects/ [team]: https://about.gitlab.com/team/ +[build handbook]: https://about.gitlab.com/handbook/build/handbook/build#how-to-work-with-build |