summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGrzegorz Bizon <grzesiek.bizon@gmail.com>2017-09-05 10:04:40 +0200
committerGrzegorz Bizon <grzesiek.bizon@gmail.com>2017-09-13 13:35:18 +0200
commitd2e02224cb4b8b340631edf29aa842e386fc7f1e (patch)
tree8768e9db9d904555e7f512adecda48316cced2f4
parent6a4dd0519055a35e415d060daa18e2dc6d34e097 (diff)
downloadgitlab-ce-d2e02224cb4b8b340631edf29aa842e386fc7f1e.tar.gz
Optimize generic specs for services
-rw-r--r--spec/requests/api/services_spec.rb13
1 files changed, 7 insertions, 6 deletions
diff --git a/spec/requests/api/services_spec.rb b/spec/requests/api/services_spec.rb
index 48d99841385..7e174903918 100644
--- a/spec/requests/api/services_spec.rb
+++ b/spec/requests/api/services_spec.rb
@@ -1,10 +1,13 @@
require "spec_helper"
describe API::Services do
- let(:user) { create(:user) }
- let(:admin) { create(:admin) }
- let(:user2) { create(:user) }
- let(:project) { create(:project, creator_id: user.id, namespace: user.namespace) }
+ set(:user) { create(:user) }
+ set(:admin) { create(:admin) }
+ set(:user2) { create(:user) }
+
+ set(:project) do
+ create(:project, creator_id: user.id, namespace: user.namespace)
+ end
Service.available_services_names.each do |service|
describe "PUT /projects/:id/services/#{service.dasherize}" do
@@ -98,8 +101,6 @@ describe API::Services do
end
describe 'POST /projects/:id/services/:slug/trigger' do
- let!(:project) { create(:project) }
-
describe 'Mattermost Service' do
let(:service_name) { 'mattermost_slash_commands' }