diff options
author | Robert Speicher <rspeicher@gmail.com> | 2017-08-31 14:41:53 -0400 |
---|---|---|
committer | Robert Speicher <rspeicher@gmail.com> | 2017-09-01 10:44:56 -0400 |
commit | b1f581c3c291eaa3c07907c8cc3147f6bd4c759a (patch) | |
tree | f625cb5c468d5c7fd56de5df71a26e54989f265e | |
parent | ba3449a7bed71cca93b392267390f6e78d6d57dd (diff) | |
download | gitlab-ce-b1f581c3c291eaa3c07907c8cc3147f6bd4c759a.tar.gz |
Scope group creation to the specs that actually require it
Only one context tested group behavior, but we were performing group and
membership creation on every example unnecessarily.
-rw-r--r-- | spec/features/issues/filtered_search/filter_issues_spec.rb | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/spec/features/issues/filtered_search/filter_issues_spec.rb b/spec/features/issues/filtered_search/filter_issues_spec.rb index 2b399b3a357..8ef4d88b892 100644 --- a/spec/features/issues/filtered_search/filter_issues_spec.rb +++ b/spec/features/issues/filtered_search/filter_issues_spec.rb @@ -3,8 +3,7 @@ require 'spec_helper' describe 'Filter issues', js: true do include FilteredSearchHelpers - let!(:group) { create(:group) } - let!(:project) { create(:project, group: group) } + let!(:project) { create(:project) } let!(:user) { create(:user, username: 'joe', name: 'Joe') } let!(:user2) { create(:user, username: 'jane') } let!(:label) { create(:label, project: project) } @@ -39,8 +38,6 @@ describe 'Filter issues', js: true do before do project.team << [user, :master] project.team << [user2, :master] - group.add_developer(user) - group.add_developer(user2) sign_in(user) @@ -538,6 +535,13 @@ describe 'Filter issues', js: true do end describe 'RSS feeds' do + let(:group) { create(:group) } + let(:project) { create(:project, group: group) } + + before do + group.add_developer(user) + end + it 'updates atom feed link for project issues' do visit project_issues_path(project, milestone_title: milestone.title, assignee_id: user.id) link = find_link('Subscribe') |