fixed rendering bugs

fixed eslint

6 files changed, 7 insertions, 18 deletions

diff --git a/app/assets/javascripts/repo/components/repo_file.vue b/app/assets/javascripts/repo/components/repo_file.vue
index 905da9ef43c..61057b2a60f 100644
--- a/app/assets/javascripts/repo/components/repo_file.vue
+++ b/app/assets/javascripts/repo/components/repo_file.vue
@@ -58,10 +58,11 @@
     </td>
 
     <template v-if="!isMini">
-      <td class="commit-message hidden-sm hidden-xs">
+      <td class="hidden-sm hidden-xs">
         <a
           @click.stop
           :href="file.lastCommit.url"
+          class="commit-message"
         >
           {{ file.lastCommit.message }}
         </a>
diff --git a/app/assets/javascripts/repo/components/repo_prev_directory.vue b/app/assets/javascripts/repo/components/repo_prev_directory.vue
index d042fc664b6..f657276ad52 100644
--- a/app/assets/javascripts/repo/components/repo_prev_directory.vue
+++ b/app/assets/javascripts/repo/components/repo_prev_directory.vue
@@ -22,7 +22,7 @@
 </script>
 
 <template>
-  <tr class="prev-directory">
+  <tr class="file prev-directory">
     <td
       :colspan="colSpanCondition"
       class="table-cell"
diff --git a/app/assets/javascripts/repo/components/repo_sidebar.vue b/app/assets/javascripts/repo/components/repo_sidebar.vue
index e7c269cdb57..dc990324313 100644
--- a/app/assets/javascripts/repo/components/repo_sidebar.vue
+++ b/app/assets/javascripts/repo/components/repo_sidebar.vue
@@ -136,7 +136,7 @@ export default {
     </thead>
     <tbody>
       <repo-previous-directory
-        v-if="!isRoot"
+        v-if="!isRoot && !loading.tree"
         :prev-url="prevURL"
       />
       <repo-loading-file
diff --git a/app/assets/javascripts/repo/helpers/repo_helper.js b/app/assets/javascripts/repo/helpers/repo_helper.js
index 9d05db0e414..2481a8aa107 100644
--- a/app/assets/javascripts/repo/helpers/repo_helper.js
+++ b/app/assets/javascripts/repo/helpers/repo_helper.js
@@ -94,7 +94,7 @@ const RepoHelper = {
     .then((response) => {
       const data = response.data;
       if (response.headers && response.headers['page-title']) data.pageTitle = response.headers['page-title'];
-      if (response.headers && response.headers['is-root']) Store.isRoot = convertPermissionToBoolean(response.headers['is-root']);
+      if (response.headers && response.headers['is-root'] && Store.isRoot === null) Store.isRoot = convertPermissionToBoolean(response.headers['is-root']);
 
       if (file && file.type === 'blob') {
         if (!file) file = data;
diff --git a/app/assets/javascripts/repo/stores/repo_store.js b/app/assets/javascripts/repo/stores/repo_store.js
index 2950e5702d6..1a9757f1a4a 100644
--- a/app/assets/javascripts/repo/stores/repo_store.js
+++ b/app/assets/javascripts/repo/stores/repo_store.js
@@ -2,13 +2,12 @@ import Helper from '../helpers/repo_helper';
 import Service from '../services/repo_service';
 
 const RepoStore = {
-  monaco: {},
   monacoLoading: false,
   service: '',
   canCommit: false,
   onTopOfBranch: false,
   editMode: false,
-  isRoot: false,
+  isRoot: null,
   prevURL: '',
   projectId: '',
   projectName: '',
@@ -38,23 +37,11 @@ const RepoStore = {
   newMrTemplateUrl: '',
   branchChanged: false,
   commitMessage: '',
-  binaryTypes: {
-    png: false,
-    md: false,
-    svg: false,
-    unknown: false,
-  },
   loading: {
     tree: false,
     blob: false,
   },
 
-  resetBinaryTypes() {
-    Object.keys(RepoStore.binaryTypes).forEach((key) => {
-      RepoStore.binaryTypes[key] = false;
-    });
-  },
-
   setBranchHash() {
     return Service.getBranch()
       .then((data) => {
diff --git a/spec/javascripts/repo/mock_data.js b/spec/javascripts/repo/mock_data.js
index 097d5c88d1e..6342b3539b5 100644
--- a/spec/javascripts/repo/mock_data.js
+++ b/spec/javascripts/repo/mock_data.js
@@ -1,5 +1,6 @@
 import RepoHelper from '~/repo/helpers/repo_helper';
 
+// eslint-disable-next-line import/prefer-default-export
 export const file = () => RepoHelper.serializeBlob({
   icon: 'icon',
   url: 'url',