summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAchilleas Pipinellis <axilleas@axilleas.me>2017-09-14 12:09:03 +0200
committerAchilleas Pipinellis <axilleas@axilleas.me>2017-09-14 12:09:03 +0200
commitdb81ae2894be6ab886bb452b5ca78a68271e5990 (patch)
tree2bc77fd98c36d801c78dcd20de7a31212537160c
parent54a49a06584e5fbd1f7f36b63cc330188bc3a581 (diff)
downloadgitlab-ce-db81ae2894be6ab886bb452b5ca78a68271e5990.tar.gz
Use a secret variable to define the repo suffixdocs/environment-url
That's a hack since we cannot inject variables that are defined in `script:` into `environments:url`, and we want to avoid maintaining two different job versions in CE and EE. Relevant discussion: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14236/diffs#note_40140693
-rw-r--r--.gitlab-ci.yml5
1 files changed, 3 insertions, 2 deletions
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 61810f5c458..0520f3b1c37 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -191,8 +191,9 @@ review-docs-deploy:
stage: build
environment:
name: review-docs/$CI_COMMIT_REF_NAME
- # The URL must end in /ce
- url: http://$CI_COMMIT_REF_SLUG-built-from-ce-ee.$DOCS_REVIEW_APPS_DOMAIN/ce
+ # DOCS_REVIEW_APPS_DOMAIN and DOCS_GITLAB_REPO_SUFFIX are secret variables
+ # Discussion: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14236/diffs#note_40140693
+ url: http://$CI_COMMIT_REF_SLUG-built-from-ce-ee.$DOCS_REVIEW_APPS_DOMAIN/$DOCS_GITLAB_REPO_SUFFIX
on_stop: review-docs-cleanup
script:
- gem install gitlab --no-doc