diff options
| author | haseeb <haseebeqx@gmail.com> | 2017-11-30 09:57:58 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2017-11-30 09:57:58 +0000 |
| commit | 869877ab2691f94927e49610349e284633688819 (patch) | |
| tree | 3221ac2b8013380d702788a733f36a269a68136a | |
| parent | 73e48b745c34c048c56abf28e6c278707d9bd2f3 (diff) | |
| download | gitlab-ce-869877ab2691f94927e49610349e284633688819.tar.gz | |
fix for special charecter in file names
| -rw-r--r-- | changelogs/unreleased/40146_fix_special_charecter_search_in_filenames.yml | 5 | ||||
| -rw-r--r-- | lib/gitlab/project_search_results.rb | 7 | ||||
| -rw-r--r-- | spec/lib/gitlab/project_search_results_spec.rb | 9 |
3 files changed, 19 insertions, 2 deletions
diff --git a/changelogs/unreleased/40146_fix_special_charecter_search_in_filenames.yml b/changelogs/unreleased/40146_fix_special_charecter_search_in_filenames.yml new file mode 100644 index 00000000000..00f7dd7c0f0 --- /dev/null +++ b/changelogs/unreleased/40146_fix_special_charecter_search_in_filenames.yml @@ -0,0 +1,5 @@ +--- +title: Fix search results when a filename would contain a special character. +merge_request: 15606 +author: haseebeqx +type: fixed diff --git a/lib/gitlab/project_search_results.rb b/lib/gitlab/project_search_results.rb index 561aa9e162c..e2662fc362b 100644 --- a/lib/gitlab/project_search_results.rb +++ b/lib/gitlab/project_search_results.rb @@ -47,8 +47,11 @@ module Gitlab startline = 0 result.each_line.each_with_index do |line, index| - if line =~ /^.*:.*:\d+:/ - ref, filename, startline = line.split(':') + matches = line.match(/^(?<ref>[^:]*):(?<filename>.*):(?<startline>\d+):/) + if matches + ref = matches[:ref] + filename = matches[:filename] + startline = matches[:startline] startline = startline.to_i - index extname = Regexp.escape(File.extname(filename)) basename = filename.sub(/#{extname}$/, '') diff --git a/spec/lib/gitlab/project_search_results_spec.rb b/spec/lib/gitlab/project_search_results_spec.rb index 9c3e7d7e9ba..a424f0f5cfe 100644 --- a/spec/lib/gitlab/project_search_results_spec.rb +++ b/spec/lib/gitlab/project_search_results_spec.rb @@ -70,6 +70,15 @@ describe Gitlab::ProjectSearchResults do subject { described_class.parse_search_result(search_result) } + it 'can correctly parse filenames including ":"' do + special_char_result = "\nmaster:testdata/project::function1.yaml-1----\nmaster:testdata/project::function1.yaml:2:test: data1\n" + + blob = described_class.parse_search_result(special_char_result) + + expect(blob.ref).to eq('master') + expect(blob.filename).to eq('testdata/project::function1.yaml') + end + it "returns a valid FoundBlob" do is_expected.to be_an Gitlab::SearchResults::FoundBlob expect(subject.id).to be_nil |