summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Kozono <mkozono@gmail.com>2018-09-20 12:38:00 -0700
committerMichael Kozono <mkozono@gmail.com>2018-09-24 12:11:26 -0700
commit22bf3848ef0e59fb7689bfeab3ba0d8079f1597e (patch)
tree73b0890c315d3af3b0dad22e509f366e2a47cb1b
parentf107bc69e34f79ea8faaa154caefe56948b8dd68 (diff)
downloadgitlab-ce-22bf3848ef0e59fb7689bfeab3ba0d8079f1597e.tar.gz
Add note to docs about `Gitlab::SafeRequestStore`
-rw-r--r--doc/development/merge_request_performance_guidelines.md5
1 files changed, 3 insertions, 2 deletions
diff --git a/doc/development/merge_request_performance_guidelines.md b/doc/development/merge_request_performance_guidelines.md
index 12badbe39b2..ee01c89e0ed 100644
--- a/doc/development/merge_request_performance_guidelines.md
+++ b/doc/development/merge_request_performance_guidelines.md
@@ -168,6 +168,7 @@ user objects for every username we can remove the need for running the same
query for every mention of `@alice`.
Caching data per transaction can be done using
-[RequestStore](https://github.com/steveklabnik/request_store). Caching data in
-Redis can be done using [Rails' caching
+[RequestStore](https://github.com/steveklabnik/request_store) (use
+`Gitlab::SafeRequestStore` to avoid having to remember to check
+`RequestStore.active?`). Caching data in Redis can be done using [Rails' caching
system](http://guides.rubyonrails.org/caching_with_rails.html).