summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Chao <mchao@gitlab.com>2018-06-05 13:45:30 +0900
committerMark Chao <mchao@gitlab.com>2018-06-22 10:23:34 +0800
commita6174bb055d63f5a2541f5b45f8c2a5c27606a4d (patch)
tree04fd4679e5584473590a928b5fc943ce325e52f6
parent7d042438730676346d23820553045a464ee64cad (diff)
downloadgitlab-ce-a6174bb055d63f5a2541f5b45f8c2a5c27606a4d.tar.gz
project.team.masters
-rw-r--r--app/models/project_team.rb4
-rw-r--r--app/services/notification_service.rb2
-rw-r--r--spec/models/project_team_spec.rb16
-rw-r--r--spec/services/projects/create_service_spec.rb4
4 files changed, 13 insertions, 13 deletions
diff --git a/app/models/project_team.rb b/app/models/project_team.rb
index b6b935bcbd9..ec2ade8607a 100644
--- a/app/models/project_team.rb
+++ b/app/models/project_team.rb
@@ -81,8 +81,8 @@ class ProjectTeam
@developers ||= fetch_members(Gitlab::Access::DEVELOPER)
end
- def masters
- @masters ||= fetch_members(Gitlab::Access::MAINTAINER)
+ def maintainers
+ @maintainers ||= fetch_members(Gitlab::Access::MAINTAINER)
end
def owners
diff --git a/app/services/notification_service.rb b/app/services/notification_service.rb
index 636cfbf5b45..5eaffee3430 100644
--- a/app/services/notification_service.rb
+++ b/app/services/notification_service.rb
@@ -513,7 +513,7 @@ class NotificationService
return [] unless project
- notifiable_users(project.team.masters, :watch, target: project)
+ notifiable_users(project.team.maintainers, :watch, target: project)
end
def notifiable?(*args)
diff --git a/spec/models/project_team_spec.rb b/spec/models/project_team_spec.rb
index ea512545674..509b266c182 100644
--- a/spec/models/project_team_spec.rb
+++ b/spec/models/project_team_spec.rb
@@ -16,10 +16,10 @@ describe ProjectTeam do
end
describe 'members collection' do
- it { expect(project.team.masters).to include(master) }
- it { expect(project.team.masters).not_to include(guest) }
- it { expect(project.team.masters).not_to include(reporter) }
- it { expect(project.team.masters).not_to include(nonmember) }
+ it { expect(project.team.maintainers).to include(master) }
+ it { expect(project.team.maintainers).not_to include(guest) }
+ it { expect(project.team.maintainers).not_to include(reporter) }
+ it { expect(project.team.maintainers).not_to include(nonmember) }
end
describe 'access methods' do
@@ -53,10 +53,10 @@ describe ProjectTeam do
describe 'members collection' do
it { expect(project.team.reporters).to include(reporter) }
- it { expect(project.team.masters).to include(master) }
- it { expect(project.team.masters).to include(guest) }
- it { expect(project.team.masters).not_to include(reporter) }
- it { expect(project.team.masters).not_to include(nonmember) }
+ it { expect(project.team.maintainers).to include(master) }
+ it { expect(project.team.maintainers).to include(guest) }
+ it { expect(project.team.maintainers).not_to include(reporter) }
+ it { expect(project.team.maintainers).not_to include(nonmember) }
end
describe 'access methods' do
diff --git a/spec/services/projects/create_service_spec.rb b/spec/services/projects/create_service_spec.rb
index e8cbf84e3be..ed0f62ec11b 100644
--- a/spec/services/projects/create_service_spec.rb
+++ b/spec/services/projects/create_service_spec.rb
@@ -23,7 +23,7 @@ describe Projects::CreateService, '#execute' do
expect(project).to be_valid
expect(project.owner).to eq(user)
- expect(project.team.masters).to include(user)
+ expect(project.team.maintainers).to include(user)
expect(project.namespace).to eq(user.namespace)
end
end
@@ -47,7 +47,7 @@ describe Projects::CreateService, '#execute' do
expect(project).to be_persisted
expect(project.owner).to eq(user)
- expect(project.team.masters).to contain_exactly(user)
+ expect(project.team.maintainers).to contain_exactly(user)
expect(project.namespace).to eq(user.namespace)
end
end