diff options
author | Mark Chao <mchao@gitlab.com> | 2018-06-05 12:28:48 +0900 |
---|---|---|
committer | Mark Chao <mchao@gitlab.com> | 2018-06-22 10:23:32 +0800 |
commit | f0a04a185771e29bfd7977bc82a61521515424b3 (patch) | |
tree | 40356a202c6849c522db58ec2db95f4682b7ece3 | |
parent | bf635255962034e39a9c5c0fe543a4761efb3cba (diff) | |
download | gitlab-ce-f0a04a185771e29bfd7977bc82a61521515424b3.tar.gz |
has_master?
-rw-r--r-- | app/models/group.rb | 2 | ||||
-rw-r--r-- | spec/models/group_spec.rb | 16 |
2 files changed, 9 insertions, 9 deletions
diff --git a/app/models/group.rb b/app/models/group.rb index e324db811a5..48f9feaca94 100644 --- a/app/models/group.rb +++ b/app/models/group.rb @@ -198,7 +198,7 @@ class Group < Namespace members_with_parents.owners.where(user_id: user).any? end - def has_master?(user) + def has_maintainer?(user) return false unless user members_with_parents.masters.where(user_id: user).any? diff --git a/spec/models/group_spec.rb b/spec/models/group_spec.rb index 7dac18fa29a..fa66ca2be2a 100644 --- a/spec/models/group_spec.rb +++ b/spec/models/group_spec.rb @@ -325,19 +325,19 @@ describe Group do it { expect(group.has_owner?(nil)).to be_falsey } end - describe '#has_master?' do + describe '#has_maintainer?' do before do @members = setup_group_members(group) create(:group_member, :invited, :master, group: group) end - it { expect(group.has_master?(@members[:owner])).to be_falsey } - it { expect(group.has_master?(@members[:master])).to be_truthy } - it { expect(group.has_master?(@members[:developer])).to be_falsey } - it { expect(group.has_master?(@members[:reporter])).to be_falsey } - it { expect(group.has_master?(@members[:guest])).to be_falsey } - it { expect(group.has_master?(@members[:requester])).to be_falsey } - it { expect(group.has_master?(nil)).to be_falsey } + it { expect(group.has_maintainer?(@members[:owner])).to be_falsey } + it { expect(group.has_maintainer?(@members[:master])).to be_truthy } + it { expect(group.has_maintainer?(@members[:developer])).to be_falsey } + it { expect(group.has_maintainer?(@members[:reporter])).to be_falsey } + it { expect(group.has_maintainer?(@members[:guest])).to be_falsey } + it { expect(group.has_maintainer?(@members[:requester])).to be_falsey } + it { expect(group.has_maintainer?(nil)).to be_falsey } end describe '#lfs_enabled?' do |