summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGrzegorz Bizon <grzesiek.bizon@gmail.com>2018-03-07 12:39:53 +0100
committerGrzegorz Bizon <grzesiek.bizon@gmail.com>2018-03-07 12:39:53 +0100
commitc9d2fd3cffbe3c1d85de05d9d26bcabd19676256 (patch)
treeccb5cde1cc7b85ff4ec527a9277bd4ccafb21b5b
parent640f9ee8e188b16d50c7c83795e3289572aa37b1 (diff)
downloadgitlab-ce-c9d2fd3cffbe3c1d85de05d9d26bcabd19676256.tar.gz
Improve pipeline tests for variables to test ordering
-rw-r--r--spec/models/ci/pipeline_spec.rb6
1 files changed, 3 insertions, 3 deletions
diff --git a/spec/models/ci/pipeline_spec.rb b/spec/models/ci/pipeline_spec.rb
index 14d234f6aab..86bb2fefae1 100644
--- a/spec/models/ci/pipeline_spec.rb
+++ b/spec/models/ci/pipeline_spec.rb
@@ -172,10 +172,10 @@ describe Ci::Pipeline, :mailer do
it { is_expected.to be_an(Array) }
- it 'includes the defined keys' do
- keys = subject.map { |v| v[:key] }
+ it 'includes all predefined variables in a valid order' do
+ keys = subject.map { |variable| variable.fetch(:key) }
- expect(keys).to include('CI_PIPELINE_ID', 'CI_CONFIG_PATH', 'CI_PIPELINE_SOURCE')
+ expect(keys).to eq %w[CI_PIPELINE_ID CI_CONFIG_PATH CI_PIPELINE_SOURCE]
end
end