summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFatih Acet <acetfatih@gmail.com>2018-07-18 01:58:01 +0200
committerFatih Acet <acetfatih@gmail.com>2018-07-18 12:55:58 +0200
commit13ede8cfb763888c70447a487722c620c87d2a40 (patch)
tree59c21ce6624d526780b6ae046dc0697fffa76197
parent3a3c640ef2b90c107fd019d3c0ce199923a5f44e (diff)
downloadgitlab-ce-13ede8cfb763888c70447a487722c620c87d2a40.tar.gz
Revert debounce.
-rw-r--r--app/assets/javascripts/autosave.js11
-rw-r--r--spec/javascripts/autosave_spec.js17
2 files changed, 3 insertions, 25 deletions
diff --git a/app/assets/javascripts/autosave.js b/app/assets/javascripts/autosave.js
index 32789186020..e8c59fab609 100644
--- a/app/assets/javascripts/autosave.js
+++ b/app/assets/javascripts/autosave.js
@@ -1,6 +1,5 @@
/* eslint-disable no-param-reassign, prefer-template, no-void, consistent-return */
-import _ from 'underscore';
import AccessorUtilities from './lib/utils/accessor';
export default class Autosave {
@@ -14,13 +13,7 @@ export default class Autosave {
this.key = 'autosave/' + key;
this.field.data('autosave', this);
this.restore();
- this.field.on('keyup', this.debounceInputHandler());
- }
-
- debounceInputHandler() {
- return _.debounce(() => {
- this.save();
- }, Autosave.DEBOUNCE_TIMER);
+ this.field.on('input', () => this.save());
}
restore() {
@@ -64,6 +57,4 @@ export default class Autosave {
dispose() {
this.field.off('input');
}
-
- static DEBOUNCE_TIMER = 300;
}
diff --git a/spec/javascripts/autosave_spec.js b/spec/javascripts/autosave_spec.js
index 404e1b53bf4..dcb1c781591 100644
--- a/spec/javascripts/autosave_spec.js
+++ b/spec/javascripts/autosave_spec.js
@@ -1,5 +1,4 @@
import $ from 'jquery';
-import _ from 'underscore';
import Autosave from '~/autosave';
import AccessorUtilities from '~/lib/utils/accessor';
@@ -11,24 +10,12 @@ describe('Autosave', () => {
describe('class constructor', () => {
beforeEach(() => {
spyOn(AccessorUtilities, 'isLocalStorageAccessSafe').and.returnValue(true);
- spyOn(_, 'debounce');
- spyOn(Autosave.prototype, 'save');
spyOn(Autosave.prototype, 'restore');
- autosave = new Autosave(field, key);
- });
-
- it('should debounce the input handler', () => {
- expect(_.debounce).toHaveBeenCalled();
- expect(autosave.save).not.toHaveBeenCalled();
-
- const [cb, timer] = _.debounce.calls.argsFor(0);
- cb(); // execute debounced callback
-
- expect(timer).toEqual(Autosave.DEBOUNCE_TIMER);
- expect(autosave.save).toHaveBeenCalled();
});
it('should set .isLocalStorageAvailable', () => {
+ autosave = new Autosave(field, key);
+
expect(AccessorUtilities.isLocalStorageAccessSafe).toHaveBeenCalled();
expect(autosave.isLocalStorageAvailable).toBe(true);
});