diff options
author | Douwe Maan <douwe@gitlab.com> | 2018-07-18 11:16:36 +0000 |
---|---|---|
committer | Douwe Maan <douwe@gitlab.com> | 2018-07-18 11:16:36 +0000 |
commit | c35089d6658d19efe0b7a700d63dcce7866093bf (patch) | |
tree | dace9645b78f56e2a4672df36caaf182ddbcb275 | |
parent | b341b2ad52757fc8488eeb29dcd909f7f0b81c4e (diff) | |
parent | dcae1cc908532bb0f8e12f446e542108b90ad59f (diff) | |
download | gitlab-ce-c35089d6658d19efe0b7a700d63dcce7866093bf.tar.gz |
Merge branch 'rd-48920-backend-support-for-clarifying-search-bar' into 'master'
Add avatar_url attr to the response of the autocomplete endpoint
Closes #48920
See merge request gitlab-org/gitlab-ce!20661
-rw-r--r-- | app/helpers/search_helper.rb | 6 | ||||
-rw-r--r-- | spec/helpers/search_helper_spec.rb | 14 |
2 files changed, 18 insertions, 2 deletions
diff --git a/app/helpers/search_helper.rb b/app/helpers/search_helper.rb index f7dafca7834..cadb88ba632 100644 --- a/app/helpers/search_helper.rb +++ b/app/helpers/search_helper.rb @@ -105,7 +105,8 @@ module SearchHelper category: "Groups", id: group.id, label: "#{search_result_sanitize(group.full_name)}", - url: group_path(group) + url: group_path(group), + avatar_url: group.avatar_url || '' } end end @@ -119,7 +120,8 @@ module SearchHelper id: p.id, value: "#{search_result_sanitize(p.name)}", label: "#{search_result_sanitize(p.full_name)}", - url: project_path(p) + url: project_path(p), + avatar_url: p.avatar_url || '' } end end diff --git a/spec/helpers/search_helper_spec.rb b/spec/helpers/search_helper_spec.rb index 6c9a7febf14..8bfd520528f 100644 --- a/spec/helpers/search_helper_spec.rb +++ b/spec/helpers/search_helper_spec.rb @@ -55,6 +55,20 @@ describe SearchHelper do expect(search_autocomplete_opts(project.name).size).to eq(1) end + it "includes the required project attrs" do + project = create(:project, namespace: create(:namespace, owner: user)) + result = search_autocomplete_opts(project.name).first + + expect(result.keys).to match_array(%i[category id value label url avatar_url]) + end + + it "includes the required group attrs" do + create(:group).add_owner(user) + result = search_autocomplete_opts("gro").first + + expect(result.keys).to match_array(%i[category id label url avatar_url]) + end + it "does not include the public group" do group = create(:group) expect(search_autocomplete_opts(group.name).size).to eq(0) |