summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorReuben Pereira <reuben453@gmail.com>2018-07-03 21:46:13 +0530
committerReuben Pereira <reuben453@gmail.com>2018-07-03 21:46:13 +0530
commit9e9137a6607e95bbe1e113da02fb95c2b19d66f9 (patch)
tree0dbf32d55061e686012e092e6be832a2d9b2c25b
parent7429eb3b48515d05d3840b6ba8ca68581eeb5ebe (diff)
downloadgitlab-ce-9e9137a6607e95bbe1e113da02fb95c2b19d66f9.tar.gz
Remove the Project#to_reference_with_postfix method since it is only used in the project_reference_filter_spec
-rw-r--r--app/models/project.rb4
-rw-r--r--spec/lib/banzai/filter/project_reference_filter_spec.rb2
-rw-r--r--spec/models/project_spec.rb9
3 files changed, 1 insertions, 14 deletions
diff --git a/app/models/project.rb b/app/models/project.rb
index afeb4625cca..79beec77843 100644
--- a/app/models/project.rb
+++ b/app/models/project.rb
@@ -904,10 +904,6 @@ class Project < ActiveRecord::Base
end
end
- def to_reference_with_postfix
- "#{to_reference(full: true)}#{self.class.reference_postfix}"
- end
-
# `from` argument can be a Namespace or Project.
def to_reference(from = nil, full: false)
if full || cross_namespace_reference?(from)
diff --git a/spec/lib/banzai/filter/project_reference_filter_spec.rb b/spec/lib/banzai/filter/project_reference_filter_spec.rb
index a57f4644866..559293d5ac3 100644
--- a/spec/lib/banzai/filter/project_reference_filter_spec.rb
+++ b/spec/lib/banzai/filter/project_reference_filter_spec.rb
@@ -8,7 +8,7 @@ describe Banzai::Filter::ProjectReferenceFilter do
end
def get_reference(project)
- project.to_reference_with_postfix
+ "#{project.to_reference(full: true)}#{Project.reference_postfix}"
end
let(:project) { create(:project, :public) }
diff --git a/spec/models/project_spec.rb b/spec/models/project_spec.rb
index acc7821a21e..abdc65336ca 100644
--- a/spec/models/project_spec.rb
+++ b/spec/models/project_spec.rb
@@ -344,15 +344,6 @@ describe Project do
it { is_expected.to delegate_method(:name).to(:owner).with_prefix(true).with_arguments(allow_nil: true) }
end
- describe '#to_reference_with_postfix' do
- it 'returns the full path with reference_postfix' do
- namespace = create(:namespace, path: 'sample-namespace')
- project = create(:project, path: 'sample-project', namespace: namespace)
-
- expect(project.to_reference_with_postfix).to eq 'sample-namespace/sample-project>'
- end
- end
-
describe '#to_reference' do
let(:owner) { create(:user, name: 'Gitlab') }
let(:namespace) { create(:namespace, path: 'sample-namespace', owner: owner) }