diff options
| author | Robert Speicher <robert@gitlab.com> | 2018-11-07 20:11:16 +0000 |
|---|---|---|
| committer | Robert Speicher <robert@gitlab.com> | 2018-11-07 20:11:16 +0000 |
| commit | 829e452588575c634b2a3dd778e702a6b21465e1 (patch) | |
| tree | a87f8db21d395fceee2d67227c9f380ac58de874 | |
| parent | cc9e3d09007174d4e0c30ae894c67160dcb72d10 (diff) | |
| parent | edd3e107c65edda75ec83398ff6fe031fbe1b4a6 (diff) | |
| download | gitlab-ce-829e452588575c634b2a3dd778e702a6b21465e1.tar.gz | |
Merge branch 'danger-mr-title-warning' into 'master'
Warn when MR titles are too long.
See merge request gitlab-org/gitlab-ce!22845
| -rw-r--r-- | danger/metadata/Dangerfile | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/danger/metadata/Dangerfile b/danger/metadata/Dangerfile index 51fc9e6bfca..1adca152736 100644 --- a/danger/metadata/Dangerfile +++ b/danger/metadata/Dangerfile @@ -23,3 +23,10 @@ has_pick_into_stable_label = gitlab.mr_labels.find { |label| label.start_with?(' if gitlab.branch_for_base != "master" && !has_pick_into_stable_label warn "Most of the time, merge requests should target `master`. Otherwise, please set the relevant `Pick into X.Y` label." end + +if gitlab.mr_json['title'].length > 72 + warn 'The title of this merge request is longer than 72 characters and ' \ + 'would violate our commit message rules when using the Squash on Merge ' \ + 'feature. Please consider adjusting the title, or rebase the ' \ + "commits manually and don't use Squash on Merge." +end |