diff options
author | Fatih Acet <acetfatih@gmail.com> | 2018-07-16 14:35:16 +0200 |
---|---|---|
committer | Fatih Acet <acetfatih@gmail.com> | 2018-07-18 12:55:57 +0200 |
commit | 3dd556f2d68e760989eda9262c4683b43158b48a (patch) | |
tree | ed405cc41868190acd3893435e5c70d42d8f30c5 | |
parent | e95be13d4d75ed52b64ef87f7e0b2c98e2ec1af9 (diff) | |
download | gitlab-ce-3dd556f2d68e760989eda9262c4683b43158b48a.tar.gz |
i18n changes for note cancel confirmations.
-rw-r--r-- | app/assets/javascripts/diffs/components/diff_line_note_form.vue | 4 | ||||
-rw-r--r-- | app/assets/javascripts/notes/components/noteable_discussion.vue | 5 |
2 files changed, 7 insertions, 2 deletions
diff --git a/app/assets/javascripts/diffs/components/diff_line_note_form.vue b/app/assets/javascripts/diffs/components/diff_line_note_form.vue index 7ad34c3121d..cbe4551d06b 100644 --- a/app/assets/javascripts/diffs/components/diff_line_note_form.vue +++ b/app/assets/javascripts/diffs/components/diff_line_note_form.vue @@ -56,8 +56,10 @@ export default { ...mapActions(['saveNote', 'refetchDiscussionById']), handleCancelCommentForm(shouldConfirm, isDirty) { if (shouldConfirm && isDirty) { + const msg = s__('Notes|Are you sure you want to cancel creating this comment?'); + // eslint-disable-next-line no-alert - if (!window.confirm('Are you sure you want to cancel creating this comment?')) { + if (!window.confirm(msg)) { return; } } diff --git a/app/assets/javascripts/notes/components/noteable_discussion.vue b/app/assets/javascripts/notes/components/noteable_discussion.vue index 46be43610db..2f1a68731c7 100644 --- a/app/assets/javascripts/notes/components/noteable_discussion.vue +++ b/app/assets/javascripts/notes/components/noteable_discussion.vue @@ -6,6 +6,7 @@ import nextDiscussionsSvg from 'icons/_next_discussion.svg'; import { convertObjectPropsToCamelCase, scrollToElement } from '~/lib/utils/common_utils'; import { truncateSha } from '~/lib/utils/text_utility'; import systemNote from '~/vue_shared/components/notes/system_note.vue'; +import { s__ } from '~/locale'; import Flash from '../../flash'; import { SYSTEM_NOTE } from '../constants'; import userAvatarLink from '../../vue_shared/components/user_avatar/user_avatar_link.vue'; @@ -194,8 +195,10 @@ export default { }, cancelReplyForm(shouldConfirm, isDirty) { if (shouldConfirm && isDirty) { + const msg = s__('Notes|Are you sure you want to cancel creating this comment?'); + // eslint-disable-next-line no-alert - if (!window.confirm('Are you sure you want to cancel creating this comment?')) { + if (!window.confirm(msg)) { return; } } |