diff options
author | rpereira2 <rpereira@gitlab.com> | 2019-01-07 17:00:51 +0530 |
---|---|---|
committer | rpereira2 <rpereira@gitlab.com> | 2019-01-07 17:00:51 +0530 |
commit | b8c54680e512a7196d374e65f3acc5838189d356 (patch) | |
tree | 7ebcb4436f81fd3825afae75d049d83d5fa8cac0 | |
parent | 5caea522967e33a05601c699a045c383db1cdd29 (diff) | |
download | gitlab-ce-b8c54680e512a7196d374e65f3acc5838189d356.tar.gz |
Refactor spec after validation change
-rw-r--r-- | spec/models/error_tracking/project_error_tracking_setting_spec.rb | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/spec/models/error_tracking/project_error_tracking_setting_spec.rb b/spec/models/error_tracking/project_error_tracking_setting_spec.rb index ac730e1893f..83f29718eda 100644 --- a/spec/models/error_tracking/project_error_tracking_setting_spec.rb +++ b/spec/models/error_tracking/project_error_tracking_setting_spec.rb @@ -22,15 +22,15 @@ describe ErrorTracking::ProjectErrorTrackingSetting do expect(subject.errors.messages[:api_url]).to include('is too long (maximum is 255 characters)') end end - end - describe '#api_url' do - let(:project_error_tracking_setting) { create(:project_error_tracking_setting, project: project) } + context 'With unsafe url' do + let(:project_error_tracking_setting) { create(:project_error_tracking_setting, project: project) } - it 'sanitizes the api url' do - project_error_tracking_setting.api_url = "https://replaceme.com/'><script>alert(document.cookie)</script>" + it 'fails validation' do + project_error_tracking_setting.api_url = "https://replaceme.com/'><script>alert(document.cookie)</script>" - expect(project_error_tracking_setting).not_to be_valid + expect(project_error_tracking_setting).not_to be_valid + end end end end |